From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6AD2E77183 for ; Wed, 18 Dec 2024 06:49:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AE3F6B00A1; Wed, 18 Dec 2024 01:49:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 45E666B00A2; Wed, 18 Dec 2024 01:49:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 325036B00A3; Wed, 18 Dec 2024 01:49:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 122B16B00A1 for ; Wed, 18 Dec 2024 01:49:57 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id ADAAA140C0F for ; Wed, 18 Dec 2024 06:49:56 +0000 (UTC) X-FDA: 82907153322.08.CB9BFCB Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by imf01.hostedemail.com (Postfix) with ESMTP id E7FC640007 for ; Wed, 18 Dec 2024 06:49:30 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XJum7zMt; spf=pass (imf01.hostedemail.com: domain of yosryahmed@google.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734504561; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r4podPIcegl1WmRB4nSJzIUsGQgCQp45AYv2N9xZSEc=; b=5AD4mpbekRjA0B+qUyRyDcB7ZPwSBb9vyomBneOCRm1WC0Wjg3I7WQUVz+Wx5DcVwCqEt8 bydzbzkUdcNmwlpWST9FASwxWBV5YasbRxXnSDsSpNGsYiRIY9QMocRousxdFU52GqB7IH MErPlYvg73goQzz28GYUM1n5HS/vrys= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XJum7zMt; spf=pass (imf01.hostedemail.com: domain of yosryahmed@google.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734504561; a=rsa-sha256; cv=none; b=3k673WdoCOt6DZsD4zbq7VZBc72yPOIii2a9hxqppXqrBJwgrDUKDpiR5ohloCjJ0URAF5 jQl5hh7whqS+hqzmHMe3eXkDi0OzARC8BPOZvqwiCUSAJp0ljOMaOqE61KpXcJkVJO2JaL vtpa4+BMBcKPfMJVeHBJC1Uw1F/CCus= Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-6d91653e9d7so57398396d6.1 for ; Tue, 17 Dec 2024 22:49:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1734504594; x=1735109394; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=r4podPIcegl1WmRB4nSJzIUsGQgCQp45AYv2N9xZSEc=; b=XJum7zMtKeAxzcqkkPMRr0JIkku/51Ecykxr6suNSjU+Ni0bWsRZ31I7BCQgwfIcWr t3swuhWUCCbO2vtPWXXMn5p8xr0fuqqRtauC/w0x60g9o27stvUMNthKQk8wNTymnGxn JkmC14sQWyqlhJMCgqAstJKaJAiPUdKXSuWFqb8yvMfaG+RHs9QUypgirAx39jwNFVt0 P7v1VTBiuRISowP2doYIzECPiPMlj+jFRbBQ0lNo+RQ57yhF1CrwlWUjnfFQ4ZjMo129 47+z64cxZ/ot/tKMVrRRxV43sOc+BcPJRia39x72EZ381evChEfQ/BDkMQUefuxYQuId +CWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734504594; x=1735109394; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r4podPIcegl1WmRB4nSJzIUsGQgCQp45AYv2N9xZSEc=; b=iNMjFULMBvh/Bugv+gXjoczKwGNDYJ0sG8sE1Vlq1vNSSGXREy++ooxYSW29jKFl+V mhXYt7mAOOfU7Fs0QuQd+PS/TUmrWBA7/lLS6t+2ESSWHR6em5Hm6SgNvMo3/myZqrxM G5C8dN/krk6JOPdSUxJ8sXK1ARjFWvH9DlrI9T75W/Mz6YBSCtJVpkPYt2v/O6Ue+t4B JslvT1IB2VKPaJAe3U/itiX3L3ndU2nhY811R/M9Bx33IYPuYlDpJsBd0flsr0JR+wD8 Qnz9nDVhk59eVsuCv8eMD1oxEwGQMa3EQR0brhBqnN5z8uSkeheBW0jPicCZT3ewHURM cDGA== X-Forwarded-Encrypted: i=1; AJvYcCUIYgVqgHjj3qD9n2rvueEyoksJ/f/FQk81dU6ERD51WT+LPrUZMxjD6+YFC8MK4DQKu+MpRLf9fQ==@kvack.org X-Gm-Message-State: AOJu0YxNvhrq4wxtPjMbrMGX5QbHcPzC0vhXiKhFcPHaJkbkIE35rae3 O7nw7qypOB1NfiuVQiLbcRolQ3KEe/9L26RMcfyLcklC7lPp0zHpnU6EuHRqI0uLlkOtXNbn4XA OngCowY0CDaKaBd+bY5rodF0AqTYvxUFh78Wx X-Gm-Gg: ASbGncvpG1UDTBVVptLS+ajri7e83gwxJyHDw4+85HfUzb9HKob2uRdLH8h6wEk8Cqj kWbeF9zyBrU4bzMmQf4KgoeAfrcVIkvI+9Ag= X-Google-Smtp-Source: AGHT+IEiY0doIzVRi/o0mbu86WO9XgujwLT4vmrvu/dfR9MfTyl54vyqGi6QNhFn+v5PAB2el18vB7VPk6T+E3mFDho= X-Received: by 2002:a05:6214:19e3:b0:6d8:9002:bde2 with SMTP id 6a1803df08f44-6dd091da53bmr37249096d6.28.1734504593716; Tue, 17 Dec 2024 22:49:53 -0800 (PST) MIME-Version: 1.0 References: <20241218030720.1602449-1-alexei.starovoitov@gmail.com> <20241218030720.1602449-3-alexei.starovoitov@gmail.com> In-Reply-To: From: Yosry Ahmed Date: Tue, 17 Dec 2024 22:49:17 -0800 X-Gm-Features: AbW1kvY4pzMcuxkqREUzSdwwDtMsLHvd6NOK-dwbEaYsc6jTPt0v4wsbGUz9Fdc Message-ID: Subject: Re: [PATCH bpf-next v3 2/6] mm, bpf: Introduce free_pages_nolock() To: Alexei Starovoitov Cc: bpf , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Andrew Morton , Peter Zijlstra , Vlastimil Babka , Sebastian Sewior , Steven Rostedt , Hou Tao , Johannes Weiner , shakeel.butt@linux.dev, Michal Hocko , Matthew Wilcox , Thomas Gleixner , Jann Horn , Tejun Heo , linux-mm , Kernel Team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E7FC640007 X-Rspam-User: X-Stat-Signature: rn9in5h1z1fmxdkfc4xn3ijg5c9iqwjf X-HE-Tag: 1734504570-882868 X-HE-Meta: U2FsdGVkX1+EaXsash41U/fQvgqPKzSfBJth08K/iu9S/fiksfk+ODdYqZGC0YNu0xrMU89F9QfIehtTfpCAvV1Sdqch9EPikZRP5WXHDsoCQobimBup7tYuwVomsF/Mu7Y1C+Rz6BaKhXJQmuMrq34zQb2ytKhh/MsNlwGSt1BJYUY1XI6PvXuKk1kh7LwLeksQ5bHzW2R6Ppr0MgkxsHNefCC31ClAqko7PdpD1o8VHvrFw9yqmkr+14OfU+vfeDmg42HWevZy/bRgIShc/tAsq9lgBb2O0NSi2tXlSTTDKvwkRPBxZAwCwkni04liHTrtBPm02t0YUZi1vfjyT4VqVXf557N1Jh2ffz45ngB9qNNowg7XDoXEimAJAsJTZwaectSQo+xl29jAIMpGk+5jpsR+2V2QB6egIwTF9NZ6cudKwnBvC9EH/98/j7CmxMCnAM5qTB47mB0Bpnxw5HaP1mJhDYWFy33dTPky9UoFyT77aaw5xcyKJG1KKYc1DbRsrLKIOCHoeg/0QyCOUXJRTxKZpNxjHGgKwwc641WzQcZJcTn4BYKCXCHtV6TLPxNYQLLQ7L3ygOAU9umb/MdE6YzrikgWtv3zixiwEv7NXMsLts7aYWuKMKMmxpUf2tguBIsk/vOjJ42PNgWidbLYt9sCRMfbEVPIuGPMmNMjT1xMiJ5AZub5ZJCglOOHCctinRFj+8Nlfn3bggPKjsHZtC1lLHbfdMeeyUHkogzwuvLRsN8syekxX9vidzdT0KCGkwOQY9Cox9qwMOiPKt5x+fvM2MpfjRViM4A33FsNguphpCmYdPHvHwcNiTmIaQGXdnVhg3oV6u3QqKgcieeQtxi67xC+iQa+6AliBwYjDWslXnEQW1irEq/OdXqmyLizG05y7RZR3z/7dhIrsDhW4C15XjN7lrTJqp+gKBz9EN8hB2kERgLNNzsRQJ/9IBNf4j4S7HpOoSTSvUB YDYTGAnK xKTGNrHmuFz520MRMK63tlgUUVa3Ad53CUFDc+dVg5nIVyeI1JevRm+bo9cJxCXeiNfRWmbVMMflrGpPxLyQCu4JmIvNnw4SgybA5ezkjf7fe2wfXZeDvTukHZc6w6AuHJvxKFNfUSjsYcUejuyatq4pst2PGlp13Ft/mJJ484PiBYGFl6I39saz0xSYwZCjQ3g5aBytXOTeS9xA7fTZ+JGqRhiWddAi2mFPRTMKYzrpyN7aBEIdAVEmf49RxEU5c9F95q31ZeZpMyMP3o+Y2uxOVCbVRKd/1nZQTr5U/RF+ZAeqZyhpTK+7VCb5buTkTru5nfDscDxLr+eyGc4p0/6LxhvUpMsZtGS2tiMIyywikx40= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001700, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 17, 2024 at 10:37=E2=80=AFPM Alexei Starovoitov wrote: > > On Tue, Dec 17, 2024 at 9:58=E2=80=AFPM Yosry Ahmed wrote: > > > > What I mean is, functions like __free_unref_page() and > > free_unref_page_commit() now accept fpi_flags, but any flags other > > than FPI_TRYLOCK are essentially ignored, also not very clear. > > They're not ignored. They are just not useful in this context. I think they are. For example, if you pass FPI_SKIP_REPORT_NOTIFY to __free_unref_page(), page_reporting_notify_free() will still be called when the page is eventually freed to the buddy allocator. Same goes for FPI_NO_TAIL. > The code rules over comment. If you have a concrete suggestion on > how to improve the comment please say so. What I had in mind is adding a WARN in the pcp freeing functions if any FPI flag but FPI_TRYLOCK is passed, and/or explicitly calling out that other flags should not be passed as they have no effect in this context (whether at the function definition, above the WARN, or at the flag definitions).