From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCD72C02180 for ; Mon, 13 Jan 2025 16:11:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69F726B0096; Mon, 13 Jan 2025 11:11:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 64FC86B0098; Mon, 13 Jan 2025 11:11:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F0656B0099; Mon, 13 Jan 2025 11:11:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 22D5B6B0096 for ; Mon, 13 Jan 2025 11:11:25 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A52F812053A for ; Mon, 13 Jan 2025 16:11:24 +0000 (UTC) X-FDA: 83002918488.22.B8827F4 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by imf13.hostedemail.com (Postfix) with ESMTP id BFCC620006 for ; Mon, 13 Jan 2025 16:11:22 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=OFw3P8ww; spf=pass (imf13.hostedemail.com: domain of yosryahmed@google.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736784682; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0nln6xuSTTaoMOsjO/bzAdYR40fjFobKxVXqk79yIRg=; b=vJBjrfCvN+p6F5XnaJF2EMA/0HRYNsu2Nn0kw+1DnhuLKkX5LELTgEEez2RJM0vSpdln+N U/+OCTAPkgd8kBZdAFiiDB2VWFDxvT4hhdIZNlsPb9kDjIN/UAx+3dGYlSQEntKkH/jhs5 lbbtPTyG9vfil9gBINDc27oKWhGk5A8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736784682; a=rsa-sha256; cv=none; b=bVJOZHWLQvqvQod8FtUHHmxbnrYuqV41EwSDqcIpqKL5RuGTHb9gIlRfPEIQfQ79IvE/mU SUgILpfx2fnQp4yEnvI2SSgr01pYTDfMYi7AYQSmEJnd708oD38qFwLko6GsbsvcTqm8gn ZOQRP4gb8u75CkvoOxaB2HNj6KY9Z7E= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=OFw3P8ww; spf=pass (imf13.hostedemail.com: domain of yosryahmed@google.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-6d8f65ef5abso33630726d6.3 for ; Mon, 13 Jan 2025 08:11:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736784682; x=1737389482; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0nln6xuSTTaoMOsjO/bzAdYR40fjFobKxVXqk79yIRg=; b=OFw3P8wwgNCvqgZSYikM+DDR1dHL7rCLHxjFuqm2il/ERBCijsDhEgLavn+HB7HQLm x9cSPNC+51W/ILLD2PFTIdXpsSAmu2y24aw/wTTdljBJlQcN1xzIAQR+Fm8rNv/6JVwu Evksrjq6kCpUyWNKEqbC0R1XhDpoquD1pTKz08SIyr3rKeuV0RX4c8jU7AgtOKPS8WJs mTCTgTeeAR2owO+d7xmNUXXx6rBnjShSyWYqAqlin77+C6iF24WZhf0ddW4o0TNUCuo1 2UynUBp9g68R+CiCnu3+CSMBK4mpQBGfjfIHtptQ26OGMPKS8b+VBbdiN8B+/XOIl5G0 55OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736784682; x=1737389482; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0nln6xuSTTaoMOsjO/bzAdYR40fjFobKxVXqk79yIRg=; b=c3xEWDDZb4DHdwn4BtXS5H/5qhSN/VTpmuwnrkC7SSnDhQFst6He2oz4wYDQYquQBZ qbr073DUczVUYhn2jVTdootQdaVkyd+EAhOtuyaELOk6dx4iFiMek3SkJqxjmz0ZQfky GyAJDZ5BoPlKrGuj4abYN2cN5fetCMgAaM+nt3xtpvSyKKxatAINy7jBhNozkRrcbPEH LGVpRyk2PIac111y8iivXj8S04aeP3LyrhPgHXzT9bCM/V8VsHclL9YUauY1t+Rw/czs OHUpz5h5i7hDFgsmZbdNLJ58WEY1QFa9Eovx2E0rbyoOF4ulh4vvj4cKnezv1mu/RBoD yg5w== X-Forwarded-Encrypted: i=1; AJvYcCWlZjbaSyYNQcYe7fr7yXKTWTmqKiu+NvEyqzm9a7tclQqPqwuAao713OnkCBO/qqXyQWpGgfLIxQ==@kvack.org X-Gm-Message-State: AOJu0YwT0zLWvVRPUBOOIjr4lfxU8yMcqPxYP7XVmwBFj+oFO9KiJAbp 3IytrBfPRKWJZeKcf88c55SZXmPqYBHDIKSGdf8Bmrgmk6LALl58IJ/EZmJW5ho5pfy7VEe8f4e ffOYfe4PBZHywBUSlM96pKgOk5Sc0hmyA1aEDbKmwQNifF5HyCA== X-Gm-Gg: ASbGnctyZUugzCAuSXF/C9+ZNtKB9rE2rxSvhvu7y4/cFsRDCXkyQfrPolhGMV2yNeL ZwMKqT/MqYIEWKIvhKAjWhqfUCOqIq45CPCc= X-Google-Smtp-Source: AGHT+IEZHimf0erqHl9P9hdsVm///MN8stQzn+Oj7UFKcLM1rFbaFHquGnXMlUQnxJqTuDGwgck+ox3NI5bhvjgf1ZE= X-Received: by 2002:ad4:5ca5:0:b0:6d4:25c4:e77d with SMTP id 6a1803df08f44-6df9b2ddad5mr358474696d6.34.1736784681463; Mon, 13 Jan 2025 08:11:21 -0800 (PST) MIME-Version: 1.0 References: <20250113093453.1932083-1-kirill.shutemov@linux.intel.com> <20250113093453.1932083-4-kirill.shutemov@linux.intel.com> In-Reply-To: <20250113093453.1932083-4-kirill.shutemov@linux.intel.com> From: Yosry Ahmed Date: Mon, 13 Jan 2025 08:10:45 -0800 X-Gm-Features: AbW1kvYVFjw-APVc_AtsFocTeHs3A7WI3FQm934n3hdXUG8p6Ploc_paz3DXv-A Message-ID: Subject: Re: [PATCH 3/8] mm/zswap: Use PG_dropbehind instead of PG_reclaim To: "Kirill A. Shutemov" Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , Jens Axboe , "Jason A. Donenfeld" , Andi Shyti , Chengming Zhou , Christian Brauner , Christophe Leroy , Dan Carpenter , David Airlie , David Hildenbrand , Hao Ge , Jani Nikula , Johannes Weiner , Joonas Lahtinen , Josef Bacik , Masami Hiramatsu , Mathieu Desnoyers , Miklos Szeredi , Nhat Pham , Oscar Salvador , Ran Xiaokai , Rodrigo Vivi , Simona Vetter , Steven Rostedt , Tvrtko Ursulin , Vlastimil Babka , Yu Zhao , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: BFCC620006 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: o9aekfg4h59j4psse1yms5p8h9x35xzf X-HE-Tag: 1736784682-319160 X-HE-Meta: U2FsdGVkX18GAwvYjjlxk0tYSKv0MHnEF2VCLHdXCMDgBApLJx3T4J08HQ5TkQwXo3UKBhN6TmJv342o7zKGfMPQRXqP7nuOosWdPB4pN08oM4Ldax+pMEcxj8qrk0/PrDdtt9Y7skcAl/TBwQB2rav+hFfpGaO8+vUrsQCr6YdjfVGxmob1IoUmBLgRZm9wy3jqbMqWFOqJXFgE1A79Y8URoLlX566KIgGDyQrC+amwqqK+HDee9HtgbbL7Wq1llvJ9LXxJfVWSoA7WG6k6d2G/4IhlD4xntC52muO/yfIrZbRT4AEBrQVi3RCKlF0rHmbpI/GJ9M5/homqnHUjnEsX/3Pj9uQBYJzIvg818FqgZEAex6CdaQ+LehM8LkbREvUK9/E+5WmHMzuonhaw2yoDNawEsho513hzug8fvwK16PFE7Gk3rQiQPCG5INcEdkqyNyseRq5R0CToPWJnMlC7+GArUmn5Qn96kNCLSqvTzTrpHoKH3un80yDF7OgfMCtFzA8TakyK/1zRGuMP7wked04GSxQKFaBStYZ26xdicBWIyD4ps7KsI3RguOx4c6eVopOPM8OBGe6OGBA1+Obbq2cIcqhOindv02NC1I7/dr9unn9xUs9cWlp0gXyto+HJzN4OtPAfI7IMSNbwIH9Qh2R2Q+v1NyGe+KrWaGDDeng5p8MAODUrdzp9M+Bsup1BtbN4k5pF5SCuWwJSFPR54rm3k+2wkRqKCuXc32DlamZ7uWrMWmg9sJF5snrqv/IJWmzkIAloaMioW+sKeK6WuOElRX9bEnGQrTB2glp31AoVC2NK8ginOQdFmfi0xy1hZAGtgxN8UC15jlsVTkL4WZrWWehMoDGasiXbUzT1QLopp70G2fVL1TAdWZl+JpaObxjipAu/wZGZr+Jm2VHE4ALKvAD1GgKKLH6TzqglmDY6A6ZQHlIANoPlLyHsvW/QYP4CML102PaatY5 U/aJmaaY cTM+E4XWDybpQzjUXlbQoYNpiRJTaweTWPHlaxFwhQYlqABdWbl4+4TVmHmD5ZGZBcJBd30sS8tkIKASszU1Yn0ZhT/UD3Crm32RYJ2lLbV3MbEJl790zSsofsXOOnelIXsFmGeupqhIauJXEmk7oXpkFv4AWqNs+u0AP/hitn18Q/ez+7jMQuhGZm7q0E1S1IciqH49wKKB2tQccEJJjr7pepU7TvVN84MK8opwcKFs6pidF+D0EZFUa3g601kTRvQwHWFJyl6lX0/prcOn01Nr0Cs8cVx1asQXj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 13, 2025 at 1:35=E2=80=AFAM Kirill A. Shutemov wrote: > > The recently introduced PG_dropbehind allows for freeing folios > immediately after writeback. Unlike PG_reclaim, it does not need vmscan > to be involved to get the folio freed. > > Instead of using folio_set_reclaim(), use folio_set_dropbehind() in > zswap_writeback_entry(). > > Signed-off-by: Kirill A. Shutemov Acked-by: Yosry Ahmed > --- > mm/zswap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 167ae641379f..c20bad0b0978 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -1096,8 +1096,8 @@ static int zswap_writeback_entry(struct zswap_entry= *entry, > /* folio is up to date */ > folio_mark_uptodate(folio); > > - /* move it to the tail of the inactive list after end_writeback *= / > - folio_set_reclaim(folio); > + /* free the folio after writeback */ > + folio_set_dropbehind(folio); > > /* start writeback */ > __swap_writepage(folio, &wbc); > -- > 2.45.2 >