From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40D06C46CD2 for ; Wed, 24 Jan 2024 09:12:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88BD66B006E; Wed, 24 Jan 2024 04:12:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 814906B0072; Wed, 24 Jan 2024 04:12:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 703636B0074; Wed, 24 Jan 2024 04:12:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 62BAF6B006E for ; Wed, 24 Jan 2024 04:12:39 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 32B1EC02BD for ; Wed, 24 Jan 2024 09:12:39 +0000 (UTC) X-FDA: 81713639238.19.86EB204 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf07.hostedemail.com (Postfix) with ESMTP id 5BD1340008 for ; Wed, 24 Jan 2024 09:12:37 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gF+iufzi; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706087557; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qDGWWvngYrXMHFwGpStoErGRJgClfXa6zjwKTrnmtoY=; b=dYLcoscleV5V5Qpnbt6plWJnd2ByWoRtXikGBoqJpvX/bhcZVVoEVeQ7chs5fv1vYt2RvS awkyfxrz/e6tJ8TmMrBI461sN5LGfa8vEum/EKgEe+MA8p8R4QS8jhQhE0KTWipK9eSAv2 JXNGfoxEErGsR7QISV3UssB9S8fj0u4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gF+iufzi; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706087557; a=rsa-sha256; cv=none; b=V4/NHWXnMZ9PUkxdlouOz5uGPiVzX3ikPYTzz0OUftKkGEGLjFLnvjZckaGzCIld1kHhyR Gi328ZkL6K3n3SDRK/I6/N092aYLCnn+0OmiSuPU4zu7DfnYY8VOjsKG5waWZ4cT3kff6r AK2jx28WYceIpf16GwQpXWpYnAl05Eo= Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-50e7d6565b5so6481629e87.0 for ; Wed, 24 Jan 2024 01:12:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706087555; x=1706692355; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qDGWWvngYrXMHFwGpStoErGRJgClfXa6zjwKTrnmtoY=; b=gF+iufziYD+bYepLgg1GvvKR0aRizSsz4JuI5MxlxcE6jt+EZShq5FcekK/957EDZC Izj0hALCT9QzGpCCcd99c8nd57E5WxeuWIb9sedFOzVKQZbXmo/VkCDv/EeW47ClrTrS 7lh74IB79WDqBym8kwff2idvMCu+lMJ+gvc4v1n/KQ5vnq7IIw9iG4yrme6wYsTUtLjT /HyFCeEnEyWYxvfRvV9G2clkpC0jEEI8FprB+4yR1KttFgYB2INYBR6RD1E90Z+JWeCR 08UelRZAh95CiSUMbiReZ/Y72DM/7Z85FAaa547aipPwxuQITJ3uMcj5nWwTNxkmtMYv 0/fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706087555; x=1706692355; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qDGWWvngYrXMHFwGpStoErGRJgClfXa6zjwKTrnmtoY=; b=IazWMPvY3Lg4l2t/CTzQNaP0Uq+ja8bFDhe1oOWwd5h/AnRN0s4xZ6XcFFi5vp8iuN b/P3wX7prT8v2vE9FbXuS/RJAqX38IdRGp5IJ+cDKAhkxZRrEHuvXl2QCm+IINSirW3J NL855wMKEkfw1YRNVKQNhsXRFWwYBFBoGKhO7ZkeP9s8Ho25xINAyKQ2CM7nG5LKf3Pu egpHddrb18H1aArys/nyAH2awvir2IKyyO9sXcbj7fd/0aYf1WFVsjUSClbPIkbq44v2 bOvZp1AvuNcAWYBeXS4c6sF/zpTXJBQLt807fVJGKXxERWEdmSW3lpIMnxcmVDwEi706 CXaw== X-Gm-Message-State: AOJu0Yy5cF/SEvFPRYc7KfxZgFPWT+KwvioKIozJEUrFbjQfT6Y1i+YC Z4hjzk2mnq2hfOfC8eHMJ/wm9ZvJ/cnPSY0k8syGZ2epXkdgpAPREK/LxaZP8D6G0++byUJ1UIK 5/u8koTxj4DuoKs7XQmIpa0VGXL1r+W61ejmq X-Google-Smtp-Source: AGHT+IFfLbd/FARYk6hM3cTdPgBQ12QvsaQkut9PupCddCOicPnR9Oc8j2wvTSCWe9Y4/ZeUwERHZdpt7K9X51TdCA8= X-Received: by 2002:ac2:5384:0:b0:50f:732:c4d5 with SMTP id g4-20020ac25384000000b0050f0732c4d5mr2849591lfh.64.1706087555324; Wed, 24 Jan 2024 01:12:35 -0800 (PST) MIME-Version: 1.0 References: <202401221624.cb53a8ca-oliver.sang@intel.com> In-Reply-To: From: Yosry Ahmed Date: Wed, 24 Jan 2024 01:11:59 -0800 Message-ID: Subject: Re: [linus:master] [mm] 8d59d2214c: vm-scalability.throughput -36.6% regression To: Oliver Sang Cc: oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Johannes Weiner , Domenico Cerasuolo , Shakeel Butt , Chris Li , Greg Thelen , Ivan Babrou , Michal Hocko , Michal Koutny , Muchun Song , Roman Gushchin , Tejun Heo , Waiman Long , Wei Xu , cgroups@vger.kernel.org, linux-mm@kvack.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5BD1340008 X-Stat-Signature: ocysq9upf7qpce5jem5ykbmdaxqa4oar X-HE-Tag: 1706087557-187103 X-HE-Meta: U2FsdGVkX18Nj/4jK5gfvBlaxmDRdH2SPpfqOIJZ1dqep3xAB0SNy+vAS7k0zE7/w6cuWUpz9ckj+HItBdOo2hzhC8gpbN0wb04lfNcMu/jPUQPgNLYbBwC3RBUlXTAMKov4Y/Gr01dH7ZvzxbH+UkmnG/2bp2Rkzb4ANgO4MyamKlb6B+J9vToNYJahJUhU9sSj1sIjbCt879PYkrmZt+DyRnMaYip5tIqaEsIJbA5E+KndT3g6BL/G7TmozTc3yVkTH8AAO7zXX5KwpxJ9jVRdYDOD+Upm3xGGSZ0D+YnP4ViZN2N0ymQWHXXir7wbqsPlXwd4CWmDC3IhPK8TdrjnCi2IPp0Bmlw1eXxa2oMr0ZQmqYiLKNTmIwYhR91iCrLF9UAePjNbE19c5CuWaERd1avqza6fLFfyHzvQqxdIdg/KRTJl/l57M9yoJkKAc2Wt2PCS3jpRYJbyNtxRf5K47COGm/OEDdeR4nhmGPVUPBN0fTFez1S0Jlu72I129v1HYWaWo/smQMcBaMp+hlPoEGEoP/tAHFXIUL5Z8i7VsRX1stQmTN5Nw7I3496TgZwzcKMvZjuJ7JPFgGtwc6pqRpAOQj8cXP6fKC6GZ2XOb/keXHWzREth4O8NX0w02syNcIZn6cfExCGfKt1D0XpzfWsSehEp0GiV67cyggtnPA5qRxjkHzI4H5zs/dtrJyLq0GEAEA0y+b+4quXmfiYbZefwmPRvTsE9IddWGLftlSSDBN6Y5teGC99dEzJGK4g1b415+3x1w3cAbnOK11yX+vviMw1US7Xhr57XQ0d+WnyXI+augzULg5cTgn0rf1Iq/CIvtURyFxAXs34sBBPyvl7UaejPyTnATBdNyUd2CeMQQPea8TxeGqhC0Bf+y6UNv6PLVsqF0I1a09EK0ffrzNcfgihpbysplmBfNv2/rAj5MXkjqewQcQSY145yhxn7/NMLZSRsMEHQkLa 6efvNQ/S wp/58d9Gk9rZICMcnfbCcLIOxIbcHF+I52tCrTNqO+Dzj0O5U6Hc/T1zogmyNsMMEXcTUaJoIi1rNTuqcvBx/Js0STAyvvkJdxJDEDjwTmviosVywdwlpLJ5v6XlAPfOSsmFLrWlwMNqPQEY+hgCMB2WmqASx3olKTtqpa5zIHHjJMSbC9jmfPwSMcMY9A6Xz70oLne0k4RP57dltRwr7NAv2Cbg6RTd0AV9FtTD4SKgpXEKqk1gDaO+IhQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 24, 2024 at 12:26=E2=80=AFAM Oliver Sang wrote: > > hi, Yosry Ahmed, > > On Mon, Jan 22, 2024 at 11:42:04PM -0800, Yosry Ahmed wrote: > > > > Oliver, would you be able to test if the attached patch helps? It's > > > > based on 8d59d2214c236. > > > > > > the patch failed to compile: > > > > > > build_errors: > > > - "mm/memcontrol.c:731:38: error: 'x' undeclared (first use in this= function)" > > > > Apologizes, apparently I sent the patch with some pending diff in my > > tree that I hadn't committed. Please find a fixed patch attached. > > the regression disappears after applying the patch. > > Tested-by: kernel test robot Awesome! Thanks for testing. I will formalize the patch and send it out for review.