From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED789C4829E for ; Mon, 12 Feb 2024 22:42:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DE7E6B0071; Mon, 12 Feb 2024 17:42:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 68DA96B0081; Mon, 12 Feb 2024 17:42:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57CE76B009F; Mon, 12 Feb 2024 17:42:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 45A006B0071 for ; Mon, 12 Feb 2024 17:42:49 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D634980969 for ; Mon, 12 Feb 2024 22:42:48 +0000 (UTC) X-FDA: 81784628016.03.042C812 Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by imf12.hostedemail.com (Postfix) with ESMTP id 1D32C40004 for ; Mon, 12 Feb 2024 22:42:46 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Ch6ge94g; spf=pass (imf12.hostedemail.com: domain of yosryahmed@google.com designates 209.85.217.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707777767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7qwxet0SdK/KijzcEcZqFiBIv3Lx4sNueH8dt0TXMEA=; b=gAeSWVB8HDAUgIPDZirLATtAPCO8OK9xcWMkb/KBlmQreDBZ+oEmM5Fi0j6qMM6RxwfTEn x4xuSv/8OB/Ud1KkL+8t6kHvqXamX/DBQq/iNKvJvEVAe0E35TBiE1/ehjnNqq9sfQshm5 Np85lnaL9cXOua8ULkAeYkThP4Rn3nE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707777767; a=rsa-sha256; cv=none; b=opsQMTOai7+VJbBf5qSfdY/tGb7B6dM4NID4WHOYSh5GAG3/BxLhELQLm3SC4ED86PcsP6 gPsKfpPYh/dlU566dLAIxeGm1RfIEVk5IQ3a8zEVsXEZcZaJ2+wbRwjhY3Q1YoO+OOw4N5 YnoZ8L863mXCQG2shQ0C2TF4qauO/Zg= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Ch6ge94g; spf=pass (imf12.hostedemail.com: domain of yosryahmed@google.com designates 209.85.217.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-vs1-f46.google.com with SMTP id ada2fe7eead31-46d745c4fa6so289427137.0 for ; Mon, 12 Feb 2024 14:42:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707777766; x=1708382566; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7qwxet0SdK/KijzcEcZqFiBIv3Lx4sNueH8dt0TXMEA=; b=Ch6ge94goWiwZyhruFG4Bd4+auAq5FWOcqrFtPOLR7K10aYYGP7BD1kExFCxZxcsPX mWkFhs0mQmnUUKc6SHBhlpqXTvM0sKoPxexJ0C4G3ZkV0vncL5h2SgcSJ6hFgfmOfde3 LIGYKaKKuPJvHsJ3tHVJf15mAR29vzJRIMThwQ03D39uOCU073GaqeEFU8v7XObh7ECL EkONptrJyM40RnBJHyPASxVPVeh1Clw7moPbM/6T6hwTyHWA6/W6wcehEt98hbiL6lGC kNz+JsAHq/i+HFvxhwo8k8DM5KM52qXtI/e1MA5HKdUt/C3bau5gCJZnNeRouea3HwDf L3Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707777766; x=1708382566; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7qwxet0SdK/KijzcEcZqFiBIv3Lx4sNueH8dt0TXMEA=; b=QQjvGfdyQS+ighKvgllgAsSgUO9SrTJ841KTXer12MU2amd8BmpeZlkt0ChgYUT6p+ NEWbYaA7aqWmIX6Clwh5/1yYlo8SG/6/SvHZ1zEisn2fuX1REqeSMcmcsHi/cQoSBTm5 qMv2G0/dF13HeoaljP6NU9Q07Fkv2T3ni2MmmfSdAzvtvR4bjxCWZrzJkABmUYyN2ETc Q1w+UiDCNMp9izddCR0XIirUyNeF3StFtgJAbqc5S0SN08Gmda7jrEKr8y40AiCY0ILd B5oR6HFvyqUM0w+L1LFHTSfAzUlRVJbXbYxTIgupAQtNNf8lb7QhktzP9NnO/dBBhd9c mSzg== X-Gm-Message-State: AOJu0YzVjhCgtKFjNrVzqfwZrdCowbsQ5vetkJpVQ3XoE2FTDUwPMRZW hONxXQNFMox8MkjfT8uMXhXON+sRWd3y6slbJp4qKYiqse5FQhjt2UXf4/IRIJbPy9CVXie/kOU /2ilaEcT4fMvpXwnhBsT52AXxf9PxNYjdmcd3 X-Google-Smtp-Source: AGHT+IH2PFWckqE2GJ70cLraXtxiXeFdzwkuapkjt2RE/iVug7s4bx+SA7ex/sf/XeUJ6mzlBaAZrxr8mL3iAaLX638= X-Received: by 2002:a67:f8d7:0:b0:46c:ae93:9c7 with SMTP id c23-20020a67f8d7000000b0046cae9309c7mr4378021vsp.18.1707777765979; Mon, 12 Feb 2024 14:42:45 -0800 (PST) MIME-Version: 1.0 References: <20240210-zswap-global-lru-v1-0-853473d7b0da@bytedance.com> <20240210-zswap-global-lru-v1-2-853473d7b0da@bytedance.com> In-Reply-To: <20240210-zswap-global-lru-v1-2-853473d7b0da@bytedance.com> From: Yosry Ahmed Date: Mon, 12 Feb 2024 14:42:09 -0800 Message-ID: Subject: Re: [PATCH 2/2] mm/zswap: change zswap_pool kref to percpu_ref To: Chengming Zhou Cc: Andrew Morton , Johannes Weiner , Nhat Pham , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1D32C40004 X-Rspam-User: X-Stat-Signature: i1gwti8neiistrmzqdzm6ks9na4bzjcs X-Rspamd-Server: rspam03 X-HE-Tag: 1707777766-385011 X-HE-Meta: U2FsdGVkX1+qrTEQBj2muIVtndKCmXqmiJ/qvs+nhjfQkDldy7kr6krC+0r5W4N8GHp6jfcgZvW9vCq6xUGN4+C0bFx1JTqd0Qpnf9hur4rh3aI7obHZbGMiUeK+G9AjA2ItGVMpDKpuXo5WJv/+VW6qkV9V7Ym3ObJBGAfONRHDTLMxByBJpJNi/OE3WXTCf6pXwoM0pQgwxo9aReU5nHxwEDe7vmUJuinPYtw1pBUHyd1FnaQ6fD5jgP9yHxfIK4WQtNLfefBwuH0Fuc86VA7sOv8BgKazvh9rRFeJgPW/RVjcL+1E+eJPsHTV5WgE+Ye0TDlLUpEQy+Wxm1EY6sbkUx+AZN16JQ8LbGqxlG11eJzy9Qs7NMhrC1BKaqvhLhnC/2QSIbAd48nzPIj+4bEu1eC9G+8sixtsEjukZHxv5YRIrUCLnLXqdxnSeE5b7pqc8dT7nYPABkOZb0p9b0R811f7mHjU7Qbz0T4e6WOX3b1UrwW9jR6lTUh3o8mSXiTu6CeV9gRfEnCWYkdErXafPktMIocGizIw8lVoQCgM6CcA1qTVD+u+tJqgutk24P87uyghy/lYtTGWXA2/kUW0yvMnGaqOos+Y0xokU3Frj5rlutbI+ASaaj7dh5mCCiahf7kwWLxNzsOnurFjp8ns/oNhFiJdT6YL9ee+9HhViRW6MZGu5V2R9B5dCDbcAiUrlmsUeF4P5CaSm7mGOZgzjGfkJmeob5RdcxpBxiRFCH36djXVS3O0RgeaOuKoTft1tqL7zuR348cE8WWAx3n1Ae8NBz+ixW7dPRB+5TkJyyTMhllNUqD6w92iFcGCFN0YjHCcYRTOBnU59c/CoostSSTbZQdbjJh58vyoPliDEr+h3zgkx0Y/ZSvXljkjE2krldictZ7AyxkjVFbPdbSDGN1i0OUMWQEhCTekQOrSn8fdhE2emRaI2lf4i49ECF0h2D5Ix0A69wRlKgy w4x8lWpQ wzxLWz8vuZR05GRjJ0+jRtdZBze4ksPUmXoRWDZM0Gn7PGToxunf5UEz6Kv8nGujV2rwHaywfs7tDOYTQywEMNoMSc15M4gDXc1jV6WWrcUZrnIDSrjYTcEfo13zdR2Fi1xYNI569EKq6S0BD8c5SfbzQmn+oCTAbozSZuT5v48K9mQpmf+R0J8uIyDPLiXNyaucf5KrHAv9jiHY6NTuSXnJg6D/EYnGWA8gcT3UCltxd3iX95vpray04a8rpC4n8eDA0nh7pbQGqQLOxtadtK+koSxXsBy6gTuB+vTW6Y+Y15KwdClixT5hbCx+AdTiBa57iQsCiMHyKAuY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000737, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Feb 11, 2024 at 5:58=E2=80=AFAM Chengming Zhou wrote: > > All zswap entries will take a reference of zswap_pool when > zswap_store(), and drop it when free. Change it to use the > percpu_ref is better for scalability performance. > > Testing kernel build in tmpfs with memory.max=3D2GB > (zswap shrinker and writeback enabled with one 50GB swapfile). > > mm-unstable zswap-global-lru > real 63.20 63.12 > user 1061.75 1062.95 > sys 268.74 264.44 Are these numbers from a single run or the average of multiple runs? It just seems that the improvement is small, and percpu refcnt is slightly less intuitive (and uses a bit more memory), so let's make sure there is a real performance gain first. It would also be useful to mention how many threads/CPUs are being used her= e.