From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF4C9C001DE for ; Tue, 8 Aug 2023 06:00:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 225D56B0075; Tue, 8 Aug 2023 02:00:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D5908D0002; Tue, 8 Aug 2023 02:00:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C5F48D0001; Tue, 8 Aug 2023 02:00:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F090C6B0075 for ; Tue, 8 Aug 2023 02:00:05 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BA322A0BBB for ; Tue, 8 Aug 2023 06:00:05 +0000 (UTC) X-FDA: 81099886770.22.EDC397C Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf02.hostedemail.com (Postfix) with ESMTP id E1DB880011 for ; Tue, 8 Aug 2023 06:00:03 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=h5JeQynP; spf=pass (imf02.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691474404; a=rsa-sha256; cv=none; b=eMM8o4D6VlpJoQvUK0P76uAhRa04Nztw1G5XHArTV70hHcbVsEFC/3inHbrmsH1S0V4UhY dAisNsXTsHwJsPQKB/VkEaFKaXgjFffZtaMbUVHK9SmLHuak7IG1P46HsiOS1deKZV3XvX AtlzaQWG52beRy54Akhp99ul0XFE9G8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=h5JeQynP; spf=pass (imf02.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691474404; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wCbMzDcejfu/r3vpxjg6PbySnEm3Gs6QvurIEsP6gTw=; b=OL1HadVVYPLgkjoSzJ74StzNukfaJMTAWuFUjkF7Sg6E1QxVqdEcaPbZFfy0+R/zPrS/Dx VvgQsh9vxZCPDkGZ9dNEbzxqgq8DU9oq/n3LOLRMsYDF0FC5jMWotszCS3wJZhn2668Ksn JXa+VMWzRe8FZMObRFnfWOwehaNlEDU= Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-99bcc0adab4so765549466b.2 for ; Mon, 07 Aug 2023 23:00:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691474402; x=1692079202; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wCbMzDcejfu/r3vpxjg6PbySnEm3Gs6QvurIEsP6gTw=; b=h5JeQynPx4PrRO4aAZ/oAhW8b+5Y0LPB7xAwPPP/3Jgki3Eq/Gpv/s4ZjmN2wOCt2o a3sbbpZw1a0icSN07bWokxQVNO+kN3Nk5x/dzwTb0rV1u+aQ/knf37rEQG3DbTkpe3xi gvmkPwxXx8a7fNagR93eMvNMfB5XyarT53pkC8O1bTZyE6SwXWEzTHO8wtPxYbwCU0Rx uVejU0ACNZX198tCmt3JMU2hxfzPHalPu4f+/LRHLy/T/SHq/xN1K503DkQGYWtqZ2pS 35n2Vnyc6T65QfiMueEMKUyLKfkiyK6D7dIpYp3ugC6Q9vVZLjzDJn3Gme4bVpTsudxM qfJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691474402; x=1692079202; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wCbMzDcejfu/r3vpxjg6PbySnEm3Gs6QvurIEsP6gTw=; b=L28PMh07/GEQhVrf7qauCBqYpN7XDZnQx6TPzSVpV7VWZD3Kpp4U/iG2GyhUIG4SQx C5Dfw2u601l5kSgNdrr2lGOfLbokokRBmQIDU2sjSOPAWPy9RvuCx5PRoHee9qWYESN3 gPdGjTcRO0ifE9Z7D4pH1xGZH96RU+ozWHku/xMpRoTP/DsxkgNTY2kwqVMe33hT4S+a mMtNj1QFgD/Ci1hCKIPdvi0vSI3cOAOEzsWzRdYO0v5VfxASSA8b0Ji3k3sjArBgKZz7 Kqh7Wtp8TFGad9ioCBui2ZWWT01nHUjtz4lRawieMHqToZ9tYPxI0ZUMwNPc+dt/u1N8 TjpA== X-Gm-Message-State: AOJu0YxR27XkAOTSGqsmyskCYjmeEDXVGtB6pPNg6XS6OXsZT0YUse3l XbQosOE9vtlpCn7fmoBUAUvpdI0T6NHpK3TMDOYTfw== X-Google-Smtp-Source: AGHT+IGcEK2hDecY74/x95WaVKttBWmwP5HFSEsp0UHzTkcS9CidUjOGxouTVbbD4iYiRSE8Ct2p0+AD18hnFD7VMAY= X-Received: by 2002:a17:906:847b:b0:99b:d4a0:1322 with SMTP id hx27-20020a170906847b00b0099bd4a01322mr9900510ejc.41.1691474402231; Mon, 07 Aug 2023 23:00:02 -0700 (PDT) MIME-Version: 1.0 References: <20230808024714.292048-1-xiujianfeng@huaweicloud.com> In-Reply-To: <20230808024714.292048-1-xiujianfeng@huaweicloud.com> From: Yosry Ahmed Date: Mon, 7 Aug 2023 22:59:25 -0700 Message-ID: Subject: Re: [PATCH -next] mm: zswap: update comment for struct zswap_entry To: Xiu Jianfeng Cc: sjenning@redhat.com, ddstreet@ieee.org, akpm@linux-foundation.org, vitaly.wool@konsulko.com, linux-mm@kvack.org, xiujianfeng@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E1DB880011 X-Stat-Signature: 4777k8kwfq51znp176xganco8yfruxnx X-Rspam-User: X-HE-Tag: 1691474403-5429 X-HE-Meta: U2FsdGVkX18zYhex8WGWC26Bx9XWJy352m3zc+m2LQgzC0+6PT3ON1XBLT58oDTU7vx8QV5HxiZx2NQxccdOQUxhrCRQpFtMKHilWBqxvQZMUS9R1/4VDxTCBC3HrHQoli+X1WZ6rdE9CvB5VK5MQijEYnWp3fFTzBQRwXfX74gYznDTU8GhnnIQ483ZHvacP+B9DEFXQdngS/4MipRgl5X4PncZk5/tO8vlxWSr+wQCtlFDpFw9rWyMbGCeZS2LzCxE+W7ZB1KoOn+CV3sQVEmNbM7534vzFw2JFPla2wlcQoxs9Rr9Hxn0V0yejnmXNFHNXD0gGMuKo2LVbheIrKaS3MPQbvRD6IVaXFIw6QmGeZafL65DV0QvrjU1MW4QyG1ityUhSPkJ/o8AOy4pRgOlXZ7EDg/9nPC3urJ3KEXUC6hEDiKh9R4Kf1vGh68bmswGWsEFj87yZ9n55ZNEGyf8u6ha32CoTEzIHUjfiIdEdA0jakG2dCwEspAbX074kzyS0im7VXsmbFrMizmMkxKVf35XGH2FSXRxZQEhAQcLJ4TxAQOFouKMSXMdi9T4vwqqIvYgbGWBol3T3BZUTmjomVBcgoge4sdEJTMtw91mkLxoh8kfbd7nPUVNYi6h8+N62wz5XrpAXl1zFxb2jNexkodrcOUPT3gYdrQqultuJK2jXtI605xI6ALzSBgEkyRzDbAJOis4Vv2kToj8pQ6TSs/Vcr7b1LTsl2G3zeklQHpJXvBuzAMGkEH/k5EWVZQkIlKG6r12IUXX2eWa7wKk3bE64eH9Bb/GzaMwQXvQpbpUi/TENo4LmWzLSgFYq7as5qh32a9PkDQW8pchdmlmhD8FXaQTFo5aSUycIKQVo9BEZVcBmvo1E+PE8jaDI0zY6N33Pp5jatrGxtfBE7UNIf+kXFlMPJyGIv9upQXa7rKSjcBeeqLuqzCSx/ZZOP0nqDrPffnKpYqDsS2 oGPgeerT zVby4sBufDMnsbtVD7cX3VNJAtntbUoSjzTEW3emlJAIlgQXAiXUivAmDskNgmoaq5HLoxIUm7lqBv+e9592AYpfMwjgN7yn6HK1UlwcdEK0olAFkWPx9iBogr2VdTz9/Z4J4oXyUIgaJBaQsTfbYfFykfUTiglaxuORzGg/VgdDgif8N3EBtIrLJlBJFJ9ECnvyNBOzs9h8kPM6vdvf3QFbH3eID66TmP+VEURmiaJUxt/jUDg/TTX4FcL/v33fxGr3NNDLLEAq4rBIUnDPU4RpC1xSjKbAyi8RwofjqxWvgbDfqJLOb8059StcR7w3Bby6zuaoR27rgu/sP+tKoK2YGdz9UstjhAmDS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Xiu, On Mon, Aug 7, 2023 at 7:49=E2=80=AFPM Xiu Jianfeng wrote: > > From: Xiu Jianfeng > > Since commit 0bb488498c98 ("mm: zswap: remove zswap_header"), the > 'offset' has been replaced by swpentry, update the comment for it, > and also add comment for 'objcg'. > > Signed-off-by: Xiu Jianfeng > --- > mm/zswap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 5b56d38e7339..d7863c139c82 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -182,7 +182,7 @@ struct zswap_pool { > * page within zswap. > * > * rbnode - links the entry into red-black tree for the appropriate swap= type > - * offset - the swap offset for the entry. Index into the red-black tre= e. > + * swpentry - the swap entry for the entry, include 'type' and 'offset' = fields This is not the place to document that a swap entry has 'type' and 'offset' fields. I would also avoid the repetitive 'entry'. Maybe something like: swpentry - associated swap entry, the offset indexes into the red-black tre= e > > * refcount - the number of outstanding reference to the entry. This is = needed > * to protect against premature freeing of the entry by code > * concurrent calls to load, invalidate, and writeback. The = lock > @@ -195,6 +195,7 @@ struct zswap_pool { > * pool - the zswap_pool the entry's data is in > * handle - zpool allocation handle that stores the compressed page data > * value - value of the same-value filled pages which have same content > + * objcg - the obj_cgroup(actually memcg) this entry belongs to Again, not the place to document that objcg is an abstraction layer above a memcg. I would do something like: objcg - the obj_cgroup that the compressed memory is charged to > > * lru - handle to the pool's lru used to evict pages. > */ > struct zswap_entry { > -- > 2.34.1 > >