From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B421C02183 for ; Fri, 17 Jan 2025 17:02:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E0196B0083; Fri, 17 Jan 2025 12:02:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 267DA6B0088; Fri, 17 Jan 2025 12:02:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E1AC6B008C; Fri, 17 Jan 2025 12:02:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DFE9E6B0083 for ; Fri, 17 Jan 2025 12:02:40 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 663FDB0812 for ; Fri, 17 Jan 2025 17:02:40 +0000 (UTC) X-FDA: 83017562880.23.47BB1B2 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) by imf29.hostedemail.com (Postfix) with ESMTP id 7EFC112001B for ; Fri, 17 Jan 2025 17:02:38 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gjYxZK1R; spf=pass (imf29.hostedemail.com: domain of yosryahmed@google.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737133358; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VOhRlzFLatiwMnMgWUCUofi8FW89XTrIZpSjj6Xqij0=; b=4LdoTftdMPnYhQT0cSAO2Om4HRRgfI4UY+Za21FKuWDTyAyw7Zhf+YXkNu9o3rIjXL9M7S glIqCP5EZxUeoiK7i/wGTwWUdzryUYVgg6y52zEFE1AkT5Tf0VXUrKs8S3/dk51R6o6DHu U6lPhwwJMYbdhQAeobHfOTMPTTH09mA= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gjYxZK1R; spf=pass (imf29.hostedemail.com: domain of yosryahmed@google.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737133358; a=rsa-sha256; cv=none; b=xkLts4y8rz2Q5e5bF0HYt/Tmot4gVbgceNMekm1mW5UrjV8SRjw8VRzefgso6BfsOkFZaa wTpPrig+BNnrCD8jeVbJR3RZSTzp+swDNDeLsRGfzHQG4f2oKtsvtOqtLSlUs6ggBJElXs vNvTKcM0/WOBO6B82Ojb22WQt25N8Vw= Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-6dd1b895541so51924706d6.0 for ; Fri, 17 Jan 2025 09:02:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1737133357; x=1737738157; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VOhRlzFLatiwMnMgWUCUofi8FW89XTrIZpSjj6Xqij0=; b=gjYxZK1RJKnwZAPylU5ZKyIJCQV+Fo9bDx2g4HyofWnteyw4VFiZGlgKPD65Gpv93A T9dAMX4yjgYsLlMcXYxKKKyu0hSoHo/T1Fak7MdChT2E3pAZZFOUWiRoDEU1yqljZkPi fj5t2OR+sgcUQZPJCMIUGqz87lv3hfAZFK7Sc/nn1X82UCz9KN85lgA8Js5JGAosLRQK S1d+W9AHgHm3zfhRRaHUjQfficDrktm4uPLs9J+u+u0Ub32Q+mh2BpYK9vrMsbH5oVn0 eYuG9Ce02zy+zheajdmQFuf1PI+Q5EPG+noB6in5+Bq2WaYtCB8pJhL0SBQkbzxkD6e/ 5qVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737133357; x=1737738157; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VOhRlzFLatiwMnMgWUCUofi8FW89XTrIZpSjj6Xqij0=; b=bC+b1zjO9lKSwurSFfmKlpXBCCzuxkHrZmA5QvjCYNF00szMRKNFaqU7HcfInNQVHU +CfXhapSt5jVSK9BTjgNnJvHgEXbRyr69cLW3z46HSZLaVBM7LJ0ulqVhlMDkGiGQHHz hZPQhOQiae5tbNABJmRZjONTkuTI3s37dlx8bjBNi3bO7i+LaLMTgi63XjwBO9ID0K/U 6BUAZmXzTZuwucUt+C6H9DiRaXyD57O5GKxTvSRyBkzZfQc7mGwOw4/eQoOOgHzQQTQD a0ttreihPw45Jvw2y3Shp0gD54CgTi9i9VSvjfnEcFf6yrGjz0BE+MBfaDYPGkpTeYMr 8Buw== X-Forwarded-Encrypted: i=1; AJvYcCWu/V3ocrzNuspPzSBox/vbtSRCQEQcQ1/KwCZKviCx6o17x7+Vl/i6Ds/zbBbaPKGdcdY18aI0OQ==@kvack.org X-Gm-Message-State: AOJu0YzEa7GeyMefbnJN7XJnxv8brz5/ujBrHpJjSCTVgL7lngKh3j/S mp6M+2CeMukZi5fvpETLbqwnDYHw7YoADHJFVV4hPgo30aSjgIffHNsqoAc2ghcFQI0UGMC2RYl m+9qzI3GujrwezV3OjcOaK6LnyjIYbNMOZDS8 X-Gm-Gg: ASbGncsawufEPS6PksCmAEyRYGWJwDPAwIe9hINw5N54xITqKnladf4geYSfNAY0xGa U71iOkRhaipTd1aarMQJtVzjlJROKdg6wqho= X-Google-Smtp-Source: AGHT+IHy2OFDrfhYJvKp9ooseej/uVcky7fBAj2fPTm7u2EE2MaqnfwXScOO7uisZqZE31rknNHwGfStLwVGA5D/w0k= X-Received: by 2002:a05:6214:1cc7:b0:6e1:697c:d9b8 with SMTP id 6a1803df08f44-6e1b216efb9mr60107866d6.9.1737133355973; Fri, 17 Jan 2025 09:02:35 -0800 (PST) MIME-Version: 1.0 References: <20250117014645.1673127-1-chenridong@huaweicloud.com> <20250117014645.1673127-5-chenridong@huaweicloud.com> <20250117165615.GF182896@cmpxchg.org> In-Reply-To: <20250117165615.GF182896@cmpxchg.org> From: Yosry Ahmed Date: Fri, 17 Jan 2025 09:01:59 -0800 X-Gm-Features: AbW1kvYx_hSht555Bb8ABr_l-VOiTdmK7c_18YD4Qnme2JcEqIgeCXZYh2-x6rk Message-ID: Subject: Re: [PATCH v3 next 4/5] memcg: factor out stat(event)/stat_local(event_local) reading functions To: Johannes Weiner Cc: Chen Ridong , akpm@linux-foundation.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, davidf@vimeo.com, vbabka@suse.cz, mkoutny@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7EFC112001B X-Stat-Signature: z1dir8kq4mzcogfwmkt9uajcdusxs9t8 X-Rspam-User: X-HE-Tag: 1737133358-642153 X-HE-Meta: U2FsdGVkX19cnYm4fqqN8R9S3ND2Q7Jqdup0Jg3l3VmFaIFj652clAYZavR1qT5bGSDUgjEWiD2JSu1XcfaXyXntkOel9h6ee7FqOgxNfCXAQEs2Vno5whT1CwrAVguFcSSqo7e5w0C+onT2KbX2tA3pFswh0FtzbRXmaHBJ9c5R8JkRaHAnbeIz5Bu1aI5Hs6RH5icE+BmpAxeu7mJN1umpdZCEJScyCOGnZmU63VLbL+ieZY6ja0PY0shgzBpJDzL43XMR8VAnaMR733ARE12ZILECB5I6iJeJxxnSZd7NXoEMEydBNPOdM2/C+AHhF6uNjNWANaYdvIK/acINpv7T1jzktPnt19rMwNBfDTpw/H6XzRJFQomT6NjimpM2IWpAKBT1dyc1buoD/CgBKhEV09UFFMRzG27Vk0RIMTa5zikU4wLz77K8wiSpf9/cl0RNb+DGhiQVLVo7wtsIkHW+b7ScGv04dHs1VKreDPUy5zXEG11CxTIeS5uLsGctJT23SRrFx+4xMYQRy8f/FAEhSfziorUcilUiMHPkpnaZP3md05sx8oyWvg3Ias97Kt6+0XQ0LKAePLwh9kQsj5KJlVQvqx9HlK80+qxJvcqaeUcFqO+B29iuGEBYlwLWctUiiQzL69KaG4ioe6FxGdUUWc2OXFTGTJcCZ6BX80NtqQwQTjPgI1K+KOgRYV1btLFIdvy6nsW4ghwIVk6R5PJdh+Av3KdmDmBIMyijxq+8XVmz1Vzps3PN/p72wMAiw2VFoUxUPUOdvMqyDbsRO5iOZck4FwZh+Qr3GPHk1TjNdedZ13EbVDr72NIg3eXRq6H9o1h/2WkTf3aM0UQrLYjix6ZM4PxhqpePtGLApFyjNhDQPvhZVYlyJk66tTTNvFkfAGGG+EuAmGyiX6b4ZVQHrSGfjBwKcJhwgYzmvYf5QgNyYutvCVj4BqjHjSoJgmDOG9ieVfjEFKDlTb/ ppPmHY7x 546cZ5UH70DUcHrumquOG2uxhv0hp4BVuxcKKhcf2XjatReR8yEsIdJyVeZGcRu7IXOMnvqIb9utDzEkq03a8aHOGM6smL7VmvaCiDeslhxFCLkivr8h8vn+zFbsDa7qx/L3SEhEv2XoV/ZiC3RhTOvz3GCrJhytann3rGbHyExFf1Z0GwH2KuuD8J8mQ3Tl3SktQtjnUezEi35LpH6XgZGppfbm+Kv87JSM3wsQQ858Iyir+a2dXUzT6vPFGtKttDzD+2P1/pEGrScfSzkgguOfL7jHDXxuRBnR+ZRdAm+jfzMR+g+rbHfNNXNT3bSOqfX7l X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 17, 2025 at 8:56=E2=80=AFAM Johannes Weiner wrote: > > On Fri, Jan 17, 2025 at 01:46:44AM +0000, Chen Ridong wrote: > > From: Chen Ridong > > > > The only difference between 'lruvec_page_state' and > > 'lruvec_page_state_local' is that they read 'state' and 'state_local', > > respectively. Factor out an inner functions to make the code more conci= se. > > Do the same for reading 'memcg_page_stat' and 'memcg_events'. > > > > Signed-off-by: Chen Ridong > > bool parameters make for poor readability at the callsites :( > > With the next patch moving most of the duplication to memcontrol-v1.c, > I think it's probably not worth refactoring this. Arguably the duplication would now be across two different files, making it more difficult to notice and keep the implementations in sync.