From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 718C4C77B72 for ; Mon, 17 Apr 2023 11:43:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F37928E0005; Mon, 17 Apr 2023 07:43:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDCBE8E0001; Mon, 17 Apr 2023 07:43:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA4318E0005; Mon, 17 Apr 2023 07:43:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CA1738E0001 for ; Mon, 17 Apr 2023 07:43:44 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 942FAA05D5 for ; Mon, 17 Apr 2023 11:43:44 +0000 (UTC) X-FDA: 80690698368.29.E5912DF Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf11.hostedemail.com (Postfix) with ESMTP id C112740008 for ; Mon, 17 Apr 2023 11:43:42 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=AJInmT4O; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681731822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xvYzdosW+pl7hdpIOnke9mGqwsf21NWemxvx9QGqO7g=; b=iIsMmwnaUNcVmGyhRrCxJfmGNVJ3irxzP8tno4jT5NTehRFpy4M/7CNAK3b1n4ntHFPSHh CFs+k0vBajGhDBuoaBPT2il5Pk4qpQscRbMob9mC+mghQaiiLfM609VaERaHqjAYyUNcPk d82psbVzrYpbK5PCsxFdNjp2JVQDeTI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=AJInmT4O; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681731822; a=rsa-sha256; cv=none; b=rIzWZ76FJ4AAh/0QHl+bF0MKGU9aUD9AYlGxecDj5TS8npq8oMDR+UiNe4HcM8H5hwvLl4 KgPuQHMB7Hk9Q/IVCi5fvQph3eWHiMAqgtABeGqKVAHE4f+WvMccJ84tpfA3/SVmPOztw3 TaAZpmn1Q9cMJH5HUHQxXfFH/EUD8gA= Received: by mail-ej1-f42.google.com with SMTP id sz19so6226184ejc.2 for ; Mon, 17 Apr 2023 04:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681731821; x=1684323821; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xvYzdosW+pl7hdpIOnke9mGqwsf21NWemxvx9QGqO7g=; b=AJInmT4OcLIEQY+GD2XQHALBCXIcHvQJqMLztaaCbt2SO/Qjzie0qsYDg/cMZin9NY i+Lk4tKMoh7EEmPZ234yP49QmA4o+SIAuUTzxNxk5qMrVekL0efcMGk4hzDS/ylir1tC jAYp9AOP1pS6eCFAkOLE91xVCTLgPtTpqUdZJuorzWUJj63up2vjB5qWYzloip/RjAA7 wAjI+BPQhckBSo+VJ3Iy+p1sTnszyTThRpn4Aguj4p7vYms28M3KeCefhPgVeqOxmX7C ERoJOyueRav2HAcqejybOPM2AUW4cyRpunPgnW/CEnsO8B5BmTAYT90WYhAhfzExYoxj x1Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681731821; x=1684323821; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xvYzdosW+pl7hdpIOnke9mGqwsf21NWemxvx9QGqO7g=; b=RodwZ4beCWYstoE/+EUbXy2Yg9vlc5Q2kfUTRMta+vEQdv8DWAS+iGA1OXMglk6xg6 wR+iuqWps+I/ZvOQvbljyf+EGfx78so8DHEiEeaLHGGD3W5YV3QlrTOhY6wMSCuQhoNR 2aydkpmxmeK2pObfSou55hfDZJtIf/Zo4wo7WizPclywL4GPfJGWxYajQFcAq+4WD4DG r8xO5O54CGRMOBJMPJec23rxctonUtI2ljaw8HxzWGZ6yDYwQP1nc62wlBPn6THjBntF uTGbvefu/YKQjjKfaJH6kYJtiCMbdOO8Kx2Sc9R0I9MTVadj40+tAVZqrGQC7R+j3yI6 Zkxg== X-Gm-Message-State: AAQBX9c2J8yQpgZB4gpvmRA/aKaweUL0TQ3qiY326ojR53ZA/Wvp2T7d oTU2s1YMXIZJJhaSn5d2aEyrDtVb+LZi31SalqFbMQ== X-Google-Smtp-Source: AKy350btwfqyhvz2GjP4rsO5HviV0z00JGlfvMRNBkF1/rvxruwwQkHN7fuoOYEQbY2b/B3+Pbac+RzAvLFXaJ7JwAs= X-Received: by 2002:a17:906:48d4:b0:94f:1c69:f309 with SMTP id d20-20020a17090648d400b0094f1c69f309mr3146862ejt.15.1681731821217; Mon, 17 Apr 2023 04:43:41 -0700 (PDT) MIME-Version: 1.0 References: <20230304034835.2082479-4-senozhatsky@chromium.org> <20230417050140.1653593-1-senozhatsky@chromium.org> In-Reply-To: <20230417050140.1653593-1-senozhatsky@chromium.org> From: Yosry Ahmed Date: Mon, 17 Apr 2023 04:43:04 -0700 Message-ID: Subject: Re: [PATCH] zsmalloc: reset compaction source zspage pointer after putback_zspage() To: Sergey Senozhatsky Cc: Andrew Morton , Yu Zhao , Minchan Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: C112740008 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: wrd3gdqhj7n565s7x6ogys1b8nysqosg X-HE-Tag: 1681731822-324478 X-HE-Meta: U2FsdGVkX1/02Hw4jleBsk87iRJCcF3LC9+At1n3Hg5SZwtYJpCqa1+o8h7MR4e7BrYnQo6buET7PvxVbrkJ9zTMm0W91aSA+G6lFGltspqBoV+rC0soHbUkBq9NxCrH7W9qbBASSEXor/cHT1N+tjp2K19xWYQt6yC2Kvx6NG+N6RP5cuim4x2cJLIsIjRYs4mPT2JzB+sA1eYorO8WyhI+tStM3KuOm3ux7GgfBfQvJcrwLXIGpO1vObEJb3McvengMBZhXfKmJjIoYdNURRI96O6AvvvNsQZEumQdVwWzazkET6s2sh/ObnXM8mHtKFBySWSOQNUbdastvE4PF1I9fo8Ywz5df3MMwihCdTufLk+qr+OHDeQX+BMJ5ylft6f4vwJ0a/o9gkKnGiTHcuSUryOLJcTRBEQq8jNEInZH4cMp1zHU5edNgr6ap12zH1lil4AKG1spzJQlno3OVYqN0gR4gVMgdlh4DfIZn70FY9mqO9u59ORIlAO7YlU6Gk9XEJmi9XFRXgDDgyvA2n7VMLRCih2jgIiCWRjzHeP+K8T4FUWnsNdV3tbmrx5yWWPoxUMDLgHFgyOtr3RgW/fwuSEva4JKT6iZOWTKc06KCMrrDJi7SoDkSdPoxveuPw0HUwv1ea+z2INxm85UEQ60kPYY1V2OV0XfiSlRrZtxRbVdiJNCG9xnXlPNqRZ7a7dGUPfqH6alynVFG++Q5rHqEiZo7WdFcRrSyZ6d8Fhy6xWtwDtdXFRboR8ObOOFIIaIBIaniuAlFGc6I9ZyyygYdmMOwoUP0ZhTQ0Vs5rymYQo3/sPADhCY4W10zjKNP+V/Lm/mw8sOEoEiubdLCwsjlAYHXaiNbZoz99R6b9mXlH3OClD60qCtS2fzNwDRiupw5ubuDFMzfxj1AOoFCVxLC8sIp3inRaER7PxAz8SAIxZIIoj9Rdg626Os/ZI5xnSsnWQVSNhfuNewXCD nOxaFV+a Kf/DFil9vPvMOrPYr8NylSjSecrC+F+NNmyfpp/RkqpjXBV1YWxvsgInnjFUv3SrcJQGBRJwIsBQSR+9dQX0XIV1UQ79AcDiYmVv0H/0ItDqiESa5Ma+pJuiNAyLIgaU+uRSq0cZayLmz3pjWkCWniBVFMyFXguJtMawwrWlpdp0+4TO6N0/QEZZM+LjKXUPudeaQZeaoTKG1bA9sYeZrkTqWHZnGgf/eCXcvdr1/NVNeOIC3r885dVMIzxvI2fiL/iHGcDjGKL3MMriIPd1lHTRjLdAvNMwTJ57OLM/dc7a0kJV4o0SEecJfJfSIji+d+KibnEa/7BlMezQLpyZ24iQ3LlJbiJEwF5hWoPOGY2q6/HmR57J+MPM1tA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Sergey, On Sun, Apr 16, 2023 at 10:01=E2=80=AFPM Sergey Senozhatsky wrote: > > Fixup. I think the original patch landed in mm-stable already, so we might want a proper commit log and fixes tag. I suspect we want: Fixes: 5a845e9f2d66 ("zsmalloc: rework compaction algorithm") > > Reported-by: Yu Zhao > Signed-off-by: Sergey Senozhatsky Otherwise, LGTM. Reviewed-by: Yosry Ahmed > --- > mm/zsmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index aea50e2aa350..cc81dfba05a0 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -2239,8 +2239,8 @@ static unsigned long __zs_compact(struct zs_pool *p= ool, > if (fg =3D=3D ZS_INUSE_RATIO_0) { > free_zspage(pool, class, src_zspage); > pages_freed +=3D class->pages_per_zspage; > - src_zspage =3D NULL; > } > + src_zspage =3D NULL; > > if (get_fullness_group(class, dst_zspage) =3D=3D ZS_INUSE= _RATIO_100 > || spin_is_contended(&pool->lock)) { > -- > 2.40.0.634.g4ca3ef3211-goog >