From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CDBEC47DD3 for ; Mon, 22 Jan 2024 20:49:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECF736B00B8; Mon, 22 Jan 2024 15:49:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E80216B00B9; Mon, 22 Jan 2024 15:49:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D208A6B00BA; Mon, 22 Jan 2024 15:49:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BF1D36B00B8 for ; Mon, 22 Jan 2024 15:49:45 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 533E9C06D3 for ; Mon, 22 Jan 2024 20:49:45 +0000 (UTC) X-FDA: 81708138330.24.B27C1D5 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf17.hostedemail.com (Postfix) with ESMTP id 83D7240020 for ; Mon, 22 Jan 2024 20:49:43 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DACoQtNc; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705956583; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a3IFgXkLl95HUfhHT8xvYlvUcRJv9Sps5HuKi7yJyr0=; b=PlHw6PBSggpEReBD0CckocptTsDomA8bRVYq6E/mihrBK9xf/YN0aeyeLcLVmFS5FkN6DV UsXrg27N+nV/oftCuEtGtlUERRoM6D0gXfmPp+ofsZS4kp2lqYEwKAXlIJ0jeguHetkG9i sojWLhi3MuLSmMsVwSgkAbyS1prZfF0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DACoQtNc; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705956583; a=rsa-sha256; cv=none; b=pDPKuC9oKPofacdnGNOqeJyiEUCwX13abfI6FCL6w/HNmRPYE3rYV85cr6UjW1XQGYJw/U uRxj6dqfA4WmxavXL9T4BSeHBl6p9TBRGat1nMhOyYOyqFWm7goK28Hy/YZK62cmGABijl i5bjeishIUWFniK+ooS914eZTNE0Cvk= Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a271a28aeb4so389409766b.2 for ; Mon, 22 Jan 2024 12:49:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1705956582; x=1706561382; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=a3IFgXkLl95HUfhHT8xvYlvUcRJv9Sps5HuKi7yJyr0=; b=DACoQtNcndA9YltZrqsYX2UynabAS2HdGZFGfmzwRS3oFqshh+f+Dkitxo8wQFyEde TD+scrxRqJMPEbyNDzI8rufwTKLKsbiFN+3jjWfHxUF3gokCj630c9Toc6WOv0nVjjGO PPPkMHcAVNhvIn5nctc/Av+tl9xnNwLn/RUDqKCwrnObzSdnSvGj/VjHdSZMOiBtnepz 6BTEsq2DBoIogz4ziezFlR8BbiEk4l1jeqdVPNC4EV/X7HfXIQ0ZQPRuSa0MEX+4Kcf+ PJgdK0ghadJDMXYUiLj1a0rQFNQBjVHcBs3vhHAFJslQMcGm/XI9cYAIGI3xLkTxLPEt v6xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705956582; x=1706561382; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a3IFgXkLl95HUfhHT8xvYlvUcRJv9Sps5HuKi7yJyr0=; b=jZ3zwmC6EuAhRACy3fv0jBMaw8xgp4wztUA/fEpf9te0cG6TA8r2SSV1q7PHgzVul6 LgJJtY/h6qkAGbIpUH+mqXBl0tzX00C0M5EDT1Owh/vO2ydjUnHo3ugjLPOAH7W22QT8 ZVGjjTdT2NWpZK02rERiG752misVDYgwnzboFPbjLRMsIRvJ34AwBY02/mMKdGBIcSXZ nctlokA7wrO2L9gsvfHsvmQTwfGkY4/rldHQCLLhw+qnmav73CHy1VV/FGQdJF1TDLcL Bjd3DQhFoDKU5md00AV+Pz4OLHZ/i1UHyT+jgd+rPNOdO8uA7AzbecHpz2vmGc5cS6qe XCDw== X-Gm-Message-State: AOJu0YxXcXlRLkoT+jkEvyGBnpr2G6Wh3M1sYkcc2VL2EduAYrVoiyUN tztCZmNA8YCW+wX86OWsS3tc/5bv2XcgR7sOTQxhh3Q6pRFdELIxmA0u6OduptKcBccLXu+28RD AdtTpgJCe1TM8ii6qI3EPPXrcs8lFSg06w7NF X-Google-Smtp-Source: AGHT+IHmoA2jzTQf7fFoYCB9p19IElaggUb5JNtVRvLZRR2GWNFR0iDWTD7SCEap+uVo0WQVp+gXFBeD6HpBvfznDFE= X-Received: by 2002:a17:906:3a8f:b0:a28:b574:8551 with SMTP id y15-20020a1709063a8f00b00a28b5748551mr2420412ejd.147.1705956581807; Mon, 22 Jan 2024 12:49:41 -0800 (PST) MIME-Version: 1.0 References: <20240112193103.3798287-1-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Mon, 22 Jan 2024 12:49:05 -0800 Message-ID: Subject: Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED To: Christoph Hellwig Cc: Nhat Pham , Miaohe Lin , Sergey Senozhatsky , Huacai Chen , Nicholas Piggin , "Aneesh Kumar K.V" , linux-mm@kvack.org, loongarch@lists.linux.dev, Johannes Weiner , "Naveen N. Rao" , Minchan Kim , Andrew Morton , linuxppc-dev@lists.ozlabs.org, WANG Xuerui , Vitaly Wool , Chris Li Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 4jrxfffey9w5rcrisbsrkj97qrrc51b4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 83D7240020 X-HE-Tag: 1705956583-843635 X-HE-Meta: U2FsdGVkX19X+BjL+nrdHphvooOGR3C9PSItQbXyEJc4vZjEQbgC8GTUfNhWl3m0xKDuJ699BvILQhFdsRE3BarwyAo+gRu/g9r2PbKL58qyt7TkpdBYwAdQJhHym5hMGKEoVnYhX1JuV3NaeezN+vG4lVFA2GSZsYaCy5HClLBYoCRhRcB75JZBGUyGEpniwoQLwUC9X0uHgVB9SiRRSTwUVjFj9KPEOSxQTr23IMYsDCTvUKKA/EJJHy/4E6s0jMG9NLix0lZ02UMRKoNWmvdl+t4itidbAdEztCxqD0JETvAd6Yy7ebMiFHLtYlMXRBV5ADu90rNR4ZkD8FfJVQly9kinLpzXDiCdZsLb3Z/QeF8gNN3if+CWIRv8D+vcsSgh01Z38MPwgysdn+WAwpvSbsTUYLQwn3lhGh194ngvYwyizAgoQe3xqPmgRY7QWSU8bHWMIrQGMsY9ia8TfUG11g24Q8FdKwRY9MPWtu00Rouer3Ux6SikhnHhT7eOjiXAcxt7oeugKMRuxQnKdbPe9VCcQlRZw4303CNJGhp+STRrz6xYfDUOlaonu+syV74CXWA+RTi5P4QpYaYYdSs692hT0fOC4TSMDKWNzgtzxytO7LMzsDQnxz/nqOa9Dt6sann1jNRcyeO9BANvmXKlILmgZU216dsNmVJiGAoSAkceLQxmbiND/vG6LVXxA1TfISFabXLpSeMacExoHAhmqi1CPOzgNfErLesHw2tmTXf+D5/WijYdDvfoGLZYYhDFS+IMq/Lo+nIrv6Q7Whfd0l1TaLvodFheuTMGscY8nmB3htnLWHu/wTJApAtdwM/y/G3tj9bDDU2yOxbho/A5Cfi3XknFvPjHLSjkwPN0zz++pajSOP91LS2+n69CQloLHUu3vLcDL9qFzR3Z6llvExqJ8MKemFW23u5PRhNxfgSNucLA8Uu1hY8+az3ubjg8bmHCZV5SnY8WYe9 xvShTAUv WDsYJ4esuFnyTRdL/ZtlyksbJiwNPB+dFb2KYOzURQeqTqLHej2pTkg+VpK6SEqcdpGrsJMCK3+cQ66N8w7sD6mz4BOH+tpq85uZ4b4+bCsM/Kk+tXkTLe4461mcw8jTkHWb50gIjdDEt4Gcvm9qlSBylE1E87BioqCNphyQg6NPQZkD636+ESFvEw2/tqUDUVq2+lmstKkhzd/pwlN2Mu5Pog9UfaKExXxbUNF5Ck652mvXTdkf4kEfrQj8DGL9uE2ztqrsilt3Fnurgjcu1lXHXl2vLbwuPWic1M/2BThh3tTU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 21, 2024 at 11:42=E2=80=AFPM Christoph Hellwig wrote: > > On Tue, Jan 16, 2024 at 12:19:39PM -0800, Yosry Ahmed wrote: > > Well, better compression ratios for one :) > > > > I think a long time ago there were complaints that zsmalloc had higher > > latency than zbud/z3fold, but since then a lot of things have changed > > (including nice compaction optimization from Sergey, and compaction > > was one of the main factors AFAICT). Also, recent experiments that > > Chris Li conducted showed that (at least in our setup), the > > decompression is only a small part of the fault latency with zswap > > (i.e. not the main factor) -- so I am not sure if it actually matters > > in practice. > > > > That said, I have not conducted any experiments personally with z3fold > > or zbud, which is why I proposed the conservative approach of marking > > as deprecated first. However, if others believe this is unnecessary I > > am fine with removal as well. Whatever we agree on is fine by me. > > In general deprecated is for code that has active (intentional) users > and/or would break setups. I does sound to me like that is not the > case here, but others might understand this better. I generally agree. So far we have no knowledge of active users, and if there are some, I expect most of them to be able to switch to zsmalloc with no problems. That being said, I was trying to take the conservative approach. If others agree I can send a removal patch instead.