From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11CE9C25B4F for ; Mon, 6 May 2024 16:13:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B9BC6B0099; Mon, 6 May 2024 12:13:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 869346B009D; Mon, 6 May 2024 12:13:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7311A6B009F; Mon, 6 May 2024 12:13:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 53C216B0099 for ; Mon, 6 May 2024 12:13:33 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 019AD40923 for ; Mon, 6 May 2024 16:13:32 +0000 (UTC) X-FDA: 82088466306.17.46D03DD Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf06.hostedemail.com (Postfix) with ESMTP id 09D12180018 for ; Mon, 6 May 2024 16:13:30 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=HGewapqB; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715012011; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WCYAJR1IdgPjREP1tbDJpbumcoJvWIKDqFqpn65YT0o=; b=Ie6+waBH2OQlyHCywvGJnknQu8XLZ2nZaqpk1gvtzfbIni7eLBj+4h+yxTlHjl1PG5Lnk/ jzG7COL5fpBI1ik65WECgShJOQBt3W/+O5D8CR1RtMshKfs+9GmTEjX5XYeTBbo5X76O8E f5Nv4yiIohrpgY5itCxH0LpSdYbV6EM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=HGewapqB; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715012011; a=rsa-sha256; cv=none; b=gSQjiHoF7xc1hX9irJGU/E1hy70/FFEo/u/zdrZfBzYX2MNb91k0FSkwDdREG8dNVF8P3U ntA9n4kxs2S2lD/cp5A+wiOgWGGHIND2rnz4RdIUT4/ExchPZmdhWoOiKTTsShO7pvVYrI OZOh6HLR9eeB9ogvV37Ckp8WvLx4sj4= Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a59a352bbd9so341216166b.1 for ; Mon, 06 May 2024 09:13:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715012009; x=1715616809; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WCYAJR1IdgPjREP1tbDJpbumcoJvWIKDqFqpn65YT0o=; b=HGewapqBXVUVSXw4wIrlQrxobStpBdbA0JC9AoXOMKorDTZHD5lUbEo6lZMEGQWp3M bQKnCYfyYzgCXNqrEb8Njl24nJkm/gB5QOP4pj9JFSiI6/4D1RCddiWnT68yM2NXfz+B Og+5GcTPczueglXY/gJs0+vTZZGmFlkVRNPX37UIEeKtGytI+fj12QLXPNzJubtMgvPe HaHU3+16VYAERM5PXWPewOq/GsjCNVVhzj37CUTDB3bh+XIEL7EgsS93DrtY/5uBujx6 ZXI2D9DRnMl+lkpK9Kr8lyAYAS49mdxwPAGm0eIMJQca3TnGQ1qFAx7ZPqj44QVobV2G An5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715012009; x=1715616809; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WCYAJR1IdgPjREP1tbDJpbumcoJvWIKDqFqpn65YT0o=; b=N6q1Tie1TUBwyFjF5gekDyz+BxxRTZuWtIxA9XwNpfA32b8snou9TZ0pSCaMA2QgOj t2S1Msprih4rSkBIn/qMOhbjG0uXxIEY1rQSXVzHFluaKgRKDzgt5fPknMa1ISYStDUi aLFgR/+5mNAx41z5IIuslrcF6Rb8eMeNEqZFWq7GKHdSImDx8wSC3S6iItwOL5ULootU 2JPacSfcRARfEnwcZrpplBlOlHrrMtkZEKQik3yQit9gQzr3DugdWniCxSEDUpk8zc2l Ry72J16vMXJOgvwmTgVS6/K1MsY6uyJV9uQTkH1dyrvchesIUyk7FbT8h2kUZz76yfrc yuKw== X-Forwarded-Encrypted: i=1; AJvYcCVhHA6kPTmEJjq6c/arl6FTrWR17R6GD9PAXXRaUJg66zzWk+1n/wx3UMX2S99AYZaAhngYR79yEfKtZHui0JVxv4c= X-Gm-Message-State: AOJu0YyGTyhHu6vS4Au8XRsUsPHjieaC79XeGnGCQtOZMs5qoTmcA1Zv ZUsXZFkUL/xTyOAAl4KQ2vM3Tu2e/RZdw1RQprfgpX8mPoy6YMJ46DyN9vWkRvWeO9DNYeqfYTH /sMdUQYAIIqMgS0QAcrbqu20pl9re606cy7L0 X-Google-Smtp-Source: AGHT+IEl6O4ILNj9fQHQiZgV5xjHRsOzMtUZx6feBdBMRClUOE2LxlyQoEi9EaI8l5Y5k/bVp0avGFzlHE80pzDES6s= X-Received: by 2002:a17:906:2a98:b0:a59:c807:72d3 with SMTP id l24-20020a1709062a9800b00a59c80772d3mr89978eje.17.1715012009336; Mon, 06 May 2024 09:13:29 -0700 (PDT) MIME-Version: 1.0 References: <0000000000007545d00615188a03@google.com> <0000000000001b9d500617c8b23c@google.com> In-Reply-To: From: Yosry Ahmed Date: Mon, 6 May 2024 09:12:53 -0700 Message-ID: Subject: Re: [syzbot] [mm?] [cgroups?] WARNING in __mod_memcg_lruvec_state To: Shakeel Butt Cc: syzbot , akpm@linux-foundation.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, muchun.song@linux.dev, roman.gushchin@linux.dev, syzkaller-bugs@googlegroups.com, yuzhao@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam01 X-Stat-Signature: 5ugprhi95x8aihy3qz34hz6jkkdwnadp X-Rspam-User: X-Rspamd-Queue-Id: 09D12180018 X-HE-Tag: 1715012010-617362 X-HE-Meta: U2FsdGVkX1/iCPlqoRj0Y2ktqaQtSBmab/FZl22mNxdVE/2vLmAD55ka0xdoKDHcFyyzbKQeQehAY+VORgVxOjkrDiL2QfxRO3wbS813NU/4fZT8iRUm8zMpcrnBl0RyvQAGCU93kli2MFVtPKXPLdiwkOPFhAXdcrzleuh1pdr8VvOtKiCLg6fmIVG++2GX71x+Kt+J6wzwi3E363slbn7k1DAlmoyztMyXolwhfuC8m9mjUVwdeLMi65T2y/1LOppib+oCExJTL8TVlWrS+3WVfLwZY7R4v/vPKu3GZKBGQmSQOO/A8CG4+lAgRpj8cWq4Il6v8drbuh7zlOyG547jKV/03uF3601/LsQu/trvUzMpya/ze5ccyZAFbWMjRywsINKMkajPEBM4sIREu8MJDRqyW+uB0AkD4A02lMi5dRdQmDgxuggTmWPfFMsxGUsaQyT5kT9MgGVNCGZnPmtVSEHQXaBJkpmPhA1SZDfHrndB2y8DvV2LODIDuO3yJMB9EQmLae16kr5vJy20BdE+Jnzw9gwTmPfliiRdrfN+SjO+CVe2aF31RKm+I7KWDO7HoLPtL090/QZnr7wKdeiFbbK/WMPoCu1kjwZsO+Jeiklgs2NNZgaFRbLlLHPqCV+74h0CUKwsm8/xRWmTD/IEiEIuRCSiKfr2kRbErpi2wAxnwASapWs/59uaW5Y8f86fNqEHJEL69u2vXUZJpeXDwmavfXEQ64SJAy/FcTFRGBHCfL9l1TD5ZAYgRKnIckJ13v2y+f1jXkFF4+SLVlYNllAOQTx3nulLg7yqG6PFVAR1mPIOZL3Blv4YCdOL1I/6SlSVWXcqjWepYwFLiLzKO21YgXE1XJCFc2PuO13wp2Z6nQekLHCj1C2tWmTb8fWrIA59SL4pGe29JFSiKDEcQBJdvBHCjtUTJEIPc3DDhdVAfaOklqxWqoF36B/SmqTbsURxH3X9y8PWL/g OkhSAnJ+ jy5a6f5I/jO1MfXn0DgJVWGArtSam7BpuAKTOwaVO1o7v2s+gidzf0zuTeGd8VsrPBbszU9Ufbwyq8iEg7P6m7j8Og3qoSjQGbrjHZ0L0UQ9NKAVxFkoCiKCabo9EV3TR9JNqPuENUm9HsgwA3zAmMmOIa/aFVH5a+Da8jztPz+bCik/wHUz0ynnFAlXr3Vvwf31/n36Lzvxr2NYfFg46BCFrR21b95rWlsglmeBk5wQ39fsUmhrJnaOahyp3J6Mdb5rI/1wUSSj3vTH3UOd8cViL1MMoThbCsLoC8QjRETT0tGzFLP3vIetWh0+OfkcE6zfg3R5kKN0ssc5sJCL61vhxX32jdnSfx+Em99DLscP8UEykMg6oansd69JBmkH9SEAZOKO1HAjDDITrFdn5NRDs+HF3iDQ4CpSVTUXDvsfFnPrs7aTiMZ/lVkBKbj2d/X4aX1Idh1nj8U/VAoV8MT8sIE0oFzl1nSznPrm6ZnNOnx0JZJ+CwVENqR+cLCTfWF77YG3X0dNBsO9+YkioENto9Yiax9HZwd2XnA94jPDg1L9s8T0CdPoGAkEuQbI7NIF+1302djJZifjy+sgPNJ/9w5WyFG4kSJp3lxiJUfNBYnZsMO5C7TgWhr5mn1PFWf0GVDb3C7D62c2ySQCfNscdN0rGhkKu9P5Ify/LBeeg/5JPk4yZ967tPHQzo8wi0HLenp3sxV5MqmOAgYxndoLV2O8ho14zAxlxw3eDFZrXEUIAoB5gFfKNu+Cix9C4HfRlfXQLNZ2AHwfC+JKiHnnBaqX/pSWfKx0OIKIkjVK6h7RWYLByr8cZwryBBEqc7oqKHns1hn+sJ/zkEp4n/Db6Bg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 6, 2024 at 8:59=E2=80=AFAM Shakeel Butt wrote: > > On Mon, May 06, 2024 at 02:11:57PM +0000, Yosry Ahmed wrote: > > On Mon, May 06, 2024 at 06:03:29AM -0700, syzbot wrote: > > > syzbot has found a reproducer for the following issue on: > > > > > > HEAD commit: 2b84edefcad1 Add linux-next specific files for 202405= 06 > > > git tree: linux-next > > > console+strace: https://syzkaller.appspot.com/x/log.txt?x=3D1164931f1= 80000 > > > kernel config: https://syzkaller.appspot.com/x/.config?x=3Db499929e4= aaba1af > > > dashboard link: https://syzkaller.appspot.com/bug?extid=3D9319a4268a6= 40e26b72b > > > compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for= Debian) 2.40 > > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=3D123d5d1= f180000 > > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=3D165274509= 80000 > > > > > > Downloadable assets: > > > disk image: https://storage.googleapis.com/syzbot-assets/6a22cf95ee14= /disk-2b84edef.raw.xz > > > vmlinux: https://storage.googleapis.com/syzbot-assets/f5c45b515282/vm= linux-2b84edef.xz > > > kernel image: https://storage.googleapis.com/syzbot-assets/9bf98258a6= 62/bzImage-2b84edef.xz > > > > > > IMPORTANT: if you fix the issue, please add the following tag to the = commit: > > > Reported-by: syzbot+9319a4268a640e26b72b@syzkaller.appspotmail.com > > > > > > ------------[ cut here ]------------ > > > __mod_memcg_lruvec_state: missing stat item 25 > > > WARNING: CPU: 0 PID: 5091 at mm/memcontrol.c:999 __mod_memcg_lruvec_s= tate+0x18c/0x430 mm/memcontrol.c:999 > > > > This doesn't seem to be the same issue as the original one syzbot > > reported. It's the same function but a different warning. I am not sure > > how to tell syzbot that. > > > > Anyway, this warning is the one newly introduced by Shakeel. It is > > firing because NR_SHMEM_PMDMAPPED and/or NR_FILE_PMDMAPPED are being > > updated using __lruvec_stat_mod_folio(), which also updates the memcg > > stats. However, these stats are not exported per-memcg. > > > > I think the following should fix it. > > > > Hey Yosry, can you please post your patch with the signoff? The patch > looks good and you can put my ack on it. Will do. I noticed we also update these stats from __folio_remove_rmap(). I will send a patch fixing these as well, so I'll not include your Ack for that as it will be different.