From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82371C43334 for ; Wed, 20 Jul 2022 17:36:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E00C76B0071; Wed, 20 Jul 2022 13:36:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAF6D6B0073; Wed, 20 Jul 2022 13:36:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C769F6B0074; Wed, 20 Jul 2022 13:36:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B5BB86B0071 for ; Wed, 20 Jul 2022 13:36:07 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6247680677 for ; Wed, 20 Jul 2022 17:36:07 +0000 (UTC) X-FDA: 79708181574.27.7ABB1FC Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf30.hostedemail.com (Postfix) with ESMTP id C90318009A for ; Wed, 20 Jul 2022 17:36:06 +0000 (UTC) Received: by mail-wr1-f54.google.com with SMTP id d16so27108812wrv.10 for ; Wed, 20 Jul 2022 10:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=02lsKOmjymw0+voRSiZssITm3QnQDwCZm++EAm96eVk=; b=AXz4zLK1VM061H4lcJHGjYLvRNfx+YUTCIfw8oq3KgqGXfJomypHgHt+ZjUVjSpkw7 ygfdWOTJN6EKqQPYnyG97Yc9pSYo4apVrs685dRj2Lis1r313+yLrAE4zAnyES49TN3Q lNcDBCtRLJFxz8TyiWl0yMv1RoxKjDusQIC6P579ng+zMKgK2gaZPeAdN3puFuuwlnS7 HKHcJLtVxhvMvaIqoeeHrzwsR8KA6ih1ZB56OPQc98CikP+vqXQgFD/VuEH63RuvK/sa 8WBl+IeOZ4d3hEpU00LbcHvGxvYwKYjFAuzwqdsEXJFfTblyeJv0cGW13ou6DV33hOXv Sw4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=02lsKOmjymw0+voRSiZssITm3QnQDwCZm++EAm96eVk=; b=NSRauZ+Rxmz43TItQ5BhSkS+TOIcSzdAWt4kXMiGy+6nAZu8tJCNQIhmjjmxRKF9Ln i+1K3Lo8omHIhNUzrjfhitzD9bX10BDlt1g+LT6sEyoxkyL4lQo6lF2pFtJunYmIQUBU tpW7GeRIYHBWdD5gRGQf0voW/w6GDC2PNrP24IdXBTPGRn0n3iz1Mk0EMj5oL2IFOoUv fG+5K4C+iCP1T/6YLrVwZDlES20TLcm64iVS5SG3z3hr3/VQAQHIex6cCz21i5Aikt3+ UmuMXQ2n2Me1nTJSUONGEtX/ogc6kgK5RlycybjjqvsVOqNSTaas79VP5L4GfBFKRk3g sUZg== X-Gm-Message-State: AJIora+/+KYS/efyMzG4LBr8OA+LBKzi9Ci1Uz2X9rLKqIR0cKmCSVki fiRl0lc5DKTbuUz0qYYkFLIIprF2FUHuqNpHsf+1tg== X-Google-Smtp-Source: AGRyM1sVDW8tYnXZDH5GAJtfDD0oKvvEaaIMt0UCdQWhpZMJt6LRZI0HjOnjkG0MNPv2hBnm38VQ0JCEOp4f1ZPH0dQ= X-Received: by 2002:a05:6000:156f:b0:21d:887f:8ddf with SMTP id 15-20020a056000156f00b0021d887f8ddfmr31271381wrz.534.1658338565332; Wed, 20 Jul 2022 10:36:05 -0700 (PDT) MIME-Version: 1.0 References: <20220720092918.GD2316@kadam> In-Reply-To: <20220720092918.GD2316@kadam> From: Yosry Ahmed Date: Wed, 20 Jul 2022 10:35:29 -0700 Message-ID: Subject: Re: [PATCH] selftests: memcg: uninitialized variable in test_memcg_reclaim() To: Dan Carpenter Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Tejun Heo , Zefan Li , Shuah Khan , David Rientjes , Andrew Morton , Cgroups , Linux-MM , linux-kselftest@vger.kernel.org, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=AXz4zLK1; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of yosryahmed@google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658338566; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=02lsKOmjymw0+voRSiZssITm3QnQDwCZm++EAm96eVk=; b=FQ2oxJR5bcVlu1btXiDcazSBpzMcxRX+BY1Dki9k5uRALvCa4+Yor/MSHQywo2xa/LECo3 +CEsxpI0nY89D+aHI2EqftiZRLaS46fNw+siT7GdqnYPHPSKadfB+FgioT6VYK5U2K0pzI mLrwktk9vKXmHM0Z/Ap+S5eT0DChscs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658338566; a=rsa-sha256; cv=none; b=W+hV0TBs3co6YKmlDBPnBnys2gakH0sHFm4lKKT1GgpIIJJv9ecjGOshjnDfoIl2v5QZmA iL6dgEezbsRQwTP3baZ/Q5vY8LBpI82eunFwJzEiZDt9lW0IkzNRkoP4co13Oq+ua0pBre ecI7CvtGYwEm6DynHlevCr2X5jSMiOA= X-Stat-Signature: irjtp5o9ph6bx9tp446puwka6gw3mjdd X-Rspamd-Queue-Id: C90318009A X-Rspamd-Server: rspam08 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=AXz4zLK1; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of yosryahmed@google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com X-Rspam-User: X-HE-Tag: 1658338566-782678 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 20, 2022 at 2:29 AM Dan Carpenter wrote: > > On Tue, Jul 19, 2022 at 10:27:36AM -0700, Yosry Ahmed wrote: > > > > Nit: keep the cleanup_* naming for labels to make it obvious and to be > > consistent with the rest of the file (e.g. cleanup_free, > > cleanup_memcg, cleanup_file/cleanup_all). See > > test_memcg_subtree_control(). > > > > I would honestly have one label to cleanup the memcg. Calling > > cg_destroy() on a non-existent memcg should be fine. rmdir() will just > > fail silently. All other tests do this and it's easier to read when we > > have fewer return paths. My advice would be cleanup_file and > > cleanup_memcg labels. > > One error label handling is very bug prone. You always end up freeing > things which have not been initialized/allocated. Or dereferencing > pointers which are NULL. Or, since most kernel functions clean up > after themselves, you end up double freeing things. I am not suggesting a single cleanup label, I said "one label to cleanup the memcg", which is separate from cleaning up the file. Basically just merging the destroy_memcg and free_memcg labels to be consistent with other tests. I don't feel strongly about this anyway :) > > regards, > dan carpenter