From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E6F9C77B73 for ; Sat, 27 May 2023 04:13:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D7F8900002; Sat, 27 May 2023 00:13:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AEF56B0075; Sat, 27 May 2023 00:13:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C3D4900002; Sat, 27 May 2023 00:13:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5047D6B0074 for ; Sat, 27 May 2023 00:13:45 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 179F740FDF for ; Sat, 27 May 2023 04:13:45 +0000 (UTC) X-FDA: 80834716410.05.5827E23 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf16.hostedemail.com (Postfix) with ESMTP id 389B6180007 for ; Sat, 27 May 2023 04:13:42 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=00i267X+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685160823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2CLI5dDlGRzvV0LMDARHxx4pfVRGX/zlI8ZJMCOjbQM=; b=wvXm5hJiwAwZ3czDjVCfyb8ePmHwyjltCMcskTW8H2FFDVrxPAB8yIfirXURkmOFAGBnkn MKLntKHUpfkVsSAT2C4bIvMjkKsS+6Rqpl8flvJnWyOlll99jlmnTuTkFvUvVB5FVfOZ36 BnTerl/hP6NLbWk4veP20gqGJS4hfJg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=00i267X+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685160823; a=rsa-sha256; cv=none; b=vGjseVDDd/opd/BH/ehdp3H0adYBC+vEtjJX04qfSv2Hr4OOKTbTrkXivedTaoPCMyOlTY qlZuFcQcxOoCNxP03WSgkx5Bt/ZLIrdqTvaIKN8tkWcwjr3rSWZqNPvZu2LkBn63VHBh/D ERVXuJlK+ICRFW/D+LAnHxhBDBZ5ooA= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-96f6a9131fdso210588166b.1 for ; Fri, 26 May 2023 21:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685160822; x=1687752822; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2CLI5dDlGRzvV0LMDARHxx4pfVRGX/zlI8ZJMCOjbQM=; b=00i267X+Zy5eHdWjx6icwa/P4rEW82q+O0IlAkQOt+vbOOfMFcbzvHAqzdv5/FL6Tn NGyG8n911S2yL4hThaPoslwa2Yp0aWDGMz1hzLFHXKZNQaQomJqFbN/bS3kmfm5rIZEH E/kTKAFGZMSFyjfPuX0trHV8y4SyOcNW4XxXMuPtsqKb75/O/An4NBcrABlt0E7wYMco +6FcgBKaPsFKWh5JEpm8ONiFvKFQDl0Z6axXQIodaarTWfRB4M4czFFJCh4bzCIgMf9j bD4/klzy5Hx1YNAZL/T64uaDacPyph4Z2wiGMe9lX4Xx5acRCtSdJ+H+JROb8oV2xle7 wg0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685160822; x=1687752822; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2CLI5dDlGRzvV0LMDARHxx4pfVRGX/zlI8ZJMCOjbQM=; b=gA8XrOVj6ioayY7wz7l/cB7fF4M/qeRpKyUGhEb9SJSj46pL4wV3S2tsHiGJhkml6t iVbzzsESqM5WbFJksjUAwqe3K0rgGOqpzZGp69yf1U8JjJtNymp8EYTGcCmA3dGapXrq ZkBhbEydWpDiFF7qBQwf/ajKlWibFZZJ4qTQyxClQYGTLtlfvjR5xwa2NspK7GYREvP1 Z526gYPzdlyy3jFcwJTxs0YRVYVI08ILoUmGd5SLKj3dnWxOuhfuUyDXWI70RSRCqB7O RfPQFyWOnHR4NlDcOmi0kdtiB/Rv+TkgfZtQGUoosNj6a+qIcLnaplVIp66WXFn/udBL 6E8w== X-Gm-Message-State: AC+VfDyeih2cEshEWV9ag/Gkpw4JWI0AGElNIsvJSa8uihK1eLkOKqmb 5RTu8iZ3pOBTTnT7dZyXKCIlYTMx0kTuKYEDLg01Rw== X-Google-Smtp-Source: ACHHUZ6NV8cibR1lUGRmOTw2ml/5B4EWeeDGTjdt7m1ithRgYmnoCh2Bgdmd4mPLrekMgqAkfMPufDzec3S5lJkJ1Ok= X-Received: by 2002:a17:906:9b87:b0:966:484a:335e with SMTP id dd7-20020a1709069b8700b00966484a335emr4048945ejc.43.1685160821581; Fri, 26 May 2023 21:13:41 -0700 (PDT) MIME-Version: 1.0 References: <20230527103126.398267-1-linmiaohe@huawei.com> In-Reply-To: From: Yosry Ahmed Date: Fri, 26 May 2023 21:13:05 -0700 Message-ID: Subject: Re: [PATCH] memcg: remove unused mem_cgroup_from_obj() To: Matthew Wilcox Cc: Miaohe Lin , Vasily Averin , hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, akpm@linux-foundation.org, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 6jhdo84x8awbrsqkjynkq5npuznq8oqf X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 389B6180007 X-HE-Tag: 1685160822-755584 X-HE-Meta: U2FsdGVkX18dC2j8lv5RVqt0i9YSwxfRymUd5IBvq0csGbQaHLSebjqXPbHlpHPMm0ZHWKIS8FCggurcTo3sD/XF87ITmqlUfjcNzrmkUuO/AfLqXbZImryr5JS9eLKRAGDUoigmmnf49ebXEYCaEV9qVO06N4uDJfTXBGHEFdrmLoA57GdLgEA4uZJlqcdORUauhKj634ePERjmYYe3Xtr9P2bXMcUtkAlR27F3qUtRGg9sMEtGROdINQGLvEXjtcM9HZZ5m+zxGpyAsnXT9iK20dt7I6Wz9ied6n6+TSd7cB5ZwuXuYmtFvco82FgTXv0MGjeRZ+tpVQfITBkdrrqqkhwkOZxCUtFnq3soNMz0aoNOxJKVUtiUtrKAdYudjlbhGOpyES5iHJ2oci+7Rq5uR66LVRTpm71gil9uXdOi8oWAq8Jru0xUKuDkLU8R8Re7bq9kgqg6kk2KAdxgg85ns/ujNNdppm6BhJF1qxABHUrVquo/FTgI+fsnxd18RDqqfAjbkDo5xttpaS+fMz5BWqZv5+bSuQbAxSYxFr/VfTGb9z5Gb66xEy0b/HVNKcUYCIBk2kmaEsjMP6MXYaaVsQcqwiJFm3wXLUnTSgWzPPI37bNUB9JGX90X7mFWpsPwwS1Iq21xpbrhYxtfjP1szmN8t3N8htED32i/Kx6cyaiTkcIwkX0d7DbQHJof/S1+9hBlgDnLihPj19vkF83voL4XjQfMeWPA4Eg0L6Sjf8+6zSjcI2xUaokNwQE4r2/j41/0QcFnge7sArwvPhP7+b1YwkFUldC3ILMUmDVjjJzg5NN0FM7KrCgL0V15+lJBEGi9kWG2CUOSE1Nl7O28bzv6D5SfO/OUyFb06x5cOcGGYEnNQqUqxkLUz3Skv4TKb9V8zmhYU8wPKZ+s6kpGXQ2BzX3l8EJqH7G8EZXCzWE/j9KbF281yGC8gV8CfSNhJ6WbswO6csCwICr Rviadyg/ OE8QLEnxlRdOlbuLACTo+ZnFT8QHdR7m3iK7ft+hEw/MBnsNzoROJzU4Jjs8wf0C/2n+PD3obb/+29dFMbVbgzN28DozqnOQ3L/yySbNt78ISvEsCoUJoQGAAyrofHBaIALja4bVN961Ad4GIpmvCZ4Ksp1+qswsyedTFnmlPXUv5YrjU5mayJSrdUNpOzfG6B5rNqI1BKuq9dkCgEjEcMUrMSfyYkOx9UtKonHMbZpZGv8msxKDExa0SpUyRTXB1fRzv0TE8sBLHLCNZuBVneZFUTApPzZ1kcocwzDZsjmuHeU7sRWnXlH883m53LbUrzkfwD/FonEouJHQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 26, 2023 at 9:01=E2=80=AFPM Matthew Wilcox wrote: > > On Sat, May 27, 2023 at 06:31:26PM +0800, Miaohe Lin wrote: > > The function mem_cgroup_from_obj() is not used anymore. Remove it and > > clean up relevant comments. > > You should have looked at the git history to see why it was created > and who used it. > > Shakeel, Vasily, are you going to retry adding commit 1d0403d20f6c? That commit did not introduce the function though, no? It was introduced before it and replaced by other variants over time (like mem_cgroup_from_slab_obj()). It looks like that commit was reverted ~9 months ago. We can always bring it back if/when needed. It also looks to me that 1d0403d20f6c was using mem_cgroup_from_obj() on a struct net object, which is allocated in net_alloc() from a slab cache, so mem_cgroup_from_slab_obj() should be sufficient, no? > >