From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECA34CF3189 for ; Wed, 2 Oct 2024 19:09:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 551836B00A2; Wed, 2 Oct 2024 15:09:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DA446B00DB; Wed, 2 Oct 2024 15:09:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37BA66B00DC; Wed, 2 Oct 2024 15:09:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0DA6B6B00A2 for ; Wed, 2 Oct 2024 15:09:48 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 96DF4140B9D for ; Wed, 2 Oct 2024 19:09:47 +0000 (UTC) X-FDA: 82629601614.11.D6DC0F0 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by imf17.hostedemail.com (Postfix) with ESMTP id A3CFF40002 for ; Wed, 2 Oct 2024 19:09:45 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kKIBnopn; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727896091; a=rsa-sha256; cv=none; b=ZjH4Szajj43WeOM3tfYu2+B1f8jEyO3XSEZrFumY7tPKhkBidJjiuk2fgAhw9jjMN52odu kmuvrQyZjCC3TQd7fvvZ47XaNEMZKOECwT/+Atdz0NyG5uQCz4Twfz43b6nogCUMoClTik tXINE5gmZdTRHbc83kTqXzAuLGa7vEo= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kKIBnopn; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727896091; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9pk5sxpXelnlcFpZhaVYKsnlMlWwcl7IaLwVfXSaqYY=; b=qGwVRKO1mlSNSgLIbzjnD121AkiAGO628Q2Mnbz9gEIivIzmw3kqt8AEJbzhRAPduqh6Bn 4I+CDjHQyBBC2L8BX58VXNJ8wxKrknM5HHKupQyG2aMwnokAco7StACXgOSR1l1GQwj30z /x3cad6jyW7nOTI17DhAo8RwHzNeGXg= Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2fac187eef2so1774471fa.3 for ; Wed, 02 Oct 2024 12:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1727896184; x=1728500984; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9pk5sxpXelnlcFpZhaVYKsnlMlWwcl7IaLwVfXSaqYY=; b=kKIBnopnuXB9JFSSraz3Kv8zxLN+MQvoFdaRDKGe8TcWDqsWQKO6fynY3G/HPmzsVY /rW+8P/gPSZe2q8m/xqxEUnlLk57dk5AB9Ds5Tvye1khicq1UV0a80OiCLib21Glnt/E Wz2QutQ2lsiYdxwxXwku5DR4dBtPOnRf/f3mR8WOEc8BXmX7JxnoM5RjBeJE/ypnq4wh ZTnjkNJqzD7AJI6IPgi5KBAybnTxb2yny2PRsPRV9713Q5zk4Dt5a2bptdPlaQyKImGG 7MsNFvLyvzDIycH+ubfuM88GNCEjagzxAx7Zt/60rWu3fCmMSr7saGTYj32+EDMEUg2u d+NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727896184; x=1728500984; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9pk5sxpXelnlcFpZhaVYKsnlMlWwcl7IaLwVfXSaqYY=; b=gfTXHRZgUSpW7qKwDqtRgGyLEs62FSzksH1mWM2eqXyvTakzxztyYyk9qSsMQsWcOu jrtTMTcZG/6NKXQNyYDyUeqEZV5YPKZrEBWE/k3H/UK3jmKRsh3flWGztPMdW0MHpg/P t+x2ZiGn4rRGcaLuNTYeD1eVDlRCEZKRCBcvspQfoe2qwDudsZ8nQVnPfTjFc7KTVGGz ACE3d9r4GdKphgIHLItnJ7bc/QQwr8mV/9NvRf6uveeeaBXdbmJTUNTUIiyJWliZ29vA zUx2Gcukx1X3pes1MjH5LfO3M5P74KO2s2cLD1zQLYYh4aq1iSiM9ZXWlGGPd0ToxqYj LcfQ== X-Forwarded-Encrypted: i=1; AJvYcCVz6JStPXK/HOqRCSbWqfwIyF7FuuhheLGLJ0agfV5lCb6qq3V8HMvr/nNlsxLKGfMZIxekWucWcQ==@kvack.org X-Gm-Message-State: AOJu0Yzbm1I/+fjNpihylWyiZoumh2oqpPECUPI/8v40kpaMwT7TNXki w+yaZDF+ICWqG/wJwWjjjrb5JSUQjcKt9C6/55Qfx6Ul2alADxpdi9EY/IexmJS4WLS15vimFm0 UE4Bet5k5jUo5UpBFeWQ1IPJdDLkTcke1ccV1v/tqL+GqOEpiKKPP X-Google-Smtp-Source: AGHT+IEQt7ReEYDqSY4zyY91bDH/qUjp+ixDClQiovmpzvG2Hkk9clXBh+QR0WalQsCDKdeFliAJ5KFFI/XDIDV9ylA= X-Received: by 2002:a17:906:dac3:b0:a77:c95e:9b1c with SMTP id a640c23a62f3a-a98f825d922mr442028066b.27.1727895748742; Wed, 02 Oct 2024 12:02:28 -0700 (PDT) MIME-Version: 1.0 References: <20241002173030.213536-1-kanchana.p.sridhar@intel.com> In-Reply-To: <20241002173030.213536-1-kanchana.p.sridhar@intel.com> From: Yosry Ahmed Date: Wed, 2 Oct 2024 12:01:51 -0700 Message-ID: Subject: Re: [PATCH v1] mm: swap: Call count_mthp_stat() outside ifdef CONFIG_TRANSPARENT_HUGEPAGE. To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, nphamcs@gmail.com, chengming.zhou@linux.dev, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A3CFF40002 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: csa4zckocedh1gf19tmug8sdk4bj4mcf X-HE-Tag: 1727896185-165883 X-HE-Meta: U2FsdGVkX18htR1Ft17DZ1gLk3/5iFP+uZbq1TAfK7ETFg8KMDnw0RVU8vEpp9Pr5xdFszp8JqEDrFSmBJklXRY50bdziNOVNynKl/S8NvWpOygfdaPQtwSqoj2AEujPMPxD522ZodaBNvJLVr4KaYUT4pVSIv9PIj8Cxrz4TGfyaZIrBI8R4yUyKxpY2JDuzQZgozQmSq8dVHy+suwW0Ct99xHPIPFx/A62aeu+3BYRx1H0ZauyYJZoTQHAf+/FHW8vZGu8dRRxaHBd0M4zyPd4UptnoSVucMw0dgoH6BI1NuFBC2qdAGfbWM7KUbJInAIRQtWa2FtFoqcAtNDAZxY+gcW1v2K3NYbSE0PNREfXc1bUZPVy31s2/laayUAKPCA5wvL8ZCTsKbqfgH2eQhRua3lWOBsM7SxlQsU7ATN++5BVF5TEbabpWIAIxGr+JDHz7t0Jpqnr0B2UhLl/R5ypLmi5OS5GSXZ2ezq20mTYYzGKFLjbjY5aIr9qD7fTxz6rJ6RnkdcZKpnC1cb+yHsilVofUC8HBCUOuT9dD1JjWgsz2GagN1B61jxDAjcC+wIHOYEPWLDmPqObWpvBbybqACvaUKSdhoRtLJwIMhH1rHyv6gKxsnHV9GNc76nqRPz69YIE8PA1P3TNTUre/XUNvIK4oytgfOTMNp2qJ7FisQPYxQtUuymWWaZKAhvLge37CBcI9BFINIrzaqKDl4N2NEa9gKWJmcva/R+74mhnTHMoQa6nIVVgGEHmE8QOUQIbT2EnRTK5VafbyGoY7plB/Mr0krR8HuwcLDux+I//zNfq/9kWMJqf1fwXLJYzsQfzd1ydL3ex1wxrAlFlfAJ70b7t9rpf+uqye5C05f2/xbn6Y6ozafiXfZhOk+Wg2ZflWPbzLe6Mme+pBUpqEJDV29rDvfp2RF+9w0TqHkJk0wO/NUNuQRPI7TwBzG01vdmdasnxZs/Ub1llfGi ooOsn3DO TSAFff1ukIrrnHzeFW5F6AItdaS15RvHgQ+cq2CLWx4nXBnYOJVcVQSHg7xJFH6BbM38TMNevgLjcad1QSkHjDC2ZLaOXDY6f4asEiV2l6A5S7vP39PrO4KPWlBV75pDfOcFMc0N2+e68h1BwgcyB8aNZZZYPrO54qnvkaq8WmthtpUarNpwjqn8/GtnCQkIlxBEsVcZ11/jS/coRk1hK4KiDrj069o8P84DnvRl7xgupLI6a77tEbPAs9Y10FmVf0wNa3nlUxZJOmU8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 2, 2024 at 10:30=E2=80=AFAM Kanchana P Sridhar wrote: > > This patch moves the call to count_mthp_stat() in count_swpout_vm_event() > to be outside the "ifdef CONFIG_TRANSPARENT_HUGEPAGE" based on changes > made in commit 246d3aa3e53151fa150f10257ddd8a4facd31a6a ("mm: cleanup > count_mthp_stat() definition"). > > Signed-off-by: Kanchana P Sridhar I don't think this really makes a difference, but I will leave it to the THP folks to decide. However, if you go through with this, please also do the same for the call in shrink_folio_list() for consistency. > > --- > mm/page_io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_io.c b/mm/page_io.c > index 4aa34862676f..a28d28b6b3ce 100644 > --- a/mm/page_io.c > +++ b/mm/page_io.c > @@ -289,8 +289,8 @@ static inline void count_swpout_vm_event(struct folio= *folio) > count_memcg_folio_events(folio, THP_SWPOUT, 1); > count_vm_event(THP_SWPOUT); > } > - count_mthp_stat(folio_order(folio), MTHP_STAT_SWPOUT); > #endif > + count_mthp_stat(folio_order(folio), MTHP_STAT_SWPOUT); > count_memcg_folio_events(folio, PSWPOUT, folio_nr_pages(folio)); > count_vm_events(PSWPOUT, folio_nr_pages(folio)); > } > -- > 2.27.0 >