From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72D5BC4332F for ; Thu, 9 Nov 2023 00:08:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6AF180027; Wed, 8 Nov 2023 19:08:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C1B068D0073; Wed, 8 Nov 2023 19:08:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABB1280027; Wed, 8 Nov 2023 19:08:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 99FC38D0073 for ; Wed, 8 Nov 2023 19:08:02 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 73D9A1CB98C for ; Thu, 9 Nov 2023 00:08:02 +0000 (UTC) X-FDA: 81436478004.16.4138ECB Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf25.hostedemail.com (Postfix) with ESMTP id AA747A0019 for ; Thu, 9 Nov 2023 00:08:00 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Nw8+c8sS; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699488480; a=rsa-sha256; cv=none; b=03tMiaHrOuu14ZkN2PpumYENgAPAyywnlbIOVyPIYUQMO7HMgK+cGdq5lDMFXQ0D4xUQTo FQkjSeuJVMrumgSmL6KbEeGEvwtuXLSpVOT//zLomPDc+g91YSSpyehu6bSLnEbKuZcppv R27LyUL5aCaWy2UCZK+0OLiX1PxNb6s= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Nw8+c8sS; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699488480; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rz7mhIwDEHwZ7Y0YNWv+J5BlWu5bz+Y6wtW1QfLOmcM=; b=ULXM9rkkM9xq3J2bi8FODNzx21IrIxS2glsK2Uhe2klPUeJDyCYejqCL2RYq1Gh2pH6QCc 8pH+rIMBOf91RB5i14fPvjdBRUrIJb1xh7CYe46YdIboBz1z1dKBGrHMMcoJj6N4cpRYh8 96ZJs/5C04E4UlL6rnf9NkMJOx18J/U= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-9db6cf8309cso49981466b.0 for ; Wed, 08 Nov 2023 16:08:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699488479; x=1700093279; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Rz7mhIwDEHwZ7Y0YNWv+J5BlWu5bz+Y6wtW1QfLOmcM=; b=Nw8+c8sSKiupPrLFdeFWQVwFvv7CBXFVPjf9k8RSv3Edp956WF1isuXDxv0HhaGb+V /4IYs1l7ep6nEBLpjt8Yc+WuFmh8Xr1yTyaKxQqIufEC3FgAKwjX+RHEacKOnAEcSd7t oULkErEe1K6H6jtU28Dqqpu/y3jivwCdND/Vmi+HNsmdgT7PnycO46ot18FKkANZN1fh 23AAidjqxl+wV0TWG9sPD7A8jUUB4reEvjvDHJ7fT9YTfEEvHE+d6IjMdiKkWxSnyFp8 HoXHtuY2isYOTOOkMD8YvvwAkkC8VyRjPHBGY5mT927MZYOTfcUW1T82rOfvxCBDOFSJ jNXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699488479; x=1700093279; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rz7mhIwDEHwZ7Y0YNWv+J5BlWu5bz+Y6wtW1QfLOmcM=; b=oVYxCL78F3J2rCd8Tc49ij0RG5MOi0+HaZUcAUjIBKr9v7MdyR5Fm9Syk1OJdW5RJA zqdJ7uHBI81SG3CS8NkHiDXwmDrB/p0JCWsH+uj90o+kU7vYa4ftY+mOxsqthtJM2T1x V5nf3nYMdQzrZgWN7LeQrgqw+tMIgfe74t7mYDayagRSXapZbSIc7TShSLZ76oXXGcqn 3R3HA4f9zp3HwpLyZFvaJI5NTwXbwpKyMMERObDbgRe6jsWvhHinTDiMVwQ4QNptDu2+ uT+HR3AnzMGfvhoadNWYLZMRlQ+YgOYpsmoeE30m9+8dRLd9uywnB2qSlIcsLFRDDDF8 ex1w== X-Gm-Message-State: AOJu0YwYPi7ZO6zCe6FxoCG67GdSPbHa2ZLJS/BqSrxxVBQ0ouAKLkcz +r+i754MQ6R4VFqTm3cZJdWsXnXHs+04wPsw5ED6Kw== X-Google-Smtp-Source: AGHT+IGpO7H+kRRWyzMj4BetZ3oYPaIbaBlz2jRUUfN3V+9mya/7be4ceQJGfNOaDOryDYKZgvJQi3sXhasVWJqBjBI= X-Received: by 2002:a17:907:7f1e:b0:9d5:ecf9:e6a0 with SMTP id qf30-20020a1709077f1e00b009d5ecf9e6a0mr1348753ejc.0.1699488479067; Wed, 08 Nov 2023 16:07:59 -0800 (PST) MIME-Version: 1.0 References: <20231108164920.3401565-1-jackmanb@google.com> In-Reply-To: From: Yosry Ahmed Date: Wed, 8 Nov 2023 16:07:21 -0800 Message-ID: Subject: Re: [PATCH v2] mm/page_alloc: Dedupe some memcg uncharging logic To: Shakeel Butt Cc: Brendan Jackman , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Muchun Song , Andrew Morton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AA747A0019 X-Stat-Signature: h4umpe5w9fxp3knm5hbpo3zn95nayzza X-HE-Tag: 1699488480-510198 X-HE-Meta: U2FsdGVkX19wEla5qxJSZem4Ih56O+xTR4qjogcRzRVC9mAi7mlMkmfqm4ONjaeF7zaViruCaJ97I7YQo1/qywxnSpha6W2GxgTuKA7iG7cCsyC3NVvit08tiblKa94vEAqKxHcIZzuD3KtoLUJKalXmbZo0GoEUCaP/XBNGSPC/7ZMf3U2n7RKE4UO6Tl9bsyQREGwHZeU+wfRIhXFS4puX3F/uliqroEnldM0+aCiNnCT8MKK33MQa+psmM7Nb3XMzmH5jheSbUWMnw866FG6wlaUR2w6eDZdtR1QqddWb/QRBuxr2D3iKKpNaBCxyDxKxPFJHHrOyUT0vssWtQT+g9plpVpxWAhl3kGW3dqAsArIwS+0z0OLRqQjNodCzs4RtP3fBD0oiZU363q7wglCaXG+hKkWUzT6kQyNZGV+C8tb4NvcBIGeFyGaFVFBmwTKSZpNJ43ZCiQa6KQiIxFcREZjhxIIJo1X79wNn0wUZrxOGp4AMPWKjcF89w4ZVTLi3scvKdVw3w+9tW4QWhycfjfVAqhd8rR6sPZUpEifKXQzBCdkJdCcREEZMqW/jK0D1SgL1LEPL1r70RvcRF65+Ja6CRKiw32R3sNw4nDwP63mKhROTy3z1vz4Qie7jz/9i2CvS5Vct9CeD0Y7Yd5Zmd1L8aueKBnBriBqifPjZAJ0kAugUU20fC7TMeHlFhTj89KzxNYloonPjXq4qA0hj4mdnwS8qC9XzV8Sp1/TB7tAtpXZjkznNtLOFdAJbKCwrMMUAb7+DbHD7wc0+lE1dzi9MFJ2AUM9RZ72DQ54p1OxAk07IkQmRmVcCZU+cT/QRB3KskpMStxCQOtXPOElerpXKulVkoubbn2EARxOWi1GmCBmUGMxfEYfnGrrYQgNsXl2Ln6GPeLDoiLUq333VgQ1B8ucvpxqTkOClLW5jHxaigqsXWK4aitiF6N8ysjbqKgluYYSgKMRXWfW +Bu+t9vp LmKu58z+mEUNnp8dUThzu5FVJKG9uIVFI19gFpnZWnK0JjFOInbl7rwvXhrgvfnMCQslab8ASNbbM7ASFeoyIQlVBxUQ/O6dz4vEYUKzgbZVPFeHI9snqbjVu1leYooDysKFNIAXx8L6RK4msAvVfKyVbmHRVQs/Na7rUwuwm1vn4wP+kRygB9MerOyrw0VdkfuqRTFCDp8kvw9HCizhpfK/nrBJRT7cWnWdGb/ZQv3BXvTDFXJbKGV/fVv3mnaJI9qlZmRGwHwjTp9NbRgnblvLOVB9ApTl6HC+W X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 8, 2023 at 3:52=E2=80=AFPM Shakeel Butt w= rote: > > On Wed, Nov 8, 2023 at 8:49=E2=80=AFAM Brendan Jackman wrote: > > > > The duplication makes it seem like some work is required before > > uncharging in the !PageHWPoison case. But it isn't, so we can simplify > > the code a little. > > > > Note the PageMemcgKmem check is redundant, but I've left it in as it > > avoids an unnecessary function call. > > > > Signed-off-by: Brendan Jackman > > Thanks for the patch. Actually the PageMemcgKmem/folio_memcg_kmem > check should be in memcg_kmem_uncharge_page() and not in > __memcg_kmem_uncharge_page(). Anyways, that is orthogonal to this > patch. Agreed. If we move the check into memcg_kmem_uncharge_page(), perhaps we should call it directly here instead of doing the checks, since there won't be an extra function call as it is inline, right? We can also make __memcg_kmem_uncharge_page static to mm/memcontrol.c I suspect the same can be done for __memcg_kmem_charge_page() as well.