From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D589ECA0EC8 for ; Thu, 29 Aug 2024 22:54:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69E456B0085; Thu, 29 Aug 2024 18:54:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64D1A6B0088; Thu, 29 Aug 2024 18:54:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 514636B0089; Thu, 29 Aug 2024 18:54:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 350466B0085 for ; Thu, 29 Aug 2024 18:54:13 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A99A01609F4 for ; Thu, 29 Aug 2024 22:54:12 +0000 (UTC) X-FDA: 82506787944.04.28D0E7C Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf12.hostedemail.com (Postfix) with ESMTP id CE4774000C for ; Thu, 29 Aug 2024 22:54:10 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Ggvw589w; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of yosryahmed@google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724971984; a=rsa-sha256; cv=none; b=nhq3YoIsQVY29zZ/Bn1nwwXxyVzLY4DSaX0525bgCOMLdWi/bx/4sN/ZKdFioJVZcNK+XT lsTZJxlWXGqe6tVxNoIjZI748kU7m/AtWfNyyEU210am72CzHR3lsv10pI6T2UKCq68DQ4 59zh0j2Sj8vYzUCCakMdvbmeT4taddo= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Ggvw589w; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of yosryahmed@google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724971984; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tT/N7885nHKfty/eDWE+p2zE6nTWtJgYs5jLN0H8wTs=; b=hwvNpQadUsPk918Kv8hqXr0tf+4HJXF+RQd6X3j7cQXsmJcPNNN75DwHLq0J/IoaRSS2jt 556QSIg9zuubh+EbWOTy7HK8yITbBbcl7Hy4pdSBBPLEu7QhekF0ziuOOVsvJJg9wn5CoD 9xUn+fLN48Qa2yH2XJE2ON2dCr7jQro= Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-429ec9f2155so10390335e9.2 for ; Thu, 29 Aug 2024 15:54:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724972049; x=1725576849; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tT/N7885nHKfty/eDWE+p2zE6nTWtJgYs5jLN0H8wTs=; b=Ggvw589w+EZEr70mI6hqsi4Mi2GEzhnlvVX21OK+UibcYPiBDsNGjBImOgmPlMgqop OI5PPVi6SMnrMjTHTGd3LWTGOq8jgId8cTchpBJ0CvSbELuGX5seyDotLZDMdDxKZPZp Np4pku2CUQK2ikl3zk6ABqjS9QyRAc8kFg4o4bF5Hmt2fcrD6XQddwSFnw7HOwIGHNbv WlDsFJ37RZOrbRvbZ6bdSOFje8mCBoSWshUnf2a2FdGAoJpmj5DP1M9lfDRykL2EB9Ee hl1PqnQN3pKddRTqQGia90vlk4dXkNHEYMvvuNgfcTbTC9WrFkm8conhrA5w83rP7ApG PVmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724972049; x=1725576849; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tT/N7885nHKfty/eDWE+p2zE6nTWtJgYs5jLN0H8wTs=; b=L5OnuI6MGkN4M1ZM4XOQmdCREBx+om4FlTnfk2gnuvLArof/PZcooI4mXUUgg6bY9D xgArEqdeRrfMC3hKOBjvX9wunVQh8rIpp2IwatZh7dz4tfOngBfpNkzDgvJWFd+T2OiR Vx5Q4OKU4rfZ8q3WdvtpcGJGQh6cx4IXeX74h+TVOsUIsEGPL4cVJmbCLWgrN5pP/TGr nMB98l5p3seuCMbhuVlNXiUESatRRSj7xu3EPLljp6e7HGSuPveyq/3jyCpfv/MOtQW/ Dgm+a3ANlf/pzUNWaK/5pTEwnjzOISF+3TCGftLhu/epcjkrah6NiAx0vrIO/VZucvkC cdVw== X-Forwarded-Encrypted: i=1; AJvYcCWLXOcAn4Jvn0U73derVamdwueSJglCMQh1vu2dFL2kTljbXbxCKwxNybp/RmhtezPj4oQjwgUxZg==@kvack.org X-Gm-Message-State: AOJu0YxvU4b5Rno/i/YGITG6sXOQWyS5x+rslFea6LVNDBSq8XZsXh8t 2uWNfYogxuDu7APALdZqYfeF11uabFxYIdQUgA38EIuFMpRCYxX0bLtFCPXad4wH6KIieM5W+x6 wnfaBIBROpHzCuATGEPiUV/m06k1fKCmpYqLo X-Google-Smtp-Source: AGHT+IGhqfbnmkqeuTCD7bZKUdym4y9AL8tm7CgZ4nVvzkL1/icn0ir93wqM4ghcuzeFcJOcDO9xHxShdQCRi0L0i5k= X-Received: by 2002:adf:f58e:0:b0:371:a844:d32c with SMTP id ffacd0b85a97d-3749b57c4f1mr2996255f8f.39.1724972048738; Thu, 29 Aug 2024 15:54:08 -0700 (PDT) MIME-Version: 1.0 References: <6f65e3a6-5f1a-4fda-b406-17598f4a72d5@leemhuis.info> <02D2DA66-4A91-4033-8B98-ED25FC2E0CD6@gmail.com> <3D1B8F1F-2C41-4CCD-A5D7-41CF412F99DE@gmail.com> In-Reply-To: From: Yosry Ahmed Date: Thu, 29 Aug 2024 15:53:32 -0700 Message-ID: Subject: Re: [regression] oops on heavy compilations ("kernel BUG at mm/zswap.c:1005!" and "Oops: invalid opcode: 0000") To: Matthew Wilcox Cc: Piotr Oniszczuk , Pedro Falcato , Nhat Pham , Linux regressions mailing list , LKML , Johannes Weiner , Linux-MM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: CE4774000C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 5fdxcrnes94y4xmqpcn9dkawwkmecb3n X-HE-Tag: 1724972050-962136 X-HE-Meta: U2FsdGVkX18tEtHjghxIIxhnpwmMihZuGaOHXDa1vAdTDBk38lwrpM1IA/9nB7eTo0wq8lvrr8W8mUa+uCj5bWCsPkqAbTJ+W3VLYYZr7X1Kj9e74TkEDPR7gKJScuSPnkCiIZdnyjWVWAcpCqEtayIicoAnuFQPRfSO1mQYmnMij64PQLFg+ihBk0wUHek2jHAWceUn3gDxg01Vzsvxe8lh0oGcRm8QGs99MtB+MtGoV5KA6/HHBRzQlrZFObsgIoPSWMHvq8EKqi0ttoDufFmsUabUEZSjj8AhpeMN8wYH2qzt87A8uBoFQi7zfN78ZY7nTRliyN9/70xQe5rLvno1qkNxkk8L3eJnPZUpZmIhWm8svvyse5P4gd8L+Mpi0gmWtwCCeGbM8zbw/0CdQtORWrcpGIj6TY0RsDv8e8QEIG4nk7SyyQ8Czl9NirZrjQkULaEdjlSot34QbGJlg82ou2JZuZpnMLEIG5jPQp3DKHV1bWXwdpG0EcglC30Ww9IYiJ127qqlF9IxSscal5IZ+/wLWiwJs4HEW6jt07Mux609fDrx5Ee4ObEeVLSK0R/hKcY9tcn6dx1/sEmMWFMj+0zA8nq/qAXSrKFWDDgH1O6uWZUYvnYhEwXVjZB0KnBVbUQlZCCU8ezZlWpK7eTszd6meeOhZmGidbfnr/irLm1pVYmp0E6zsU31eqg6mdex7/KeLiKnajnM/3ob9k4IRSCDgEzsD0GM7QCELsmANBssibqX6rr7UvkHq+iKHwSzB2b966xJPuhNc5pnhma4az2sPeze+at6cMN4EHmxH2QwMgjwFvhxt9cAVggK1WtDo6Pd1DgfbF3lQgQTxX9Mymx/Kgem84bckn+9N190U5RqnJjuB6Gu/xnot2uHXJJMFr+mkX+yHbl1+7DzllUWXWa1S5XEyfLFNJi6lmL+Xkry/UYS6mRj3tYDFFkJVfK2/kQpYcj7iDTOWEG 4wLdekAj V4Ti/xz2t7Z2DWLUNip+VtEvDw0qIidQ5NRcKWeXagWprwYxLddntQV9FCvd84YrMDGWCon6z2FWc31O0ss7Gy1yMGfPhO9AgPXpyTItaX8G+BprqSNgnRsY1zYzaGfVCZs8FcDLOW0CTr4Md0SXj0FsrnaSN2S40A/cKh2Qn9RPSo+rboFWpATQ22Qj7J2I06kYmeyiw98jQzpUr5msLetc6UZYJ7J6ycNoCK0ChTNYY19QKIXJpNyabS/BVxM3rFitw4WEX9dPYeJ2FwgoP1kai5Q65R6Q1Dqcrf3HiLRdG8+hN8rT3obz3xfk56+xANSYJaEYZJrSXnkK2OV6XnxyA8SYRH838nwdh9BhvdnwBbMGA/zmsYEMvb4oE5pqit1ON+1UVmgVaMSGmwQ1zvaarDA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 3:29=E2=80=AFPM Matthew Wilcox wrote: > > On Thu, Aug 29, 2024 at 02:54:25PM -0700, Yosry Ahmed wrote: > > Looking at the zswap commits between 6.8 and 6.9, ignoring cleanups > > and seemingly irrelevant patches (e.g. swapoff fixups), I think the > > some likely candidates could be the following, but this is not really > > based on any scientific methodology: > > > > 44c7c734a5132 mm/zswap: split zswap rb-tree > > c2e2ba770200b mm/zswap: only support zswap_exclusive_loads_enabled > > a230c20e63efe mm/zswap: zswap entry doesn't need refcount anymore > > 8409a385a6b41 mm/zswap: improve with alloc_workqueue() call > > 0827a1fb143fa mm/zswap: invalidate zswap entry when swap entry free > > > > I also noticed that you are using z3fold as the zpool. Is the problem > > reproducible with zsmalloc? I wouldn't be surprised if there's a > > z3fold bug somewhere. > > You're assuming that it's a zswap/zsmalloc/... bug. If it's a random > scribble, as suggested by Takero Funaki: > > https://lore.kernel.org/linux-mm/CAPpoddere2g=3DkkMzrxuJ1KCG=3D0Hg1-1v=3D= ppg4dON9wK=3DpKq2uQ@mail.gmail.com/ > > then focusing on zswap will not be fruitful. IIUC that was for the initial bug report. Piotr reported a different problem for v6.9 in the same thread, a soft lockup. They look unrelated to me. Also the patch that Takero found through bisection landed in v6.10, so it cannot be the cause of the soft lockups. Piotr never confirmed if reverting patch Takero found fixes the initial problem on v6.10 though, that would be useful.