From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03D22C00140 for ; Thu, 18 Aug 2022 22:24:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D59E8D0003; Thu, 18 Aug 2022 18:24:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75E4E8D0002; Thu, 18 Aug 2022 18:24:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D8A38D0003; Thu, 18 Aug 2022 18:24:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 477FE8D0002 for ; Thu, 18 Aug 2022 18:24:54 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 29DD4AC854 for ; Thu, 18 Aug 2022 22:24:54 +0000 (UTC) X-FDA: 79814144508.30.C770140 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf26.hostedemail.com (Postfix) with ESMTP id 98F32143762 for ; Thu, 18 Aug 2022 21:44:39 +0000 (UTC) Received: by mail-wm1-f48.google.com with SMTP id s23so1451813wmj.4 for ; Thu, 18 Aug 2022 14:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=UEM6xwL26wno309XpbhDNsg9frqzMJCiGi3REZwC0DM=; b=HeuOsZXmNcXgVKTTXFFcFjO113/PnINlhnItAs7AitwtBI6uKfgSxZnr23iW0cMQ2M qZe5Ce1QmdbYgYvOlxhFBGOL/XnFM1ot3f/gUC9tGtsFq2ysv1zb0hN0ysTow1YwW1JX FuQuCP1EjHzCbuuNrOvH8G45xwsXBGVar6TbfD2jxxryv0ItRyejdDxEdWv9ZetRjXZR i172u1ZhOfBz2fUdp4o/FFoOhkl/Ngb1Fs1BZcP8urMghqdSkkX+KEtVyclANwItuExU EVBDKeMoatrTl6DzQGsx4Kvzmt3UwBquZAlu99FB2BTx9Rrpf2tToJaAyg9pJbxAN0/T eRTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=UEM6xwL26wno309XpbhDNsg9frqzMJCiGi3REZwC0DM=; b=IKEEKixdH8y6hWlO0jopqYPLuDVhDck3lNw+9tpHJknuMQbgTji+zQoe7EIyc39FNs 7vSqdB2ShrpfTHthORokuR5PApQtmm1thDbCtmOBKK2zfQ/RB3AEmmeKmwSEwPGZpe/R 7XnDgOVm/Had/B9mwZVEDnEmaE2H4uI4xcYdBNTvBr6WlaOobORo3bHSIf3dsncamdX7 nd7AF2omDPwgu0mKDb4ViCh5ZPvQU3rjRbIP0frMkPNg5L3NEciR2BewyAfLc494/DiM RzWB3/Z+wLcRy04+R/QU/z0r1p3oAvRmi9iDUuTNl+qGDwOiFnZtrq8xADtjFI3kw3Jw UaVA== X-Gm-Message-State: ACgBeo2sWYYMr3qnbolA30xhiTbaYVQiQLZnxalrqGOrt7I1dx8MzALj Pq8WM0TZ4eCpe92KUiz/8WvqgAPqVj8iqsfmcT1x/h60uZPLiw== X-Google-Smtp-Source: AA6agR7BuFOI5nYDP1+UNHdgYqJp5jObGk15uAmYt3qTDdh43G3F7FQNDBYYXQezeZ+H9BnmKo3qUC8aUKVndQuo1oM= X-Received: by 2002:a7b:ce12:0:b0:3a5:4d8b:65df with SMTP id m18-20020a7bce12000000b003a54d8b65dfmr2718292wmc.27.1660849913483; Thu, 18 Aug 2022 12:11:53 -0700 (PDT) MIME-Version: 1.0 References: <20220818143118.17733-1-laoar.shao@gmail.com> <20220818143118.17733-2-laoar.shao@gmail.com> In-Reply-To: <20220818143118.17733-2-laoar.shao@gmail.com> From: Yosry Ahmed Date: Thu, 18 Aug 2022 12:11:16 -0700 Message-ID: Subject: Re: [PATCH bpf-next v2 01/12] cgroup: Update the comment on cgroup_get_from_fd To: Yafang Shao Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , john fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , Zefan Li , Cgroups , Networking , bpf , Linux-MM Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660859080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UEM6xwL26wno309XpbhDNsg9frqzMJCiGi3REZwC0DM=; b=GMUr6FqyJWkg54HK58wv6vzsiqe5i2GqAP9iaD8KLDCfaFm6sYRvYHGhekA6mhpUK8hjlW XNxnlmgRCwqB+VR+LieMOf0LsUnvnSDinXhoPphOaCd2Tzv2gw1DtTbNWKkiP9B8ReAqYY M8GLtOBxKS9p7f0oLsmwgIWJ+86wCCk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=HeuOsZXm; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of yosryahmed@google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660859080; a=rsa-sha256; cv=none; b=oEbH22H97vFF4ORTRC7hPkcTktGJEqlRiw5IQSt93qUaTB3vXFktvrQoM1Ilig/W+HgfUo Lf+lh71+/ltyXeVTk/+8uVwqU4W9j4ElbJwhZbcba/p1vPi4Vt0KRqgMsN6JtETRl/WcXX A2zLk43QCfdZu+Qnu8F742cUXGmLuFE= Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=HeuOsZXm; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of yosryahmed@google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=yosryahmed@google.com X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 98F32143762 X-Stat-Signature: k14tyr4o7t1i7doq8bj6ik1izgoo9ua9 X-Rspam-User: X-HE-Tag: 1660859079-59013 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 18, 2022 at 7:31 AM Yafang Shao wrote: > > After commit f3a2aebdd6fb ("cgroup: enable cgroup_get_from_file() on cgroup1") > we can open a cgroup1 dir as well. So let's update the comment. I missed updating the comment in my change. Thanks for catching this. > > Cc: Yosry Ahmed > Cc: Hao Luo > Cc: Tejun Heo > Signed-off-by: Yafang Shao > --- > kernel/cgroup/cgroup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c > index 5f4502a..b7d2e55 100644 > --- a/kernel/cgroup/cgroup.c > +++ b/kernel/cgroup/cgroup.c > @@ -6625,7 +6625,7 @@ struct cgroup *cgroup_get_from_path(const char *path) > > /** > * cgroup_get_from_fd - get a cgroup pointer from a fd > - * @fd: fd obtained by open(cgroup2_dir) > + * @fd: fd obtained by open(cgroup_dir) > * > * Find the cgroup from a fd which should be obtained > * by opening a cgroup directory. Returns a pointer to the > -- > 1.8.3.1 >