From: Yosry Ahmed <yosryahmed@google.com>
To: Chengming Zhou <zhouchengming@bytedance.com>
Cc: Nhat Pham <nphamcs@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Chris Li <chriscli@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Seth Jennings <sjenning@redhat.com>,
Dan Streetman <ddstreet@ieee.org>,
Vitaly Wool <vitaly.wool@konsulko.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/5] mm/zswap: change dstmem size to one page
Date: Thu, 14 Dec 2023 10:34:04 -0800 [thread overview]
Message-ID: <CAJD7tkYB1MHC+rJa0wA8FHVM_sJb-DFcaqT1Oz+nSxdvkE0DyQ@mail.gmail.com> (raw)
In-Reply-To: <7a0e3229-be63-4a24-a3fe-7e3ff517de10@bytedance.com>
[..]
>
> I think we shouldn't put these poorly compressed output into zswap,
> maybe it's better to early return in these cases when compress ratio
> < threshold ratio, which can be tune by the user?
We have something similar at Google, but because we use zswap without
a backing swapfile, we make those pages unevictable. For the upstream
code, the pages will go to a backing swapfile, which arguably violates
the LRU ordering, but may be the correct thing to do. There was a
recent upstream attempt to solidify storing those incompressible pages
in zswap in their uncompressed form to retain the LRU ordering.
If you want, feel free to start a discussion about this separately,
it's out of context for this patch series.
Thanks!
next prev parent reply other threads:[~2023-12-14 18:34 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 4:17 [PATCH 0/5] mm/zswap: dstmem reuse optimizations and cleanups Chengming Zhou
2023-12-13 4:17 ` [PATCH 1/5] mm/zswap: reuse dstmem when decompress Chengming Zhou
2023-12-13 23:24 ` Yosry Ahmed
2023-12-14 13:29 ` Chengming Zhou
2023-12-14 13:32 ` Yosry Ahmed
2023-12-14 14:42 ` Chengming Zhou
2023-12-14 18:24 ` Yosry Ahmed
2023-12-18 8:06 ` Chengming Zhou
2023-12-14 17:59 ` Chris Li
2023-12-14 18:26 ` Yosry Ahmed
2023-12-14 22:02 ` Chris Li
2023-12-14 20:33 ` Nhat Pham
2023-12-13 4:17 ` [PATCH 2/5] mm/zswap: change dstmem size to one page Chengming Zhou
2023-12-13 23:34 ` Yosry Ahmed
2023-12-14 0:18 ` Nhat Pham
2023-12-14 13:33 ` Chengming Zhou
2023-12-14 13:37 ` Yosry Ahmed
2023-12-14 13:57 ` Chengming Zhou
2023-12-14 15:03 ` Chengming Zhou
2023-12-14 18:34 ` Yosry Ahmed [this message]
2023-12-14 18:30 ` Yosry Ahmed
2023-12-14 20:29 ` Nhat Pham
2023-12-13 4:18 ` [PATCH 3/5] mm/zswap: refactor out __zswap_load() Chengming Zhou
2023-12-13 23:37 ` Yosry Ahmed
2023-12-14 0:52 ` Yosry Ahmed
2023-12-14 14:45 ` Chengming Zhou
2023-12-18 8:15 ` Chengming Zhou
2023-12-18 9:38 ` Yosry Ahmed
2023-12-13 4:18 ` [PATCH 4/5] mm/zswap: cleanup zswap_load() Chengming Zhou
2023-12-14 0:56 ` Yosry Ahmed
2023-12-13 4:18 ` [PATCH 5/5] mm/zswap: cleanup zswap_reclaim_entry() Chengming Zhou
2023-12-13 23:27 ` Nhat Pham
2023-12-14 1:02 ` Yosry Ahmed
2023-12-14 22:23 ` Andrew Morton
2023-12-14 22:41 ` Yosry Ahmed
2023-12-18 14:03 ` Johannes Weiner
2023-12-18 14:39 ` Yosry Ahmed
2023-12-18 14:58 ` Johannes Weiner
2023-12-18 20:52 ` Yosry Ahmed
2023-12-19 12:16 ` Chengming Zhou
2023-12-20 4:30 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJD7tkYB1MHC+rJa0wA8FHVM_sJb-DFcaqT1Oz+nSxdvkE0DyQ@mail.gmail.com \
--to=yosryahmed@google.com \
--cc=akpm@linux-foundation.org \
--cc=chriscli@google.com \
--cc=ddstreet@ieee.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox