From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA43ACDB47E for ; Wed, 18 Oct 2023 08:55:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F0D88D0148; Wed, 18 Oct 2023 04:55:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A08B8D0016; Wed, 18 Oct 2023 04:55:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3412E8D0148; Wed, 18 Oct 2023 04:55:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 216298D0016 for ; Wed, 18 Oct 2023 04:55:04 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EA26940172 for ; Wed, 18 Oct 2023 08:55:03 +0000 (UTC) X-FDA: 81357972486.15.C8D868F Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf18.hostedemail.com (Postfix) with ESMTP id 218D61C0003 for ; Wed, 18 Oct 2023 08:55:00 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=GHvPu+Ks; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697619301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yL/UZARaAWUIf6+4o54rQD6Gfs68ZHxoU8jk1dJAyXQ=; b=coC9xk5w+/M7NArZwk7ILIVQ89cDPdnmodbYqHXtwNu6fYO2J3zQB91l2VACs8GtX0wMN2 aO+2jvHVvxpW07vl/dHCCyrqpkFzW8DGd7MPqTUeQc3CWwEIO0vCCf6i3/3X9Idrgge0/3 WVCgDM3DNvn7XlWS9Td4AG2/2/oOw6Y= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=GHvPu+Ks; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697619301; a=rsa-sha256; cv=none; b=ytBFFaeoaYCvCtfoU0cl67ITJCQrZpczl93QFPu272PYPdec5fqRZKsMTO56N849JD5wqy hRZpkVWk11qykJx1JAiAZfrQqAQdwKdJHI2kRs0qFbty0dMob9B9igqWWy1BCqsX3Xx/h/ hxrj5j033bDtCFGZd2KbHrub/0h+/ms= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-9ad8a822508so1069747766b.0 for ; Wed, 18 Oct 2023 01:55:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697619299; x=1698224099; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yL/UZARaAWUIf6+4o54rQD6Gfs68ZHxoU8jk1dJAyXQ=; b=GHvPu+Kszoc5YEQJpjzZz7LksYb27Uk+N7GCebsPrwiPRlPzY73RIs5TiWa860BBYs cgVXZ2bEfPx0vTwToelUvScBXi1oQsIz3GkuK5T39uVD2y9/WDFFSFUKREWVA7fAQ9VF JmdSBvnAJMSWT1BaEyHcnceE+7xwGd7cRdCN4xrMfubdA3unVro1CGccjpKmicPFOr/K Tq29ZZ+Vn7gHRTxfIjxvBA1Pih/8JC1Fd4rlHt/7ia2xwkDn9uJROe1fxIqzUDYhKIKy UN7SPVPZ4fmMO/YmljpJzaWgVq31Un4FUTt9w4pwW/VibOQ8ZToGPWnoH2IeKFFi8Mx7 OxNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697619299; x=1698224099; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yL/UZARaAWUIf6+4o54rQD6Gfs68ZHxoU8jk1dJAyXQ=; b=tdftmkKpi0iloa7K3HGadti2TZFqIXb7t/YzWGJn/57KJmUzDazTTMmJgtzZDdsHaz jOTKTakE7/GJ9o1V9edyJ0AR3ktiF+mnwWO7W14669tPJXX+TzzRQQWY85nJLz75cFvq PKc7TZMee7xNgXQvze5qBc7I5z1kmIH6u0QJGSWxScKvnfAoil5rVue8YeXyafVUzWmX ILLlxylstnnkdnDhVvdB9t/eHgt1e3lM6WAY+pmSMRPQuDVVHHm0YmtqEMtjTifr8ig9 +x1Mlwrc+V1KJarNNg4eJ77wddHKlXvtPWOa4uRx4izZU38S2gmMVkj3QeWKMq44Gwnv Sewg== X-Gm-Message-State: AOJu0YwSJKN1Hx2QZWXWhcpgOahbXH37Jbw32v5r0zbpSrrVSxFP/TYp RnRvPkG+SR0xhrS7Tj5+MMa7oi8xIPkR2jnMNMMPgQ== X-Google-Smtp-Source: AGHT+IGGtmOH11oZ1Cb59UA//7N6str2jENUft6xZQE93G81xgY9OLXEg+0bgebtR43pEb9PTMWIKAdCJH6cxE6feGU= X-Received: by 2002:a17:907:9712:b0:9ae:50e3:7e40 with SMTP id jg18-20020a170907971200b009ae50e37e40mr3787316ejc.52.1697619299344; Wed, 18 Oct 2023 01:54:59 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yosry Ahmed Date: Wed, 18 Oct 2023 01:54:20 -0700 Message-ID: Subject: Re: [PATCH v2 3/5] mm: memcg: make stats flushing threshold per-memcg To: Oliver Sang Cc: Shakeel Butt , Andrew Morton , michael@phoronix.com, Feng Tang , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Ivan Babrou , Tejun Heo , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Waiman Long , kernel-team@cloudflare.com, Wei Xu , Greg Thelen , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 218D61C0003 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 4mj8h87k3oapaxbqheipwhau78mx77cx X-HE-Tag: 1697619300-746489 X-HE-Meta: U2FsdGVkX1/nPhohSksKsPI6Ww9LnpxHfa8K6U7ljyDQGQM50VOP9ZFoHeCIal2CgMkGZDkDKsDztc93WKFtBVkByyYyH92Sv+0+rb4IYO5v2V2RWfhOaunXM1cbJyS5jeE9vrrjTna/uwKKqZcp3eyZqD+sspGbRsN4FhXsy4mxQ3XtBbumK1OAPYAPCTsBra+JIK9k+UzvS7c79S+/319UAovHc1lY72nfBN7KqmgLgLCH8aPQBlpFqG2nGbTfWmmtWU1sywisFTnfZb0CCYyPh5uvJldHTKfcUMjniHK8uiY5Vk8gO/CuC+967hng49rm9kxua+wV0+3huffQNfmEGxbSTo2Xqxr9Yji6MPITMzesX0nd6PSNY3YmV1+DKyLvG9IODXaacprlLpmrlx23HeIOPYurNSDVcBz/d3Xqx2fNk+C8ZLUlIcbrrHpE5ZlJf5srIA3pwbM4+YUsiH/H3fey3KGl/n0V65S0RfVmC2Np/J2Y4Kl1pgMS5iBHVhefFqIc1UkLMkMlZZ9yo+I96mxM6qn0eZKRmJUQkb+uDRFc4hUKyJnGx3uPz4OfYolW9mapCiX94u1UmbjomWYAK6KKqDQnfrtZkm04fyB+YTiSO2wWXbYdw2pC1O2+gwYF9lY7bjlW0Ifay3XpclDP2rBmVp7CZ5r79eYf392qi7qSid67v6dTbQWcU8kWmRYHDgVlxOAncrtGbUtUePV9/xI41axR8vTqkEotNqRxUyfGzuvnDihzJmddrl5kwSXYRRf3flK64wAFLm0kPwk3GWkVgTV7q6LbcBUeMq5BYePKzsyv2UgnrXJH9EfRad83zOeknjtgGoWt450kZIU+i5Lhyge0tBWVpJcmfwPEhXueB/SzbNAL6tfPGNuGPrEDZNzjYn6iXg+ysz3dN9HS0P+8NSh6NXLi3W4eZf3WJjynJHHCN7cD5iq2+GU/zt7IKdsy3XqqWRPj76h NwHFe7Uz dhsiBVj/FqoBqM1PcH87SL4L8Bl54qaJ0RjncyEXo66KRuVJuEyLokTpcUL8rMvILYyv9rdBjsZ3H9KcRjLauyAZ+VKpgPblSI4GgdaQkePp6XJ+BYS22aupqITfx766d5D43bUn9WpZez4v+tN6k3o8rApZ8aGrbgNNWVpLdiH9mhZULH1N1rHKpyra7v0/YPhXw34d+7JJanW2ZR7BaktuNny/WjaPt8ik/bKCpJ6nbJhn+g1aTk2gmUrDiJlKGP46gNf80cxlBJGaMGkxDURUvg5ZLHBHOwoq6DK2blY9LNa8Yck2ee0FL+i9lbz13cEvIus/2CKwrtOs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 18, 2023 at 1:22=E2=80=AFAM Oliver Sang = wrote: > > hi, Yosry Ahmed, hi, Shakeel Butt, > > On Thu, Oct 12, 2023 at 03:23:06PM -0700, Yosry Ahmed wrote: > > On Thu, Oct 12, 2023 at 2:39=E2=80=AFPM Shakeel Butt wrote: > > > > > > On Thu, Oct 12, 2023 at 2:20=E2=80=AFPM Yosry Ahmed wrote: > > > > > > > [...] > > > > > > > > > > Yes this looks better. I think we should also ask intel perf and > > > > > phoronix folks to run their benchmarks as well (but no need to bl= ock > > > > > on them). > > > > > > > > Anything I need to do for this to happen? (I thought such testing i= s > > > > already done on linux-next) > > > > > > Just Cced the relevant folks. > > > > > > Michael, Oliver & Feng, if you have some time/resource available, > > > please do trigger your performance benchmarks on the following series > > > (but nothing urgent): > > > > > > https://lore.kernel.org/all/20231010032117.1577496-1-yosryahmed@googl= e.com/ > > > > Thanks for that. > > we (0day team) have already applied the patch-set as: > > c5f50d8b23c79 (linux-review/Yosry-Ahmed/mm-memcg-change-flush_next_time-t= o-flush_last_time/20231010-112257) mm: memcg: restore subtree stats flushin= g > ac8a48ba9e1ca mm: workingset: move the stats flush into workingset_test_r= ecent() > 51d74c18a9c61 mm: memcg: make stats flushing threshold per-memcg > 130617edc1cd1 mm: memcg: move vmstats structs definition above flushing c= ode > 26d0ee342efc6 mm: memcg: change flush_next_time to flush_last_time > 25478183883e6 Merge branch 'mm-nonmm-unstable' into mm-everything <----= the base our tool picked for the patch set > > they've already in our so-called hourly-kernel which under various functi= on > and performance tests. > > our 0day test logic is if we found any regression by these hourly-kernels > comparing to base (e.g. milestone release), auto-bisect will be triggnere= d. > then we only report when we capture a first bad commit for a regression. > > based on this, if you don't receive any report in following 2-3 weeks, yo= u > could think 0day cannot capture any regression from your patch-set. > > *However*, please be aware that 0day is not a traditional CI system, and = also > due to resource constraints, we cannot guaratee coverage, we cannot tigge= r > specific tests for your patchset, either. > (sorry if this is not your expectation) > Thanks for taking a look and clarifying this, much appreciated. Fingers crossed for not getting any reports :)