From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 537B0C6FD1F for ; Thu, 21 Mar 2024 23:56:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D78CB6B0095; Thu, 21 Mar 2024 19:56:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D28906B0096; Thu, 21 Mar 2024 19:56:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF02A6B0098; Thu, 21 Mar 2024 19:56:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AF6396B0095 for ; Thu, 21 Mar 2024 19:56:46 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 79293140BC3 for ; Thu, 21 Mar 2024 23:56:46 +0000 (UTC) X-FDA: 81922708812.20.0757815 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf23.hostedemail.com (Postfix) with ESMTP id 9C2FE140012 for ; Thu, 21 Mar 2024 23:56:44 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Y8DizdPd; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711065404; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q7hLBXZVRvGfE/2Hpd2oBop/g59lqRf4KQplnrPKrJs=; b=hJjaeT5FNFpFEtcGKEqjQQUPEiv2crJA4haGONGErY885YAtW7LSJdN/Lc7g4RCteH8+jd ww5KsByl1BYEMdkDZkruyNJV5QBBui9bLrs9+EFOipZwOCjQqDG168QXYbnEYfLMSm9Eec ZN+xrBm8CIqHu3YGLoyn4OyUTg/Wi5M= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Y8DizdPd; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711065404; a=rsa-sha256; cv=none; b=nbKWUAiqcf4SRlGBK2Ln7ZHhzvLVUmOwEtKy/NaAdcdlzqY4UCzExxTyXIfVnoTn5n/XJz /w106q8S/Q/i4U+6Zq7tuyXqyC3b+boTlY3q2wDzMJ1b3zgreUqGZVrJhW/6SlgqiIg2gM nH2DNlnmesew6kPhzAPaQALdirXX/Gs= Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-5101cd91017so1791561e87.2 for ; Thu, 21 Mar 2024 16:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711065403; x=1711670203; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Q7hLBXZVRvGfE/2Hpd2oBop/g59lqRf4KQplnrPKrJs=; b=Y8DizdPdA7IT9Xmhtk3166r/U5kPRs228Q16bjYU9pS1R/lYLuLOq842qCGz7vI3gh FUqsflpM221lS9PP4LwCFzDkzJ5QTyjgt0pZ9EIg2+HZEYUIiTJo9mn85yhXlQeT7Z7D 26/+S4V7wcFp7Nznh2GKo5yenjAer/dRDptO0gX9YWr8oRDpclkzlxQdl/zPQ+eo94dy 9O8jdFdk1ez80eguvnXnnFwINnoyCAM5Uq+nY40ouWdW/Oy2jYnA904gEXgGfivMleIx hqE+HzYiTgcz2OYfvv0TA2eLZNki69TL9yw87Kqy+JUIce2tJPTFxmBSF0JD3t7LQHto B4wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711065403; x=1711670203; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q7hLBXZVRvGfE/2Hpd2oBop/g59lqRf4KQplnrPKrJs=; b=nZoHe1ek5Y6lPJtVMCSNzBTaUiEj7ns7AYNsrIdoMw2pWqgAqXTHIfJit8iimoaKTi re7NqRQbwlzZOclXm6iZ6dDx4VT5X20e1VmcidhSpfVwfzERNz9NOT6OhgxTO+E4XvvO KdXSO/1BscB0lvm7tq2xukSi++4LXneEH+JOLTuU8Voxz7ZnwCxmouIM5oTQrinptCsf ykSe2A8KVRv5ju0+Wbn6fF/FbxScINic1LfOChX+yW4JVoZzrkyLOPoPoHw0WOf2JSnO lpBS71XfWSgvXnPtsGuqNNh5cpO/J8Yi1yqEtMWk2NcpPPRfBwPbdMY5opvZq2wKPnEa LeGw== X-Forwarded-Encrypted: i=1; AJvYcCUlbFix+ze63c5qOZJlK6T/qlhCPHFSvJrJLNBCY2LYRriB1VMAWcVmUU1tamTOkOmy3MjJqs4We+gfrUJr55a2F6s= X-Gm-Message-State: AOJu0YxaheVw9Rz5x6I+TddnvU/587q6+imPh6QPoAZfcR8aLPgfmeHQ pc/iKkPa5Ua0WiL1WBHwJGWryX0lsVmje3qS+7Xmxdy9fnO+0WHaQV2mcEcQwp4jMxMOW2ptIId nJmqyo5W0DslgRg0awksjKOzcvIazqbzOiPiW X-Google-Smtp-Source: AGHT+IEBnyEucTPs+PzbUoRwIWW8ICXSNiNdqnOVM+OXaugIGXlD0uviQekxj8YFoz7OGp2LjhUyW0jv+uHGl/MM6KY= X-Received: by 2002:a05:6512:2ea:b0:513:46b4:4eb4 with SMTP id m10-20020a05651202ea00b0051346b44eb4mr526727lfq.3.1711065402566; Thu, 21 Mar 2024 16:56:42 -0700 (PDT) MIME-Version: 1.0 References: <20240321-zswap-fill-v1-1-b6180dbf7c27@kernel.org> In-Reply-To: <20240321-zswap-fill-v1-1-b6180dbf7c27@kernel.org> From: Yosry Ahmed Date: Thu, 21 Mar 2024 16:56:05 -0700 Message-ID: Subject: Re: [PATCH] zswap: initialize entry->pool on same filled entry To: Chris Li Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Nhat Pham , Johannes Weiner , Chengming Zhou Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9C2FE140012 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 8hpiqmeijt19ott7n63x36ketqtt81fy X-HE-Tag: 1711065404-853630 X-HE-Meta: U2FsdGVkX19vYYwgD6fVYL+8l26GR21hWUaLWP98zSZuvhhzJZHlv2VuQ/KT00cd8sm5RAz/VEScuFnIQyCVXTiixJ0oYtMzRkKoF4LEITFqOAsaWVptaMKt4p/kWQwwT08uHBuqomayIFui85LklOzxp7+wq3StfAmuuGHCRdjFBY5qbGAnJkE3jHFzrtVAYMh3NvnJguuqv9Obbl9iLXIn8xWKWKXTrTnn8aD6mEz3UoZ2jPu5fDMrmkfphVdV5OvBsLk2QjgQ8J8qUP7xEtgEpNR9pW2LW78fxCWMwAR6cLB/1O9kKTRF/93hQKjyFYH5n+6roWMuIN+RkMj6N/iXj7ZCrOA4dmLivyPm8+kVV2DKNphzBYPq50n2Cib2p/80F/761yykxGxU75f7xpIhuxmG5F9OJKUiinDz+QPJjqBeQsy3qeSwTS6KElwbnOOhFLKT0ZPE8HIMkPvh9n5dRO7hwVbn9DrbwC6d9HVXIP0FXWNgjG0H7l7rMQGHsBwQH26Tp1Q18dTdl4E+wTq7syq5i+TILytRThV0yrJwb+RYvhtuODkubSZJM9Gv1q1st/EFkU/I8rKADHwsRV9OlVZ2YMp2AiCRMEO0y2/wY46UIFm63ndfyJoMOoiHBU2WltLY/7QC6jXhb609CHKasfS7W1MWzP8Q3leHs+/RWm+0VfTPLoO/lYG4AH4e6fBlKr8TE7fzTVS+WFBQ6tRBZ10GxvpZ2zTs5Z8HmYQX6PcMEPr/+5arAWkE2eFVhJqo8lLUoeOiGEk/jzvC6Ut9wMR5vOQ0EiQmOWoBH4l5U6qzBjgTWLnv5MubDsvqNdpQ/thOhsSfR/6fJuqbrFL1sK/chEKEN+WkkCtD6h8bpVuun64/758wjPJxPVxt6zoXQA0nX2NOR+rkDh/eXLnw7RcwX7LW9ttmgtdvZCguEY1Bq69DpfVu83vWSvtTuYsFfUUkaYnP2eEEZxo rrJ4QrqE dEaNBKH6gtpsT2zeO2WeOEBFLwJBnQ4rZAmtf+VWh4+LLOWzF9tr+w/IFegMfaHunSt2gvc2sG0chqnzUbKnMyOxsxHqLhhybfve63yQRdqFrc7I97jpisnRDqCQt5aOvXkLXljbZQJ1wVWkF+L1kfSAgk9ENqkalIef1b0acXIa18NFOUkFjvzMSx7zj9eA04t+0NPH5wxRa2MiaB45vMTLekDhBu7kyi27dF8lJEpS/nbpzvGMoqixZnljM81wBkzaIgy2zNXyvW/kM/5KCy3pyzTYfSzBNAuPImh1JyveGVNbnaHUFbXg0Aw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 21, 2024 at 4:53=E2=80=AFPM Chris Li wrote: > > Current zswap will leave the entry->pool uninitialized if > the page is same filled. The entry->pool pointer can > contain data written by previous usage. > > Initialize entry->pool to zero for the same filled zswap entry. > > Signed-off-by: Chris Li > --- > Per Yosry's suggestion to split out this clean up > from the zxwap rb tree to xarray patch. > > https://lore.kernel.org/all/ZemDuW25YxjqAjm-@google.com/ > --- > mm/zswap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/zswap.c b/mm/zswap.c > index b31c977f53e9..f04a75a36236 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -1527,6 +1527,7 @@ bool zswap_store(struct folio *folio) > kunmap_local(src); > entry->length =3D 0; > entry->value =3D value; > + entry->pool =3D 0; This should be NULL. That being said, I am working on a series that should make non-filled entries not use a zswap_entry at all. So I think this cleanup is unnecessary, especially that it is documented in the definition of struct zswap_entry that entry->pool is invalid for same-filled entries. > atomic_inc(&zswap_same_filled_pages); > goto insert_entry; > } > > --- > base-commit: a824831a082f1d8f9b51a4c0598e633d38555fcf > change-id: 20240315-zswap-fill-f65f44574760 > > Best regards, > -- > Chris Li >