From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6306ED10BE3 for ; Sat, 26 Oct 2024 06:36:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF1416B0083; Sat, 26 Oct 2024 02:36:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA10D6B0085; Sat, 26 Oct 2024 02:36:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D67FC6B0088; Sat, 26 Oct 2024 02:36:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B80F06B0083 for ; Sat, 26 Oct 2024 02:36:57 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B705B14101B for ; Sat, 26 Oct 2024 06:36:35 +0000 (UTC) X-FDA: 82714795464.28.441DF3A Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf10.hostedemail.com (Postfix) with ESMTP id 3C052C0018 for ; Sat, 26 Oct 2024 06:36:46 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CoILzwxh; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729924562; a=rsa-sha256; cv=none; b=KkbOqULgB7QNFiAvd6fgPa3t0G3g6L84nK6MYUtJduqZ0vaylcwJgfzVTxBDkUzOjwJOOL lGqeWhD0nAQ7CdwZTY7FsW92kk4vzZy1vxUAIegJh2wpfg9o5NPrZZIYjK+jYrEGUTZKBT LOPcV4BRwmfjacIspYJrsrUBhlagwGw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CoILzwxh; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729924562; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M+qy2zQX0aaHTR7GxFs5bd2bieBYlh/M2zFjazhitkA=; b=n5IDVHHvbVa41ADk/o7fcXM+ePvL+sZviqKuS7T8O6mT1MM0eg4KfNdVKEAYqZUUvXjbps gYEEwqEqWfNF9AmYEhZOddaYpuDdkPBuRlCncxftbt0zRZhNk9I6rOcr2kciKvvmrt6cxq uUSL9NqWWUpJE7qik4h7jbTbP1tQSHQ= Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a9abe139088so384610666b.1 for ; Fri, 25 Oct 2024 23:36:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729924614; x=1730529414; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=M+qy2zQX0aaHTR7GxFs5bd2bieBYlh/M2zFjazhitkA=; b=CoILzwxhPwdqI8BXIADPUCL5cHE9mKACuOjHHOwhXw7iTBecQDFnDzxven5hbQCEpJ VjXMXoraVhG4iYk1h7tjBpEflNlUjOq9J+Lul9/0oxc+gQnbs4IEgmgLrMLVNpHUF+Ui EDR3wx1iidWDm6mXzdmqUsn9vboA2YUvnivP6bTajmQ4uqcO6JK+T5OsDRdH1TgqX3u5 YcMbbZ8v/Xxbxe7nUI6pY3dZ3Korns2hK5KWp50LXIwGwR0l+osQ4CSmOo4V4AslbeFi 8W7C6hYVSYCosqOrkTFaM6B0CymwoWML5KYgI1Rx0ve1xB54IGdNPG0Zyk8kcjmQdLis Plgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729924614; x=1730529414; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M+qy2zQX0aaHTR7GxFs5bd2bieBYlh/M2zFjazhitkA=; b=fj00iSUw3ImQYysuLlJymUuDsYQv2s9lNkPJHxaT02rKfuvPJEK0fI+novx8EJmCVr jiUXXgHXhdHj0JJiTOb3Nl2SH3j3OdsCXraX3qRdoQ2juC3J5OZGWYYH/ZhUcilKkS5y BzmyzqUz/k+WSOwkrqqRUWoKm7xxBm9J2vqbEJrgcFTvnMPgLs3pKDG7UYL733vmDUE5 Ci9x3FVGjsDVACpMKEtXf83UxJt0z5qP4+ejbfTGW4oiepWdskd2RtK37Mf5pSi9CsVx OHr1tCYzKeZcV139cKW++7rtN5QXuoo0a+0DaXy+4Z2iKxeZ0WpoNm8HPyNb9kA+N8dM uNWg== X-Forwarded-Encrypted: i=1; AJvYcCXVJYlWI4pjpGq7iSwm8kk+yaqegtI60LALSZIABpjqyzj7/FnTqQHoHgx76Ov5GF8bDUZJKh8YkA==@kvack.org X-Gm-Message-State: AOJu0YxT9UYvEf5hJq9uTXdFEKlARJPkWzn8v9qF7XbWlZ0Ia1LJIpLb 0J2BTFfRPv4EBUCIdoviTyYpG3xvNyJ59FziSMwOk893h8NKFSl6pfFHh9xmBj4oW2fR8mKezA2 +n33iNAgjUdKV0jSXdJwiRdisOByrY0A9DRxC X-Google-Smtp-Source: AGHT+IFgD0L5JjUW+CHqidonMlwwHMsl6bGtJqYpaisQi1tq5t2valMcY9r2So4B4VtRTvcEdOebNwVejifKQj3ZazA= X-Received: by 2002:a17:907:3f9d:b0:a9a:1160:993 with SMTP id a640c23a62f3a-a9de5c91c9dmr144210966b.8.1729924613651; Fri, 25 Oct 2024 23:36:53 -0700 (PDT) MIME-Version: 1.0 References: <20241026004826.55351-1-inwardvessel@gmail.com> In-Reply-To: <20241026004826.55351-1-inwardvessel@gmail.com> From: Yosry Ahmed Date: Fri, 25 Oct 2024 23:36:17 -0700 Message-ID: Subject: Re: [PATCH 0/2 v2] memcg: tracepoint for flushing stats To: JP Kobryn Cc: shakeel.butt@linux.dev, hannes@cmpxchg.org, akpm@linux-foundation.org, rostedt@goodmis.org, linux-mm@kvack.org, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 3C052C0018 X-Rspamd-Server: rspam01 X-Stat-Signature: g9yrzkcyfjbq4s9dsfmwuf59ebxakwf4 X-HE-Tag: 1729924606-891484 X-HE-Meta: U2FsdGVkX1+QbZmvIcBcF0ktOA6179vPtky6zRkgrtFcc/kmwRQQ4EZ4QVuBp4u9gJgrDQAhSLRt+6ZAowC5zxR87Faty8dl7R1cE/7jn/OxqyTIQxgQPpE9c/kCAk7SNmNWpDDXwc2ijzP/k8urNHK0E6KI79+3MZj67NFBftFV8tnlrSEk5wKvFLPoHleUAk4nbnq9jLBoxtiPZ8z4syPGff4FLgRRHTcb1J+iNY8tVpBdeYtGj7bMSJrGAzg2yUZPDE9cv/lZ2hvLOF3mfE/SuA3Y8f/2IpCZdeGPFj7+EEdG0xMSCYo6DYOwybQKx+cNPIFvNO9fHsrmNIqpLWuFFp4Zw4uPgI6exWCpsE+uGoDC0CtHuCuB731cwv8ldLo9pP7QEXY5kloHwsh52jeZrRg4pX8+0GbzB1+qpSqvyhoYc0slvTgywbc/fzlq9l7rejZh+oV0Qz/tuVKOBR/B217H4YMPHobpog13za3CB6JjdLmsjTmauCijzD2je6SwUjvQS10c8s1YtMkhLpxfYtQSQS8D+2gAotVhsspjOKzEyieO8+Hx2NZqdW0mfVh9IHyBo7z7hfHvSkQg+2uOdKcq6xPx61NFT9uxP932YnpESezKqDh87bF8JSX0uwwx3WsWhgpDpbz4BUFPlFDhsi5AsyZXWPgezU/AIv0dz+K1ZqFSsg3xUroAj88TBufsf6JbZTM7hY0RnlJ6yiWDByUYgINPm+SVYMEIJ2Hj3nL3xAajcfE6BExfscGh2NnbdD1+QHZX1QHFUz3+Vr1FrJzkj7/iJUAS2yVanvXZ665tJXgju8vsVx70LiYHbNC06kSC51CplU/TXkQCO8sM/nHjFziX+uxemB/qM4sKpvV5dJVsDr/d4pGWj88+2XPUIfKYakKI2pigFh6mBusBwokP22rLJigTB/H1gXws4HKc0u9FmTL1u8ApZYQFqeACQTxMcB/Dq37hEAs 3aFpA9gT G8H5l1f2pT7ZDqj7keSSguVjJh6e4u+qwJcSVRO15JolOaO8ixDCdBJSSiNMLoSsLPQ8i9P1BltNZuVi6JSFh7Q+iu7Y96HdDaeKv0s0BLCfjFo7BKZBYIpoBBIjg4TXEL9Vd4eJTiDhhnRTeO2fcCfu6PCPcAIr8NXxHjPc9Es6X3s5ws4PM6VBp+ToxCtbP/WGL9KkqxR3JG/AHbnbLGdg9sg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.009217, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 25, 2024 at 5:48=E2=80=AFPM JP Kobryn = wrote: > > This tracepoint gives visibility on how often the flushing of memcg stats > occurs and contains info on whether it was forced, skipped, and the value > of stats updated. It can help with understanding how readers are affected > by having to perform the flush, and the effectiveness of the flush by > inspecting the number of stats updated. Paired with the recently added > tracepoints for tracing rstat updates, it can also help show correlation > where stats exceed thresholds frequently. > > JP Kobryn (2): > add memcg flush tracepoint event > use memcg flush tracepoint I think this should be re-arranged. The first patch should have the refactoring of the flushing code with no functional changes. The second patch would introduce the tracepoint and use it. Also, please use more descriptive commit logs. Most of the text in the cover letter should be in the patch adding the tracepoint. For the refactoring patch, please describe the refactoring and its purpose, and mention that it is expected to be functionally a noop. > > include/trace/events/memcg.h | 25 +++++++++++++++++++++++++ > mm/memcontrol.c | 22 +++++++++++++--------- > 2 files changed, 38 insertions(+), 9 deletions(-) > > -- > 2.47.0 >