From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5E4AC4332F for ; Thu, 14 Dec 2023 04:29:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 345D18D008E; Wed, 13 Dec 2023 23:29:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F4D68D0083; Wed, 13 Dec 2023 23:29:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BC3C8D008E; Wed, 13 Dec 2023 23:29:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0C5258D0083 for ; Wed, 13 Dec 2023 23:29:35 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CE5B3C03D3 for ; Thu, 14 Dec 2023 04:29:34 +0000 (UTC) X-FDA: 81564145068.06.168C113 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf02.hostedemail.com (Postfix) with ESMTP id 05B8180002 for ; Thu, 14 Dec 2023 04:29:32 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=pSOlp7hZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702528173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LrJKnh7rQalxBTETxx0mDtTP7C8D7JFwx9paPElxJ0A=; b=1iFddSn2ogqvk1Gtr11EXDMKz0vH9UrxmLWMprkYJi5Wlbew0d5UZWS22qitThAqSu/I7I rgURke/sgk2DrUe7B2l94DfHun46vWPufaxyfaSDQEN8H4wJ0+yi4SllvcTEgArPUhZ3cE jeYmj3euNGgYx09l1PdTKQyIFTkWuoc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=pSOlp7hZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702528173; a=rsa-sha256; cv=none; b=u+bzY0ONwHo9avLT+bZ7nRRJwHdrhy7l/6FsIiEGbkuxBs4ZMo4lOqWhqHEVUwuN7ZgSK7 KDQDPRX8qGKnjTqI+Y5G33L/EBR+4SAsRwoKmLzJkVPo+W5oU4w5HnYRYXZFU+s9VNl0s0 5N9+Ah7eylPeW4QvUy6DCkKiYSu73iw= Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a1f6433bc1eso40217966b.1 for ; Wed, 13 Dec 2023 20:29:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702528171; x=1703132971; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LrJKnh7rQalxBTETxx0mDtTP7C8D7JFwx9paPElxJ0A=; b=pSOlp7hZyKkfVY+btSAY9qnCIfTMrqy/AhhNhMIxpUX0llCClaybs6UqBe/3domGCb Mww90oVkgetSw0ltjtFNFociuFV2svhErZLldLtdSXcj0n66t74Ec9qfwRpAh2O8jOuv LhFfefjTwBQanuZCnSa1j7YpgAst/act9HsmkIN6x6xoBRaTBmMvpuXrVIpMAb8L79MV CCs30Icw5TXePj/i4qgMtz67AE/cU9hPT24ffgN9A9zT0c3VNUFUhm4w+eU7RlCj9NfW nMSSzr9EzuHaGB8Rxj4EOGt8/q8pTVWlJDZrukoEEL1foOXoQLUQrTxo6zeExFfwCkyI +QFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702528171; x=1703132971; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LrJKnh7rQalxBTETxx0mDtTP7C8D7JFwx9paPElxJ0A=; b=YelyFgIZhPg2sn3/OX0PweQ17NYuwEW+kF0boLWninBf6rOtGY6NttzIkcEcnSN6fz VeyUiL+XoVlsuS2aLC0LhvzwMpY8UkHzLRdS0F6w3tF/rG7kkjPKQF1NOCFX/q1mwSha 5zFVg5NdDYUZF3nTB+do3nrmMR3Xp42bDNrnaRYNs/m62d93kQUh6mc6SCXLXVVasHJn JPocD7HK5KLIxc1a/JBP+VdT1uEFK/zZd20HGK+Fp1iCI1BjKf69aw8kR9xier7dtxN9 6fL1nmSi7Q9FHxMiHTLkDR4cFACTNePxPMOyjuZQzfNrpZ+wOViPnGm7V/r+suEV0HxK T4iA== X-Gm-Message-State: AOJu0YykbAsU+tozoD8dSMgUEEFkYcNVaP+Z/6Ky0JKIF/+gVVjhe+tB op1MYANcejUXXTAdd4nvpIE78gsok3usQZwpAFq62Q== X-Google-Smtp-Source: AGHT+IF2ysdaKi0/4cWuvP0ESjKBjqyr35uOzZgLtm21MWAnyPwgiig7C13qI6K6cwlt+VbUCfaj23WiFvcTno8KwPI= X-Received: by 2002:a17:907:b5a2:b0:a1f:6ead:c119 with SMTP id qx34-20020a170907b5a200b00a1f6eadc119mr9472498ejc.21.1702528171233; Wed, 13 Dec 2023 20:29:31 -0800 (PST) MIME-Version: 1.0 References: <20231213013807.897742-1-schatzberg.dan@gmail.com> <20231213013807.897742-3-schatzberg.dan@gmail.com> In-Reply-To: From: Yosry Ahmed Date: Wed, 13 Dec 2023 20:28:53 -0800 Message-ID: Subject: Re: [PATCH V4 2/2] mm: add swapiness= arg to memory.reclaim To: Dan Schatzberg Cc: Yu Zhao , Johannes Weiner , Roman Gushchin , Huan Yang , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Tejun Heo , Zefan Li , Jonathan Corbet , Michal Hocko , Shakeel Butt , Muchun Song , Andrew Morton , David Hildenbrand , Matthew Wilcox , Kefeng Wang , Yue Zhao , Hugh Dickins Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 05B8180002 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 1kqi3mak4o4dkwtgx5nejjbxa75r61br X-HE-Tag: 1702528172-744725 X-HE-Meta: U2FsdGVkX19217lFJ6nIEgoSJCaYnv7a74uO5BOQlQyPtz85xNUAvzrLFJPMDhGtnNxDrftxw/yE50slc9N6VzHkNYW4KJ2AGTCLjnYvqhmXRnrqgRgcKfnCVTflaJZvqz/E98gIhTKySKzfpPiK05C1aRW1ZvaZca7pQnwWDz38WLD67t7rBNNXr6OfzmVvg2+TYBLKXYKuBJB31KJBQlcQPQuers8xdsnGygAwYViE96hdf/fz4ZVPaodxZ6upjWxEl6stQcZvGaTKFseXkBaRryjUfZQoVz2J2haUfJia+3vuEm/AiHGIUtUEIMrZcxLCknq8AmbnV4xl3Hljd/s8qd100gUFJbgwyyk4RyLyV4hM7zbdGk6lM2+kITXu0bfiSFZagd1fpxKO5XYQdlS1Q5TiTSnTnOq+RVBlHVlpAmf2mZPa08T7tg8Cyqs9wI7zOtogGehpNrXFB/WpAK1NVH1GKgkutvTO90Hk9bwaLNPUDdP1Ej9bx2y/4PArIsF9CD1MTvJaHKzegQoHslmgSSgjBurlJYMiiU0hmL8SB5HU8I/7pcLuJk1Q2/R4/AXrHW2DQfFeFWfyePcggpySpehM3jqgbv/bemoFknjl5JZEJRfZZ0sK72nkmCvBeSoK4NNcLZq841kr552v1gyjb7YrSBQQgwGJrN2iWPiA7XDQn1NwXRDeh/SSEbw3r2dMPr9Y46/aKwX1FN4vviyjcoBwgpnd1rRQP/KGVMMwnyVfUfeuzJjzeqjHLbnyBooK48Xb/RJVQALngf5xh9hqUGs/txiOcpvEMvjA3cfA9VrhnrvkUKwtiqFUPGH15vyJMOUyMi6DITRSwABZj7cA/eabAtAKmdpP7iZ1oy1BAEthMF2izoKuNnagxCWDFVoaDT8xWl/dAcUbk1zVdTVVB7CMp6y/Kz7ommtxoke3VhfNb3lvCBKLwUWj2RqDES/8xN4fU32gYTmxTlR ks3MU5Zk v2978yX3cRD3V6n/6OBUjDt4+I46oPj2V2qqkwt4QeDXp6o0f8Iwtout04kigPOTQTO+7rbVyZ4ibmUdN/7ifV23O97NuMAjpcp7IBwEdJ13pDuBywMkJJS6mlZ+/oqgQBj+VqO2ulkvBukF/VKjZJCdbFSUyfdN4QCe7JlJkzbz9ZomeN/kquTe/tYMFOVjHjMgnNPBFoulGqwUiO7pD4XnLakiJ+Ax++lcGJe4CIlLZbrXqsmYNn1tvs8/FNrQjgJeWOnnhVUnBVLfnNPSIkH1+vJwR9lziZfY8q+/w2Pi5jTE3E0qUvnWA+Yh1wlr56BB9kLlPVNOgNbuRI4cGGDeUfVWQjbmZIJWkvfkYew0mknM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 13, 2023 at 8:38=E2=80=AFAM Dan Schatzberg wrote: > > On Tue, Dec 12, 2023 at 07:05:36PM -0700, Yu Zhao wrote: > > On Tue, Dec 12, 2023 at 6:39=E2=80=AFPM Dan Schatzberg wrote: > > > > > > Allow proactive reclaimers to submit an additional swappiness=3D > > > argument to memory.reclaim. This overrides the global or per-memcg > > > swappiness setting for that reclaim attempt. > > > > > > For example: > > > > > > echo "2M swappiness=3D0" > /sys/fs/cgroup/memory.reclaim > > > > > > will perform reclaim on the rootcg with a swappiness setting of 0 (no > > > swap) regardless of the vm.swappiness sysctl setting. > > > > > > Signed-off-by: Dan Schatzberg > > > > NAK. > > > > Please initialize new variables properly and test code changes > > thoroughly before submission. > > Could you be a bit more specific? The patch is compiling and working > locally but perhaps there's some configuration or behavior that I > haven't been testing. scan_control.swappiness is only initialized from try_to_free_mem_cgroup_pages(), which means that swappiness is now 0 for all other types of reclaim, which can be a huge problem. It might be easier to restore a special value (-1, 201, whatever) that means "use mem_cgroup_swappiness()".