From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34ECCC4345F for ; Sat, 27 Apr 2024 00:52:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A216A6B00A1; Fri, 26 Apr 2024 20:52:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D16C6B00A3; Fri, 26 Apr 2024 20:52:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 898846B00A4; Fri, 26 Apr 2024 20:52:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 71A286B00A1 for ; Fri, 26 Apr 2024 20:52:03 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 15349160548 for ; Sat, 27 Apr 2024 00:52:03 +0000 (UTC) X-FDA: 82053484926.14.3091750 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf10.hostedemail.com (Postfix) with ESMTP id 47E8BC0002 for ; Sat, 27 Apr 2024 00:52:01 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ii1oSIb9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714179121; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fUScy4CDQzemTknfjsfZBWJBSrUtTixdIVJuNp4SGp8=; b=v8cUt52kH3YlQ+czEyTs4Q/7mCFfwku7owxP8omqyfdwP6DJ3a2DDosKWn1qzpdAF6QtEp D1MCWxmqe/5oSL8xWBHBsDbKj7FSZ7pmXnZmllYHGm+2/2Qms6szm2buc503jXQmvC9oo8 4ZBZ9YqY/RqK7ecIrpm15Z/dppRF+wU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ii1oSIb9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714179121; a=rsa-sha256; cv=none; b=FIFBm4+RI29H7dokLSw0/xxtpvWisuIiPZzy3O1wqUKFaA7R3xgtS5ZeGE4n/pNQhq8Nnu 5Fco33iVOtcUAZie3PBEKAZiScfD1gNEA1vXQryQb1Y+bdLXc3RvKOxxCNbcH8GHdyvLwo ICllchfaGbzYwsCNyfeXTcztjHK3ZRE= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a587831809eso316706866b.1 for ; Fri, 26 Apr 2024 17:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714179120; x=1714783920; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fUScy4CDQzemTknfjsfZBWJBSrUtTixdIVJuNp4SGp8=; b=ii1oSIb9rZ8pLuhb52xpAMQfq8hjl7fGXb5qyQUlxwOZ3lMx7zM7DGolnMdZgmEp1o UoEXZ5lQSN/9I/hWJ+3LgzLY3byepK4EerWiK0DI3BuSm9NGyYflpqiNAOzvqDWlLI7C KbAuykvjgBhdBri9RH3klG8HXHhqF1bmluqFruseUkMqsrsuR767BVFdNNNPG9/BR5Rk FAoGlErqftGueXXbRDYlx3uMD7M6w7D3Plskkg3Tv7MY09GUZS0FZFF+NRvNBP+CQpYg wcAk6lm80l4X8sfOjVRpvOak63LU1JSLnXvaBQVcNxRFcVKk5e9jNuNEm6yFb19wr8Fo uYjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714179120; x=1714783920; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fUScy4CDQzemTknfjsfZBWJBSrUtTixdIVJuNp4SGp8=; b=wqxogoXgg9Y+Oq5GGfj+TW9HBEeXyTAMPLonLzpb17BjompfOABfHm2E+LhY/zU+RI IghnP9+QACD98dPO2ADLCYCA/VBTE6LhQZcRYi+uk7LMPmDck2RmrqHIikz+4jvVuzjz 1+y5c34LVa7kqZPx6bq+G2TXmcQZ0jlI9w9H6Encb0EaPUhJoPb6kKWthqhLHPPUo7iQ dk7IL2yZnuf8cH6A5PNaslTJd6lUKB6WO5xbd2jMl9vmieAhdPGgmMiHuFYgh8E9PN9W v8jA/ZYmjihtmOboa9KBKbf4xfF4y4QDXtmktBzxCgkwRisKQEC/Ruj1e6Zb/AyV+zoN 5aow== X-Forwarded-Encrypted: i=1; AJvYcCUGvVFZUk/M5pDJkYGlIA9iLInZ+3KqTkN4DRPz+Gre27EHlkzr0u5zQUJMFPHn+cpb3VKIYMJqVrYuPtOBE1/MdIM= X-Gm-Message-State: AOJu0YxYZXGZh+fbzNbXoBB5Ba7yufwHWcZeKE1ag5csYUU6cYVQVc8j C6dnZQe44HcbGzNxTGLltptqkDz66cPD8QgC6SJ3acn56FCoxL1WHf0Jh1N5gCyAsak1pRAX9d3 br19oHZV5D+G3Zkf/rrmwJvEU+agfcPMeoe9bgAWe6bl1rOc4wdV9zwU= X-Google-Smtp-Source: AGHT+IENM3+vqJZUAP4pwreGwwcuKC80xieBst0NU2JKw0jAEPkLUSJvuN/h5ayrVasiJ/V8gG8GgXK7KZtoX8i9M/s= X-Received: by 2002:a17:906:6a8d:b0:a58:308:274c with SMTP id p13-20020a1709066a8d00b00a580308274cmr2911288ejr.21.1714179119602; Fri, 26 Apr 2024 17:51:59 -0700 (PDT) MIME-Version: 1.0 References: <20240427003733.3898961-1-shakeel.butt@linux.dev> <20240427003733.3898961-4-shakeel.butt@linux.dev> In-Reply-To: <20240427003733.3898961-4-shakeel.butt@linux.dev> From: Yosry Ahmed Date: Fri, 26 Apr 2024 17:51:23 -0700 Message-ID: Subject: Re: [PATCH v2 3/7] memcg: reduce memory for the lruvec and memcg stats To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam01 X-Stat-Signature: 4s5h7mwpib89qmfrpsjww3kc89hj6dwc X-Rspam-User: X-Rspamd-Queue-Id: 47E8BC0002 X-HE-Tag: 1714179121-376664 X-HE-Meta: U2FsdGVkX1/oQDCye8c1AMI+jqtsuxmIBw8A6Lh7M0B6fPqBpmJog3krvXfj46sove4pqU9DPX9Ty7voQXi3oLusNgM1un/Zmn8TbfCjXQImumQyVZ505AfKPzv901+lNCOi4OPvoW2cGzKN9YDYKfr7EPHf0OSrU+vV2a9WEHthV5nqoqgsaHQ2efvaPrsDRmYjmiOnNSP46FmuSE/Y8boV4IANx9BKbQXlCouVgw3vykQkARRZiYahj6nnVJ1wvDseaGCVTqq0CMoOh1CZuM/hUwZiaHDcpC1XCkBs6HM3UgQL4A0ML124Ll515qPkQX2JixuErjQ2iSx1DCvyR1e7JvAk8Ki58RaM8fMgo8H7VfaBXStnRdI0yOtpkRB95M0UQhDvXGZLVwoImZ364LXZeqRerOMCLYGmgbHb0MXauZQL6e3CcPolJrhoRBJL3AMuInoPggyIaa2iObQV0pkyMEZ/2uOfC2JQW3V3rMrDvlOq96GvhTfKZtYYeSaIqUVQ3pNgsDKNrpeJF/3NBBva6POnv68s9Za+P8zvfFV3w1wMWRwKwqi3df8dMe7vOKnn/xU+tcBdt5EXQFUC+gFP3l94cX3Kahr5Bdbk/bsS0wGumiKmjZ8jzJZQSu2L14ttQ/sRE9175oQ8mysyX7cvyftpoYSRE1atdQsaTSkWkRUxeukxurrGfJKe10lhhMBhV8WCxibIQbimbWy5Da/a4W/c5bdgG3jhbrrWLE3rqrmmCD+iEnM3Xmx9GWnWXSGajXp9RdCggnFp42LQGRRAPYpt0/m4V+g7Per55M2kvjRSNInJ3D43Qi6rNfbKiTWnSEunsbpphgXCFDMsASyVtrb7/cKcGIy8B7gWrI0jUEQSjsM1ykTCyjXoeGOqSTabaNOR1h5awfIFDL6VevCAH00T4OrwaJvPRXznX4O1Fztg/29bmE1vvLQQerjYWn8vwKkCOs7m6DWXvvE fByGnThr Wm5IVOFTPbJffVGfddWuh18gzxdGOAnnSKl+aoq+YY6HMxJeKjfXoa4Lp78JMqhCf3ezmXv7IhC3azBDCUI8k9zyZiFpAnZCZ/OMmitQupA5cO+IaMLaJV+XfnXpi8TvCOQDzquxH4bqK9CULsCkA7R7EGo2E16adKawtbn9npJEXL2j1HSrRBWLUPewx9PMEW1S2AuVdoprAPRe4sIL1mcHDIq6b+a/viKxK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000328, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 26, 2024 at 5:37=E2=80=AFPM Shakeel Butt wrote: > > At the moment, the amount of memory allocated for stats related structs > in the mem_cgroup corresponds to the size of enum node_stat_item. > However not all fields in enum node_stat_item has corresponding memcg > stats. So, let's use indirection mechanism similar to the one used for > memcg vmstats management. Just curious, does the indirection table cause any noticeable performance impact? My guess is no, but the update paths are usually very performance sensitive. I guess lkp will shout at us if there are any noticeable regressions.