From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B7E2C4332F for ; Tue, 12 Dec 2023 20:45:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C49376B02FE; Tue, 12 Dec 2023 15:45:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BF94F6B02FF; Tue, 12 Dec 2023 15:45:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A99F36B0301; Tue, 12 Dec 2023 15:45:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 92C4E6B02FE for ; Tue, 12 Dec 2023 15:45:04 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5E371C0AB0 for ; Tue, 12 Dec 2023 20:45:04 +0000 (UTC) X-FDA: 81559345728.27.EC67C0F Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf24.hostedemail.com (Postfix) with ESMTP id 7BF7718002B for ; Tue, 12 Dec 2023 20:45:02 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="u/Fkph2N"; spf=pass (imf24.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702413902; a=rsa-sha256; cv=none; b=aG+X71VWJJhTptY0Y078ZWZMMHpZOO5bnWhAyvB1lhgBv+HgMNgccAxyLbxsU+8OK19GPp U8ova4ZHq7F1mdonfCpnAOoq2QN3+cVSgCDEt9A44qsiSgYAs/1dLYqyc8HiWo3dY9GHvc mqvCGmMgPREn99vtrrzIZfLg6YQBKIs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="u/Fkph2N"; spf=pass (imf24.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702413902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kE8RZVsLlDqV/tHQsV0pBVubgKNBa3FvWZVPRZsHSAs=; b=xVVSTrmaSZDEOlwZjTfhGP2EDDgOg3EFX69X+ASgrhqGWEi/M+uIXR63Zaq0eXcJRiSlhd 1IbRTR7zUTF4C9ZE06OByEBcrS8F717pQE8WgEt6NA/3tO7ZektO0jYdeh2MxoLx5ziBFh LW9gYLgR8f8dB/4mCFbohGqY6Sk1t1c= Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a1e83adfe72so573685366b.1 for ; Tue, 12 Dec 2023 12:45:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702413901; x=1703018701; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kE8RZVsLlDqV/tHQsV0pBVubgKNBa3FvWZVPRZsHSAs=; b=u/Fkph2NfaRwhL3UCDPo0XDg4YyagKKXFIqoRbhCnPMsDmVuwftFThGIqHuz65donM 8hFWL4KMG+dmhEGW2gtXghIfrkk4SgsreKy+eKvep1oUNUOklPHmS22m2yubOx9ZYKWG BTxLO9BSyDgP2s8Z0MipERPHZEtpQNKWheU1pCB4p6OWSN1ErA6nDGp957OSuT6eEO71 WDFm+kiYwvKdievPgynHlk+a1tYwtx2IGwxb/tA//yjW8vupKoqg8NdLvpBqXT4P4eU1 T2tyGZC7/UI4QSOXbXIAcExHo8BfBaJiEgvUN4gyrv054ooccY5gnwy57kgHNCq3JLxq zKCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702413901; x=1703018701; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kE8RZVsLlDqV/tHQsV0pBVubgKNBa3FvWZVPRZsHSAs=; b=q0blLhxJqP2Mf49PR262RuI6zLBL42auBSaRJZJoeajzYrX+7LNvHTn8tUFgvzVWLu co8760Rf7bJVQxdxOiuKK+1xyxE+ijoSTPxk/XKg2t9/NX2X7hSX3z1SV25i8R3VQ13k dHftchxTTHfOgeMCI/ev7jNR//cS5NxtijdPshasRCS10srflhoSVZYsHjLHVGIJevhc 1Hup9LqUsPC+VTtMLIS5v5N5np8wGvL2HM4qHwmtMRhqsC14XxnzSDAJ/PlmV8/xGkTX ZG7nF/cvsqPZwqI+t4052Usmm2Y/NdsEDzDWufyAOb2cUPzmLCdiaTCeGaXGBZLjN1rm 6G7w== X-Gm-Message-State: AOJu0YzHZsW345+7rMKCFbJF88ire16O9w3x3AdNclG950CvrKxYitsn GaJ1II5prDNKr4NKSqogLd+YpudGwldlFRaAhfpZhg== X-Google-Smtp-Source: AGHT+IFAT5lsVwBH0E1qAd8i6cYOV214omt1/uBJz3rz4Sjo68LKbG5FT2JF7Tj9rLm3fl0eLDj2fJFUKGMgaDUislQ= X-Received: by 2002:a17:906:5992:b0:9da:ee00:a023 with SMTP id m18-20020a170906599200b009daee00a023mr3752550ejs.30.1702413900702; Tue, 12 Dec 2023 12:45:00 -0800 (PST) MIME-Version: 1.0 References: <20231129032154.3710765-1-yosryahmed@google.com> <20231129032154.3710765-6-yosryahmed@google.com> <20231202083129.3pmds2cddy765szr@google.com> <20231204235856.k4izppfsrpg2rng7@google.com> <20231212104355.ba052748471e1e0ce5cc35a0@linux-foundation.org> In-Reply-To: <20231212104355.ba052748471e1e0ce5cc35a0@linux-foundation.org> From: Yosry Ahmed Date: Tue, 12 Dec 2023 12:44:21 -0800 Message-ID: Subject: Re: [mm-unstable v4 5/5] mm: memcg: restore subtree stats flushing To: Andrew Morton Cc: Shakeel Butt , Wei Xu , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Ivan Babrou , Tejun Heo , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Waiman Long , kernel-team@cloudflare.com, Greg Thelen , Domenico Cerasuolo , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Bagas Sanjaya Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7BF7718002B X-Stat-Signature: t39q9xopt9kpffsc4onp6tdt1pg8fh4r X-Rspam-User: X-HE-Tag: 1702413902-307612 X-HE-Meta: U2FsdGVkX19YiTxUPE20scFnI36uTnb1ckoqx1jkB5fMNxI77zir8nxows5yH8d91PjGkIMlVJF8WucMBxA8sdHVgXD5BDx0EsJf0yTVN13L4Aw1Pf/E71LYFIil0Rya7iCMEYBrcDRxzjJj6YGfdTshrGP3fLBw4B/UhP5G2jqQR2ZQSUml+4o1XthGKdGSC3LwYX4lKO5a7J5ed8f9yIuVdR9k2qFvKAsV4AkwL+HQgITJ3l76aeBdz/izHpDln5IJL9Kvd9hmBGstL3mi4xfT8yaFgppPLJ6bieG1nOQ8iedLKKBHXxm8KBnLmyINskDzHs6uboL12R1sz/OTYxfYsPNRjmkdpXFT0BCbAgox8yg3fJM3UzGDWTB4ArJe5ww8kNM6X3NqizdU+MmzaRewTRFuwVvwm7laI+PCPBuSsmu8OOUb7MUAn23Wqw46MA+cB4XGm1Wf0MVWaSEJAdfzekR70gc+M7L0gANZFQC7BQTHrSNUZljSNiqRQp8a6VsHYc0yRAjadXfP3LWcgM9ic6GnyGlfi4eLHQr1CQtm2O959NUgShJ5fO0NrkUGnHGzwHsi/CFG5ezhJbmiEtekUNPjT++IX2xFugPEYj91OwCbQYeQD/6sLIY1MD2QcxhT3BXHvWOuyqoeZv8KxJZ4pdy+RtCEDdV937BQbZPxpO30uvueRzYjcbMglolraB/UQybzLNYmt4Y0WPgStqxojExMZ5uWRJ/60nHzbWqg3mvNPKybjaHv1j8itk/+0GAvvLyHKrfTCX29RtPmWEy2WuetrX7CcSl1ONHBC8k6sFiXQhiRT9X1CWYaBet/2FQIJcWpJBVg9SkZt51icfUDhiktbrH/kuqLTmoxBw9S7+1HiXbN6aWFwC/b9d7YNq3ndyQlfLbFT2WC6/90MUCPVX/MNp1DWKXOK+p7jxbiBmJlKDSAwZBHxFxbwQc1xqKnHCIIcExVRgoqU9z DEt9Mzic MDDpNKea8VQxPifT9RPr5R8Qjsb1QyRpSrJDjYwLVa13UQ3wZD5Z94LHTmGGGWa8x42u2ps5fBiH30VyWUSX4fWcaXBiuaKWZ/4tAuDop+Bkmv1gYdJ6WcwZDNCaQHtAyX1njMU3nE4bT9jHRH+Z1wDRWuHbtJdD+hI3WJ1aAYvYVqEGMxbc4jpvKY2qZCKA3t9uHw4dPpCPBb8X87RCbTHvAOyk+Vww9B+KQE9HHAZVM5EkXHpggil6frUvr+wcsxsXIpqoyR+bs/E+Pvtja80U+rLlwp2C4WXFXC7RWXEVxRZkre1p7quQBlg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 12, 2023 at 10:43=E2=80=AFAM Andrew Morton wrote: > > On Mon, 4 Dec 2023 23:58:56 +0000 Shakeel Butt wrot= e: > > > On Mon, Dec 04, 2023 at 03:49:01PM -0800, Yosry Ahmed wrote: > > [...] > > > > > > From 19af26e01f93cbf0806d75a234b78e48c1ce9d80 Mon Sep 17 00:00:00 200= 1 > > > From: Yosry Ahmed > > > Date: Mon, 4 Dec 2023 23:43:29 +0000 > > > Subject: [PATCH] mm: memcg: remove stats flushing mutex > > > > > > The mutex was intended to make the waiters sleep instead of spin, and > > > such that we can check the update thresholds again after acquiring th= e > > > mutex. However, the mutex has a risk of priority inversion, especiall= y > > > since the underlying rstat lock can de dropped while the mutex is hel= d. > > > > > > Synthetic testing with high concurrency of flushers shows no > > > regressions without the mutex, so remove it. > > > > > > Suggested-by: Shakeel Butt > > > Signed-off-by: Yosry Ahmed > > > > Acked-by: Shakeel Butt > > > > I'd like to move this series into mm-stable soon. Are we all OK with tha= t? Looking forward to that :)