From: Chris Murphy <lists@colorremedies.com>
To: Hugh Dickins <hughd@google.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Vlastimil Babka <vbabka@suse.cz>,
Chris Murphy <lists@colorremedies.com>,
Linux Memory Management List <linux-mm@kvack.org>,
Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: 5.7.0 page allocation failure: order:0, mode:0x400d0
Date: Wed, 10 Jun 2020 17:31:14 -0600 [thread overview]
Message-ID: <CAJCQCtS4MORvNYGZnNJckDwAGfxFu==PiAygc+fxMJnKwf3Dig@mail.gmail.com> (raw)
In-Reply-To: <alpine.LSU.2.11.2006081321120.10251@eggly.anvils>
On Mon, Jun 8, 2020 at 3:33 PM Hugh Dickins <hughd@google.com> wrote:
>
> ChrisM, could you try with the patch below, and see if it works
> for you - I hope it doesn't just give you a blank screen.
Did this. Does compile, and boot, no blank screen, and webkitgtk
compiles without error (it ends in OOM, as expected).
>
>
> --- 5.7.0/mm/swap_state.c 2020-05-31 16:49:15.000000000 -0700
> +++ linux/mm/swap_state.c 2020-06-08 14:27:38.211813658 -0700
> @@ -23,6 +23,7 @@
> #include <linux/huge_mm.h>
>
> #include <asm/pgtable.h>
> +#include "internal.h"
>
> /*
> * swapper_space is a fiction, retained to simplify the path through
> @@ -418,7 +419,8 @@ struct page *__read_swap_cache_async(swp
> /* May fail (-ENOMEM) if XArray node allocation failed. */
> __SetPageLocked(new_page);
> __SetPageSwapBacked(new_page);
> - err = add_to_swap_cache(new_page, entry, gfp_mask & GFP_KERNEL);
> + err = add_to_swap_cache(new_page, entry,
> + gfp_mask & GFP_RECLAIM_MASK);
> if (likely(!err)) {
> /* Initiate read into locked page */
> SetPageWorkingset(new_page);
--
Chris Murphy
next prev parent reply other threads:[~2020-06-10 23:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-06 7:38 Chris Murphy
2020-06-06 15:12 ` Matthew Wilcox
2020-06-07 0:50 ` Chris Murphy
2020-06-08 9:08 ` Vlastimil Babka
2020-06-08 11:44 ` Matthew Wilcox
2020-06-08 21:33 ` Hugh Dickins
2020-06-09 2:01 ` Matthew Wilcox
2020-06-10 15:21 ` Chris Murphy
2020-06-10 15:28 ` Chris Murphy
2020-06-10 23:31 ` Chris Murphy [this message]
2020-06-10 23:33 ` Matthew Wilcox
2020-06-10 23:43 ` Chris Murphy
2020-06-11 3:14 ` Chris Murphy
2020-06-15 20:29 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJCQCtS4MORvNYGZnNJckDwAGfxFu==PiAygc+fxMJnKwf3Dig@mail.gmail.com' \
--to=lists@colorremedies.com \
--cc=chris@chris-wilson.co.uk \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox