From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E3C1EB64DC for ; Tue, 18 Jul 2023 15:11:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76C0A6B0081; Tue, 18 Jul 2023 11:11:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71CD96B0082; Tue, 18 Jul 2023 11:11:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E3B28D0001; Tue, 18 Jul 2023 11:11:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4D0626B0081 for ; Tue, 18 Jul 2023 11:11:53 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 094BC160288 for ; Tue, 18 Jul 2023 15:11:53 +0000 (UTC) X-FDA: 81025072506.28.3DE7579 Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) by imf07.hostedemail.com (Postfix) with ESMTP id 5CE2840174 for ; Tue, 18 Jul 2023 15:10:26 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=googlemail.com header.s=20221208 header.b=CV3ZKEqZ; spf=pass (imf07.hostedemail.com: domain of cgzones@googlemail.com designates 209.85.161.52 as permitted sender) smtp.mailfrom=cgzones@googlemail.com; dmarc=pass (policy=quarantine) header.from=googlemail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689693027; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JNQ6/gc5vfGP1wHAlH0r+RXd8q2VGkAv8eOnlipw9dY=; b=1fRpTMpzyqHhwC20pzOksPvN3BUuUiy9JS6yL0e/7+l55Nd92/pE6qpUjsOP1kaz9OJU4D +NDvX4uGkLqNaFwEeXXHORUF8TuJpl+vllNQY/ZufvOiLo3anj9N5x/h8t7iQovBQpJiLM 9ERsAaCDilQs57p/LfTqVfMUB5kaMGw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689693027; a=rsa-sha256; cv=none; b=vXI2vkk+dkre2wNW7dD6TK3lttUFN5Zae2mV+AUQ5jMcDtk9gT24u2SDss7qykIq6OtU6l IJ9ACDiW7TRtu5r3EnQVEWC2Yf+8mFg1tAoPhBhEUFkti5V07gYBUcwnyVue+m4XFVobUF ymCajrLounQVJu6XNw7R80/t3l05laY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=googlemail.com header.s=20221208 header.b=CV3ZKEqZ; spf=pass (imf07.hostedemail.com: domain of cgzones@googlemail.com designates 209.85.161.52 as permitted sender) smtp.mailfrom=cgzones@googlemail.com; dmarc=pass (policy=quarantine) header.from=googlemail.com Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-565db4666d7so3906811eaf.0 for ; Tue, 18 Jul 2023 08:10:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1689693026; x=1692285026; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JNQ6/gc5vfGP1wHAlH0r+RXd8q2VGkAv8eOnlipw9dY=; b=CV3ZKEqZWXlKDj1uZ5AVabNJrLd2Eg+AK05DTeuCA+f5zQEMBxYFca0FBmwFTkHcK7 3MlmM5lZTYfktW0UF6SbvxyLoTf1TuBv6ZgILXcv8VOuLPDPduWcM5h/tDvlr0ypg5/q smpype/Nr37YgegIwLWzCYWecOynGyznMId0h5Yu07QY99zOYbeNAPhOMiBJCFwdHIg1 os2djPgcqhMTtJsBcOr448wqDatFIAol+X13i+uIjse3EoWbTEh8eawvWBB+t+x4nBHX AwOdbRVZlXT+Nd0dKShzXbdAGtZ+nCvMDk4XVNYGLQfeaKo9QT1PyMpwDQCP/QPpHn7V zClA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689693026; x=1692285026; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JNQ6/gc5vfGP1wHAlH0r+RXd8q2VGkAv8eOnlipw9dY=; b=IaWTqYECbyNu9k1OAVxvOcn6lTnQvmAhUDMbWHQEAPTWdd/5hauM1mJ9FOYSysYMcE 42UjlrmILqCoLIaAzLmm9dxGL2v0DBaCAu5SHfFWbGb7qEiBqaBNlEMKeiG+ReE1RULA cOax4eT5f5tnwYh7QrCNLHBjhrtyGVaiWlAmFEg5imFo5T3HwVB8sGEN0vR93rkfm6uw 5BeYY+mofUuGOhxzJJmLOpNpQwGJc8/ej6xpqMXandVSB/Wi+QkRDu+f37IJu9yuUdoj s0YX+qfTXeq9C7XTdC9JUgt5jogKYHA+uwE8skU4QvnshCuKA/f5WVGJTj7anCj7ppO7 dF5g== X-Gm-Message-State: ABy/qLYKtmyVplZTNmi1vTlOpMuIy6tvjE1Due1XSMuKC8S0SQ2hA7wk SBFl8fQYEK0gNoSfO1x/Qfnz5113JSg22q2nitM= X-Google-Smtp-Source: APBJJlHDVXGokvOwlHVsvWNoqkFMjjyNFTxOWLqeqnl954tIVvHpuyY0R8psa6PK/CXU+eZaGshpae8nJo4WqnvYlBA= X-Received: by 2002:a05:6358:7f0d:b0:134:c37f:4b60 with SMTP id p13-20020a0563587f0d00b00134c37f4b60mr11494410rwn.32.1689693025766; Tue, 18 Jul 2023 08:10:25 -0700 (PDT) MIME-Version: 1.0 References: <20230712143831.120701-1-wangkefeng.wang@huawei.com> <20230712143831.120701-2-wangkefeng.wang@huawei.com> In-Reply-To: <20230712143831.120701-2-wangkefeng.wang@huawei.com> From: =?UTF-8?Q?Christian_G=C3=B6ttsche?= Date: Tue, 18 Jul 2023 17:10:14 +0200 Message-ID: Subject: Re: [PATCH 1/5] mm: introduce vma_is_stack() and vma_is_heap() To: Kefeng Wang Cc: Andrew Morton , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, selinux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: jxbjjkwbxy3he9o861b3pmusksfmd66n X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5CE2840174 X-Rspam-User: X-HE-Tag: 1689693026-919913 X-HE-Meta: U2FsdGVkX1+m9sklRPJ3zDHRRx1XuZAbNgbHJWi1wq4myQx2whidWAAjHBRBG+naBoRVpZEsK2al1+/RK0u29luZE8sVReQq8sjPAkJ9voUum7SilfPBn+wlJ/Za9MXV6nERtSpJXMi9fcdK/O+EHHJr1wZ6Kmxq3gzrNAr0acPRpakuYZ+1CYb1M3D2O47g3amN1r/dmIXcy/igdOW+/xiYFUjAdRA5QY5Qf59KZ8mGVtZRuJbhDKujueh0lsAixHyV2D6wMSym8iCZRoxPmHwIiYGfhZdNhBnA+AmgadsUGs80MXaOm32YRcApsTs7BUxwXkc4O4HKJCKPUj23PaGLuinHsfREGUBfL6zXGpFYz7l7SdH8ggH8ejxyIso8Hohem+K1HWAAt3WLro5Emw78Yjv/X2BNDAVX7mPLOqYPDEjnKnNww0YI+4bu/wtTHlkIlnJvLDAIzz79GHjM0nziNx5B5aZ2GxDzFoiwx6/loUzH7wdhVHbvc5B+6/0VWqdjRuIgB8cDPFVPorDJec/81HaMPIJX86QTlIGNhWK+qyy6H/fQOMmranLShpfTPpj8urP7ocbhcwHpRfyXTi6vUD74fX5kTnEEEV1n5SxN6E44fomEidBx4x2QtL5MGUN8CUTm1AUMInb65MeGfXQj+hdtlRPm7LbpGLycsXxjrEb5Av65GZrSGZVaaiEJLOTAbYYRgYcSgKlIFUZLpKx5KghlwxKUUP0wfq0a9vZXvuPCJczFkvur2aaXbcPhlo9LOh7WqnKBAJjQUQBtmsIlC2q+s48b/ljS+pGprvzi41P2tWFu6w9OtCfD+xYynD8nKQKp7EwGYEmGLIhZgNjLL3TcC7zZCb5yZTTBvqscA+EOIkW9fx3mA6GFiaNu/Ny/EJMN1q9rsN2L2JUjyB6x9gBTiTtDK2mQj35yLXmfrJxjjjhUIZWtOx2gDH3SarJT0vkFKwmxb1i251t 3EwGtaZp mW95lBKDop61F3O8bmYoKBAic1/Nqgg3A2h6q9CY4kzgH3Y0Au18NqQ6BYG3VUXfBFEPYRzZgbvxWpPo6QQ4gBeAOuj9Darnsc5Shpe0IiZ+4w+AqhEjQNjim0zsD+Gu1RJgsnhJ8dzf6048hR3hpL0rmCBAii17c4d43434mXrhBQoc3YsZxCpzs9zTn01IJJLdMYgubz02RXR7u6PrhdU1Oxc2oBrTlR2bAcv8V0LyAC9rSTTb6gVp9CzE41WXwnuEuqJ9mlxHfJ5N1guSWi1YX1nwlBfETfM5ThTfjV45cVX7gKUr4agVPjEoK4SlQupRWDnBctImu4rkzehJZEa0L2HEVwwbxAZK51dsgROkyP7NW4mmcgg5XQjPBovF0wAlY+3AAZjoPJLtq6VZSkblUSF7ktyyiFBws/xdswz2eRlQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000021, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 12 Jul 2023 at 16:25, Kefeng Wang wrote: > > Introduce the two helpers for general use. > > Signed-off-by: Kefeng Wang > --- > include/linux/mm.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 1462cf15badf..0bbeb31ac750 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -926,6 +926,18 @@ static inline bool vma_is_anonymous(struct vm_area_struct *vma) > return !vma->vm_ops; > } > > +static inline bool vma_is_heap(struct vm_area_struct *vma) What about declaring the parameters const to document in code these functions do not modify any state, and allow callers to pass pointers to const? > +{ > + return vma->vm_start <= vma->vm_mm->brk && > + vma->vm_end >= vma->vm_mm->start_brk; > +} > + > +static inline bool vma_is_stack(struct vm_area_struct *vma) > +{ > + return vma->vm_start <= vma->vm_mm->start_stack && > + vma->vm_end >= vma->vm_mm->start_stack; > +} > + > static inline bool vma_is_temporary_stack(struct vm_area_struct *vma) > { > int maybe_stack = vma->vm_flags & (VM_GROWSDOWN | VM_GROWSUP); > -- > 2.41.0 >