From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A84C7C0218D for ; Wed, 29 Jan 2025 23:18:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 388CA280274; Wed, 29 Jan 2025 18:18:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 338322800AA; Wed, 29 Jan 2025 18:18:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FFDB280274; Wed, 29 Jan 2025 18:18:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F39C92800AA for ; Wed, 29 Jan 2025 18:18:20 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id ADEB816050C for ; Wed, 29 Jan 2025 23:18:20 +0000 (UTC) X-FDA: 83062055160.09.8829ED2 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by imf30.hostedemail.com (Postfix) with ESMTP id C3C0280005 for ; Wed, 29 Jan 2025 23:18:18 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="JiWKh5O/"; spf=pass (imf30.hostedemail.com: domain of tamird@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738192698; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QvpZ7PmBrG3gp5YeFE37+hnKtxRr8CPClHcCzrd1MIk=; b=4KbCg1mhreP+blJqEji+618frpaFoHuJNZscaTu4FGaDauEk9N4IEp7P6fOnzrZJi5GF4N 0mF6rxfJkDCk3PSadGdo9FpaTOw8zqyebv4KG4fRhYUWZsOzmsatNZaWyezzWdgcghn7PY /GxAlYN/eEpmR8m3LqNMq6+Ir2ZnIn4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738192698; a=rsa-sha256; cv=none; b=wS6VQI7wMTqGAegRk/Yc43K4Wnuz9mTt5p8Ppqa0QLKiEUCCX3TRloV0KkCuV6jHyM1e3D gn8uUd9EY57KXvXsDPeHi1n9Axhz7Noc28ssg1Y8lN7Nzfo+V18UlXhhw16rjxHT1870E/ JU6iGi36fkkAnbKfL/08pCLw0WVJkNg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="JiWKh5O/"; spf=pass (imf30.hostedemail.com: domain of tamird@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-30615661f98so1685291fa.2 for ; Wed, 29 Jan 2025 15:18:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738192697; x=1738797497; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QvpZ7PmBrG3gp5YeFE37+hnKtxRr8CPClHcCzrd1MIk=; b=JiWKh5O/ZtxVE9gIz8+ynI13qNu/vBwrildEGQUJIyNiALFLohTuQkRyIA8Om4HR7G RKvaO83bD6z0nJxcHwpitMsHZLuQMJeEWINmQ4ai/+Txl5zcgycE+Zp+BMOZ7twNoWwJ S2E0e1q/dDxSbybvRY/ahn+oCTwvYG1vIZEiTH8PmJUmzK5zgIrIblzc5o4dIzJic0a2 +fNLQ9PUPD3C+J5jrsJrnkEH7ej407KfGjb6bgyVfVmTj19/oZXs5VptEqkLxc6nZpAb H9CcdtYNwjUy3uo+9XQ0Xb1VuubPzpmghtE86qdGaZWQPNaisEv0OQ9FqAK04g5UIYbS YjJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738192697; x=1738797497; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QvpZ7PmBrG3gp5YeFE37+hnKtxRr8CPClHcCzrd1MIk=; b=dWkLVL2YP0KCl5KpwXCPbSDRk5w90dhcBT+W+C6uJs6Q9dPRxPQi3B4KnrJTdpQOFh PfPwt79gy6tvbHeTb0Q+SHuXKPxot+hfuW9ozmtuIiEyBtP5rVw0bA8vo6ZtpquR/ydm p4ycCk+KqoKoFMSjEmplDcjpG4RInH4wNhldCAlLrLKorAj6hG85bTf9faLIp0yMiRMO c7yKVvsXjeSx9xadfj7dhQMtjie8lOwSFZ9iqVvqENk4G8F+IL8/3l1c6gzTFZLwgfdS u+ga/HsRbiyMxl/Ec2Ii1j3K8lc0rDf8rhwE86S9ct4v9seFlL66Q6+r8PNl5zShq2bd aL1g== X-Forwarded-Encrypted: i=1; AJvYcCWamQ3iBiewoLerC3HTJVN8G0HgMeO5OEajDKiBQ2ja+JvGgSV4ByvN5PV0Nvcjxq/xxCe9kQNO4Q==@kvack.org X-Gm-Message-State: AOJu0YytTOnt1Q5TJBHLShwunR5PLY5J54IZkrwUyc4Bn5GOQr0mMzQy Kcro3EqgtP3Z2r+na6MFfT9CuapeojOcUtBNbBMiBMrtU9JpA+3Irb0U23zAbdVJ28QHhvHf7TM xYOf1iDdcjWf3p/BxDGKlznlcfEs= X-Gm-Gg: ASbGncvnV3gd2JlskcDvTzFmoR+dlQfAoDM0YG+bwiUa13zSQ9kPN0ZMRXhDDuchHtA wyKfezZS5XOiJE/2uP9VuEThD0H/62YvuTsyeyXtj2CLufrdIZhZif9VjBc8oh2bTtAN3eSGb03 YximRLU4hrRnUGgnbV4Vt8V2H+JstDkw== X-Google-Smtp-Source: AGHT+IHaAKHEaFfIIrl4XoFSnnfGpYvAmUJGb3+mGNwMi0XiBaSkv8xOXbNKQLBjZ1eD0DTNqyAy4nr7gh28RazKqW8= X-Received: by 2002:a05:651c:50e:b0:305:d86a:4f01 with SMTP id 38308e7fff4ca-3079696b37fmr20071361fa.31.1738192696891; Wed, 29 Jan 2025 15:18:16 -0800 (PST) MIME-Version: 1.0 References: <20241205-xarray-kunit-port-v1-1-ee44bc7aa201@gmail.com> <07cf896e-adf8-414f-a629-a808fc26014a@oracle.com> In-Reply-To: From: Tamir Duberstein Date: Wed, 29 Jan 2025 18:17:40 -0500 X-Gm-Features: AWEUYZm6-Axfuwo7gaO51xSLYv-t81bl89X3xorrqlt1HmTwF2QQ0EEOzVieTek Message-ID: Subject: Re: [PATCH] xarray: port tests to kunit To: Matthew Wilcox Cc: "Liam R. Howlett" , Sidhartha Kumar , akpm@linux-foundation.org, christophe.leroy@csgroup.eu, geert@linux-m68k.org, justinstitt@google.com, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, llvm@lists.linux.dev, maddy@linux.ibm.com, morbo@google.com, mpe@ellerman.id.au, nathan@kernel.org, naveen@kernel.org, ndesaulniers@google.com, npiggin@gmail.com, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: e7scw88wgsnhyhgkzzhhm6boocjc86tf X-Rspamd-Queue-Id: C3C0280005 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1738192698-917495 X-HE-Meta: U2FsdGVkX199v4X9MBx8VxXT3yG9/xyfcB9z/illd/E9d0yS8WYlqciwF0e+ZvOClRaxX5ftF1ZI6zWvxOxeWEVzYnB16nkfqmtvjVLjfnKTKGpQpYvIRkb2nX03PM+HDOPNZT1CU0i5HAGo2EFR71AlkYAk0c/vcUP04sL9EpX7oXucqvE4wBws55mP+3Eq92FrFQUJE0PahpzEyOJCBhtiQSU+od1nNp4dGTAFCm/fb3DoDNW0358b7XsIHPijI/Y1fw3Utfz9zzLa3QsAFmTR3ygnHt172b63QTOAkJhgIMX+EvYhpOaVEDlo73sF26+V+ekGMYKMWn+uqGRmHDQEem8KeCT52GDHY6gyFPFrMarWmW0Msyi3k5stJ1LBdk+QjfYvaT5LShRXLpqoH+0GMCvqq0se8SYdwILISSQ+qxFziS0XebrOQJmq/wXqP0gKrVV8bsXo6+OH/exaav1z8Hi2cPE8jhrxFn8Ecsofyujd71UELT4FqLTp89wjeff5z1OGTNzdsa8byLE40zmnIgrSIhyNSubgthTRR86/QfpsWE2ktLux8/cLIBCmPL28GKNOZbBKX/cbncsfqidcK8/LJRJ/xok13pemZ7wyGJDtqmcos70DbWOt9tQWRf4sVQaujzcHJrCxAg6BNHt+BCGka81KYLLw8y9sVY/JXJl48YNiwuyZ5ppr9Rt6MMBWCLNd2blgV+JxS50/5eqVLs6EDUi5/fTrvfLvyn/G0T0v7WMp6m0k2m1nDWXbHvBE5bsVCceLWkZpA6/KQ+tIL7ENg+3giVQkEf8I3be2odLYALf5wt/+3I/nNKKQXM5EVaoZSMC/Beg49e0LmLaz0iLkrRy7qr4NdNZ7AHgKdTRNUhsK0LaV5e4sMIzs+UriwjDynIG/Bie7ABynDSXhbxGYruEVJs3fISv635a6BLnrjaPfqqfDm9UHsCQuuTmfyv3AkYh3rzpkDAw lr8Hc9l4 SfMO0I53r0dcIHzI/MNn0bEGnQOjUlgxi0leKh8tHAXJ2EO5TdJmPH/Sff+8YzdXuLGFZ6kjncjKNlkHvGRTVfFBCLReA2dWxUSHoo+jLAc5v8C769lfdujylXigCccL98UssOqUQkJbGSiNZe23K6rX6QFN0/hCKDd1dmMkI4PpypZU1sNczdtF99iJaZe2vp1RIQOQWUbTy8G8+lL2QWxOuohYn1f7d9jpWJq5UfKRHjBtYspVRNgMyYn2enuq8AM68ar2RDQbbrpzqxNhztzXrx+3HIlQBRLuIbdtoyEq7W8r277YXVqw9X/SeBu2fx4HqDKgus1A5+lwOnimhncz+ornBVPemb/tlvtlFGhwPqyxwR3fslaZ7hUqo65+UYIco X-Bogosity: Ham, tests=bogofilter, spamicity=0.054052, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 29, 2025 at 6:11=E2=80=AFPM Matthew Wilcox wrote: > > On Wed, Jan 29, 2025 at 06:08:22PM -0500, Tamir Duberstein wrote: > > The whole point of tools is to liberate stupid humans' brains like > > mine from mundane tasks like working out who to email. The tool wasn't > > wrong; it did exactly what you told it to do in your MAINTAINERS > > entry. > > Tools do get things wrong. So do humans. When you take your hands off > the steering wheel and the car crashes, it's still your fault. Which one of us is driving in this analogy? > > > > For what it's worth the kunit invocation, while obscure, is > > > > self-documenting. There's usage information that's reasonably > > > > understandable embedded in the tool itself. I looked for the usersp= ace > > > > testing initially but failed to find > > > > tools/testing/radix-tree/xarray.c. Even now, I'm not sure how I'm > > > > meant to compile this. > > > > > > kunit is useless. The test_xarray.c module is useless. If you break > > > xarray, the kernel won't boot far enough to load any modules. You > > > haven't thought about this AT ALL. > > > > I don't understand what you're saying here. > > Then I don't want to see any more patches from you until you do. Yes, I see now. But it's not quite true; the patch was itself motivated by the difficult output of the tests, so I did run this with kunit in a state that produced a failure. Your point is taken.