From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB43C282DE for ; Wed, 5 Mar 2025 18:44:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80FB3280020; Wed, 5 Mar 2025 13:44:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7963528000B; Wed, 5 Mar 2025 13:44:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 637D8280020; Wed, 5 Mar 2025 13:44:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 40DAD28000B for ; Wed, 5 Mar 2025 13:44:05 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B9C66B1139 for ; Wed, 5 Mar 2025 11:36:45 +0000 (UTC) X-FDA: 83187295170.19.CF166D3 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf17.hostedemail.com (Postfix) with ESMTP id B8D964000D for ; Wed, 5 Mar 2025 11:36:43 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SuL0cenT; spf=pass (imf17.hostedemail.com: domain of tamird@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741174603; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JWlFdYO+U5pkyvFkJdSxJPcpii24zFkKT+mvaAzenDM=; b=beYwYDG0CKpomPWM3OHgv5/Z4C8GhNWCzhluGv7grg0PwSDMijKx9oqUGDw5DZ6lnAQLoJ NMt4DZhtuEKvPwf/XbWLX6dRZoL5CCLuCh4x3w0D2UgofnxmO8S9XYnT0uGbNOHEiSmZXY hgJsMkyT3rj6Wq6oGXlXd00hTzPQ45E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741174603; a=rsa-sha256; cv=none; b=12i+LLLYOqoGcfT7b1kQRSu6k9gvUdiH6Ivx+aYDcDWgwVPVdvfdBNcEZYingBKdqdGg2l 8lV/s9DdYVvn+pRNRatooV08lMDwinZ+bes38vVuNmbEfjAJpdu5qcZ3oBJ3kX2jQlmeyX i4ytTTfOFztVJgpgYxodqmfz/HjTGJE= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SuL0cenT; spf=pass (imf17.hostedemail.com: domain of tamird@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-30b9b1979b9so56869821fa.1 for ; Wed, 05 Mar 2025 03:36:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741174602; x=1741779402; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JWlFdYO+U5pkyvFkJdSxJPcpii24zFkKT+mvaAzenDM=; b=SuL0cenTfVgeEiqkhpkEXAn03BhDoccc24+UvwlUgeSOZ5Nmq3Rr8VIfCbwEI7y8hi 2vL75ir+oA8IXtfbrLH3lS2nLn2SOxis1JR01AET1zdkpJXID8NCbSFuN0jCoQsuwbUK L1Adm9dM/x728IGkTz9gK0qgxcLEqeSmu6ZYcNA7XYLLLXV6hdZcut6dJv7bMCeb9l6Z n4kd8ioEj2LehJCSKjIcX5ql4n2jmAIJ5o5g92OYJhhn7zAC9zvov29Awtrp1kiNJxQ6 0Xi3iFFpElx8YVhSKFRYhBTEUQBiEeV+RizNQyFbLGqknWDrDAdWyD6VjyTv4bQYCNc8 hPPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741174602; x=1741779402; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JWlFdYO+U5pkyvFkJdSxJPcpii24zFkKT+mvaAzenDM=; b=vLoCa0BhR2roorgBimM8yp9OHlneI55+7nIHqZznfgtWTAhL5kmnbuNCpCzR+io2ji dBmaRTNROqTpRqQ9552z7NeUbv7KwRnM3loMofX8bUq4kNGxMGeEShAL7yZ/5WIMwB6E stDNpiDaqC+PYERGJ7C8y+g4tLJ3xPE1CSdrmuJFmbRWfhVEFg0QXQGOC392HkGjdd3v 1yWfR2YdyZkdnvw4IDipj1u9cGfSQVlbZ60d2yPbyhZhamqJy8L+J3Ul9c/LXOVjBGEu 3vlLx/WRCnslJOmgjWz7g5h+obwd2VAs4oGGG7O/JCJ6NGea6Umea5xHyighbGXdHgVt mY6A== X-Forwarded-Encrypted: i=1; AJvYcCXi1pInkiAavFGixD/RNFJaacrJTe/GJSdETMKULHCiHcT5+87lcMgerX84I/Pd6Yws6E59pXW9mA==@kvack.org X-Gm-Message-State: AOJu0YweQKU4ePcsMqL8DlcPyMGM+D+mBJ0RbTuvRdUeTLyUxcqiVT5f S+aii+5N9OcltpI1iK5of+VWsGC/JSZQI2W7sJSA9Fk4l4OK5IEoikaS0IPOc/xYzr/6qSjYHWz J8F0yOsb9hC998v4y4NF+94K35bs= X-Gm-Gg: ASbGncsydM/zDMAoCzhIj2s3H23yA8cIRrttNDHYnSf7k/Ho6dS3wP5V60ti4onHhlW oBopXLFxYNcRK/+2eYeapnmFSuILj+izKJz4OuY/+p4ULQxgPcll84kXP6HmmNuplFrTjON2X17 5Tq9cDdpEKtRuMoFvweT0O0LmrsEjfB35lp8fWegMGM5Cvtz04fHmrInqRjmjp X-Google-Smtp-Source: AGHT+IEoFkcbxDDv1dZPxu93WwtasiJI2Lz3qV5/cJ/6/JfY41teVTwgtDE1Riii8TG+BQq6FVk+CV4MaDNemyWbAN0= X-Received: by 2002:a2e:bc18:0:b0:30b:d63c:ad20 with SMTP id 38308e7fff4ca-30bd7af199bmr10137871fa.24.1741174601641; Wed, 05 Mar 2025 03:36:41 -0800 (PST) MIME-Version: 1.0 References: <20250214-scanf-kunit-convert-v8-3-5ea50f95f83c@gmail.com> <202502160245.KUrryBJR-lkp@intel.com> In-Reply-To: From: Tamir Duberstein Date: Wed, 5 Mar 2025 06:36:03 -0500 X-Gm-Features: AQ5f1JqURv3wm0FFfsHXNlwRx6ZYwKWLutLxKPRJPNR4Ik3Z-kjKd3V7yI5FsHY Message-ID: Subject: Re: [PATCH v8 3/4] scanf: convert self-test to KUnit To: Petr Mladek Cc: kernel test robot , David Gow , Steven Rostedt , Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Andrew Morton , Shuah Khan , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Geert Uytterhoeven , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: myi4m1e3codd96574y6gtq7rkiokgofo X-Rspamd-Queue-Id: B8D964000D X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1741174603-243258 X-HE-Meta: U2FsdGVkX18DogHHpKWplMYw81/osy7qAcZKGw5Vwy5QDuE52mxQUNxvKJzCpWzp2M7RosUxHXCdPhUEVpvUhi5hU7Vmc/SsqUu1KrBW2JDpy9LerLyAMacnLKCqfmlgaWKY3XM7AAkOQ/08yr06jHEOwfSEGp0cv6nMdkOhTprCgXTKIxVU0KBl9pCFuYNT8kqpfepq0o/bfQtZK5sxQjOA91EPucZaEIIizSgOuTUGXPfE9n0e3MtrlDB3YhB/0JC9owj3AWU6DUcn65P0oX7ashU6l2U0xXKZcPo+HWE6g5Vc2BUI/w+rMgmno3SEan09Pha0/taBpcuPDsY/TiaetinG4XvtTetV3UeBF6d1Z7T7hUNhvoqP4pq3ckO5O7i3+InFxcmEd2IQuzWo1GfLxqdE7+pPupVmvIkkybKplkVW4hy5lcCIG6OFlGxaKAquOoF2I2YxQrhLQoTqJIjCv1sTEMLoKsHGHJITO3LT+L69HK3erJ+Vjd9a3fMgiA3X+Xcj1zcHHQrGttUBNKTukmFsRnOqZ48LLlADY8daCLO2EVp9XwI9/SJpuY1FvS6O5IUaNjdE2iLkmRmgxjc/runbHwwQM8nYQC3/kbJLd9lnrEBKsFtdgporIXt75svc4XyRF1Zuje9aAPhmiEw2NDzqNlxk6QJ3J63Be6i6TKwXOtE8z/VRHOWt/eRSekZtHh3kaIkbgFUKOdNYvDmRjBr96zCF3AJ8ZXfYYlvNs7ZyNRkFJroUTeXb5o0TGKi0FSC/+UEYOHJzhwUw9igRwdahuSSVwhLbeY7SnlDf2WtpvdY0qbstQF68Z73s1P0/oot51uCMnbLwjXVbZFD1OxZtwv0sSX42HhGz82jGynthH+enH6Xho2rDL+TXV96SQXAYTPUeB2b5zx5Y9RCHfa/ay9/Iw/+sFhvDnYkuOEGWy2K7P8S2aRi6ZKHD6QofrEkoE/rPrv0pFn4 E40/rSyn oJG78PwUsC1V0i8qtiWUnrb9ceJTyR/eJyIc1WkEDbFpSC8IPT7XQRWkGZB3+qyJw7gRambnBUpEtYoqHD/FxdDNWaKA0WWCHVHS9oEAvgxv/H2yL955Rb+M+t2tkOTugWLpOEz+W3kILQAo4K8nwc6SbVvDkH5xWynFS3iFTfwwu1b40wYg2ocbPNQhL88NOuTM07R7exsNPxQPnOCFACL4NUF5OLrW2cDF9WwO/fYg/5reHfHVmIizCQu55VuuYrqBBeQRz9NrG1Hk9e4GEbF7NYAPSCuILQbZ4WmUE+UFIs9B4EOK8WZQlXDaem9HcOMekv8yi80t/pSREQi4KlztqolfJZCk1Q+sTKfkIzaBudb79w2yKOWBSxN4/f3JZomjV2Z2RTuVpqxNWJ1aAegyRy9UlOG20n5w2FUQU/UprstlJAnPWwRQrCAXcqBi6fcj9t/P3CZ0zpFwXmOmE7GIhZEHHoneh1coenEFMYAwqAVHQUrRqxY+hqA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 5, 2025 at 4:47=E2=80=AFAM Petr Mladek wrote= : > > On Sat 2025-02-15 14:52:22, Tamir Duberstein wrote: > > On Sat, Feb 15, 2025 at 1:51=E2=80=AFPM kernel test robot wrote: > > > > > > Hi Tamir, > > > > > > kernel test robot noticed the following build warnings: > > > > > > [auto build test WARNING on 7b7a883c7f4de1ee5040bd1c32aabaafde54d209] > > > > > > url: > > https://github.com/intel-lab-lkp/linux/commits/Tamir-Duberstein/scanf-i= mplicate-test-line-in-failure-messages/20250215-002302 > > > base: 7b7a883c7f4de1ee5040bd1c32aabaafde54d209 > > > patch link: > > https://lore.kernel.org/r/20250214-scanf-kunit-convert-v8-3-5ea50f95f83= c%40gmail.com > > > patch subject: [PATCH v8 3/4] scanf: convert self-test to KUnit > > > config: sh-randconfig-002-20250216 ( > > https://download.01.org/0day-ci/archive/20250216/202502160245.KUrryBJR-= lkp@intel.com/config > > ) > > > compiler: sh4-linux-gcc (GCC) 14.2.0 > > > reproduce (this is a W=3D1 build): ( > > https://download.01.org/0day-ci/archive/20250216/202502160245.KUrryBJR-= lkp@intel.com/reproduce > > ) > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new > > version of > > > the same patch/commit), kindly add following tags > > > | Reported-by: kernel test robot > > > | Closes: > > https://lore.kernel.org/oe-kbuild-all/202502160245.KUrryBJR-lkp@intel.c= om/ > > > > > > All warnings (new ones prefixed by >>): > > > > > > In file included from : > > > lib/tests/scanf_kunit.c: In function 'numbers_list_ll': > > > >> include/linux/compiler.h:197:61: warning: function 'numbers_list_l= l' > > might be a candidate for 'gnu_scanf' format attribute > > [-Wsuggest-attribute=3Dformat] > > > > I am not able to reproduce these warnings with clang 19.1.7. They also > > don't obviously make sense to me. > > I have reproduced the problem with gcc: > > $> gcc --version > gcc (SUSE Linux) 14.2.1 20250220 [revision 9ffecde121af883b60bbe60d004250= 36bc873048] > > $> make W=3D1 lib/test_scanf.ko > CALL scripts/checksyscalls.sh > DESCEND objtool > INSTALL libsubcmd_headers > CC [M] lib/test_scanf.o > In file included from : > lib/test_scanf.c: In function =E2=80=98numbers_list_ll=E2=80=99: > ./include/linux/compiler.h:197:61: warning: function =E2=80=98numbers_lis= t_ll=E2=80=99 might be a candidate for =E2=80=98gnu_scanf=E2=80=99 format a= ttribute [-Wsuggest-attribute=3Dformat] > 197 | #define __BUILD_BUG_ON_ZERO_MSG(e, msg) ((int)sizeof(struct {_Sta= tic_assert(!(e), msg);})) > | ^ > [...] > > It seems that it is a regression introduced by the first > patch of this patch set. And the fix is: > > diff --git a/lib/test_scanf.c b/lib/test_scanf.c > index d1664e0d0138..e65b10c3dc11 100644 > --- a/lib/test_scanf.c > +++ b/lib/test_scanf.c > @@ -27,7 +27,7 @@ static struct rnd_state rnd_state __initdata; > typedef int (*check_fn)(const char *file, const int line, const void *ch= eck_data, > const char *string, const char *fmt, int n_args, = va_list ap); > > -static void __scanf(6, 0) __init > +static void __scanf(6, 8) __init > _test(const char *file, const int line, check_fn fn, const void *check_d= ata, const char *string, > const char *fmt, int n_args, ...) > { > > Best Regards, > Petr Thanks for the review! I'll respin later today unless you let me know other= wise. Cheers. Tamir