From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05C40C0218D for ; Wed, 29 Jan 2025 23:09:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 751012800AB; Wed, 29 Jan 2025 18:09:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 701272800AA; Wed, 29 Jan 2025 18:09:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C8A52800AB; Wed, 29 Jan 2025 18:09:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 33AE42800AA for ; Wed, 29 Jan 2025 18:09:03 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C55024531A for ; Wed, 29 Jan 2025 23:09:02 +0000 (UTC) X-FDA: 83062031724.05.A7670C5 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf29.hostedemail.com (Postfix) with ESMTP id CEF3912000D for ; Wed, 29 Jan 2025 23:09:00 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jX2BN3Pe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of tamird@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=tamird@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738192140; a=rsa-sha256; cv=none; b=yNG5UmVKwY5676thS4G+pNdSc8kbXFOy71cg9aFEoWL4/mdosJM3FLl30vTrrDr8wDAGWR tvjfV320ONxz7oifrdan4MrXdcRbww9g7NEV0wEVfoxwT2YL385wPfEAAaAOWw6DB5KDG/ +AanJGrfior9+nPazdPiasAhABmQWvQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jX2BN3Pe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of tamird@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=tamird@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738192140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=905aLOBpG5OnSnGM7H0fP4dZu8i9mQsgLm9R4DDucaw=; b=Vwu3gIKLLrMQ+I2el5JvmOJzmwucUniBXNa1CM1vBGmwYBk0TlOWoWVvuKT4xNBWvmdTmA vQ7WE7ZHLvRe1uHekxr9gsas4qWlueBqFcZm/081D0F7SdwLF7XolTyXj87zT53/isdcud XmX95xPNRank6rCA3FPUOewnX8WPGv8= Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-303548a933aso1218141fa.3 for ; Wed, 29 Jan 2025 15:09:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738192139; x=1738796939; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=905aLOBpG5OnSnGM7H0fP4dZu8i9mQsgLm9R4DDucaw=; b=jX2BN3PeGU949sO4HhpIO/pqE6RiVNnk3z0WB0aCm6aaGNzk42iR9ezZOqGUg4+UBe 1xdpVosSzsFQplEbTm3cs8uYdF/+zYj/n7UCt26Nc2dGqhHwf/M7L8uzSmiEfOoI+tvC XGTrDm4RFIXyxn7cVPn7JQdAX+cFoIKcs4bnrAZnoVMmz7KeNQsqNUll8Fuw/0mGaDPV 66meIMv0WRA9eo8hFvM19CGqQMj0Owk6royRcbPX8joRU6iKEnxFP9u9IrP7u2VHBpD5 EGBOaIAHiiTNuWDRmw7H8HVUJ/e5T1EqiV2uDRSUNosvhedrfJtSi0Vf7teO5jDs9Jfg tvKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738192139; x=1738796939; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=905aLOBpG5OnSnGM7H0fP4dZu8i9mQsgLm9R4DDucaw=; b=vKBJvpseNelxZPMlLSY/dFFnrt54P3yxt85k+SwA27z2qpQ7j8I4uzW9UIkpxhMYy6 h8VVulMyvYzBRUtD0I/6faE6PkjyJPJeGmxJ/SwsekzCaYq+kzoTnINsJ6yd+YI6eHqx DVObR+3JM9tAHwFNH7OMIMeODlSqQlB8QsyG2vka+i2u3VjEHeT+0HYGF2Lt3/mojhxZ 39v0SpRc1PPra7aF4ymeNdhCnVmO8ucg0eZFQDqQ8JdfoQQzQ/z0in8DYbS7KAOpuX4S sZreay8e+rai9hWX57Bi9Aj5MbGy6HhlPoXhLsaL4m/HB2t/yYPE8W1G7mewGlcIlxrA +fYw== X-Forwarded-Encrypted: i=1; AJvYcCWjFMs7vsHP/7g7gxm/eWEAqm80u1AQSl1i5bs7xdeCs+mKCzLxUXq1xaDiVm/zYnbjiOo+4pRGmA==@kvack.org X-Gm-Message-State: AOJu0Ywbf00wbvPzHzDk7m/zR6gw8GXcMaEykCsNQb/saMahoA7biEbe xGROBA3Lerp9oNl73wYy2l8gOnowGqNbBDGFy0/1PqBlpQXI0Xv+GkWaFT/F9IwFFrIPosnxDrF DnYwrC6qa2PdwRpbGIhadLXxMmNQ= X-Gm-Gg: ASbGncuoLKCNPqK07HKmsxrzsVCaAhphlWY4r/x+4+X6Njw0QuW00zjnJNSDO0arowP 2S0PAFMf01WtJaQi+kINUTJSLdTQnj7FrlzAXciPbBy8AnFmonb+346GUBx4ovzu4mdxq9a9Lmy lbx/On5duIIE55vxU5noasGcrV6xxdIQ== X-Google-Smtp-Source: AGHT+IGw4hDomqOPsGmP6ryOmQMcXXWdZqLA8giCzG80P3G1E1mNKcM08esBXc35n67oCdPU79/hBsdXpNJs+7goWuY= X-Received: by 2002:a05:651c:220e:b0:300:3a15:8f23 with SMTP id 38308e7fff4ca-3079680c757mr22614121fa.7.1738192138842; Wed, 29 Jan 2025 15:08:58 -0800 (PST) MIME-Version: 1.0 References: <20241205-xarray-kunit-port-v1-1-ee44bc7aa201@gmail.com> <07cf896e-adf8-414f-a629-a808fc26014a@oracle.com> In-Reply-To: From: Tamir Duberstein Date: Wed, 29 Jan 2025 18:08:22 -0500 X-Gm-Features: AWEUYZnWxaXWv5__MIDVh4wuy5lxhHQnPr0jMuSdSi61tZVSWMfJQozfaebSPPI Message-ID: Subject: Re: [PATCH] xarray: port tests to kunit To: Matthew Wilcox Cc: "Liam R. Howlett" , Sidhartha Kumar , akpm@linux-foundation.org, christophe.leroy@csgroup.eu, geert@linux-m68k.org, justinstitt@google.com, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, llvm@lists.linux.dev, maddy@linux.ibm.com, morbo@google.com, mpe@ellerman.id.au, nathan@kernel.org, naveen@kernel.org, ndesaulniers@google.com, npiggin@gmail.com, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CEF3912000D X-Stat-Signature: y7w1fq76wijj764gsqj7u1k9bi8m61bw X-Rspam-User: X-HE-Tag: 1738192140-516315 X-HE-Meta: U2FsdGVkX18GXM4QQIfShrLGjI4JL4I55LjorOMM2Atk0Q6m6tqGcRXZOsMTTEg/my4o4HWIpzVWcwTpNR5yqd95mi1GKyX3HjXrf005lhM3udavQdUfGeaHubcf2p2rPu+tzY/87o8ly62UYoBIL2+x+jV6eHzao84Tc2VXbLFgz7JVAelBbkgfDhKIu+ZIyDO+hG449ZPbSbv0oHjeY5cHknMDXl+Rxb/aZzzXkZEsw5pjdQ0DBJ/wFq9JZTmFmUhgKzDXscyjl556ltNk1XgyXR6P6EKBPun+FOnwR6ZEjvdqphKpkKSJ0LHwRWOJ7icJJySMgTO8nDJaJDGsfi5FpZq3a7zyCNmDNe9V1lE/g6I1IxTbXNvmEDvGQuDxBIOr0mVZYEq3iEfmLEorqvw+ONHItQ83lgRw0C2Vsqi66W7MyLENwRuSZHsna/srI26THSrH9lkEY2faHygAl5AQOkuFKIfdZZ+yB5HMA54l3JJmC5XFY+owOptMx+JgWqCgo8DJ9G/ltR+riAcuvA0gvaqvTrLPxEX2xVd0rA/5vzZZ0qOEa2kLFM4pK35dkXnjJs5iHVFj7Mny/tSZWP2DLcTDEyxq7cAYtbrRqAhnOnf51H/6U52sfwsQjpXmWcK+3g+ZJny/vhdoRiJX05+W54JPuD7Vzg+jDZ3c3ETDW3D7RnhN6csPK1OVQ/4VR88H+ZYhLDr/3lwxzIsO3o9AqSj79GWfoXvJQZ1jQZkHG3P39G16uFNu4GZ/X0SmEBcHEkU+pcJFtXp4++hF15pKmKMoSu9nfdY2T3B3THc2U05tfZwuKEaRrfD7fm/2zffP/UKUwF6Vvqb/Ak0f5nWSCqf8r4xQj0tpw/Z1uWzroDcUxbO+BEmyIjqUT/cXRP4Vk+GOSAt0RoNtF9RchArEteDnMLtOhLTGpPXltUFA3OmkDRFz/6oCvQVaOYn7zJZnGbAFvLAzSqzcXrK pJypbhOB 03bP7yvo9xBbhbgClY5CTIYeihbN2efbvBYyiU/w6dAZLrY+TiFY0V9ph+JVQo2j73sXV/j7EyeLgsg1HJr7VKnmQdP0gx2pq5ff6ua/mwko7LU2cbIr6/cLMM2SnYmkKf1sjBf14AWKqAglwLbRCUxq28qUyiWC/3TCcgwRtAGsS4mn295K/fxvCYX3jJ2LbglFno+aqFscdYqv6xdbznnXBR85Rrlb3EwtRaR1bXr3yE5D3i7s06Wvk6t5YmfRNVtQBEUVI7s4z8gjvueGmwaN8EWvWE/tSiRFGIOaE2PiRNL5ee8SfREQ9mLEXeELc1b8/25ah6a0jhV6gUFRHEwwyqDLKe0UEZ6xcGKq3JxLOoOue1MYnDjzJEF5wBiqzydpy+nKtSZjGcBS0XskslTPog9h7MVMLmi8ebvxuGfvQh6kUYiLvJcMAF7MBHcFBwDIs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 29, 2025 at 6:02=E2=80=AFPM Matthew Wilcox wrote: > > On Wed, Jan 29, 2025 at 05:33:06PM -0500, Tamir Duberstein wrote: > > > $ ./scripts/get_maintainer.pl --git lib/xarray.c > > > Matthew Wilcox (supporter:XARRAY,commit_signer:= 1/3=3D33%,authored:1/3=3D33%,added_lines:19/52=3D37%,removed_lines:4/23=3D1= 7%) > > > Andrew Morton (supporter:LIBRARY CODE,com= mit_signer:3/3=3D100%) > > > > I'm not sure what you're asking. I used `b4 prep --auto-to-cc`. It > > doesn't know that test_xarray.c and xarray.c have the same maintainer. > > You need to use your brain. You can't just say "I used the tool". > Tools are just tools. Sometimes they're wrong. My email address is > listed as the Author: of test_xarray.c. You should have noticed that. The whole point of tools is to liberate stupid humans' brains like mine from mundane tasks like working out who to email. The tool wasn't wrong; it did exactly what you told it to do in your MAINTAINERS entry. > > For what it's worth the kunit invocation, while obscure, is > > self-documenting. There's usage information that's reasonably > > understandable embedded in the tool itself. I looked for the userspace > > testing initially but failed to find > > tools/testing/radix-tree/xarray.c. Even now, I'm not sure how I'm > > meant to compile this. > > kunit is useless. The test_xarray.c module is useless. If you break > xarray, the kernel won't boot far enough to load any modules. You > haven't thought about this AT ALL. I don't understand what you're saying here. > cd tools/testing/radix-tree > make > > Then you can run the tests, whichever ones make sense for you to run. Thanks.