From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEC74C36002 for ; Mon, 24 Mar 2025 14:46:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC960280002; Mon, 24 Mar 2025 10:46:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A5232280001; Mon, 24 Mar 2025 10:46:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CCD9280002; Mon, 24 Mar 2025 10:46:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6DAEA280001 for ; Mon, 24 Mar 2025 10:46:14 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EE8651A07B4 for ; Mon, 24 Mar 2025 14:46:14 +0000 (UTC) X-FDA: 83256719910.10.DD48774 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf01.hostedemail.com (Postfix) with ESMTP id AE7524001D for ; Mon, 24 Mar 2025 14:45:46 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dGcRhn0I; spf=pass (imf01.hostedemail.com: domain of tamird@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742827546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YySDT6NdhdJKGPUFeJR1/DEX+p2cFBnIzeE/4PTN8fk=; b=GI6E0yraifBChC0NSdmP5mIyW0F09UgIxFnJgkOG2Tr6h654x0QiUMySZKaWo27oQnvh8J A1hCpdLfEE8z/p5Fyfr5bQg/FTV2ZaPo021ILOQXmpMKw3RaVgQ/JKKKM6YRcqEnSOkhIC 78T4KkJTy6lFC/8f7ICiCXjDDX08NeU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742827546; a=rsa-sha256; cv=none; b=SxnX3XoBEbKWzAb29vyANlpmmFV7tyjhGw4TnKcUvHaBduyNQ7gULncRm06zrdtb5jdGtj nO7PF/oQSBtaPA+dvhClHrlWMb6f1bTzS2yCshLmvpDs2Dki31VtC1EGXiUO7teexN6+PL 7PHbld7RQULHsEyuiJllX+3jezPH0Y0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dGcRhn0I; spf=pass (imf01.hostedemail.com: domain of tamird@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-30c416cdcc0so48049631fa.2 for ; Mon, 24 Mar 2025 07:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742827545; x=1743432345; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YySDT6NdhdJKGPUFeJR1/DEX+p2cFBnIzeE/4PTN8fk=; b=dGcRhn0IUH53JucYBsiK1sz0JFW3Ld+txmFJbyCQK+Rj9uwIwcDTfeYFWYW8lh5BI4 y7gNFLQbSYT6njGUaOCPtT0kaXoF/sIgZo/cCMzg2/7znpNlcV9kfoDTM2LJo0mkZcVu AaeO3uI2f69IH8kRaGTJSTQeq0IW+zM8Ai95S6X1xHYwxGTkEUrMGMHZuBN5TPAg84rV GdA6kVRXt4V6FJVcbsY1Wtpyi/tR579BqIL5yA5u7Zbud40zhbS4bo+SuihfYHyVcElc 4ZPLDE9Xm10ig4kSAGKYMg1ORF5AgboB6RSltKEcJ2Zpr9CAegjKMHTJHroec9gDk6c1 cSNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742827545; x=1743432345; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YySDT6NdhdJKGPUFeJR1/DEX+p2cFBnIzeE/4PTN8fk=; b=Ra6bz2S7dtPKjFdSjhuW05z+s6VjYSpa3AtgLJOS3hSJKxNDnSYzDqxKZD/l2FW3HO MXX68AitTAiuZvw7vTtL8TsS1EbL6AEw5YMgTjOAgMxgMDSn3fws/d/A8V4I1StvfQ/d QvRpD768J2l3wdF1rGK7g7I6zvfJeTG0hu6yd61WupsAumCAswDLWOKziKCkE8eUnZIh HgbWV6VO6K3xprM+OlhCCJ4suGkLgqAie7ClF6KdiWvMZMQ9ryqS5tUhjEMlpk5kSfCs k6ZReXpnUwffbTvo4pKYP5Bh/iIbAiN+BtJ2cko++vCYDXXFuiN96XSLl3gRDMOW8ltK a2qQ== X-Forwarded-Encrypted: i=1; AJvYcCUR0qWP2vLFYsb/bXufxCbo+Z0d7QYPjQs1m745GwI4YFgTW5Gem/4NPIJYi8lM0lyEFVJfYOGQNA==@kvack.org X-Gm-Message-State: AOJu0YzRVnlnU/QS75Mc4GClRq0gT3MCgEIpdkTLOxepr16GCri0mPL1 mbToC92h9uV4+9wqp4GZ2jYevz4aTp1CSFCgx9nnyoYuO3sNcddpnQOIj/z61L4T1ixGk+evyKl zIRQDnFKfcQcJjmX8WcxeyqGwxec= X-Gm-Gg: ASbGncts7mkXeCX2yLvrmagDoOTNpACx9g6i5U/gGftX+SPyCEqNeuxrdI7WKXrzdvs vj4TkVD6n1JioaM2Xp7069aMiaaVBrv7giZ8SEyXeyRyCNw8D5VAcbCKJkny5RSI0Mp2ykQ3w0n TRi/hddARtio6XAJfRNWJF1od8Gpya5NaD6U8Pj4L0lbsEOjCZBbJA X-Google-Smtp-Source: AGHT+IHl9dwplhezNLn7IB7Sq3eiZyr65Hj6aswx7up7md4DBgKJttJkhnAhxsOY6v3v1JjbW7Pfci2rEpaF23aoXNM= X-Received: by 2002:a2e:b8c8:0:b0:308:eb34:103a with SMTP id 38308e7fff4ca-30d7e2a722cmr57009151fa.28.1742827544473; Mon, 24 Mar 2025 07:45:44 -0700 (PDT) MIME-Version: 1.0 References: <20250321-xarray-fix-destroy-v1-1-7154bed93e84@gmail.com> In-Reply-To: From: Tamir Duberstein Date: Mon, 24 Mar 2025 10:45:07 -0400 X-Gm-Features: AQ5f1JrW68Vn_B0jmPyAT5zcOLPzNVAsAnicIcYueNfueTreXg8ST6v187cy9-0 Message-ID: Subject: Re: [PATCH] XArray: revert (unintentional?) behavior change To: Matthew Wilcox Cc: Andrew Morton , Stephen Rothwell , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 8k93fem8qnmw989b7s67iqz6smr9shmc X-Rspam-User: X-Rspamd-Queue-Id: AE7524001D X-Rspamd-Server: rspam08 X-HE-Tag: 1742827546-54984 X-HE-Meta: U2FsdGVkX19YF5076nOmEFrFKo4A8kCCgye/sPUDsCiv1Ea1WkzAcWPKKjFvG+7KVa0+09Bj1O+fFLHscHLYXlw7Q9owUOn8DBfjSy/4yyp2LodJqNtNb30sNlhKlT3bW+QoOb1c2hvvAlLtrX0fjYoSNElUjsLItjTYl0coUu7Uhn+TagMgWD9pmGdo6NEjmzo+fDU5in47h7VwjV0Fk1GC+iR4ILepKFfzjDx8QxtRVJhZMUWdPg7yhHNCd6CpTfy2wcO1AK3N787/3XYcvieswEFtfkkr64eNk36zXzQnLxymAKQm9t4bRHb5lzFq0d18dJxd48BtQjVVLd+isEmorCBgdNWkYc0T3WhaXqsd5v1eZBTZ5VS959dQmq/CMU5G0tfksPM5ItcyNAAUXYYpxLAH2EV5xbZMSgWw7j89Po530QtfwoX1vX/Mxdk0fpUTz7RGvZsngGFtJMjS0mUGAQ0zO2QXIVdv8cO6gK46riASVaWrueV4RwZzri8ZMHHHmRTrhC6GhhoL0VtWl/UkiK0xLf1MRbhv5hneMSccSN+qKzCSthtZOyzlNIIiinJI8AsMdvr+Fz/tdyg8CHxQx9rGXcN8bm6uPeDOO20OMibPDtNV21gnNJfGLHbXk2BdVnKmFWDbpYsjAY0U3fOLVqFWpdeB/Sa2OMtja1503vLed7e6i7SgHmlZ45eVZ/E328FrNpxu4aLvaruBd5osYEM5gJuAn7e7OWtkYOvTGsvJarogWML0GkzgT/Cm1acNA/XStBlwhlTEeB3DKG3GNhXvdpUwkK8yDXzNLAB4Ou/D+vGIMg1JhnC1ypE9BkgVHPUpDB67u6POhBMaDaFoaqZfZBUxkYFSMxTOYEtLUc01AVlI6maUEPrN8LVRM80LCTeybZkE8lg1ahBEw5gXk3DvLGuf7fvj1G3YPgwSfm1s3sxhs2Sneb9+TFDXpZH8zJkYjsW5I0jLTie Nen9hS0A fKc5XI5mEUwfwXsZJI4tCHqqFHa0r3tf+SkTuXrOc47UHLH5xu2WNPvPFsiWJQ1aVZDheRSK5mkDxRktQBti37f1hemeHxySnrkHioSviAZg/iBWcbSuucRMcRVQOOJVjy0uCG58fMLeAQ/btcgJrr9cD+bX0GMwU7PL+4YlAZRjnpljHX/NYkzrefQkNf7rCgEbjQKl+toGY1HSrZX/Jjd+MtMBV8UozK09J3UgwT3ruDOJSuLEXCdHMjUWYe7icGkh0LJdBkTowlUo0Mpzm/MAkV0r996QRfU07FBjCzRJ1IMofLDyr25O4rbaVDVfK6qi/LlnvbnKB1+AgvYmsW87XNDP9CujlJbRBXvXEqwJfTIWvqk18ZecM0KwK1rIVycTtNHmjnBFu4rLONBKpTYDo99BiubH73/GM3ksNdNGM3ng= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Mar 22, 2025 at 5:13=E2=80=AFPM Matthew Wilcox wrote: > > On Fri, Mar 21, 2025 at 10:17:08PM -0400, Tamir Duberstein wrote: > > Partially revert commit 6684aba0780d ("XArray: Add extra debugging chec= k > > to xas_lock and friends"), fixing test failures in check_xa_alloc. > > > > Fixes: 6684aba0780d ("XArray: Add extra debugging check to xas_lock and= friends") > > This doesn't fix anything. The first failure is: > > #6 0x0000555555649979 in XAS_INVALID (xas=3Dxas@entry=3D0x7ffff4a003a0) > at ../shared/linux/../../../../include/linux/xarray.h:1434 > #7 0x000055555564f545 in check_xas_retry (xa=3Dxa@entry=3D0x55555591ba00= ) > --Type for more, q to quit, c to continue without paging-- > at ../../../lib/test_xarray.c:131 > #8 0x0000555555663869 in xarray_checks () at ../../../lib/test_xarray.c:= 2221 > #9 0x00005555556639ab in xarray_tests () at xarray.c:15 That's not what I see when I boot a kernel with CONFIG_TEST_XARRAY=3Dy. > That has nothing to do with xa_destroy(). What on earth are you doing? I'm running the kernel in a VM on arm64. What are you doing? > Anyway, I'm at LSFMM and it'a Saturday. I shan't be looking at this > until the 27th. There's clearly no urgency since you're the first one > to notice in six months. Sure. I misunderstood the purpose of linux-next, thinking that if a commit is in there then it will soon head to mainline. I realize now this isn't the case.