From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 237E1C7EE30 for ; Tue, 1 Jul 2025 17:04:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE04F6B00B2; Tue, 1 Jul 2025 13:04:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C1A666B00B3; Tue, 1 Jul 2025 13:04:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B09796B00B4; Tue, 1 Jul 2025 13:04:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9DEA96B00B2 for ; Tue, 1 Jul 2025 13:04:44 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 70CD1106FB3 for ; Tue, 1 Jul 2025 17:04:44 +0000 (UTC) X-FDA: 83616320088.05.A7FEF44 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf06.hostedemail.com (Postfix) with ESMTP id 528C318001D for ; Tue, 1 Jul 2025 17:04:42 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZFnqmNrh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of tamird@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=tamird@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751389482; a=rsa-sha256; cv=none; b=LuyZmxJo0yfgcFpRMLar4NxQEPpwSPfNQq0xfQ7DPKFtHJD6XuJMutZSN90A9wEhhhVsDG yEZ9q1UsjaornBk7rOsqr8QIvpIT+n0Tmru5OJnPU+zQdREA1gdhO7jbjG1zIz1r0t919t WN7cfaEXGMDUzLfrPGUtxczEmSYqAX0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZFnqmNrh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of tamird@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=tamird@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751389482; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NxqIhubUv69M8iMfBOop3LMw2L0Kp2fdzLhKTpcmD6A=; b=uVPGfH14BgjepvaOj6UYyLmL3Z2KgL+pBTtSGQkkcKZYn1QNopV3i5oJvTZpFIltPq1HO0 fg4DwljX4p+pI2ksSLYp6IeJf61WZfXcd4aMTOD5If1A7j7/W+SUI4aWMmojtiCxgZTc7u Rcw4ywBjLuwJ6iQgoSqWeYaPc7fG9UM= Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-32b7113ed6bso32174371fa.1 for ; Tue, 01 Jul 2025 10:04:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751389480; x=1751994280; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NxqIhubUv69M8iMfBOop3LMw2L0Kp2fdzLhKTpcmD6A=; b=ZFnqmNrhP5N51Qp/SWoIyX95wH4t/P0Ib+N5bILcdiJtqO2FEbAHV2J6vFei1gU2be kt9CGP4FGLBEL9fAm6xtEZ/Rj1PXl3I0I6qFob8nxC+oxgtKG8B9ClzfMx4U2DvD8k59 MS8y7+Qhmts+agWOqMHHHK7XOwHJzvTp4drenVjv1wDm/esAfTeNdNpaS0bleF9WF8GR uVCTrktpSZuuKweDwiZCYvaoH5kYYpKO1fWVD3L4eeyd6Ow/ha4fityCYbp3Bv7Y9TIl 9no5W/08NFRVY21SDsvWOqVwFQqQ5xJbMhN+RAb/BCsydB72BdYJABfAbsI14AkB6Zug 21fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751389480; x=1751994280; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NxqIhubUv69M8iMfBOop3LMw2L0Kp2fdzLhKTpcmD6A=; b=NuI5g50CatF/4jzvWe7XwWuPR7QGz1eVG7tnjjj7tCNSlTQ/qn5XBm5OJTkrQBK4bP CXJ6V1Uu2zyXzWfYUmt2YYoD4WolezeWglV1JZvnUFTd2Odw3sPZOYcU0LzozyKpzd8g 07sIpGVGkvgI/qk6sJv7dqCGgvdTsbvhMPD+ZD1ricf44hN6YPkTkC6vmQlHzGtzNBwh k8fB4CHbnMNEM+kKgVkc1c+Ch4y/f7H8ZR5y8jHoq41AeDoNqgf//IGXPV+FLGE7sq7h IiqmQdGbhZOFkGoBSYYcyG7sYYqdqCtP1QoGu7joJjL8IUBji3+3CCVHEbyNT+owMQyC zymg== X-Forwarded-Encrypted: i=1; AJvYcCXV6JDs/uARRHaCabWxHeQO8GQp0Ie9paZfJAQz5hREU9lVv38NwXWmAIDwbzqoKR1u/kzisiarMw==@kvack.org X-Gm-Message-State: AOJu0YzsqqQzsjwnJF+xLDsUDvswhb8hEbexv7qtBebQQ8j4lPRpGgyc 72wN+woZUU88Tlo8Ip3eCMLntKuErbQxmbAWkBhlvv1V25wak/7XvZl3Koc2Wt7NR8riXR6/jsd bZwckV9G8d3hH+7dfSva8PxrFpE8pkj8= X-Gm-Gg: ASbGncvpTYE+FZ+XBFegpFumS8m8oV1NDbiSaQJVMfeMfuxfjUwaD31X4jC8HvT+9rB adHzQeUmSDrVpnI8vZ9GFGQT9xDnPDXPBv7098gjbS6r33KqShdsRJayGrBNoDq265SSGwRi7lx 7AzPDV8BoHFJPqcxKg/0FJKA3PC2RQuAwRi6Wgf6zHs1Uc/cXyvz0TXuRPja0NKzOqJhMuT5+eM 7Yyhw== X-Google-Smtp-Source: AGHT+IEoQsxbSiZHk57iawY5wnpi5nf4WW7yFai/WzA54KcFJwljAAd73b6yGB+qwSMNFbK5Bk7g1hw5i9O4J0dukJ8= X-Received: by 2002:a05:651c:419a:b0:32b:492c:5d10 with SMTP id 38308e7fff4ca-32cdc524864mr69147631fa.22.1751389480057; Tue, 01 Jul 2025 10:04:40 -0700 (PDT) MIME-Version: 1.0 References: <20250701-xarray-insert-reserve-v1-0-25df2b0d706a@gmail.com> <20250701-xarray-insert-reserve-v1-3-25df2b0d706a@gmail.com> In-Reply-To: From: Tamir Duberstein Date: Tue, 1 Jul 2025 13:04:04 -0400 X-Gm-Features: Ac12FXy7e-RdRR1PBw48BY7WaB1YHjxcedC_KPOTmXI0875WVE3fJL8jozJ2aXM Message-ID: Subject: Re: [PATCH 3/3] rust: xarray: add `insert` and `reserve` To: Miguel Ojeda Cc: Andreas Hindborg , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Trevor Gross , Danilo Krummrich , Matthew Wilcox , Andrew Morton , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Daniel Almeida Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 81nqeou4s6atuiygnr3n34fuh8z56ih6 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 528C318001D X-Rspam-User: X-HE-Tag: 1751389482-450952 X-HE-Meta: U2FsdGVkX1/bLDUaX86tuF093KTYLgao3s9mwsrC8dHwuT5yMNB7NMsTKrwaSsl92rY7o6nq/4pi8VaKVzCaOzA1jLlFKC/jI7+uz3B9O3S6vTBtOINDzS5fUAY9bYKoQrnHSdMuHaQlUILuCMNgkfTDfBaGVC8IpNOfVFBHd7Jsi3l/KhpV12USiLxBzAexpD+skhSdJjO7ZukVbrQ7A55DBj3bUXu5pfHISwY/mks/S78JsZrvLfQOvgMT2WcvJZGsX2pssFwdR8/2bWR8HxTEufUl28pKWe68xqRZ3GQpBzXzqf9aw2GU8NN90LVNklG60ipgKE2xhcBcX1PQrOqynJ4oWE06XkSNuJQg+NDQXDIpC3Y5QyQ+14Y66JCnKJZuSpODfDM1AuNLSwT65BS/J3JNSb3Sx7J2Our/cd3oiabIdbhgMHOSBp2XrKrGHlL4Pfixp/E2ORM2qoxVBCfJZGb37ruUEaVcfeaZkvkU4fxT4BwBFRG+xjMltZT32/4qguvydVpuMuksWqXAIwDdN6EFM4IMTojfpZVlGKNVFiVt4xChjuxHOvWk6Ck9MW3QHEuFkCQDJLqA90USmkjo0T51L97NrjzicFdhuwtquLDmb3m6pVYuKFWFdaeu2RFabjWhhSQfiYWzmRKjoLhRTSIkwVpr9W1Q++fqEcLGGLUHXaJ2JU4O9406mACNQ2XMsN0KZocThGViRrW4j1sJ3WZw301Lz08KvJH11qrqxVaXk9EQInfnH2YLwesvacWHq6v6VmZqWUSoffDvfURBgGf9XOs4Hn7dlX6MnYg8kgRCESuH/u3VA6y2ybEKbCE2t9s7EL5Y9OWvw+j+v+3Oy943dLTlEEtW8VtqP8dQEdA+0/reXGZ+r8VJuJrAdlP2ms7Lvp4tPuwEX7imCxjwSsguED9txGB+5Q3C/rqa5VjeDI8WKrkkf4nQQwwiBesO42mSjblsiLAXH/f 2MDpwEq9 uERxyPudQa6xRYeDADKnEdtXbqHStii92vYLYOSpB1S3r8z5mqLBZdyr7vyeM2cWN7TrLDMP0USMAABYy4EnXwqFCew78+EcxasIsszGY1sKKQxYbMtAhVNL0qV00peH+A1vB6LA1mc3fu53/zNyoLsWs6AxpXt6PnMY5RpHUU6CMnfloGVyiUS+SznH2Q93HscIfvtcd9E9T5tDOxnkA5YEMqfqY16kqllgfvPUqZ4ICFcrXtMguWMKwntCMosLnCly+j6AB8xZuDOmnUhj/craTQuPiSaLPIvuN1hurkLJU60RZBs41OySZExsqIkbvYLAhFuhwuB7YYDmO56kD0Tp2nkEgp47zVVpAXqoRTyLU3hTYjAgnq0ecFXeUOOkyqz0G8Mgsu7Roe5ANGdR/Tr5nZWNaIl9x1+nh6/lw69XPg4Ys4afgJepslI+fQm1f81mXSeO6GrPHGHYPiSRjuA6ova0/aQPYY9kYpomoPAPVK7R3TZPDfJOQmA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 1, 2025 at 12:56=E2=80=AFPM Miguel Ojeda wrote: > > On Tue, Jul 1, 2025 at 6:27=E2=80=AFPM Tamir Duberstein wrote: > > > > Add `Guard::{insert,reserve}` and `Guard::{insert,reserve}_limit`, whic= h > > are akin to `__xa_{alloc,insert}` in C. > > Who will be using this? i.e. we need to justify adding code, typically > by mentioning the users. Daniel, could you name your use case? Alice, could you confirm whether rust binder needs this or not? Andreas, did you also need this? > By the way, it may help splitting the C parts into its own patch, so > that Matthew can focus on that (but maybe you all already discussed > this). Happy to do so if it makes Matthew's life easier, but I'd prefer to keep it together so the motivation is clearer in the git log. Matthew: any preference? > Also, unit tests are great, thanks for adding those. Can we add > examples as well? Maybe on the module-level docs, given the rest are > there. Will do. I ported all the examples to unit tests now that we have kunit, but I'll bring some examples back. > > > + /// Wrapper around `__xa_alloc`. > > We try to mention what something does in the title at least, even if > it is just copied from the C docs -- you can reference those docs too > for more context, e.g. [`__xa_alloc`] to: > > https://docs.kernel.org/core-api/xarray.html#c.__xa_alloc =F0=9F=91=8D