From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34DEFC021A0 for ; Wed, 12 Feb 2025 14:34:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 813796B0089; Wed, 12 Feb 2025 09:34:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C2D06B008A; Wed, 12 Feb 2025 09:34:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68A2D6B008C; Wed, 12 Feb 2025 09:34:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4D47A6B0089 for ; Wed, 12 Feb 2025 09:34:27 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 09568B0A25 for ; Wed, 12 Feb 2025 14:34:27 +0000 (UTC) X-FDA: 83111538174.19.B105F71 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf26.hostedemail.com (Postfix) with ESMTP id 06E9C14001C for ; Wed, 12 Feb 2025 14:34:24 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Iv9HX/cN"; spf=pass (imf26.hostedemail.com: domain of tamird@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739370865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h5UWrZt1SbRLiPbOCZ3FDQEs4EokuYZL5IQM659E4VQ=; b=bJX4YGV3IGJXP370BX1EmvTlhviifaysW2RyoOlDc3nCCDO88loQuD/0vi9Rl1zCM8Hyxk AE5XBblomG1PdadhumN8eQ9fxmiZC0vJ8f3TIggU3lLQ4kV7If0PMF6HBSW7VDEz9T/b6F p2ImR3A0O/zq7ew8x6XGmhTw0rwnx5c= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Iv9HX/cN"; spf=pass (imf26.hostedemail.com: domain of tamird@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739370865; a=rsa-sha256; cv=none; b=gTaKFLiT8GyJotev8wYbDmiB2AWakf9RSulYtw36XTzsv2433ytSSy5liFEpg3eMd5Y0vC Wrbh7PCGH2DyT0TX+lSpmzduIHBDlE3hCaAJxP6ASTVWmzo+hXTNpy0xLfRJC14PsEKrtG Rn2czJoRU5Dj+ZC+awWQaZfr6dKCCjw= Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-308e3bd8286so41019241fa.1 for ; Wed, 12 Feb 2025 06:34:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739370863; x=1739975663; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=h5UWrZt1SbRLiPbOCZ3FDQEs4EokuYZL5IQM659E4VQ=; b=Iv9HX/cNMsNq2tD4xds5KwDkHZD3SXUntEs+48R/OGynNkgM1HdV2CIsmwj+Qt2vwZ 7IsIAdJokwHbJ5RVZ/8NWeJANwRwKpdVkOh8KTaWwaZzAWUFbmOCbt7zkZcuVUSjIctn NqNfJ66h+N2Pp741wHCtvIEAUs5S/iM6yQC+kMRT5dr4dU7YfHQuOU7nWy0Cgpt6n7ZF PTRyFOqg9YTDoLM5W2vSI/aUlR3NkwrSM+8drV7HI2UKI0s0igiK9CfxtjW5FHY2IsGe J5w9/fIHlcmh/CPkDgYxAh0cDXGiJdGpI48HB+gVvBvnisnQpns3HpRJlQuk31+O6P1s gcEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739370863; x=1739975663; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h5UWrZt1SbRLiPbOCZ3FDQEs4EokuYZL5IQM659E4VQ=; b=DMhF8KGcQNDGSSkwGzT4BHOuQ9UfpQhuEYHei7dmMKGoziTmy5442ppF8c6tyzBu/f uH+A1pSSFsDC+8ihIjS5xtP8+NaIVBrfihChPJB6Tid1MU40enqC6oX0l0DVHC4R/Qe2 aaDj2ErDPZiJrr7rqQPxg+dAf4VQh2qqNAYv6GKdDnDZxRpEY1COGTcpc+nsS195NrT0 bKawoltt6SvCcaadUfoPQCi5kC0ug3yaDGwrKpzdVPJCglI4xSE2zpvYuO5sSZvxe1dR S0FrlAaD1usB4fejkqeGO1XOeDt27HcbTzqnSISAI8F1C3hxrhm7wI+hueT6G8IFUFXo KAsg== X-Forwarded-Encrypted: i=1; AJvYcCXZBD3Vz6TIIILz5OqLhhACvx8TpPP0dzKAq5yT+feqhLJ4ZLBMfPffjcoQI8sCA84gndlsqp/c4w==@kvack.org X-Gm-Message-State: AOJu0Yxx7Qz5xApGDWkj/U9XgQSJjRGI8PYOP/08K97tBxnSw6vbYJK3 AkU1K5RlEMhEGHKQkz/054EOYwVfwEDSCIK0LEUjv1bu82v68d95PK2SwyNUvOjfdpOjW6wVOPc zgr+ECGnFyXTi8UNKVBVLbDVXqzc= X-Gm-Gg: ASbGncvj4nyLIp5mplx6EbawUdjjL3ATMtt0KCmKNvhqaroR58ALmavjDsG/0gQlYp8 74N9+eb7bBvO1w+gzE/KFhLipsQX1x9Zg4QnLAqvGjcvbhIFXNFNd1hARkZfCfwypeB5v7+zRxD iJzfy2GPj9/P7b X-Google-Smtp-Source: AGHT+IH9eMUdHQrEJvRoMiHM5wWub8oT4MYD54w7JiRl8QYpmi+XqlQDqR1rViAif3p0R0UwpjfWAYqFDuP/fHTXwgY= X-Received: by 2002:a2e:a90a:0:b0:302:2c61:a1d3 with SMTP id 38308e7fff4ca-309036eb500mr12184221fa.36.1739370862710; Wed, 12 Feb 2025 06:34:22 -0800 (PST) MIME-Version: 1.0 References: <20250210-ww_mutex-kunit-convert-v1-1-972f0201f71e@gmail.com> <3dabe058-2308-4990-8e5d-0af1efd27431@stanley.mountain> In-Reply-To: <3dabe058-2308-4990-8e5d-0af1efd27431@stanley.mountain> From: Tamir Duberstein Date: Wed, 12 Feb 2025 09:33:46 -0500 X-Gm-Features: AWEUYZkkeElNnRNC8RIypph5mg5FZAiJl4nwjjINbxtzd2iXi_UiZ6XRGHLQ864 Message-ID: Subject: Re: [PATCH] ww_mutex: convert self-test to KUnit To: Dan Carpenter Cc: oe-kbuild@lists.linux.dev, David Gow , Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , Andrew Morton , Shuah Khan , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: hj65tw87kdrtzrobf1zwdb1f89nxnhqw X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 06E9C14001C X-HE-Tag: 1739370864-421483 X-HE-Meta: U2FsdGVkX1+FSGaJMQInc4COxM0AmHrKQ5q3HCszFIU48Dlw5ACJNDcU4GgI27cML06lH+wMx0aXWJwzzHTneq3mlW502VQBD+c4Gq3EKDgE5iT0gw4KRyzhFufbEWoZhD6pFI9LR89azz6UzNnE85PNDIs8Ok2717QQno1Ng31EzyjyEf23+5rqdtniWX9PyVfnyrF14hghxOK8/DcNhwp9gzI7xMZZj9yyOHTs9ta7CiTMdp7hefCUhxLcTDZ3fokCBFCsnJSCMKf32CBqTevC/0EwTXt/je9LJ+PRwXE00SXdnqLsht7Df81RKf30nvb5PN30FGXWVC8vM4kn9bTwoOEqeN+TaLPzxMJkKYD/S99SutoHbcS4T02C8DwJQdd8bNSUx3dav1fnZGdFnkOLsF1xBWRJkBBGRwwDvUY2wFbhAI11jKK0E7KFgiGlneiqRP76bcMyksJXQVzf2M9v3BqFuqLRY4+Dpq6ZuGfD69E5rcG1tzlB9FznBczNQ7caBsLOOHJiXzqfB5WthgnYK3N9wSd3vLNP2PNuq70GMIS64yBDL6O7C4fGP7RLuWwO1cWL2wr6VPWbTCwObvn9bTN5K46koNUoYK+oBxgD4mNBKMjz2qCDWOE9C4TuwAgb9b7aYSxrOoJGa+m+fI7N+zyrI4KttrExEHEMeGKj8dPBCyqFWdXKrBrzBGr5cmyP+oe0XxY0AV2hwwgz6Q+BJwTGto5d8T+tujuMpfHS0Jxu7drLMwglyqs5L5Ni3uPM8nsGS+/L2S80gK9drsBrb5G9OniUakQ0UDPBWh9snzfyuctI+YNmRWOisbB7x8Mo1tmv5IkjMTrMq4TgfBn+vGqNEr0ys2KSRxQbsweu6Q2rnr7sl1NmVuID078sk0eH1mzl6Mdb0pod4iBL20v5715lnb/ByslFprZ5Hbxy2fIr/8EveO8kpxwcs8XzTlvwhVaLRshtt90M/YG oW3a6hhD edHdClJ4+AVp4Jb7UzpW64YUKIzNKlwDuUW6qd4/0d5OIoEXctbfS7T6KT2EPzavrQuah/jwIuQacce96pboAf4FO6NgBQ6PDOBDN7AgpH69zsunWT6vrwVmYCsPqDzSxWRLemHvOZVXyH3bqfSFCVh7ePg8x1EuIKQPJdH14NivCFtnnXmsc62051ZtiTgB4b/IBWZhgzWo3uaiIpojWuV5oZ4FRfn6wmvO0Ld2FTglg0isa6rugI43z0KDgzsTO9cENeMVzoDp0AC8vSod+kl6RlSE6VzPmk2rlP24A+LmWF71BqQ3gWuQaFZfzRQKFZFq/CryG4eQgWJCj3MlhT4Cs9tsRmt0kkQDqfDQ3ExlbSTi7W7BpVBPmUgBJpbGxreew+mwdZipOPaJ2wQ3Z9QHOciOSb3w7B40zZhmdxTOt0kYM4yOvfDAS2WT5w0ICTUMPOT+C5MkLhReTA05x9S+GWYLn52pRfV3OnB0cn63hzZAhRRSC6AQcqvNuxr0UQSezQ0IxFi0DoB2bCsxhSXTb9vnQ9nLqkJk2PSaGVIC4rqEIFKo8sgNm3akthbxsYWPTTy3pq6StmBVvMcs08wP+qCy+3WgKhNHVWenE94+kzZs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Dan, On Wed, Feb 12, 2025 at 6:53=E2=80=AFAM Dan Carpenter wrote: > > Hi Tamir, > > kernel test robot noticed the following build warnings: > > url: https://github.com/intel-lab-lkp/linux/commits/Tamir-Duberstein/w= w_mutex-convert-self-test-to-KUnit/20250211-000245 > base: a64dcfb451e254085a7daee5fe51bf22959d52d3 > patch link: https://lore.kernel.org/r/20250210-ww_mutex-kunit-convert-= v1-1-972f0201f71e%40gmail.com > patch subject: [PATCH] ww_mutex: convert self-test to KUnit > config: i386-randconfig-141-20250212 (https://download.01.org/0day-ci/arc= hive/20250212/202502121806.CS6r741y-lkp@intel.com/config) > compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51= eccf88f5321e7c60591c5546b254b6afab99) > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > | Closes: https://lore.kernel.org/r/202502121806.CS6r741y-lkp@intel.com/ > > smatch warnings: > kernel/locking/ww_mutex_kunit.c:238 test_abba_gen_params() warn: shift ha= s higher precedence than mask > kernel/locking/ww_mutex_kunit.c:249 test_abba() warn: shift has higher pr= ecedence than mask > > vim +238 kernel/locking/ww_mutex_kunit.c > > 70207686e492fb kernel/locking/test-ww_mutex.c Chris Wilson 2016-12-= 01 231 > daf92a37bd1117 kernel/locking/ww_mutex_kunit.c Tamir Duberstein 2025-02-= 10 232 static const void *test_abba_gen_params(const void *prev, char *de= sc) > daf92a37bd1117 kernel/locking/ww_mutex_kunit.c Tamir Duberstein 2025-02-= 10 233 { > daf92a37bd1117 kernel/locking/ww_mutex_kunit.c Tamir Duberstein 2025-02-= 10 234 static unsigned int storage; > daf92a37bd1117 kernel/locking/ww_mutex_kunit.c Tamir Duberstein 2025-02-= 10 235 const unsigned int *next =3D gen_range(&storage, 0b00, 0b11,= prev); > daf92a37bd1117 kernel/locking/ww_mutex_kunit.c Tamir Duberstein 2025-02-= 10 236 > daf92a37bd1117 kernel/locking/ww_mutex_kunit.c Tamir Duberstein 2025-02-= 10 237 if (next !=3D NULL) { > daf92a37bd1117 kernel/locking/ww_mutex_kunit.c Tamir Duberstein 2025-02-= 10 @238 const bool trylock =3D *next & 0b01 >> 0; > daf92a37bd1117 kernel/locking/ww_mutex_kunit.c Tamir Duberstein 2025-02-= 10 239 const bool resolve =3D *next & 0b10 >> 1; > > The shifts here are weird... A zero shift is strange but even the 1 shif= t > is odd. The current code is equivalent to: > > const bool resolve =3D *next & (0b10 >> 1); > > But changing it to: > > const bool resolve =3D (*next & 0b10) >> 1; > > Doesn't make sense either... Probably that makes less sense actually. > What are you trying to communicate with this code? Yeah, the bit shifting here is not necessary. I'll replace this with a proper bitfield. > daf92a37bd1117 kernel/locking/ww_mutex_kunit.c Tamir Duberstein 2025-02-= 10 240 > daf92a37bd1117 kernel/locking/ww_mutex_kunit.c Tamir Duberstein 2025-02-= 10 241 snprintf(desc, KUNIT_PARAM_DESC_SIZE, "trylock=3D%d,= resolve=3D%d", trylock, resolve); > daf92a37bd1117 kernel/locking/ww_mutex_kunit.c Tamir Duberstein 2025-02-= 10 242 } > daf92a37bd1117 kernel/locking/ww_mutex_kunit.c Tamir Duberstein 2025-02-= 10 243 return next; > daf92a37bd1117 kernel/locking/ww_mutex_kunit.c Tamir Duberstein 2025-02-= 10 244 } > daf92a37bd1117 kernel/locking/ww_mutex_kunit.c Tamir Duberstein 2025-02-= 10 245 > daf92a37bd1117 kernel/locking/ww_mutex_kunit.c Tamir Duberstein 2025-02-= 10 246 static void test_abba(struct kunit *test) > 70207686e492fb kernel/locking/test-ww_mutex.c Chris Wilson 2016-12-= 01 247 { > daf92a37bd1117 kernel/locking/ww_mutex_kunit.c Tamir Duberstein 2025-02-= 10 248 const unsigned int *param =3D test->param_value; > daf92a37bd1117 kernel/locking/ww_mutex_kunit.c Tamir Duberstein 2025-02-= 10 @249 const bool trylock =3D *param & 0b01 >> 0; > daf92a37bd1117 kernel/locking/ww_mutex_kunit.c Tamir Duberstein 2025-02-= 10 250 const bool resolve =3D *param & 0b10 >> 1; > > Same. > > 70207686e492fb kernel/locking/test-ww_mutex.c Chris Wilson 2016-12-= 01 251 struct test_abba abba; > 70207686e492fb kernel/locking/test-ww_mutex.c Chris Wilson 2016-12-= 01 252 struct ww_acquire_ctx ctx; > daf92a37bd1117 kernel/locking/ww_mutex_kunit.c Tamir Duberstein 2025-02-= 10 253 int err; > 70207686e492fb kernel/locking/test-ww_mutex.c Chris Wilson 2016-12-= 01 254 > 70207686e492fb kernel/locking/test-ww_mutex.c Chris Wilson 2016-12-= 01 255 ww_mutex_init(&abba.a_mutex, &ww_class); > 70207686e492fb kernel/locking/test-ww_mutex.c Chris Wilson 2016-12-= 01 256 ww_mutex_init(&abba.b_mutex, &ww_class); > 70207686e492fb kernel/locking/test-ww_mutex.c Chris Wilson 2016-12-= 01 257 INIT_WORK_ONSTACK(&abba.work, test_abba_work); > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki > As an aside, how can I compile with the warning settings used by kernel test robot? Thanks. Tamir