From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD377C0218D for ; Wed, 29 Jan 2025 22:33:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22C69280067; Wed, 29 Jan 2025 17:33:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DC0E280064; Wed, 29 Jan 2025 17:33:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A470280067; Wed, 29 Jan 2025 17:33:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DD68E280064 for ; Wed, 29 Jan 2025 17:33:46 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6ED9D1204A8 for ; Wed, 29 Jan 2025 22:33:46 +0000 (UTC) X-FDA: 83061942852.27.5C180B0 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf05.hostedemail.com (Postfix) with ESMTP id 7E606100007 for ; Wed, 29 Jan 2025 22:33:44 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BeTQxieY; spf=pass (imf05.hostedemail.com: domain of tamird@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738190024; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TwtTqChbi4zZdf/ZVEHKDcud1fzrA6/ZFVeSu32TP20=; b=5J5Y5VwzakLA6C2mNpezGqVx3bM5UsCc4UzJ2akl9ELmqdU+59uBchly9bHuwQOoyzXKF2 ysS5gqnFXrkLlgvxi+thKwFVZEPE6K3w3O/VeQh23nmN//vrZD0ET/xCQRqqW6qq8rnqHf FwJ/AFlKnIGbY+a06PWFkpG91B4GpGA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BeTQxieY; spf=pass (imf05.hostedemail.com: domain of tamird@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738190024; a=rsa-sha256; cv=none; b=nYOJa53j3rbrSMCfODUYeeMhLX9ySKEIq7CWw/X1YgmQHHUmc9yZeSmCN+LfSrpBjzTlqV XHe/vh7bLmDa5+fp2/ngevBcrLkB1eeLiFWeis1wr+VIWrpe6wg5w6yLPRWk4ljGBF8GGV NIyQu1C67lJEMyoi83i+mL+9+AksL1A= Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-5401d3ea5a1so120793e87.3 for ; Wed, 29 Jan 2025 14:33:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738190022; x=1738794822; darn=kvack.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TwtTqChbi4zZdf/ZVEHKDcud1fzrA6/ZFVeSu32TP20=; b=BeTQxieY1OAQpgZXsymJnh8kB4dd9GDcskIOniWXflVRcCXP+bVl3Dxma83gDwOidn Q/QSmzHhROrSA1CC3JulDOu7YBUyQZ0P/Uffx70HbhEiALf8cZR0bhpg/5rEunf5S81/ Hd/N/jrXS7GvrHVcOVi80BoCOtgNGmwucQAO6dG5qRaYFrhEP/C/YAOT06ZKeKPhgcEL i0YoUEPryIRXiHcROzWmCcEdkht96SdlfOQPGUY86zjirpy6OXLh8TlYC7NHbUOgBiVj jCokzjNUfdLWAYdMlk1deed2+Rw/Z154RfF0wY9yWfhF5IScpXU6l/cL4oc8oimPM325 zBAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738190022; x=1738794822; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TwtTqChbi4zZdf/ZVEHKDcud1fzrA6/ZFVeSu32TP20=; b=HG/c4LmjL7xa1cZ6CjjOw5AwiZu2fyZ8Xb3HDWPPM1l2I545cc/N5K29bRX7lC69rW k+35DHMCjiVuVH+8M10o81sxOftB6v8lRsnzvb5Z5pPXOcQOJgNYB4L3S/MaJzM5MJl0 odg5NfeezyWiAlgkKPg+gS38hqv0B+Gn5WqRt4ghdJ4rrvkoFZ1zofBq3s9GHXRxaFQp rxVxg2LdGm45nz/8cWj/eZEf4XEbI9A15KYxq036wXWdZ9vENx1DPfF+hclH/jAyKKAV emYpj8zxVMQqvfXhtMbkH1uFaRUgEcfdH+VYa3sbLRjMIwGP60uFYwXutEVAMokFyj1e yCpg== X-Forwarded-Encrypted: i=1; AJvYcCXNZZjU6H6NVeEkjJckMShmHh3ZgKN+b4soiCsaaFPysyoCX/jVLMrLTWDFBF8JnWGhxo7uh/T1gQ==@kvack.org X-Gm-Message-State: AOJu0Yx8MXRbizNfI3ICVumlTFe12hhDrnLPjlYmju2v3Y1npHoijZXJ v1gRytZMLwQenB9RyNMv6Jz5E7ODBAAvMF5it9O4BhV0VLlYptCqHvG+4kCBCB+tkW9KcXJ5Xlm FFsgdF2cxKeaIpG/DxFZkxnnh5uY= X-Gm-Gg: ASbGncs6Ym9km928oaDZYgd3AWL7CSWFNXSenFGg+srIlZD1mMwZd+l5GwmE4VG68tY C7aJFKDJU7Wn+HsJ/d++RPtks02OMYsG9YCmJPSEbv7h3viU8IA9XNkZPNCOS0xU4P0FiLqqB2b x5NzNzirjsuq+yA4ZFac+lo/6aZ64P6w== X-Google-Smtp-Source: AGHT+IF2MeaNjouO8R0JM1et8QEoQLnG0VNYPnffzuMibc14Fpm6x8jD+8I3kdg8KrIHS3kDt2XsyPg6S66iF7JWajU= X-Received: by 2002:a2e:bd02:0:b0:307:2b7e:6ba0 with SMTP id 38308e7fff4ca-307968b8eb2mr17871601fa.6.1738190022267; Wed, 29 Jan 2025 14:33:42 -0800 (PST) MIME-Version: 1.0 References: <20241205-xarray-kunit-port-v1-1-ee44bc7aa201@gmail.com> <07cf896e-adf8-414f-a629-a808fc26014a@oracle.com> In-Reply-To: From: Tamir Duberstein Date: Wed, 29 Jan 2025 17:33:06 -0500 X-Gm-Features: AWEUYZmqB9KaPVADJVSl0RJAzYftKo4819o4ffb3JmJnxzxyng6OqI0KWIIVhig Message-ID: Subject: Re: [PATCH] xarray: port tests to kunit To: "Liam R. Howlett" , Tamir Duberstein , Sidhartha Kumar , akpm@linux-foundation.org, christophe.leroy@csgroup.eu, geert@linux-m68k.org, justinstitt@google.com, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, llvm@lists.linux.dev, maddy@linux.ibm.com, morbo@google.com, mpe@ellerman.id.au, nathan@kernel.org, naveen@kernel.org, ndesaulniers@google.com, npiggin@gmail.com, Matthew Wilcox , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7E606100007 X-Stat-Signature: 6dw5kxkub3xmdgwws8g7w7ajk756zu1d X-Rspam-User: X-HE-Tag: 1738190024-254877 X-HE-Meta: U2FsdGVkX1/5KYT/nQInxW3MUjMN2cmh4KrlZmovG16iaLyaoC9idg/o/xUM55eiF8E0YMA84wjoLBw+xuZ4R3eiwsdJmjb2JiKjlo3DPwFdgO311JJRuN8V0DllvOmJQuGm2PzIoIv3lluSqTjTFECF6fAHn76rqIVZwK3ol97tyaaIVDhLSAwCeiU7AG6SR/E/Fu89kYJz9Pw9wV4/bHWvqhmH3m/F4qfrOLkmmsjLeMUwvfkpol2VeLhdJdgBWKBchAtY08VKX+oVzgJ1MLxjBy66PcmW4xFUT68mtObWYkz4gDB6Xkr1YATn2eP68pPHn/6ewb/wVYTKAm2KT8pde6t1dkuO8Uj5FJ+iLJs1OXZNHxsPtLV3fFTwz0z16ZbY1/gmgiTez+umH2zro1RHL61phn/54xf6dEsdCr0hLUbSHiQ9SjzByikTxCP674yffkcHy2CYVNzWD1jZCXBt8w5HBin1HSLczA4K6Q4zVGKvcW4YYBgZ4o3ksuE2WJ8UjXTpTQ38knqZIj+a9lV3JWbt1KmlGmSU217V0tu8kMbMGVviQvTy8CF3NlA/MxsBLoWUS6i4Lmsoqlugk7z7VTHEeEvMAGBpozy1b3s2pq1Zb3q9IN2LQtMNH1tvFYgS8+UCZVa5wOKUhxh8PNbLkrSliZJ1zTKWBXgKZITkq0m9LgKRNCUSpCtodrjA2dnLKqXFydHmCeaPMVONO8c4qeGl74yorPhwsEl5WiA+kSeaGY0SSrgrRMuwX3yNYjRQ6xu/RWfl7kI81PtXCjUKUxkbVjyg6ruZ2I5qK3e4RMtfSX0JZ+r6G0t3WXoX1+H07y8fTL0Tubmd1xgtRQn5oUv2xc72NAePy9DS09GnafLRzC6AVAYyr65ocP/xR5CRJG+VqmmvMF5jrgFGIKIyQ+AavckCGheSkEo5ptVL6n9zKxSnSORqF4D1fe803fmpFALJxC307bb3Dx8 scLe0OCu DgG4eiYUDRY65M0H1ge8bLtSMse/FtOVp4crwTpFFqHTnfPAgMkygYDMeZ65fTIw1E2yBfjrwAxrIivd5/tK5pyIW1HURvxRpDwW3WuxxW1aB1EqsuQ+78JxicS25DEuQ6T/M7D3qIlGcgP5hZ76HewigdQBtdbsLJTEaDAoevR6HoPy1e8Ce0D/Z2IsLo1kMWfxXD5OLCbbrtdfOp0691Awx0iwNo8jlhQ7/Yc162FN3/m08p88XTSPdMKC5YNa63zVkVbbzvnkZLVZgoia8697hNvRijaOgioF4r2gMJhpbz7NaAHzDIPkr/liBoDjK6sEFXJ7x1z6PUWPEsOcx9KNz6zYjwdilDdAMYzpR/genof21zZ6gfwgs7Zp8S4gl8z1uuOOJajv+2UKcazYVeUmWGow2qp2kPHGHyBS17qA7T5MfKpEIx5cPEealJLqQ/VkX9XHXghkKCei5AuQ/ZvZ84Z+IbEZGDFVHFy2H2LhIrEyxChKmYV4KD6T988ycPm7E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 29, 2025 at 5:26=E2=80=AFPM Liam R. Howlett wrote: > > * Tamir Duberstein [250129 16:29]: > > On Wed, Jan 29, 2025 at 4:26=E2=80=AFPM Liam R. Howlett wrote: > > > > > > * Sidhartha Kumar [250129 16:02]: > > > > + Liam, Matthew > > > > > > + linux-mm > > > > > > Thank you Sid. > > > > > > > > > > > Hello, > > > > > > > > I believe this patch needs to be reverted for now as it breaks the > > > > user-space build of /tools/testing/radix-tree with: > > > > > > > > In file included from xarray.c:11: > > > > ../../../lib/test_xarray.c:9:10: fatal error: kunit/test.h: No such= file > > > > or directory > > > > 9 | #include > > > > | ^~~~~~~~~~~~~~ > > > > compilation terminated. > > > > make: *** [: xarray.o] Error 1 > > > > make: *** Waiting for unfinished jobs.... > > > > > > > > this then prevents the maple tree test suite from building. > > > > > > How are grammar corrections going to the right person (but not the > > > mailing list) while an entire conversion to kunit is not [1]? > > > > Very simple: the tests are not properly included in MAINTAINERS. I > > sent https://lore.kernel.org/all/20250129-xarray-test-maintainer-v1-1-4= 82e31f30f47@gmail.com/ > > a few minutes ago for this reason. > > Fair enough, but from the patch: > > @@ -6,11 +6,10 @@ > * Author: Matthew Wilcox > */ > > -#include > -#include > +#include > > ... > > > -module_init(xarray_checks); > -module_exit(xarray_exit); > MODULE_AUTHOR("Matthew Wilcox "); > MODULE_DESCRIPTION("XArray API test module"); > MODULE_LICENSE("GPL"); > > I don't get why the huge list of Cc's didn't include the author who is > in the git commit signers: > $ ./scripts/get_maintainer.pl --git lib/xarray.c > Matthew Wilcox (supporter:XARRAY,commit_signer:1/3= =3D33%,authored:1/3=3D33%,added_lines:19/52=3D37%,removed_lines:4/23=3D17%) > Andrew Morton (supporter:LIBRARY CODE,commit_= signer:3/3=3D100%) I'm not sure what you're asking. I used `b4 prep --auto-to-cc`. It doesn't know that test_xarray.c and xarray.c have the same maintainer. > ... > > > > > > Does the patch really need to drop the module testing too? > > > > > > What exactly is the point of converting one testing system to another > > > besides disruption of actual work? Who asked for this? What is the > > > point? > > > > All this is described in the commit message. > > The commit message says you like the output more and implies you like > the command better. > > I've never used the kunit testing of xarray and have used the userspace > testing instead, so I can't speak to the obscure invocation as both > commands seem insanely long and obscure to me. > > > > > > Is anyone doing work on the xarray running the kunit tests? > > > > I was doing work on xarray and I was running the kunit tests. > > ... > > You should look at the userspace testing (that this broke) as it has > been really useful in certain scenarios. > > Thanks, > Liam For what it's worth the kunit invocation, while obscure, is self-documenting. There's usage information that's reasonably understandable embedded in the tool itself. I looked for the userspace testing initially but failed to find tools/testing/radix-tree/xarray.c. Even now, I'm not sure how I'm meant to compile this. Tamir