From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B9F1C0218D for ; Wed, 29 Jan 2025 21:29:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 864EE280003; Wed, 29 Jan 2025 16:29:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 815016B00CC; Wed, 29 Jan 2025 16:29:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7033A280003; Wed, 29 Jan 2025 16:29:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 506426B00CB for ; Wed, 29 Jan 2025 16:29:13 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0F72580412 for ; Wed, 29 Jan 2025 21:29:13 +0000 (UTC) X-FDA: 83061780186.20.62A8653 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf22.hostedemail.com (Postfix) with ESMTP id 27327C0007 for ; Wed, 29 Jan 2025 21:29:10 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bbsxsd7D; spf=pass (imf22.hostedemail.com: domain of tamird@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738186151; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GT0rFmaKToeuXSjRSzkL/lRENUooY068EpzaG7EWYO0=; b=Hzisy/JmQT+7WpIv8Xx2mOvSty/Kmx8PcUlyn12uOUW/k/loq+U8ypysPKfGIYHHKmnZxJ 7kvAfAWep+8O5blsjEARPdhIMdGtxOQF5mlaqFmMDjc99XqDdaCAdltmTzcVmA9PH0iCsz GgnVsurJh/XFV8ahW3NdugPyybGzLcU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738186151; a=rsa-sha256; cv=none; b=T7NZKE80DIBfWiqUec2UXQiGcb8XxyAxJSydiB+aSxJgOdmjDDsBM7GIYGlLClsLq2H/jD y2BWxKJ8ZiRgSKv/uPOqGWCn856AJIJKfwteZNqyQYtD374UM15K6QaWluokEd+BHikPzF jyhvTRUWGN6h2qhWRvBcJmrXy3MI124= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bbsxsd7D; spf=pass (imf22.hostedemail.com: domain of tamird@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-30229d5b229so724251fa.0 for ; Wed, 29 Jan 2025 13:29:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738186149; x=1738790949; darn=kvack.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GT0rFmaKToeuXSjRSzkL/lRENUooY068EpzaG7EWYO0=; b=bbsxsd7D0/p3v6f4/5daakA33xeTKLDFkXt7inxagO6X4yGj5CBAal3b6M+fGFgeiH ssDTgIg1TH+tViGZKzsSUA6A6FxNTpZpJ0D28wmchE5NyOghWDIZyaC5JDhoVAmNgvnD WTaGSIhhg94NXrKP+c5BiPkWX9kxhbdSe/wMlvKu2E/DtH0Rh+vtAB59qZTk1xiIjJIU O71oLWz9X0nquheje1kQXMc7kPJsVqO7cnUSwcufkkosVckukQtPOwb+sKbvkITIx3Yz addRXN3LHqsMIo5ZeTWCphDi5hbVf9UsM6YDzHnb5XoTxIR3Qu0dkiyRkAEAWykt0T9v 2t6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738186149; x=1738790949; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GT0rFmaKToeuXSjRSzkL/lRENUooY068EpzaG7EWYO0=; b=Wcd+YSydRy0WRnOgXRTIGe6n5oC+ul4cdnbqZ3AJbBY+v7tjyTQ6ISTNMI0ERyAT4k YTtSxH/syAeBpWiW3hutO8K3gDUI0YBlGfbutHAWWaRH3S+7TlIQT8UNjj3sAHEIgc18 mPB74jhP6QVrdPgV4u5NLVEOnN9Z7y053yNYu89QxobNKEWr7yRkjXcwVEJba7bHkUu0 y7F7ZrjyfMG39nL7NrmqHKyzhvwaMYi/4685L7BO/2pTQmt65IfxuF6m9qWLdOBTDgKH U+HVu1B/2Io6LI68KxIkX3vqhhDYhdmd0y0lfyhoV2FRkTW29vk3lQg6TH0t1OM8pxyG SZKA== X-Forwarded-Encrypted: i=1; AJvYcCUTTsGUJYZV6MJjdwdZoiAz/oVUk2vTfrOQYZR0KhBkw4Qfk1FGTGR5EpNSld3+BmyDZ7hClCAPiA==@kvack.org X-Gm-Message-State: AOJu0YwrXCnxuFIEiiIXzTvllTMhOk5pRaTlq7V5Lkbfba1vCtP782K7 fQxCK5yPHcXNv8Z0zglo1MIarx1Ek5z7cFTauh4KWQhp/rsBV1WrQ/Ip4IrtbHobiQdTHZsyNzJ SKCaq4jVXXav5NwkGQ/IgCrJRjJg= X-Gm-Gg: ASbGncubDWu0vcyzZtzpp8X0Z+MX+mdbOzMlzou42uOtDECxoRql4zH/bmEoJUWCc+a GycS6t3oN91GT9GAC+L741W+2I0gf62SjyCWyU3pLePAj+RV9LqufdCpptLya2WJuWijdBqJ2RO 7MgynVE0aDJ9On/B5olA4eTJ4/WJYGAA== X-Google-Smtp-Source: AGHT+IEini7TIAvHWFfZWJAA/DIhlgY7ELxTDYTMmVhvFmOP3+WEeVrbZSpqp7JMDeFBEGMKPTMSdGVLiQ0G7+RO3zE= X-Received: by 2002:a2e:bc26:0:b0:302:49ba:2550 with SMTP id 38308e7fff4ca-307968572cemr17704121fa.21.1738186149080; Wed, 29 Jan 2025 13:29:09 -0800 (PST) MIME-Version: 1.0 References: <20241205-xarray-kunit-port-v1-1-ee44bc7aa201@gmail.com> <07cf896e-adf8-414f-a629-a808fc26014a@oracle.com> In-Reply-To: From: Tamir Duberstein Date: Wed, 29 Jan 2025 16:28:32 -0500 X-Gm-Features: AWEUYZm30qzC7OYicUCyM7022EFlqK5dvrSLqA0Ri2_QEk_6Vs9gveN9uXDYy-8 Message-ID: Subject: Re: [PATCH] xarray: port tests to kunit To: "Liam R. Howlett" , Sidhartha Kumar , tamird@gmail.com, akpm@linux-foundation.org, christophe.leroy@csgroup.eu, geert@linux-m68k.org, justinstitt@google.com, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, llvm@lists.linux.dev, maddy@linux.ibm.com, morbo@google.com, mpe@ellerman.id.au, nathan@kernel.org, naveen@kernel.org, ndesaulniers@google.com, npiggin@gmail.com, Matthew Wilcox , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 34b18uf8aiuy8fp66i7qcux4p6h9nwma X-Rspam-User: X-Rspamd-Queue-Id: 27327C0007 X-Rspamd-Server: rspam03 X-HE-Tag: 1738186150-606216 X-HE-Meta: U2FsdGVkX18gBIoNiFKt+4vCcGjAiJddkDkNMH7JKAX23g9URKTIaH+CYtIukEn/Htvnp9BDIyF9JaLDyPA+r4lT9Pl1ipCTIsZfrveQ+ylWUOWW4M1KvtnrXsAnnbkrK+t2yIvYcBCmRsUlxvDt43YDmZZhUVy0uidUcYw21ojhv313xhXsPcjz5QBqkNZbb2VlVUMxK8ubMie0kVQiUxn47ItwpZnX+pBboXp8thYZupIWvZelsaPVRa6Jw4lUWotxq5Ls9nhvzb8KRJVHswiewdcvrNM1iqj6HmIEGxVyT7lMjkxxSryxTJ4BSgWd/SiBiYBXRYZzILi6Viy3sc0F1ANAG2QdNxztoUljuiFILYN2jGDoWlu+BEyvkSirl5Qp4vqInoc0RmPwvD6yC6yUOzNB1Lc2MSaeGdWsAxq2hPiKnmOyFyPWeBlZzavYjFLTOUXnU0DpYxKriygrNSCvyHWMVB0FvJnQXwZl3/BgPZclfTfmdnoS4/5Jfvimh+9GM5SpFuArQ4owXTfjAyNlz0WsjMGeqOW7tNFOwEBEXN3yUJxqQ7tPFnffLOigjpVb+y0vXYIUFxDq9RutoeBUh+lbunO3pQRP8xIXd33Xeb5Y01aPT5b9fw6XvqrPCayDcbtJx75X/IZrzFPz4005zR6Gb4dy4GBj58vcrni2NS8WewZZLjCvz2+Nr7wsbmVbQHOb2R2qrk+vg10MYLI3WZ3Y5ssGXgAC143VYLSjgLJ0vNPEgqml9udx0az4TL4UH9XWFTqYr6CNObYufIdo88ENSI5Nc2MX4ecTm/olsFHpD00L9Gez8HcfNogYSx2f/GX/SfP+btheYNlcMQT+y69/wgapJZIqPfESI9Hb1/rBF0sqApmwHCJZIDZYXx1xMW5VuSsdqkJFNXXE5epAYEzFab0CNf7x6mi4vnj4HFrmJmmWrdhQhmMyhlDrXw8RZYAeg9eabq20Qn9 fPXBGwMw laI4zImHU3jyPR/w0a/nnPPPCs6a+XPZ67KhZIoearCEUIBT5yujgVmk5QqzPq6lhXOVeNlBXmLmOHcZkL5YvnecOPljRXCHFN/mLkEsYAAWq5U+BDSyyNPmjXYP1QTx1TMd5Owsqkza6Sh3nZNj73si98PlLuphvFOHXpodc1erQdsJ7DKoUrsfgX0SesZZGZwtXsS00z6wbBs5ebCpuhnZNYKCmc1TQ4dJL9Kw6SizuEp1WnvUau13cnlht3cNga4nH2ADy9yednfRW52TszyzYN9Omflp3ws9LaNh7p2nJ0LA8MZzpDRsLG3tcs8xHMsBgJaVvrgKgIxYZYFCkcqMh6v9Nx5dYP82S3Gyl6ajou0LzT9X9tbRTBYmGecBq2Tm2FTDkMx5MD2k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 29, 2025 at 4:26=E2=80=AFPM Liam R. Howlett wrote: > > * Sidhartha Kumar [250129 16:02]: > > + Liam, Matthew > > + linux-mm > > Thank you Sid. > > > > > Hello, > > > > I believe this patch needs to be reverted for now as it breaks the > > user-space build of /tools/testing/radix-tree with: > > > > In file included from xarray.c:11: > > ../../../lib/test_xarray.c:9:10: fatal error: kunit/test.h: No such fil= e > > or directory > > 9 | #include > > | ^~~~~~~~~~~~~~ > > compilation terminated. > > make: *** [: xarray.o] Error 1 > > make: *** Waiting for unfinished jobs.... > > > > this then prevents the maple tree test suite from building. > > How are grammar corrections going to the right person (but not the > mailing list) while an entire conversion to kunit is not [1]? Very simple: the tests are not properly included in MAINTAINERS. I sent https://lore.kernel.org/all/20250129-xarray-test-maintainer-v1-1-482e3= 1f30f47@gmail.com/ a few minutes ago for this reason. > Does the patch really need to drop the module testing too? > > What exactly is the point of converting one testing system to another > besides disruption of actual work? Who asked for this? What is the > point? All this is described in the commit message. > Is anyone doing work on the xarray running the kunit tests? I was doing work on xarray and I was running the kunit tests. > This should be reverted as it should never have been merged. > > Regards, > Liam > > [1]. https://lore.kernel.org/all/20241009193602.41797-2-tamird@gmail.com/