From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1E81C7115A for ; Wed, 18 Jun 2025 13:54:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 569396B0092; Wed, 18 Jun 2025 09:54:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 519DC6B0093; Wed, 18 Jun 2025 09:54:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E1EB6B0095; Wed, 18 Jun 2025 09:54:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2C2046B0092 for ; Wed, 18 Jun 2025 09:54:18 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CC7C6103157 for ; Wed, 18 Jun 2025 13:54:17 +0000 (UTC) X-FDA: 83568665754.10.C5F6A2A Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf30.hostedemail.com (Postfix) with ESMTP id 967BB80011 for ; Wed, 18 Jun 2025 13:54:15 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BnS82jbH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of tamird@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=tamird@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750254855; a=rsa-sha256; cv=none; b=b0SlfkecWxf63kXkb2FX7lN2GfC3drJmidi+V1dIy67hvWfjOF2PuLK1GSaWoD48DhSXoI M5XDui8DhZLWV+SFWdLJHnr62GaCvAjgyiQaJL80ILPii9A6DnkgficTjD/XZcy6jYnV6x Bn6TjFOWJzSbCGLHJ1K+OboYkQ1tF7s= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BnS82jbH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of tamird@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=tamird@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750254855; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k2W2w6wIbUYNGMzxyqMsBSzuKIfCS19Le5I7mij0LME=; b=stYGvaZU0jtmrtFK2dTmRJUzmvMWuIzvVoRwkVe0N/TQAnCpPp4UPFJgESauF+XCkleIp3 0wj/doHMvMB+yCe4kA7dpkPuKMNVZWDpPLQG9x+EFCI+EUjZ+c/kQVZHq1HpAgIKzm+V2F hpAbeLsRXFfxJpxqhXWkFSfcvENRzA0= Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-32b7fd20f99so5763501fa.0 for ; Wed, 18 Jun 2025 06:54:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750254854; x=1750859654; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=k2W2w6wIbUYNGMzxyqMsBSzuKIfCS19Le5I7mij0LME=; b=BnS82jbHc29WbdXLlw5vrx43O9TRBFtaueOvJ6YKXIwi3UMEWpmicUfCI4JxLMre3j GQIFupUzVBVprqPQlIteJ61BCU9he6J/lF5LGfcwCgc175M4Z9bdDj7+/Lv/b426mnFt slkXOEUR8wOB0P3ALnXKHWUV5DMJCM6lcUdbsKoDneH6efChOIze3NClnjsDUpk3YhOk m4adwtmzt4NPWKaiU92ZIxCBMuRwnfAXatG0CRvwD4gByQVg4cd5rrbZ/9IfTEy71Ofh GcgtDRVQBsrZOOZE6PzRHwo3BGCGNtrJnSefBlWevx0iyR3hN3LO6jlZQCIibPFyzezO nPSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750254854; x=1750859654; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k2W2w6wIbUYNGMzxyqMsBSzuKIfCS19Le5I7mij0LME=; b=b3kbprYERTu8dvrqcp3abXjsHOLyJIeE8Yy0q06ZlXZuBCRr2tflVf5c+CYPH+aLce nc94Bb4MQRFlSgvnPNlYohORMQyTVDCwHqao/+DNO0eBLRpLFCoNEi4vHW31PhSu2/5U Gwo7KP8H9g8vobIq4ftFigpdCo2zOTZzfGRjcAvZEA7cPLq37aMX5ASz3TKkcVEPP0TT 1z4VZKIs4ZMGwsuMPflU/KLsor8squmLVq6jKmXh3OURX4bubQux9Aqbjx1zCcYuw1b8 kZW5WGj9jTpBmrRgpHRbTd+aMomCFPyziAb6J9mPDnw1PXTxFpKX1d/kh1KlhAhNo9R3 xllg== X-Forwarded-Encrypted: i=1; AJvYcCXhZkiYMNekGhfwlzSw9ug9qWddm01/Bds39XHwb5RFE7TFZNRng8gRHd3ASvg5TlWvk6z19ixkXA==@kvack.org X-Gm-Message-State: AOJu0YxqaRm5pU3yhg4/O3i72jLlt97jDwle8bpB4H70V2O0Iq7UeY4k oHtjBI3J3hKCcjSlYyLGUywOukDIjiTJWmDiK2NREN5zOZIzW0LjCuBVSd0d1cbW0a577IRmQJv BgovQ8Z5TMy8MMmrmk6Zr2sW0Bxk18ds= X-Gm-Gg: ASbGncsIJYB0n+2PTUt1bnJcT98jrQT6CK7phzJChSvOyFJ/vcGHVNeCHGsfHpvQBrz VZCsijVWB9C3pFIiAG6eI7hJciQ230kjvDcKPw3N5El08SGYCsZI2pQ+xmdS/tvYEtO8fzJc5lj k1Y3zHnKgZn2LSZNzCCxoYccnIONrzBPF7UNVh5kgciHQjhjDGO8uuZd3LyfQ= X-Google-Smtp-Source: AGHT+IHZh03C5sPIQ2Hcwu1XAbcPWrubkF0FAeIxhlZg+1NSdMjscm9zrZu1R+ZNJ6L0mU+wlwxBWgoY0FO19z/Dv8I= X-Received: by 2002:a2e:a54d:0:b0:32a:e7b9:1dc9 with SMTP id 38308e7fff4ca-32b7cecbf6cmr9748311fa.3.1750254853559; Wed, 18 Jun 2025 06:54:13 -0700 (PDT) MIME-Version: 1.0 References: <20250615-ptr-as-ptr-v12-0-f43b024581e8@gmail.com> <20250615-ptr-as-ptr-v12-1-f43b024581e8@gmail.com> In-Reply-To: <20250615-ptr-as-ptr-v12-1-f43b024581e8@gmail.com> From: Tamir Duberstein Date: Wed, 18 Jun 2025 09:53:37 -0400 X-Gm-Features: AX0GCFs2lt3v0bN7NxNBw5BBQKfnl11dj5C2oqrW2YIqbWOiEntoJLEgfI50Rxc Message-ID: Subject: Re: [PATCH v12 1/6] rust: enable `clippy::ptr_as_ptr` lint To: Masahiro Yamada , Nathan Chancellor , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Bjorn Helgaas , Luis Chamberlain , Russ Weight , Rob Herring , Saravana Kannan , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , FUJITA Tomonori , Nicolas Schier , Frederic Weisbecker , Lyude Paul , Thomas Gleixner , Anna-Maria Behnsen , Benno Lossin , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , John Stultz , Stephen Boyd , Lorenzo Stoakes , "Liam R. Howlett" , Breno Leitao , Viresh Kumar Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-pci@vger.kernel.org, linux-block@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, nouveau@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 967BB80011 X-Stat-Signature: 85nn3mcqjyozyy4dq86myb991dn8phgu X-Rspam-User: X-HE-Tag: 1750254855-98664 X-HE-Meta: U2FsdGVkX18m9ATuuAf7AT2Aibk1qmc30ubkbMUJMWSGNimYpUv+ejEdYyWicmuWkQtp6HWdwpFVavlrCJ4VTa3gaEMMPygfZczRPsV6u3AO47LmnDRNLrGjiqFyOflYQrRXRJDuhuUZTw2mjGYOs2NPWS2jTngAXclGQ5zEGXCJD8vkF8ni5oDFkWOQOoCl02mOO0Aqo4+yQpfQSiM8dSfCPhzYwLHgE/ZFIM+wsDe0DerIT9WdkNNsbTSf8fPCdAjryAmHtsTS37tB/TAenb7UA+sdlvJsXmqRT9OHf3czowlKJUt3ziOfUUPsEV0y3Zec3zLxpv8ZSTsCMSW7iwE+Mb+iHpKYtx0wL8P4kCn0ZCjZEbp2vMh9Twu8xAous4dKot+1C354GSMYTJ3ApA6cM14sud10thPC1EjkgDXefcw1HraQEYePJVPNT26vLSaE6/CT3W/ymbRdrpmKbq7OQj/7HJdwqLii8SyPXoGGn4FhMiKWP/6IxCt9uz833udb4YX31nJscUCtuF6syLKEpyKNHmcZq1g3HTaPt8/oaVu0vm1h4IOfltEnCLbF14s9cfICfUgkxlJEYnG1WaCQEiK2ba21zstWHgBp+JfBFGcRxPhcMJTq4aqwj/D61Ny5UZR4nMG4Bbgh6IYwjmA9Jmg3jkXlNs75Eoz264EINZecNCa2f88OtKSNsxJgkzhVuROFdy+BNcrOPfLZ2iRkJJXlEAaSUwlX3sPiPm38BysWT/0XMsnkg4l/AH1VfguCHJXXVgXoiLRFzwYiQJDuBkaACl+lSmr8xYpLff3GAYqiz99LMxVs0e7dAvXdDv7CB/o0PNppvvfN2dmrkxHTGNNP7cEO2qAK8csgqQ5tYEs4lshLv7K0oE3Y2h8UxdwAZFLeAJMINhwB0z1bQuuAF7NaIRa27qEabxVLg774jt5iiw9Pq1G6jDPrMQH4S3boMopPd/o6TK7RLko XfgUjd4c A+UrEwSZ9OlgwQ++DQi9rcMXeg38Xab0WGFZqHCkJKdLpzQPwDX4iHlcnvuI7Wgmk2j/zaiOa8/XKt0TBk/hStfe2u4DKbOiKbx43UELPn7vNbxELuLsUIDOaxrzbjgw5wIoPtAuPZ3+r0yd0C/MSyeWWXJ1uJtdHY3TQvt6aKg8CxbP7aQl2c5w8mZWyqRjmtn3Hfg/O9x+7bEHNK8d+DXKbEdykbVZU3zCiaZg3GMEzZmX98RGl586k+SQEGAWXWlbDc3y++5NhLKrzs3dUcvDIGnNEpKI8htjh61mANdQbGLKT6+GUoPDvjyykmll57Lv+s2qLPhZxVCQoiSpeCCISKIPbd7JIMYc8toUrZJLqocuz7oCX0KFpgbubfx9oAtQakH3HfuOKwNMWHtpPr+RQkDeyZ5NWl9eNThxI9mpCb3KAnbVrOFP0sWzR6hTELfDhEKJQltLJmRfh6AkrxTIzhyHDfKtQTkB0qbQrbzEXEWMbPZQr/wutnMkitz4gwMQebA57cw6wy0Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jun 15, 2025 at 4:55=E2=80=AFPM Tamir Duberstein = wrote: > > In Rust 1.51.0, Clippy introduced the `ptr_as_ptr` lint [1]: > > > Though `as` casts between raw pointers are not terrible, > > `pointer::cast` is safer because it cannot accidentally change the > > pointer's mutability, nor cast the pointer to other types like `usize`. > > There are a few classes of changes required: > - Modules generated by bindgen are marked > `#[allow(clippy::ptr_as_ptr)]`. > - Inferred casts (` as _`) are replaced with `.cast()`. > - Ascribed casts (` as *... T`) are replaced with `.cast::()`. > - Multistep casts from references (` as *const _ as *const T`) are > replaced with `core::ptr::from_ref(&x).cast()` with or without `::` > according to the previous rules. The `core::ptr::from_ref` call is > required because `(x as *const _).cast::()` results in inference > failure. > - Native literal C strings are replaced with `c_str!().as_char_ptr()`. > - `*mut *mut T as _` is replaced with `let *mut *const T =3D (*mut *mut > T)`.cast();` since pointer to pointer can be confusing. > > Apply these changes and enable the lint -- no functional change > intended. > > Link: https://rust-lang.github.io/rust-clippy/master/index.html#ptr_as_pt= r [1] > Reviewed-by: Benno Lossin > Reviewed-by: Boqun Feng > Signed-off-by: Tamir Duberstein @Andreas Hindborg could you please have a look for configfs? @Rafael J. Wysocki @Viresh Kumar could you please have a look for cpufreq? > --- > Makefile | 1 + > rust/bindings/lib.rs | 1 + > rust/kernel/alloc/allocator_test.rs | 2 +- > rust/kernel/alloc/kvec.rs | 4 ++-- > rust/kernel/configfs.rs | 2 +- > rust/kernel/cpufreq.rs | 2 +- > rust/kernel/device.rs | 4 ++-- > rust/kernel/devres.rs | 2 +- > rust/kernel/dma.rs | 4 ++-- > rust/kernel/error.rs | 2 +- > rust/kernel/firmware.rs | 3 ++- > rust/kernel/fs/file.rs | 2 +- > rust/kernel/kunit.rs | 11 +++++++---- > rust/kernel/list/impl_list_item_mod.rs | 2 +- > rust/kernel/pci.rs | 2 +- > rust/kernel/platform.rs | 4 +++- > rust/kernel/print.rs | 6 +++--- > rust/kernel/seq_file.rs | 2 +- > rust/kernel/str.rs | 2 +- > rust/kernel/sync/poll.rs | 2 +- > rust/kernel/time/hrtimer/pin.rs | 2 +- > rust/kernel/time/hrtimer/pin_mut.rs | 2 +- > rust/kernel/workqueue.rs | 6 +++--- > rust/uapi/lib.rs | 1 + > 24 files changed, 40 insertions(+), 31 deletions(-) > > diff --git a/Makefile b/Makefile > index 35e6e5240c61..21cc6e312ec9 100644 > --- a/Makefile > +++ b/Makefile > @@ -484,6 +484,7 @@ export rust_common_flags :=3D --edition=3D2021 \ > -Wclippy::needless_bitwise_bool \ > -Aclippy::needless_lifetimes \ > -Wclippy::no_mangle_with_rust_abi \ > + -Wclippy::ptr_as_ptr \ > -Wclippy::undocumented_unsafe_blocks \ > -Wclippy::unnecessary_safety_comment \ > -Wclippy::unnecessary_safety_doc \ > diff --git a/rust/bindings/lib.rs b/rust/bindings/lib.rs > index a08eb5518cac..81b6c7aa4916 100644 > --- a/rust/bindings/lib.rs > +++ b/rust/bindings/lib.rs > @@ -25,6 +25,7 @@ > )] > > #[allow(dead_code)] > +#[allow(clippy::ptr_as_ptr)] > #[allow(clippy::undocumented_unsafe_blocks)] > #[cfg_attr(CONFIG_RUSTC_HAS_UNNECESSARY_TRANSMUTES, allow(unnecessary_tr= ansmutes))] > mod bindings_raw { > diff --git a/rust/kernel/alloc/allocator_test.rs b/rust/kernel/alloc/allo= cator_test.rs > index d19c06ef0498..a3074480bd8d 100644 > --- a/rust/kernel/alloc/allocator_test.rs > +++ b/rust/kernel/alloc/allocator_test.rs > @@ -82,7 +82,7 @@ unsafe fn realloc( > > // SAFETY: Returns either NULL or a pointer to a memory allocati= on that satisfies or > // exceeds the given size and alignment requirements. > - let dst =3D unsafe { libc_aligned_alloc(layout.align(), layout.s= ize()) } as *mut u8; > + let dst =3D unsafe { libc_aligned_alloc(layout.align(), layout.s= ize()) }.cast::(); > let dst =3D NonNull::new(dst).ok_or(AllocError)?; > > if flags.contains(__GFP_ZERO) { > diff --git a/rust/kernel/alloc/kvec.rs b/rust/kernel/alloc/kvec.rs > index 1a0dd852a468..0477041cbc03 100644 > --- a/rust/kernel/alloc/kvec.rs > +++ b/rust/kernel/alloc/kvec.rs > @@ -288,7 +288,7 @@ pub fn spare_capacity_mut(&mut self) -> &mut [MaybeUn= init] { > // - `self.len` is smaller than `self.capacity` by the type inva= riant and hence, the > // resulting pointer is guaranteed to be part of the same allo= cated object. > // - `self.len` can not overflow `isize`. > - let ptr =3D unsafe { self.as_mut_ptr().add(self.len) } as *mut M= aybeUninit; > + let ptr =3D unsafe { self.as_mut_ptr().add(self.len) }.cast::>(); > > // SAFETY: The memory between `self.len` and `self.capacity` is = guaranteed to be allocated > // and valid, but uninitialized. > @@ -847,7 +847,7 @@ fn drop(&mut self) { > // - `ptr` points to memory with at least a size of `size_of::() * len`, > // - all elements within `b` are initialized values of `T`, > // - `len` does not exceed `isize::MAX`. > - unsafe { Vec::from_raw_parts(ptr as _, len, len) } > + unsafe { Vec::from_raw_parts(ptr.cast(), len, len) } > } > } > > diff --git a/rust/kernel/configfs.rs b/rust/kernel/configfs.rs > index 34d0bea4f9a5..bc8e15dcec18 100644 > --- a/rust/kernel/configfs.rs > +++ b/rust/kernel/configfs.rs > @@ -561,7 +561,7 @@ impl Attribute > let data: &Data =3D unsafe { get_group_data(c_group) }; > > // SAFETY: By function safety requirements, `page` is writable f= or `PAGE_SIZE`. > - let ret =3D O::show(data, unsafe { &mut *(page as *mut [u8; PAGE= _SIZE]) }); > + let ret =3D O::show(data, unsafe { &mut *(page.cast::<[u8; PAGE_= SIZE]>()) }); > > match ret { > Ok(size) =3D> size as isize, > diff --git a/rust/kernel/cpufreq.rs b/rust/kernel/cpufreq.rs > index b0a9c6182aec..1cb1f29630e5 100644 > --- a/rust/kernel/cpufreq.rs > +++ b/rust/kernel/cpufreq.rs > @@ -647,7 +647,7 @@ pub fn data(&mut self) -> Option<<= T>::Borrowed<'_>> { > fn set_data(&mut self, data: T) -> Result { > if self.as_ref().driver_data.is_null() { > // Transfer the ownership of the data to the foreign interfa= ce. > - self.as_mut_ref().driver_data =3D ::int= o_foreign(data) as _; > + self.as_mut_ref().driver_data =3D ::int= o_foreign(data).cast(); > Ok(()) > } else { > Err(EBUSY) > diff --git a/rust/kernel/device.rs b/rust/kernel/device.rs > index dea06b79ecb5..5c946af3a4d5 100644 > --- a/rust/kernel/device.rs > +++ b/rust/kernel/device.rs > @@ -195,10 +195,10 @@ unsafe fn printk(&self, klevel: &[u8], msg: fmt::Ar= guments<'_>) { > #[cfg(CONFIG_PRINTK)] > unsafe { > bindings::_dev_printk( > - klevel as *const _ as *const crate::ffi::c_char, > + klevel.as_ptr().cast::(), > self.as_raw(), > c_str!("%pA").as_char_ptr(), > - &msg as *const _ as *const crate::ffi::c_void, > + core::ptr::from_ref(&msg).cast::(), > ) > }; > } > diff --git a/rust/kernel/devres.rs b/rust/kernel/devres.rs > index 0f79a2ec9474..e5475ff62da3 100644 > --- a/rust/kernel/devres.rs > +++ b/rust/kernel/devres.rs > @@ -154,7 +154,7 @@ fn remove_action(this: &Arc) { > > #[allow(clippy::missing_safety_doc)] > unsafe extern "C" fn devres_callback(ptr: *mut kernel::ffi::c_void) = { > - let ptr =3D ptr as *mut DevresInner; > + let ptr =3D ptr.cast::>(); > // Devres owned this memory; now that we received the callback, = drop the `Arc` and hence the > // reference. > // SAFETY: Safe, since we leaked an `Arc` reference to devm_add_= action() in > diff --git a/rust/kernel/dma.rs b/rust/kernel/dma.rs > index a33261c62e0c..666bf2d64f9a 100644 > --- a/rust/kernel/dma.rs > +++ b/rust/kernel/dma.rs > @@ -186,7 +186,7 @@ pub fn alloc_attrs( > dev: dev.into(), > dma_handle, > count, > - cpu_addr: ret as *mut T, > + cpu_addr: ret.cast::(), > dma_attrs, > }) > } > @@ -293,7 +293,7 @@ fn drop(&mut self) { > bindings::dma_free_attrs( > self.dev.as_raw(), > size, > - self.cpu_addr as _, > + self.cpu_addr.cast(), > self.dma_handle, > self.dma_attrs.as_raw(), > ) > diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs > index 3dee3139fcd4..afcb00cb6a75 100644 > --- a/rust/kernel/error.rs > +++ b/rust/kernel/error.rs > @@ -153,7 +153,7 @@ pub(crate) fn to_blk_status(self) -> bindings::blk_st= atus_t { > /// Returns the error encoded as a pointer. > pub fn to_ptr(self) -> *mut T { > // SAFETY: `self.0` is a valid error due to its invariant. > - unsafe { bindings::ERR_PTR(self.0.get() as _) as *mut _ } > + unsafe { bindings::ERR_PTR(self.0.get() as _).cast() } > } > > /// Returns a string representing the error, if one exists. > diff --git a/rust/kernel/firmware.rs b/rust/kernel/firmware.rs > index 2494c96e105f..94fa1ea17ef0 100644 > --- a/rust/kernel/firmware.rs > +++ b/rust/kernel/firmware.rs > @@ -62,10 +62,11 @@ impl Firmware { > fn request_internal(name: &CStr, dev: &Device, func: FwFunc) -> Resu= lt { > let mut fw: *mut bindings::firmware =3D core::ptr::null_mut(); > let pfw: *mut *mut bindings::firmware =3D &mut fw; > + let pfw: *mut *const bindings::firmware =3D pfw.cast(); > > // SAFETY: `pfw` is a valid pointer to a NULL initialized `bindi= ngs::firmware` pointer. > // `name` and `dev` are valid as by their type invariants. > - let ret =3D unsafe { func.0(pfw as _, name.as_char_ptr(), dev.as= _raw()) }; > + let ret =3D unsafe { func.0(pfw, name.as_char_ptr(), dev.as_raw(= )) }; > if ret !=3D 0 { > return Err(Error::from_errno(ret)); > } > diff --git a/rust/kernel/fs/file.rs b/rust/kernel/fs/file.rs > index 72d84fb0e266..e9bfbad00755 100644 > --- a/rust/kernel/fs/file.rs > +++ b/rust/kernel/fs/file.rs > @@ -366,7 +366,7 @@ fn deref(&self) -> &LocalFile { > // > // By the type invariants, there are no `fdget_pos` calls that d= id not take the > // `f_pos_lock` mutex. > - unsafe { LocalFile::from_raw_file(self as *const File as *const = bindings::file) } > + unsafe { LocalFile::from_raw_file((self as *const Self).cast()) = } > } > } > > diff --git a/rust/kernel/kunit.rs b/rust/kernel/kunit.rs > index 4b8cdcb21e77..6930e86d98a9 100644 > --- a/rust/kernel/kunit.rs > +++ b/rust/kernel/kunit.rs > @@ -9,6 +9,9 @@ > use crate::prelude::*; > use core::{ffi::c_void, fmt}; > > +#[cfg(CONFIG_PRINTK)] > +use crate::c_str; > + > /// Prints a KUnit error-level message. > /// > /// Public but hidden since it should only be used from KUnit generated = code. > @@ -19,8 +22,8 @@ pub fn err(args: fmt::Arguments<'_>) { > #[cfg(CONFIG_PRINTK)] > unsafe { > bindings::_printk( > - c"\x013%pA".as_ptr() as _, > - &args as *const _ as *const c_void, > + c_str!("\x013%pA").as_char_ptr(), > + core::ptr::from_ref(&args).cast::(), > ); > } > } > @@ -35,8 +38,8 @@ pub fn info(args: fmt::Arguments<'_>) { > #[cfg(CONFIG_PRINTK)] > unsafe { > bindings::_printk( > - c"\x016%pA".as_ptr() as _, > - &args as *const _ as *const c_void, > + c_str!("\x016%pA").as_char_ptr(), > + core::ptr::from_ref(&args).cast::(), > ); > } > } > diff --git a/rust/kernel/list/impl_list_item_mod.rs b/rust/kernel/list/im= pl_list_item_mod.rs > index a0438537cee1..1f9498c1458f 100644 > --- a/rust/kernel/list/impl_list_item_mod.rs > +++ b/rust/kernel/list/impl_list_item_mod.rs > @@ -34,7 +34,7 @@ pub unsafe trait HasListLinks { > unsafe fn raw_get_list_links(ptr: *mut Self) -> *mut ListLinks { > // SAFETY: The caller promises that the pointer is valid. The im= plementer promises that the > // `OFFSET` constant is correct. > - unsafe { (ptr as *mut u8).add(Self::OFFSET) as *mut ListLinks } > + unsafe { ptr.cast::().add(Self::OFFSET).cast() } > } > } > > diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs > index 8435f8132e38..33ae0bdc433d 100644 > --- a/rust/kernel/pci.rs > +++ b/rust/kernel/pci.rs > @@ -78,7 +78,7 @@ extern "C" fn probe_callback( > // Let the `struct pci_dev` own a reference of the drive= r's private data. > // SAFETY: By the type invariant `pdev.as_raw` returns a= valid pointer to a > // `struct pci_dev`. > - unsafe { bindings::pci_set_drvdata(pdev.as_raw(), data.i= nto_foreign() as _) }; > + unsafe { bindings::pci_set_drvdata(pdev.as_raw(), data.i= nto_foreign().cast()) }; > } > Err(err) =3D> return Error::to_errno(err), > } > diff --git a/rust/kernel/platform.rs b/rust/kernel/platform.rs > index 5b21fa517e55..4b06f9fbc172 100644 > --- a/rust/kernel/platform.rs > +++ b/rust/kernel/platform.rs > @@ -69,7 +69,9 @@ extern "C" fn probe_callback(pdev: *mut bindings::platf= orm_device) -> kernel::ff > // Let the `struct platform_device` own a reference of t= he driver's private data. > // SAFETY: By the type invariant `pdev.as_raw` returns a= valid pointer to a > // `struct platform_device`. > - unsafe { bindings::platform_set_drvdata(pdev.as_raw(), d= ata.into_foreign() as _) }; > + unsafe { > + bindings::platform_set_drvdata(pdev.as_raw(), data.i= nto_foreign().cast()) > + }; > } > Err(err) =3D> return Error::to_errno(err), > } > diff --git a/rust/kernel/print.rs b/rust/kernel/print.rs > index 9783d960a97a..ecdcee43e5a5 100644 > --- a/rust/kernel/print.rs > +++ b/rust/kernel/print.rs > @@ -25,7 +25,7 @@ > // SAFETY: The C contract guarantees that `buf` is valid if it's les= s than `end`. > let mut w =3D unsafe { RawFormatter::from_ptrs(buf.cast(), end.cast(= )) }; > // SAFETY: TODO. > - let _ =3D w.write_fmt(unsafe { *(ptr as *const fmt::Arguments<'_>) }= ); > + let _ =3D w.write_fmt(unsafe { *ptr.cast::>() }); > w.pos().cast() > } > > @@ -109,7 +109,7 @@ pub unsafe fn call_printk( > bindings::_printk( > format_string.as_ptr(), > module_name.as_ptr(), > - &args as *const _ as *const c_void, > + core::ptr::from_ref(&args).cast::(), > ); > } > } > @@ -129,7 +129,7 @@ pub fn call_printk_cont(args: fmt::Arguments<'_>) { > unsafe { > bindings::_printk( > format_strings::CONT.as_ptr(), > - &args as *const _ as *const c_void, > + core::ptr::from_ref(&args).cast::(), > ); > } > } > diff --git a/rust/kernel/seq_file.rs b/rust/kernel/seq_file.rs > index 7a9403eb6e5b..8f199b1a3bb1 100644 > --- a/rust/kernel/seq_file.rs > +++ b/rust/kernel/seq_file.rs > @@ -37,7 +37,7 @@ pub fn call_printf(&self, args: core::fmt::Arguments<'_= >) { > bindings::seq_printf( > self.inner.get(), > c_str!("%pA").as_char_ptr(), > - &args as *const _ as *const crate::ffi::c_void, > + core::ptr::from_ref(&args).cast::(), > ); > } > } > diff --git a/rust/kernel/str.rs b/rust/kernel/str.rs > index a927db8e079c..6a3cb607b332 100644 > --- a/rust/kernel/str.rs > +++ b/rust/kernel/str.rs > @@ -237,7 +237,7 @@ pub unsafe fn from_char_ptr<'a>(ptr: *const crate::ff= i::c_char) -> &'a Self { > // to a `NUL`-terminated C string. > let len =3D unsafe { bindings::strlen(ptr) } + 1; > // SAFETY: Lifetime guaranteed by the safety precondition. > - let bytes =3D unsafe { core::slice::from_raw_parts(ptr as _, len= ) }; > + let bytes =3D unsafe { core::slice::from_raw_parts(ptr.cast(), l= en) }; > // SAFETY: As `len` is returned by `strlen`, `bytes` does not co= ntain interior `NUL`. > // As we have added 1 to `len`, the last byte is known to be `NU= L`. > unsafe { Self::from_bytes_with_nul_unchecked(bytes) } > diff --git a/rust/kernel/sync/poll.rs b/rust/kernel/sync/poll.rs > index d7e6e59e124b..339ab6097be7 100644 > --- a/rust/kernel/sync/poll.rs > +++ b/rust/kernel/sync/poll.rs > @@ -73,7 +73,7 @@ pub fn register_wait(&mut self, file: &File, cv: &PollC= ondVar) { > // be destroyed, the destructor must run. That destructor fi= rst removes all waiters, > // and then waits for an rcu grace period. Therefore, `cv.wa= it_queue_head` is valid for > // long enough. > - unsafe { qproc(file.as_ptr() as _, cv.wait_queue_head.get(),= self.0.get()) }; > + unsafe { qproc(file.as_ptr().cast(), cv.wait_queue_head.get(= ), self.0.get()) }; > } > } > } > diff --git a/rust/kernel/time/hrtimer/pin.rs b/rust/kernel/time/hrtimer/p= in.rs > index 293ca9cf058c..2f29fd75d63a 100644 > --- a/rust/kernel/time/hrtimer/pin.rs > +++ b/rust/kernel/time/hrtimer/pin.rs > @@ -79,7 +79,7 @@ impl<'a, T> RawHrTimerCallback for Pin<&'a T> > > unsafe extern "C" fn run(ptr: *mut bindings::hrtimer) -> bindings::h= rtimer_restart { > // `HrTimer` is `repr(C)` > - let timer_ptr =3D ptr as *mut HrTimer; > + let timer_ptr =3D ptr.cast::>(); > > // SAFETY: By the safety requirement of this function, `timer_pt= r` > // points to a `HrTimer` contained in an `T`. > diff --git a/rust/kernel/time/hrtimer/pin_mut.rs b/rust/kernel/time/hrtim= er/pin_mut.rs > index 6033572d35ad..d05d68be55e9 100644 > --- a/rust/kernel/time/hrtimer/pin_mut.rs > +++ b/rust/kernel/time/hrtimer/pin_mut.rs > @@ -83,7 +83,7 @@ impl<'a, T> RawHrTimerCallback for Pin<&'a mut T> > > unsafe extern "C" fn run(ptr: *mut bindings::hrtimer) -> bindings::h= rtimer_restart { > // `HrTimer` is `repr(C)` > - let timer_ptr =3D ptr as *mut HrTimer; > + let timer_ptr =3D ptr.cast::>(); > > // SAFETY: By the safety requirement of this function, `timer_pt= r` > // points to a `HrTimer` contained in an `T`. > diff --git a/rust/kernel/workqueue.rs b/rust/kernel/workqueue.rs > index d092112d843f..de61374e36bd 100644 > --- a/rust/kernel/workqueue.rs > +++ b/rust/kernel/workqueue.rs > @@ -170,7 +170,7 @@ impl Queue { > pub unsafe fn from_raw<'a>(ptr: *const bindings::workqueue_struct) -= > &'a Queue { > // SAFETY: The `Queue` type is `#[repr(transparent)]`, so the po= inter cast is valid. The > // caller promises that the pointer is not dangling. > - unsafe { &*(ptr as *const Queue) } > + unsafe { &*ptr.cast::() } > } > > /// Enqueues a work item. > @@ -522,7 +522,7 @@ unsafe impl WorkItemPointer for= Arc > { > unsafe extern "C" fn run(ptr: *mut bindings::work_struct) { > // The `__enqueue` method always uses a `work_struct` stored in = a `Work`. > - let ptr =3D ptr as *mut Work; > + let ptr =3D ptr.cast::>(); > // SAFETY: This computes the pointer that `__enqueue` got from `= Arc::into_raw`. > let ptr =3D unsafe { T::work_container_of(ptr) }; > // SAFETY: This pointer comes from `Arc::into_raw` and we've bee= n given back ownership. > @@ -575,7 +575,7 @@ unsafe impl WorkItemPointer for= Pin> > { > unsafe extern "C" fn run(ptr: *mut bindings::work_struct) { > // The `__enqueue` method always uses a `work_struct` stored in = a `Work`. > - let ptr =3D ptr as *mut Work; > + let ptr =3D ptr.cast::>(); > // SAFETY: This computes the pointer that `__enqueue` got from `= Arc::into_raw`. > let ptr =3D unsafe { T::work_container_of(ptr) }; > // SAFETY: This pointer comes from `Arc::into_raw` and we've bee= n given back ownership. > diff --git a/rust/uapi/lib.rs b/rust/uapi/lib.rs > index c98d7a8cde77..e79a1f49f055 100644 > --- a/rust/uapi/lib.rs > +++ b/rust/uapi/lib.rs > @@ -14,6 +14,7 @@ > #![cfg_attr(test, allow(unsafe_op_in_unsafe_fn))] > #![allow( > clippy::all, > + clippy::ptr_as_ptr, > clippy::undocumented_unsafe_blocks, > dead_code, > missing_docs, > > -- > 2.49.0 >