From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f200.google.com (mail-io0-f200.google.com [209.85.223.200]) by kanga.kvack.org (Postfix) with ESMTP id E6B396B02FA for ; Wed, 17 May 2017 13:23:45 -0400 (EDT) Received: by mail-io0-f200.google.com with SMTP id p24so12275290ioi.8 for ; Wed, 17 May 2017 10:23:45 -0700 (PDT) Received: from mail-it0-x244.google.com (mail-it0-x244.google.com. [2607:f8b0:4001:c0b::244]) by mx.google.com with ESMTPS id y126si2834234iof.59.2017.05.17.10.23.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 May 2017 10:23:45 -0700 (PDT) Received: by mail-it0-x244.google.com with SMTP id d68so2198799ita.1 for ; Wed, 17 May 2017 10:23:44 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20170517133842.5733-1-mdeguzis@gmail.com> From: mikey d Date: Wed, 17 May 2017 13:23:44 -0400 Message-ID: Subject: Re: [PATCH] Correct spelling and grammar for notification text Content-Type: multipart/alternative; boundary="001a11419bfae44883054fbb8ce5" Sender: owner-linux-mm@kvack.org List-ID: To: Randy Dunlap Cc: linux-mm@kvack.org, trivial@kernel.org --001a11419bfae44883054fbb8ce5 Content-Type: text/plain; charset="UTF-8" V2 incoming soon. My first patch :) On May 17, 2017 11:35, "Randy Dunlap" wrote: > On 05/17/17 06:38, Michael DeGuzis wrote: > > From: professorkaos64 > > > > This patch fixes up some grammar and spelling in the information > > block for huge_memory.c. > > Missing Signed-off-by: > > > --- > > mm/huge_memory.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index a84909cf20d3..af137fc0ca09 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > @@ -38,12 +38,12 @@ > > #include "internal.h" > > > > /* > > - * By default transparent hugepage support is disabled in order that > avoid > > - * to risk increase the memory footprint of applications without a > guaranteed > > - * benefit. When transparent hugepage support is enabled, is for all > mappings, > > - * and khugepaged scans all mappings. > > + * By default, transparent hugepage support is disabled in order to > avoid > > + * risking an increased memory footprint for applications that are not > > + * guaranteed to benefit from it. When transparent hugepage support is > > + * enabled, it is for all mappings, and khugepaged scans all mappings. > > * Defrag is invoked by khugepaged hugepage allocations and by page > faults > > - * for all hugepage allocations. > > + * for all hugepage allocations. > > Several of the new (+) patch lines end with a space character. Not good. > > > */ > > unsigned long transparent_hugepage_flags __read_mostly = > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS > > > > > -- > ~Randy > --001a11419bfae44883054fbb8ce5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
V2 incoming soon. My first patch :)=C2=A0

On May 17, 2017 11:35, &quo= t;Randy Dunlap" <rdunlap@i= nfradead.org> wrote:
On 05/17/17 06:38, Michael DeGuzis wrote:
> From: professorkaos64 <mdeguz= is@gmail.com>
>
> This patch fixes up some grammar and spelling in the information
> block for huge_memory.c.

Missing Signed-off-by: <real name and email address>

> ---
>=C2=A0 mm/huge_memory.c | 10 +++++-----
>=C2=A0 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index a84909cf20d3..af137fc0ca09 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -38,12 +38,12 @@
>=C2=A0 #include "internal.h"
>
>=C2=A0 /*
> - * By default transparent hugepage support is disabled in order that = avoid
> - * to risk increase the memory footprint of applications without a gu= aranteed
> - * benefit. When transparent hugepage support is enabled, is for all = mappings,
> - * and khugepaged scans all mappings.
> + * By default, transparent hugepage support is disabled in order to a= void
> + * risking an increased memory footprint for applications that are no= t
> + * guaranteed to benefit from it. When transparent hugepage support i= s
> + * enabled, it is for all mappings, and khugepaged scans all mappings= .
>=C2=A0 =C2=A0* Defrag is invoked by khugepaged hugepage allocations and= by page faults
> - * for all hugepage allocations.
> + * for all hugepage allocations.

Several of the new (+) patch lines end with a space character. Not good.
>=C2=A0 =C2=A0*/
>=C2=A0 unsigned long transparent_hugepage_flags __read_mostly =3D
>=C2=A0 #ifdef CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS
>


--
~Randy
--001a11419bfae44883054fbb8ce5-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org