From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx108.postini.com [74.125.245.108]) by kanga.kvack.org (Postfix) with SMTP id 19CE56B004A for ; Tue, 13 Mar 2012 22:23:40 -0400 (EDT) Received: by vcbfk14 with SMTP id fk14so1921404vcb.14 for ; Tue, 13 Mar 2012 19:23:39 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1331617001-20906-1-git-send-email-apenwarr@gmail.com> <1331617001-20906-5-git-send-email-apenwarr@gmail.com> From: Avery Pennarun Date: Tue, 13 Mar 2012 22:23:18 -0400 Message-ID: Subject: Re: [PATCH 4/5] printk: use alloc_bootmem() instead of memblock_alloc(). Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Yinghai Lu Cc: Andrew Morton , Josh Triplett , "Paul E. McKenney" , Ingo Molnar , "David S. Miller" , Peter Zijlstra , "Fabio M. Di Nitto" , Johannes Weiner , Olaf Hering , Paul Gortmaker , Tejun Heo , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Tue, Mar 13, 2012 at 5:50 PM, Yinghai Lu wrote: > Now you put back bootmem calling early, will cause confusion. [...] > we should use adding memblock_alloc calling instead... go backward... Okay, I'm convinced. I've updated my series so CONFIG_PRINTK_PERSIST only works with HAVE_MEMBLOCK, and I've removed the patch to unconditionally call bootmem in the existing non-PRINTK_PERSIST case. (I'll upload the patches later once the other threads play out.) Thanks for the quick feedback! Avery -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org