From: Avery Pennarun <apenwarr@gmail.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Josh Triplett <josh@joshtriplett.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Ingo Molnar <mingo@elte.hu>,
"David S. Miller" <davem@davemloft.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
"Fabio M. Di Nitto" <fdinitto@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Olaf Hering <olaf@aepfle.de>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Tejun Heo <tj@kernel.org>, "H. Peter Anvin" <hpa@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 4/5] printk: use alloc_bootmem() instead of memblock_alloc().
Date: Tue, 13 Mar 2012 22:23:18 -0400 [thread overview]
Message-ID: <CAHqTa-3p1sS1QvT3bg4UAo9G8Hq+-PJsSxBAz_P8pf+tdEOq4Q@mail.gmail.com> (raw)
In-Reply-To: <CAE9FiQVkn_jHhdFfDg_zvJJuZci+kvOd6NSfL4aSc_GP=hiOWw@mail.gmail.com>
On Tue, Mar 13, 2012 at 5:50 PM, Yinghai Lu <yinghai@kernel.org> wrote:
> Now you put back bootmem calling early, will cause confusion.
[...]
> we should use adding memblock_alloc calling instead... go backward...
Okay, I'm convinced. I've updated my series so CONFIG_PRINTK_PERSIST
only works with HAVE_MEMBLOCK, and I've removed the patch to
unconditionally call bootmem in the existing non-PRINTK_PERSIST case.
(I'll upload the patches later once the other threads play out.)
Thanks for the quick feedback!
Avery
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-03-14 2:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 5:36 [PATCH 0/5] Persist printk buffer across reboots Avery Pennarun
2012-03-13 5:36 ` [PATCH 1/5] mm: bootmem: BUG() if you try to allocate bootmem too late Avery Pennarun
2012-03-13 5:36 ` [PATCH 2/5] mm: bootmem: it's okay to reserve_bootmem an invalid address Avery Pennarun
2012-03-13 5:36 ` [PATCH 3/5] mm: nobootmem: implement reserve_bootmem() in terms of memblock Avery Pennarun
2012-03-13 5:36 ` [PATCH 4/5] printk: use alloc_bootmem() instead of memblock_alloc() Avery Pennarun
2012-03-13 6:13 ` Yinghai Lu
2012-03-13 6:40 ` Avery Pennarun
2012-03-13 8:26 ` Ingo Molnar
2012-03-13 21:50 ` Yinghai Lu
2012-03-14 2:23 ` Avery Pennarun [this message]
2012-03-13 5:36 ` [PATCH 5/5] printk: CONFIG_PRINTK_PERSIST: persist printk buffer across reboots Avery Pennarun
2012-03-13 5:53 ` [PATCH 0/5] Persist " David Miller
2012-03-13 6:00 ` Avery Pennarun
2012-03-13 6:50 ` David Miller
2012-03-13 7:14 ` Avery Pennarun
2012-03-13 7:18 ` David Miller
2012-03-13 8:10 ` Avery Pennarun
2012-03-13 8:16 ` David Miller
2012-03-13 13:50 ` Peter Zijlstra
2012-03-14 1:57 ` Daniel Walker
2012-03-13 8:32 ` Stephen Boyd
2012-03-13 17:08 ` Daniel Walker
2012-03-13 22:10 ` Andrew Morton
2012-03-14 2:19 ` Daniel Walker
2012-03-15 22:10 ` Seiji Aguchi
2012-03-14 2:21 ` Avery Pennarun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHqTa-3p1sS1QvT3bg4UAo9G8Hq+-PJsSxBAz_P8pf+tdEOq4Q@mail.gmail.com \
--to=apenwarr@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=fdinitto@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=hpa@linux.intel.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=olaf@aepfle.de \
--cc=paul.gortmaker@windriver.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tj@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox