From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D1D0C00140 for ; Wed, 10 Aug 2022 21:32:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 193438E0002; Wed, 10 Aug 2022 17:32:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 11C298E0001; Wed, 10 Aug 2022 17:32:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED7798E0002; Wed, 10 Aug 2022 17:32:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D8CDD8E0001 for ; Wed, 10 Aug 2022 17:32:25 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9E95C1A0249 for ; Wed, 10 Aug 2022 21:32:25 +0000 (UTC) X-FDA: 79784981850.11.7794E06 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by imf18.hostedemail.com (Postfix) with ESMTP id 37CE51C0174 for ; Wed, 10 Aug 2022 21:32:25 +0000 (UTC) Received: by mail-ot1-f48.google.com with SMTP id x1-20020a056830278100b00636774b0e54so11479344otu.4 for ; Wed, 10 Aug 2022 14:32:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=m7O12mtRE9TkWg6wBbyGMp67dOvzpuyVtE/CzOg3fqw=; b=Jk54ci7PSY7tdCzqgeSF9+5dbF3gz0NvJ7ApJm97a2vB99DU4S2dySkCHFIX7h1lUv qtLscUGfFOR5J85EiDuL8AEmG3pHGuyaUbZ1TSjBDYFyvYTRzaVnaQefNwzKOeyBlVKv y/9OHgIdjhAqIo0YEwSfA/QGcY3kEvwWoNaEwc8ZkNoTw9WE+tjnxEC69AgU1jWZw2iP m7VjmGqF3ePAgocQVKL8QJFVVqfCS8AUwzIOuyqtAlSJZXaY6NEx45JsOVac7hZMXMg/ 1LUjz7D1rXJwdYh+rjh/Vgfn31+6bGrISFPiWvNVSCyzZYx0ZWDkQplfDvFe7vkr1Sqg evfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=m7O12mtRE9TkWg6wBbyGMp67dOvzpuyVtE/CzOg3fqw=; b=Ael2+wJ4OZaTpLv9YYy+WIZIDm8C97A7BokdnqVYzn26yIGe4BhYRiXucBh7gt1olQ i34KCZGtclU4QF6KQ/4Xe2+19NfRFM8JmFT04xWJACburgfKGtB1ThiHUs2LNTeVCKf7 jcq5uaBtrTRRyfC7EbpD2Ib25KmYqFUP06aVhMLePb+IxM61d5t7swt/YaF/gyEjwEuC xEgsaDWihudWJLnc5pEhms0koo4ItwPsyQTxv0MIdg6QI7wuq432MIfTSYY7tLa/lRpT 2k5LSTPSIsQVNjA3kMCcLOphTIwnzAU+vrcWUtnrLxTQgOmYRlNQrGakB7M2Wlo8xC3U TYiQ== X-Gm-Message-State: ACgBeo05TAn/OF9af3vUcOSJIl98U5+UGBn3HYPqaz1eDDsVZJDkdK/4 nBT5qzj+GwoFAoXjqnArL1tbun30qFE21kXepEc= X-Google-Smtp-Source: AA6agR5WI4LfxUaJ5EfyY3qi3PgJRxGO7G3AYltcG2S84baL4CCgM+/v/VC+ix3GmYp1IOK0IPYYQDO5aJHqzAN+vDM= X-Received: by 2002:a05:6830:6388:b0:61c:80a9:d5b6 with SMTP id ch8-20020a056830638800b0061c80a9d5b6mr11139969otb.124.1660167144427; Wed, 10 Aug 2022 14:32:24 -0700 (PDT) MIME-Version: 1.0 References: <20220719041311.709250-1-hch@lst.de> <20220728111016.uwbaywprzkzne7ib@quack3> <20220729092216.GE3493@suse.de> <20220729141145.GA31605@lst.de> In-Reply-To: From: =?UTF-8?Q?Andreas_Gr=C3=BCnbacher?= Date: Wed, 10 Aug 2022 23:32:06 +0200 Message-ID: Subject: Re: remove iomap_writepage v2 To: Matthew Wilcox Cc: Johannes Weiner , Christoph Hellwig , Mel Gorman , Jan Kara , Bob Peterson , Andreas Gruenbacher , "Darrick J. Wong" , Damien Le Moal , Naohiro Aota , Vlastimil Babka , Johannes Thumshirn , cluster-devel , linux-xfs , Linux FS-devel Mailing List , Linux-MM Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660167145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m7O12mtRE9TkWg6wBbyGMp67dOvzpuyVtE/CzOg3fqw=; b=6bTdJkNZfKkHSlwCeerGcc8dB/bduYnpxL3qg2iWTfKe2acyQsFQnQ0cUXZDxrlrff0alX UjF/280dpteaDHx7xbp7o0tZu+1Uhw+5SITbjGYJzma6ByZO0EwsUday8Uq5fVJje2jYEh t7lYaNnTEmtxpBB8TojZ9SLgwx1BpxY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Jk54ci7P; spf=pass (imf18.hostedemail.com: domain of andreas.gruenbacher@gmail.com designates 209.85.210.48 as permitted sender) smtp.mailfrom=andreas.gruenbacher@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660167145; a=rsa-sha256; cv=none; b=I+FFNIs5ZFEaPotZWnZ3SH8LIw+o24HiTpLzgH7rCiRVpvw4Upf3iOwOD2HrjM1LKpdjKA DMKoIi7NSxlqXz4KvFlZz2wSx7vNp7YcdrjmMvYtoub4W743Fwe0BrHQ4Bttv1zOHLLK/J 6fQUwLktlZ9uBsBkK9RBWb2vGfc4uLw= X-Stat-Signature: ueroq9a4nnhp69mhxj4r9rtuftfwu4kh X-Rspamd-Queue-Id: 37CE51C0174 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Jk54ci7P; spf=pass (imf18.hostedemail.com: domain of andreas.gruenbacher@gmail.com designates 209.85.210.48 as permitted sender) smtp.mailfrom=andreas.gruenbacher@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1660167145-440209 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Am Mi., 10. Aug. 2022 um 22:57 Uhr schrieb Matthew Wilcox : > On Mon, Aug 01, 2022 at 11:31:50AM -0400, Johannes Weiner wrote: > > XFS hasn't had a ->writepage call for a while. After LSF I internally > > tested dropping btrfs' callback, and the results looked good: no OOM > > kills with dirty/writeback pages remaining, performance parity. Then I > > went on vacation and Christoph beat me to the patch :) > > To avoid duplicating work with you or Christoph ... it seems like the > plan is to kill ->writepage entirely soon, so there's no point in me > doing a sweep of all the filesystems to convert ->writepage to > ->write_folio, correct? > > I assume the plan for filesystems which have a writepage but don't have > a ->writepages (9p, adfs, affs, bfs, ecryptfs, gfs2, hostfs, jfs, minix, > nilfs2, ntfs, ocfs2, reiserfs, sysv, ubifs, udf, ufs, vboxsf) is to give > them a writepages, modelled on iomap_writepages(). Seems that adding > a block_writepages() might be a useful thing for me to do? Hmm, gfs2 does have gfs2_writepages() and gfs2_jdata_writepages() functions, so it should probably be fine. Thanks, Andreas