From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91BB3C433E1 for ; Tue, 7 Jul 2020 11:38:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 573FE206F6 for ; Tue, 7 Jul 2020 11:38:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JirTA1Rl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 573FE206F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D5BCA8D000A; Tue, 7 Jul 2020 07:38:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0C576B008A; Tue, 7 Jul 2020 07:38:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C22658D000A; Tue, 7 Jul 2020 07:38:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0077.hostedemail.com [216.40.44.77]) by kanga.kvack.org (Postfix) with ESMTP id AF7796B0087 for ; Tue, 7 Jul 2020 07:38:14 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2F5CF1EE6 for ; Tue, 7 Jul 2020 11:38:14 +0000 (UTC) X-FDA: 77011081308.15.bun32_25066d626eb4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id F1C5D1814B0C8 for ; Tue, 7 Jul 2020 11:38:13 +0000 (UTC) X-HE-Tag: bun32_25066d626eb4 X-Filterd-Recvd-Size: 4760 Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Jul 2020 11:38:13 +0000 (UTC) Received: by mail-il1-f193.google.com with SMTP id t27so30709518ill.9 for ; Tue, 07 Jul 2020 04:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1+9PXsEHC8Tau1MQTySeSJIu15QBhP57I+JN1uapBu0=; b=JirTA1RlvJAlDXxssPiBjYAQw8/IAQxOLQXqoDRmUr5Q7eXEI05rN0ZCnBmWsZzbFe Fse1fi06L+PCjopdbPPnGNT1QeQojO3coqU1ja8XSjRjF03hlXmzC0GLIWJUCIhcm3yk nexkBSFm9tW9pjzicOY0yEmXy+WBwvcexBGHnjSkhPXZDAx3P2pkRwd5xKSEENjE1Alf /1Yf7FdVFHCXNGYnUEcg0LUccx2gPlnuBsZkwpRz7lZ661siGnnxrpYu/I5r8bEADam2 6S/vUj52Ak5EkHTaIEoaCCDdPgdGT6/tL9DFm402FNQaW5itQi11KgZOCG3mUTv8/4uC Sehw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1+9PXsEHC8Tau1MQTySeSJIu15QBhP57I+JN1uapBu0=; b=o2PSoIQDffCZ6PadXgNv2Fdtrkgio1GR/LeK7jnhucwe8oUhBxdIYSRMeYchZ1d5M1 qKiJIQB1USXEc2TWaMU2r3C/8gTdnEiW9asI/nizuU9M9oWek3qNSJucv6J8/SNnnjFn AMWDnOPZ46yva/8oegDeo0ScQrbeC+SK1JXeLKyuBijWADAOJZWFYHK3I9uRkqK0aLM7 r/TpJA6UmQ9BfpS0xN+gL0pdidvIu623qEiLgtT2yxQ4A5yO5iFt33NTX4PS3Vtmpxj3 4LgxYFvWVvVbQS/su0hjZRoHpyxY8HOt9aZmkDgF0m9pAkl/kqGH9yVQPRI7TL38l3dt Ez3g== X-Gm-Message-State: AOAM530XcbnP4bJO3rSKiLJgyRB5vA30psodIacDGW0i5MwSCDsiu+bJ PPndQRLlqmBXlrpcnT9+DukNrIPWPlvqGJ1GAR0= X-Google-Smtp-Source: ABdhPJyLy71kFINoMC1IHKN/W9Wzb6/SH2hqLTyUZVHsX7LIVZCqyVklNgrjn7GmuSwIHTTceD6R3Lnu4FTNFB1XILg= X-Received: by 2002:a92:c7ab:: with SMTP id f11mr36287094ilk.50.1594121892966; Tue, 07 Jul 2020 04:38:12 -0700 (PDT) MIME-Version: 1.0 References: <20200618144355.17324-1-axboe@kernel.dk> <20200618144355.17324-6-axboe@kernel.dk> <20200624010253.GB5369@dread.disaster.area> <20200624014645.GJ21350@casper.infradead.org> <70b0427c-7303-8f45-48bd-caa0562a2951@kernel.dk> <20200624164127.GP21350@casper.infradead.org> <8835b6f2-b3c5-c9a0-2119-1fb161cf87dd@kernel.dk> In-Reply-To: <8835b6f2-b3c5-c9a0-2119-1fb161cf87dd@kernel.dk> From: =?UTF-8?Q?Andreas_Gr=C3=BCnbacher?= Date: Tue, 7 Jul 2020 13:38:01 +0200 Message-ID: Subject: Re: [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set To: Jens Axboe Cc: Matthew Wilcox , Dave Chinner , io-uring@vger.kernel.org, Linux FS-devel Mailing List , Linux Kernel Mailing List , Linux-MM , Andrew Morton , Johannes Weiner Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: F1C5D1814B0C8 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Am Mi., 24. Juni 2020 um 18:48 Uhr schrieb Jens Axboe : > > On 6/24/20 10:41 AM, Matthew Wilcox wrote: > > On Wed, Jun 24, 2020 at 09:35:19AM -0600, Jens Axboe wrote: > >> On 6/24/20 9:00 AM, Jens Axboe wrote: > >>> On 6/23/20 7:46 PM, Matthew Wilcox wrote: > >>>> I'd be quite happy to add a gfp_t to struct readahead_control. > >>>> The other thing I've been looking into for other reasons is adding > >>>> a memalloc_nowait_{save,restore}, which would avoid passing down > >>>> the gfp_t. > >>> > >>> That was my first thought, having the memalloc_foo_save/restore for > >>> this. I don't think adding a gfp_t to readahead_control is going > >>> to be super useful, seems like the kind of thing that should be > >>> non-blocking by default. > >> > >> We're already doing memalloc_nofs_save/restore in > >> page_cache_readahead_unbounded(), so I think all we need is to just do a > >> noio dance in generic_file_buffered_read() and that should be enough. > > > > I think we can still sleep though, right? I was thinking more > > like this: > > > > http://git.infradead.org/users/willy/linux.git/shortlog/refs/heads/memalloc > > Yeah, that's probably better. How do we want to handle this? I've already > got the other bits queued up. I can either add them to the series, or > pull a branch that'll go into Linus as well. Also note my conflicting patch that introduces a IOCB_NOIO flag for fixing a gfs2 regression: https://lore.kernel.org/linux-fsdevel/20200703095325.1491832-2-agruenba@redhat.com/ Thanks, Andreas