From: "Andreas Grünbacher" <andreas.gruenbacher@gmail.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Steven Whitehouse <swhiteho@redhat.com>,
Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
Linux-MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Johannes Weiner <hannes@cmpxchg.org>,
cluster-devel <cluster-devel@redhat.com>,
Ronnie Sahlberg <lsahlber@redhat.com>,
Steve French <sfrench@samba.org>,
Bob Peterson <rpeterso@redhat.com>
Subject: Re: [RFC PATCH 3/3] gfs2: Rework read and page fault locking
Date: Tue, 26 Nov 2019 10:08:12 +0100 [thread overview]
Message-ID: <CAHpGcMJO_bzsc+9Ta7VoKkszR2_v1BqqBZ4=7re=j7OxcX-R1w@mail.gmail.com> (raw)
In-Reply-To: <20191125091508.3265wtfzpoupv2lj@box>
Am Mo., 25. Nov. 2019 um 10:16 Uhr schrieb Kirill A. Shutemov
<kirill@shutemov.name>:
> On Sat, Nov 23, 2019 at 12:53:24AM +0100, Andreas Gruenbacher wrote:
> > @@ -778,15 +804,51 @@ static ssize_t gfs2_file_direct_write(struct kiocb *iocb, struct iov_iter *from)
> >
> > static ssize_t gfs2_file_read_iter(struct kiocb *iocb, struct iov_iter *to)
> > {
> > + struct gfs2_inode *ip;
> > + struct gfs2_holder gh;
> > + size_t written = 0;
>
> 'written' in a read routine?
It's a bit weird, but it's the same as in generic_file_buffered_read.
> --
> Kirill A. Shutemov
Thanks,
Andreas
next prev parent reply other threads:[~2019-11-26 9:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 23:53 [RFC PATCH 0/3] Rework the gfs2 " Andreas Gruenbacher
2019-11-22 23:53 ` [RFC PATCH 1/3] fs: Add IOCB_CACHED flag for generic_file_read_iter Andreas Gruenbacher
2019-11-22 23:53 ` [RFC PATCH 2/3] fs: Add FAULT_FLAG_CACHED flag for filemap_fault Andreas Gruenbacher
2019-11-22 23:53 ` [RFC PATCH 3/3] gfs2: Rework read and page fault locking Andreas Gruenbacher
2019-11-25 9:15 ` Kirill A. Shutemov
2019-11-26 9:08 ` Andreas Grünbacher [this message]
2019-11-25 9:17 ` [RFC PATCH 0/3] Rework the gfs2 " Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHpGcMJO_bzsc+9Ta7VoKkszR2_v1BqqBZ4=7re=j7OxcX-R1w@mail.gmail.com' \
--to=andreas.gruenbacher@gmail.com \
--cc=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cluster-devel@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=khlebnikov@yandex-team.ru \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lsahlber@redhat.com \
--cc=rpeterso@redhat.com \
--cc=sfrench@samba.org \
--cc=swhiteho@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox