From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f198.google.com (mail-wr0-f198.google.com [209.85.128.198]) by kanga.kvack.org (Postfix) with ESMTP id B192D6B04D6 for ; Thu, 17 May 2018 07:33:19 -0400 (EDT) Received: by mail-wr0-f198.google.com with SMTP id y6-v6so2867905wrm.10 for ; Thu, 17 May 2018 04:33:19 -0700 (PDT) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id p65-v6sor1524106wmg.54.2018.05.17.04.33.17 for (Google Transport Security); Thu, 17 May 2018 04:33:18 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180509074830.16196-5-hch@lst.de> References: <20180509074830.16196-1-hch@lst.de> <20180509074830.16196-5-hch@lst.de> From: =?UTF-8?Q?Andreas_Gr=C3=BCnbacher?= Date: Thu, 17 May 2018 13:33:17 +0200 Message-ID: Subject: Re: [PATCH 04/33] fs: remove the buffer_unwritten check in page_seek_hole_data Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, Linux FS-devel Mailing List , linux-block@vger.kernel.org, linux-mm@kvack.org 2018-05-09 9:48 GMT+02:00 Christoph Hellwig : > We only call into this function through the iomap iterators, so we already > know the buffer is unwritten. In addition to that we always require the > uptodate flag that is ORed with the result anyway. Please update the page_cache_seek_hole_data description as well: --- a/fs/iomap.c +++ b/fs/iomap.c @@ -647,8 +647,8 @@ * Seek for SEEK_DATA / SEEK_HOLE in the page cache. * * Within unwritten extents, the page cache determines which parts are holes - * and which are data: unwritten and uptodate buffer heads count as data; - * everything else counts as a hole. + * and which are data: uptodate buffer heads count as data; everything else + * counts as a hole. * * Returns the resulting offset on successs, and -ENOENT otherwise. */ Thanks, Andreas