From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Tony Battersby <tonyb@cybernetics.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sathya Prakash <sathya.prakash@broadcom.com>,
Chaitra P B <chaitra.basappa@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"MPT-FusionLinux.pdl@broadcom.com"
<MPT-FusionLinux.pdl@broadcom.com>
Subject: Re: [PATCH v3 07/10] dmapool: cleanup integer types
Date: Wed, 8 Aug 2018 12:51:57 +0300 [thread overview]
Message-ID: <CAHp75VfQJPrBPG8_LLQ0Nvs9S8eaQzpwXhf67kA5Cknwy37aTA@mail.gmail.com> (raw)
In-Reply-To: <5d0aec14-73e0-280d-62fb-2b0fe6c01418@cybernetics.com>
On Tue, Aug 7, 2018 at 7:48 PM, Tony Battersby <tonyb@cybernetics.com> wrote:
> To represent the size of a single allocation, dmapool currently uses
> 'unsigned int' in some places and 'size_t' in other places. Standardize
> on 'unsigned int' to reduce overhead, but use 'size_t' when counting all
> the blocks in the entire pool.
> else if ((boundary < size) || (boundary & (boundary - 1)))
> return NULL;
Just a side note: in above it's is_power_of_2() opencoded.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2018-08-08 9:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 16:48 Tony Battersby
2018-08-08 9:51 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfQJPrBPG8_LLQ0Nvs9S8eaQzpwXhf67kA5Cknwy37aTA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=chaitra.basappa@broadcom.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=linux-scsi@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=sathya.prakash@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=tonyb@cybernetics.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox