From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 404FAC54791 for ; Thu, 22 Feb 2024 17:12:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3D7E6B0074; Thu, 22 Feb 2024 12:12:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EA6F6B007B; Thu, 22 Feb 2024 12:12:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88B3C6B007D; Thu, 22 Feb 2024 12:12:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 773496B0074 for ; Thu, 22 Feb 2024 12:12:09 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4774240ACE for ; Thu, 22 Feb 2024 17:12:09 +0000 (UTC) X-FDA: 81820082778.19.716F695 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf01.hostedemail.com (Postfix) with ESMTP id 7C52640014 for ; Thu, 22 Feb 2024 17:12:06 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WkUki58H; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of andy.shevchenko@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=andy.shevchenko@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708621926; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R62y3zmfO3vkTBKELkMH6EBSN9Umpuk/UWSNDSUJmRE=; b=tRG7/41YjODBLGzh9qKgYuvW83gxLGqLIJ1XGf7GKmuvNveLvKnwdFgIfYf663FjZ7e9Lc SUdRHauk/D4zv+emU58X5Qw6PeRI1/1ev7qrOITBRI6HIcMIopnRVis/xGfdx/cLEmTPRu QmIcJjqA6EwkHkze4qbEc4tgKgooa3g= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WkUki58H; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of andy.shevchenko@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=andy.shevchenko@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708621926; a=rsa-sha256; cv=none; b=itfk8x9Ymw2oqKo4PTCNiQga3B7SoAEAsUFmD5PcjGbCQHiWDP6a+80B6ZPHJTnUG2NMdW wFkpevxQHp1nbg7zXLYgiwN469SI5Jvv+g+fJiDIeoW5fZQHvLkRMhYjLMRVdVcwkX2V8m 3/EQd+f43fAaRq0ilza5WAp+3RnlUr4= Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a3f4464c48dso251983966b.3 for ; Thu, 22 Feb 2024 09:12:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708621925; x=1709226725; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=R62y3zmfO3vkTBKELkMH6EBSN9Umpuk/UWSNDSUJmRE=; b=WkUki58HPNCZmJsfr5yKx7jvehqRL+/YFLcC8RdA2R0tNxpl7m1+2q/bACkyyJGrYE s83lacxUMLXtkcdiWKYP+TdFpiysTUMdjuPQ9u2BqlKp5StBgDMloqMMF/khBFAO0d2H TkzVn2eYR3PEe3gwQ8DK0O8nmOHFzB/3f9bsN73FfWM+i7Bf3+kem3Gp3LU+PPp7DDy1 Kg0uYXWYghuThmlLtGWVorFXFSfiYY9qBNunSFTMiiUTb9RQGZuENhvRSYI1yMBZiHgf fpVy6BiFi8FzHiRIQQKTB60vF7tkYB8s5tNkhz2wQqGOWklOHGoGUWiDXEr0z82rJ0Ng 4irg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708621925; x=1709226725; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R62y3zmfO3vkTBKELkMH6EBSN9Umpuk/UWSNDSUJmRE=; b=QEIoiinwrnqrCNMq0chVdzBTzwCqE1s77dGOe6CXVc37zs7AkObdGufbBtZkmA9HBE LuzFCsb9UtWOA71ag4ttugW185Z/QAfX9SLBMMIBfGYL+v1sjpta0auHrD41Mmp7Ljup L6iGIC2oMGJ7+EHbF044OZp3BIGqm3d8F7TNdnjyQkjKI7ZyABGwCE36bYbYA1lbKSL+ muUBoc9rxZzwBWBlY2tOV4dgEf38+gL/7EvKxUUdBbPa/DaN0HU/Ik8V0l/8zuH0P9NH GNwyUaEC49lIJ3Od4pN5haP+hBJhbsqLR8EzSnYpzHwg4kzxia18pUxTdI16Lfa+Jrs7 9pWA== X-Forwarded-Encrypted: i=1; AJvYcCWVpc6VN2cvoR4wledLURVVjG97V98sUzwBHfaK4dtozBZVe7dLNMHk1smi8RzIJVTZBciSCcWRH0TcRxSmHeUuEJw= X-Gm-Message-State: AOJu0Yy9lT9t+23gClOn+BAAihYpdECcRytxre35SpkpP0cpLT/noEE9 c0lyl9LdE6wDv0SfrFhphPHpnzVzeYtn0mupOXy3+SAGLGm3OQXyxYR6IKXJ9RNdw9FpYUZsziw kohnEDPlIRU7GEPUt4Z8l2yCRX90= X-Google-Smtp-Source: AGHT+IE0sPki7t4TbugmLAgjhSr6glJUOzmra/6Ww/Qw1K5v8TM0qF7dC2R8Xsoh68eYEwXKc40Ck7ci/1qOLBc8qHw= X-Received: by 2002:a17:906:1cc2:b0:a3e:4d4c:d120 with SMTP id i2-20020a1709061cc200b00a3e4d4cd120mr12161358ejh.12.1708621924680; Thu, 22 Feb 2024 09:12:04 -0800 (PST) MIME-Version: 1.0 References: <20230406000212.3442647-6-keescook@chromium.org> <202304061930.4Au0PASm-lkp@intel.com> <19930c5a-f1ed-4b04-b69a-d7259966f020@app.fastmail.com> <202402220829.10C6C7C@keescook> In-Reply-To: <202402220829.10C6C7C@keescook> From: Andy Shevchenko Date: Thu, 22 Feb 2024 19:11:28 +0200 Message-ID: Subject: Re: [PATCH 6/9] fortify: Split reporting and avoid passing string pointer To: Kees Cook Cc: Arnd Bergmann , kernel test robot , linux-hardening@vger.kernel.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Andy Shevchenko , Cezary Rojewski , Puyou Lu , Mark Brown , Josh Poimboeuf , Peter Zijlstra , Brendan Higgins , David Gow , Andrew Morton , Linux Memory Management List , Nathan Chancellor , Alexander Potapenko , Zhaoyang Huang , Randy Dunlap , Geert Uytterhoeven , Miguel Ojeda , Nick Desaulniers , "Liam R. Howlett" , Vlastimil Babka , Dan Williams , Rasmus Villemoes , Yury Norov , "Jason A . Donenfeld" , Sander Vanheule , Eric Biggers , Masami Hiramatsu , Andrey Konovalov , Linus Walleij Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7C52640014 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: gtrp9ax6ffgoxuhmugburescn9o13p5f X-HE-Tag: 1708621926-890397 X-HE-Meta: U2FsdGVkX1/lmCUZfFpW7PXq2e7YHB+bhCRcxuif0EfjpO1R/m3DhFZjFTdC0QE4cD7L9EZm2zTj4OHTHkVT4Np2aFabgmwp+LXIrNOmQ5QwNKTdgiEplI3eNE+L4aS9XICuPsdHJARzAUVDw5CHQm3s8uDo+JPaABxv3YbljeOTGt3SiGtqq0Stcd3TtFVZvTqm7rhQPLPwDu4U36+gwKtS4Jp4QtKbSloAHeIfPw9NKavecL6Xhr87txsLXU0s36FXCH+RsYSbMKqDXa7mJedVZUQ6DF4Jmy06gD1u6c5k8D8pO6PSJS0qgdcCXqjMi46kYhJutC4kZ8tf36Zfn4m2866mZBdbb5gqO+zpxzcO2nx1Dtbz/yKhX8Fh7qdKJzhpFa0qg116jytKhjIrZrXi6Iz/hh3kyzR1ulfFqBDqMFWeTuaHr2TPv/NhhdKaJNaYK/iX3DDSFxS4V3NDe+MrJLlV77WFuI1bETzxKSi3160Y4xVYrVuqZoCteSZCTjSxkTRPL/UXwM9LkixFfKjbPH8QWnMbGwZkAddKO3K9o70JdnvqiThYaDhIbkG8L6GEv7S4zGzlrRC9MRkx5nNXVWRzag51aSjufV0qkAjqiJ/R/bln2lBmG1MjnS2VRTV7hakz7HdA8MHwqShAgMWgu3ExMliBxga9QFX/5LmDa8ETTeQRMdGf6a0DUvwQDisfC9zha4y1NGpcmHO+mClUleiYtFhTMDEMsUZ1DZ+zgg10+Fzq+lfNbLoc2vk4iGmHem9rfILvH8sAhP3X/oKuPvsy3phR39SFXjBHxGUxzM0wQFhK1XvtUPkvhVKt8jezD85isU/+IBkCBl856dnHX+NJYd5xBsleQ/oUFd4xmzhcJcQ12UnPVDsA7Nz9CnT/JzanidOfAgsMZl9gCX6Ru7/JrYY7/RJxUuUFXeMNpxapHwYGJjuRYc9f1zZwFPfnkZV0zapFMoeQ2bq /TiPvZTW 7RsIm8JguAvpE5EXnUpjFDdaqy2HxI7Ipw7ywb5HCfM+eP5Kik5LgmD3nT1r9TTqD8zXLkEn2wtHq2ThdXqusHCmY2mazMIwALXhK7hPb9+l3rlVZeTTEEoWlAz2jgvEGfxeByf2xuQBv+9A/fhQIRKkpfA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 22, 2024 at 6:30=E2=80=AFPM Kees Cook w= rote: > On Thu, Feb 22, 2024 at 02:00:26PM +0100, Arnd Bergmann wrote: > > On Thu, Apr 6, 2023, at 13:19, kernel test robot wrote: > > > > > If you fix the issue, kindly add following tag where applicable > > > | Reported-by: kernel test robot > > > | Link: > > > https://lore.kernel.org/oe-kbuild-all/202304061930.4Au0PASm-lkp@intel= .com/ > > > > > > All errors (new ones prefixed by >>): > > > > > >>> ld.lld: error: undefined symbol: __fortify_panic > > > >>> referenced by fortify-string.h:208 (include/linux/fortify-stri= ng.h:208) > > > >>> arch/arm/boot/compressed/fdt_ro.o:(fdt_stringlis= t_count) > > > >>> referenced by fortify-string.h:208 (include/linux/fortify-stri= ng.h:208) > > > >>> arch/arm/boot/compressed/fdt_ro.o:(fdt_stringlis= t_search) > > > >>> referenced by fortify-string.h:208 (include/linux/fortify-stri= ng.h:208) > > > >>> arch/arm/boot/compressed/fdt_ro.o:(fdt_stringlis= t_get) > > > > I get a related build failure from the same commit: > > > > arch/arm/boot/compressed/misc.c:157:6: error: no previous prototype for= '__fortify_panic' [-Werror=3Dmissing-prototypes] > > 157 | void __fortify_panic(const u8 reason, size_t avail, size_t size= ) > > Whoops, thank you! This series got a refresh after you did the > missing-prototypes work and I missed this one. I've fixed it and > double-checked for any others. Hopefully this will be clean in the next > -next. :) Thank you! (FWIW, I also hit it today) --=20 With Best Regards, Andy Shevchenko