From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Kees Cook <keescook@chromium.org>
Cc: Arnd Bergmann <arnd@arndb.de>, kernel test robot <lkp@intel.com>,
linux-hardening@vger.kernel.org, llvm@lists.linux.dev,
oe-kbuild-all@lists.linux.dev, Andy Shevchenko <andy@kernel.org>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Puyou Lu <puyou.lu@gmail.com>, Mark Brown <broonie@kernel.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Nathan Chancellor <nathan@kernel.org>,
Alexander Potapenko <glider@google.com>,
Zhaoyang Huang <zhaoyang.huang@unisoc.com>,
Randy Dunlap <rdunlap@infradead.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Miguel Ojeda <ojeda@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
"Liam R. Howlett" <liam.howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Dan Williams <dan.j.williams@intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Yury Norov <yury.norov@gmail.com>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Sander Vanheule <sander@svanheule.net>,
Eric Biggers <ebiggers@google.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Andrey Konovalov <andreyknvl@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 6/9] fortify: Split reporting and avoid passing string pointer
Date: Thu, 22 Feb 2024 19:11:28 +0200 [thread overview]
Message-ID: <CAHp75VfDxrTyPCunRbteANRu+-Pt0sMvepxnBAgRbc-Bdb=6nQ@mail.gmail.com> (raw)
In-Reply-To: <202402220829.10C6C7C@keescook>
On Thu, Feb 22, 2024 at 6:30 PM Kees Cook <keescook@chromium.org> wrote:
> On Thu, Feb 22, 2024 at 02:00:26PM +0100, Arnd Bergmann wrote:
> > On Thu, Apr 6, 2023, at 13:19, kernel test robot wrote:
> >
> > > If you fix the issue, kindly add following tag where applicable
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Link:
> > > https://lore.kernel.org/oe-kbuild-all/202304061930.4Au0PASm-lkp@intel.com/
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > >>> ld.lld: error: undefined symbol: __fortify_panic
> > > >>> referenced by fortify-string.h:208 (include/linux/fortify-string.h:208)
> > > >>> arch/arm/boot/compressed/fdt_ro.o:(fdt_stringlist_count)
> > > >>> referenced by fortify-string.h:208 (include/linux/fortify-string.h:208)
> > > >>> arch/arm/boot/compressed/fdt_ro.o:(fdt_stringlist_search)
> > > >>> referenced by fortify-string.h:208 (include/linux/fortify-string.h:208)
> > > >>> arch/arm/boot/compressed/fdt_ro.o:(fdt_stringlist_get)
> >
> > I get a related build failure from the same commit:
> >
> > arch/arm/boot/compressed/misc.c:157:6: error: no previous prototype for '__fortify_panic' [-Werror=missing-prototypes]
> > 157 | void __fortify_panic(const u8 reason, size_t avail, size_t size)
>
> Whoops, thank you! This series got a refresh after you did the
> missing-prototypes work and I missed this one. I've fixed it and
> double-checked for any others. Hopefully this will be clean in the next
> -next. :)
Thank you! (FWIW, I also hit it today)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-22 17:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230406000212.3442647-6-keescook@chromium.org>
2023-04-06 11:19 ` kernel test robot
2024-02-22 13:00 ` Arnd Bergmann
2024-02-22 16:30 ` Kees Cook
2024-02-22 17:11 ` Andy Shevchenko [this message]
2023-04-07 10:26 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfDxrTyPCunRbteANRu+-Pt0sMvepxnBAgRbc-Bdb=6nQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=andy@kernel.org \
--cc=arnd@arndb.de \
--cc=brendan.higgins@linux.dev \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=dan.j.williams@intel.com \
--cc=davidgow@google.com \
--cc=ebiggers@google.com \
--cc=geert+renesas@glider.be \
--cc=glider@google.com \
--cc=jpoimboe@kernel.org \
--cc=keescook@chromium.org \
--cc=liam.howlett@oracle.com \
--cc=linus.walleij@linaro.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=mhiramat@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=puyou.lu@gmail.com \
--cc=rdunlap@infradead.org \
--cc=sander@svanheule.net \
--cc=vbabka@suse.cz \
--cc=yury.norov@gmail.com \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox