From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A59F4C4829A for ; Tue, 13 Feb 2024 08:27:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 390FB8D0002; Tue, 13 Feb 2024 03:27:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 341BC6B0092; Tue, 13 Feb 2024 03:27:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20A5D8D0002; Tue, 13 Feb 2024 03:27:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1117F6B008C for ; Tue, 13 Feb 2024 03:27:30 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D42481407FB for ; Tue, 13 Feb 2024 08:27:29 +0000 (UTC) X-FDA: 81786101418.02.5705510 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf17.hostedemail.com (Postfix) with ESMTP id E97734000B for ; Tue, 13 Feb 2024 08:27:26 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IBWeXuDs; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of andy.shevchenko@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=andy.shevchenko@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707812847; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iNGA8ZHGAdrm/kUeu0sTwlf3VcWW6Pp9gwsOjSJOS+s=; b=iHb8jYeL0/lZPSVSqhCXg7HJHuZBDga82KbbBQe8KRVt/NrPe5R6kEaBIlJY6L1Znu4cYE 3DbAPCOvx4FdmOtZ5iqXEKmxl3Tu+wqPSQivHYnTIp1T9T3PJK4abEhedJkILPorAbsP1E 4ev6NS8rvnPKEcCjzfW4tNrRSYPfXxA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IBWeXuDs; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of andy.shevchenko@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=andy.shevchenko@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707812847; a=rsa-sha256; cv=none; b=6zwEEEzwXmu371zsPhGDI60DGu6Dh5bARloNG11SbpPU51Be3KYW0vkARBbOFogVxPWuVm RqDjsFJzmWSn17Jlg2wMBuPUTMJQCQ0tqaxC12Dy1AoC80fle2G4nxtFX+lGEIdAum+ZD5 yaqDrMRLmESnOloZCtSzZz1OlZw4v+Y= Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a3832ef7726so469288966b.0 for ; Tue, 13 Feb 2024 00:27:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707812845; x=1708417645; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iNGA8ZHGAdrm/kUeu0sTwlf3VcWW6Pp9gwsOjSJOS+s=; b=IBWeXuDsd+ax/fec8/sqON4xZLfsL285vuL8r8EapaNu75k06g2rO8bwwWT2/FK5tL /V8yvyiqewH14SVKZOuTc6dZOjg/kwMg9S+vgSZnwMIe9atOArBSUrIlKVvHZHQKQ2UR ap0JF4dvef4qtMKJAGkad0DeJDXabn2/w+DECGheTSgs8jAsirA2SzOQ1s2hQ9ciarr5 QK4TswD8nd7fJob//bIIDNGM0uHWBiIpSZ51L0T+vtHnJ8f+Tao7kVUqq5rHnB0nZnFH MXe7WzKRvaoazX/Qy2Sb2b6Upf2SdQsdKiHrrk7opJQfvOf6pWjL58EjDccvT3nJPjFe flIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707812845; x=1708417645; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iNGA8ZHGAdrm/kUeu0sTwlf3VcWW6Pp9gwsOjSJOS+s=; b=rp9n7Jl7fI1Od+Eo4cJ7rWzWJ3mhEqhoq5gVelLzrU5IiMWXibUjHUpIK86JJe7uXg GsWCa4pou/ccyHQvOsSCWXgjQuJ2l+PFk2KcdxXMLkarxgDBVDYUZPKiwHKN+1f+38bI cm+E1lI/uhRn/xGR2BLqvZPNO0Uwwd+HzcihO/ZLvv6mm4XuAOXJO74Glafa0Sox8Y4K voougBi9xlW7r/hiXLhow13tU+ABp8PhRRWvx7S+fmrInrph6jrCY/hjgJTQ5xCfE5gg 2/VZXg0yiP6jrLY2O/GGQjCiOMiBalrbWgOv8Jr+J91s29fSGDacXCeJ86BeewHZyv0H iNVg== X-Forwarded-Encrypted: i=1; AJvYcCXG/TheQLL7nIzb1qX/rJdKt6/BRHrkBwkoAxbpcXCZjQDe4YoIH/inbXPBH/6SapwjEqtLh+miBPOMMFVkYpt2B6w= X-Gm-Message-State: AOJu0Yw+NeBJlXXvxLzD03Rot3DeeTuOXuYF/7lec6axxik/9Uk9/LKS KpMeSSfDQpTJwlK1qeOuEZK19J4dm44VgZx2dK9dcEDvvmanizSzufFAntr4+CeqT0UqZQ4TlfF Wk45vZXWLy+IEwVEqdelYgSKIEbo= X-Google-Smtp-Source: AGHT+IHiWMLrwo5bn92RcxNVJHJJozT1VynVrAKPo4QX0LJ4mwZF+SLpK21LEEy+wgmtP5RFPridAor3NfrCIEw3scE= X-Received: by 2002:a17:906:ceca:b0:a38:3db5:a846 with SMTP id si10-20020a170906ceca00b00a383db5a846mr5777021ejb.67.1707812845309; Tue, 13 Feb 2024 00:27:25 -0800 (PST) MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-2-surenb@google.com> In-Reply-To: <20240212213922.783301-2-surenb@google.com> From: Andy Shevchenko Date: Tue, 13 Feb 2024 10:26:48 +0200 Message-ID: Subject: Re: [PATCH v3 01/35] lib/string_helpers: Add flags param to string_get_size() To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Andy Shevchenko , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "Michael S. Tsirkin" , Jason Wang , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E97734000B X-Stat-Signature: 9taohdztmm5csddp8u165xwfidttbuzy X-HE-Tag: 1707812846-358447 X-HE-Meta: U2FsdGVkX1/CCRUJst2yiY6K3HBydPGp9b4srBv6x0BpJ0qgc03PISJanrwhZeKyXuAcRbxqGzpwOLT+0PF0iZJ34dgSNEtliKeehuoqm/Hb7eFmTSF0YbNCGyRvaUcSgZWpzaEicechbhcu2xfcWzehlSHGu7A7S1WK5djglvtUxo8pkG3MOP5cHuxfktgu6CwNya+bzvRggtFwc5MwzLBuTho2YaRQtAvimQUjM5lfCDt9iPZckLjj7iQ778CeLiv1zhRWiJAV/m/1BANVXk105yd4JgfeTQ9LvgA51iscbtB8ofTZ+tZWllc5andQX/4Kw6JEORw3Fd4VWr4rcOgOM+/5ekBY5MTWIsdhnzkbveGN3WSaiKvdBl3iBP/DzZmdSI8vjPtWzYsO2sSLcqSF3nctzAgj67kq1vNtcos0wsICbj7mvNkPuUC6Oxtd4cz+4PuQo05lzGYYjk8dB9CK6psDzzC+QxU6NAFfYDLnfd2fLhB31CLSeIbAuZ/wfsYuaTqiXeKe+WdpowS3dvIugad9pNHUU6s56WM58zFesgmcRvIng61+9uAnHgXj6qT0uk1Atp1qxnhADopKc1H7NIuk7BPIGd04SGHZ6+2kBXofHlNkCRECEzw1CNNEyR2hffEtx2Ek1P5IX+KKULZtEWmmAqjHF6YWTLI1N3TgczX3llVyjtsvBqUY+VVJ9DMSBoqRtAilKJW53dNzi5IbMqrO5oFHNfgWG8dz8n6Xy+Dj3AX/73FOHPG8Fe9Drd/GWDe1T8sFJekAe/OvB089PeTXLjRPuw0Otq9+ImhnsZ/y0Cxc7NhgQEo8ar9saUSKz4kZJwfxuYAACO6j5zEOXAnM3KKP6sSbUsNM+HdXIPmFQumzICzFRO5iJ5wrQDSIs9o1yMLl4IUG1JeJFE3YcyV+lNbhoE6W/LbiSZiM0CJyRvhluO4Z1OKe7tw2vIqTq8xs9KZAdWyOOA5 ahDZbTXo uPB1Rxu3D/rEm2R8CT5vfWjXruK5h1fqVmM2P8ree4zdDB3+5OuN7JYro8qf+nqBSOkukWyzV+AzwiNbtUicr7PPrnKoA+qR95rL+R0bxYfYyZn7NW8DccrqDoYL3gTmE70STLonpnujj6wgfrDwqgiQIAXZ0ft0qmSkUcuYwEsfcaxYBKaG/5G1BYqHRS4X4LLJrOyyJJR19MbfgBjFlNhSnltWWH+hMYUl5fqq8FPJoG/Y8W3iMxrP0yzQ1vL3URb3Dh15ABV3doH9runb8mXyly/yLG4PHLqYrwhBLleUiFJXf82CgPIDeaA7Jf3ry8KgbFIN+1JY4JZE+2wpD2LsmTRFHrEr9E7cfOON3lUsznQhgWH3JQlsURZOHY3FcDWVt88XU9LRjl+m9B+dREb+oCZEiEtuYnEI+jY7d/O+fhAJ6/rk8CN1sOUZfCmdttjQWT8iBbHKsN6tQ/XXp8K4TyTxEXlUqXv9lhHe5m0KpXb33hEIyy0px4ndHUkwWgBR/g51CQ3QLtFUb2pAntijxLdYgYnRYlYkhe2PpQi9dZqJfxeakSwOTzvfh5fLs9e94EE70oxN15W/BIi6lOmHoWxxMzkQeg7Q2uYIYxeQZXX1+CtKcMRYiHP9EtAisZy+gSI9YYsRdTS5I+hbXwSYdK6gYN1c+sWbalkLCwjXRyL5Q9mCj7rjM/UeQBAjZmHQy61M6rziwvf7TElerWg1WwRkF0gOkFymWUQj3d3iT4waRZjcohqbUOO1cafLYePtWdYM+Amk+sGcskHDRd/rhYg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 11:39=E2=80=AFPM Suren Baghdasaryan wrote: > > From: Kent Overstreet > > The new flags parameter allows controlling > - Whether or not the units suffix is separated by a space, for > compatibility with sort -h > - Whether or not to append a B suffix - we're not always printing > bytes. > > Signed-off-by: Kent Overstreet > Signed-off-by: Suren Baghdasaryan It seems most of my points from the previous review were refused... ... You can move the below under --- cutter, so it won't pollute the git histor= y. > Cc: Andy Shevchenko > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: "Noralf Tr=C3=B8nnes" > Cc: Jens Axboe > --- ... > --- a/include/linux/string_helpers.h > +++ b/include/linux/string_helpers.h > @@ -17,14 +17,13 @@ static inline bool string_is_terminated(const char *s= , int len) ... > -/* Descriptions of the types of units to > - * print in */ > -enum string_size_units { > - STRING_UNITS_10, /* use powers of 10^3 (standard SI) */ > - STRING_UNITS_2, /* use binary powers of 2^10 */ > +enum string_size_flags { > + STRING_SIZE_BASE2 =3D (1 << 0), > + STRING_SIZE_NOSPACE =3D (1 << 1), > + STRING_SIZE_NOBYTES =3D (1 << 2), > }; Do not kill documentation, I already said that. Or i.o.w. document this. Also the _SIZE is ambigous (if you don't want UNITS, use SIZE_FORMAT. Also why did you kill BASE10 here? (see below as well) ... > --- a/lib/string_helpers.c > +++ b/lib/string_helpers.c > @@ -19,11 +19,17 @@ > #include > #include > > +enum string_size_units { > + STRING_UNITS_10, /* use powers of 10^3 (standard SI) */ > + STRING_UNITS_2, /* use binary powers of 2^10 */ > +}; Why do we need this duplication? ... > + enum string_size_units units =3D flags & flags & STRING_SIZE_BASE= 2 > + ? STRING_UNITS_2 : STRING_UNITS_10; Double flags check is redundant. --=20 With Best Regards, Andy Shevchenko