From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: 禹舟键 <ufo19890607@gmail.com>
Cc: mhocko@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
aarcange@redhat.com,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
guro@fb.com, yang.s@alibaba-inc.com,
linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Wind Yu <yuzhoujian@didichuxing.com>
Subject: Re: [PATCH v11 1/2] Refactor part of the oom report in dump_header
Date: Thu, 5 Jul 2018 15:24:37 +0300 [thread overview]
Message-ID: <CAHp75Vecv43Q6_LPaLd4YR3OowVKgpR7YJe2Od2Hj_KU7=kEGw@mail.gmail.com> (raw)
In-Reply-To: <CAHCio2hf-kfmVgz=KCvE9L4nPZxEVcFrxv2R1Y11etG=KvyBwg@mail.gmail.com>
On Thu, Jul 5, 2018 at 2:23 PM, 禹舟键 <ufo19890607@gmail.com> wrote:
> Hi Michal and Andy
> The enum oom_constraint will be added in the struct oom_control. So
> I still think I should define it in oom.h.
You missed the point. I'm talking about an array of string literals.
Please, check what the warning I got from the compiler.
> Michal Hocko <mhocko@kernel.org> 于2018年7月4日周三 下午4:17写道：
>>
>> On Wed 04-07-18 10:25:30, 禹舟键 wrote:
>> > Hi Andy
>> > The const char array need to be used by the new func
>> > mem_cgroup_print_oom_context and some funcs in oom_kill.c in the
>> > second patch.
>>
>> Just declare it in oom.h and define in oom.c
>> --
>> Michal Hocko
>> SUSE Labs
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-07-05 12:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-30 16:38 ufo19890607
2018-06-30 16:38 ` [PATCH v11 2/2] Add the missing information " ufo19890607
2018-07-02 10:22 ` Michal Hocko
2018-07-05 8:01 ` [lkp-robot] 3586e04c29: BUG:KASAN:user-memory-access_in_d kernel test robot
2018-07-02 10:17 ` [PATCH v11 1/2] Refactor part of the oom report in dump_header Michal Hocko
2018-07-03 10:57 ` 禹舟键
2018-07-03 11:03 ` Michal Hocko
2018-07-03 17:25 ` Andy Shevchenko
2018-07-04 2:25 ` 禹舟键
2018-07-04 8:17 ` Michal Hocko
2018-07-05 11:23 ` 禹舟键
2018-07-05 12:24 ` Andy Shevchenko [this message]
2018-07-04 8:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vecv43Q6_LPaLd4YR3OowVKgpR7YJe2Od2Hj_KU7=kEGw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rientjes@google.com \
--cc=ufo19890607@gmail.com \
--cc=yang.s@alibaba-inc.com \
--cc=yuzhoujian@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox