From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09AEEC25B75 for ; Thu, 6 Jun 2024 15:37:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DE976B00A9; Thu, 6 Jun 2024 11:37:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58DD96B00AA; Thu, 6 Jun 2024 11:37:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42E606B00AB; Thu, 6 Jun 2024 11:37:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1F26F6B00A9 for ; Thu, 6 Jun 2024 11:37:05 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C49011A152D for ; Thu, 6 Jun 2024 15:37:04 +0000 (UTC) X-FDA: 82200867168.17.10DF082 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf10.hostedemail.com (Postfix) with ESMTP id BEB13C000C for ; Thu, 6 Jun 2024 15:37:02 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NOqUxmWw; spf=pass (imf10.hostedemail.com: domain of andy.shevchenko@gmail.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=andy.shevchenko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717688222; a=rsa-sha256; cv=none; b=FWUyBincoOB7y9cjPuGpookZ1RqGaf3EieTFrWu5dFZlF5UqaitFfc+7qJEOuqEE0ZF807 7TBUJqovQeRgd2d47jAMUKhJiAQhiK4aajI0G+xm2JXfV1j3sWq/oTW/QK8KfeiWzAYCtG 0vffB8hX+AcxG9i4CzFpbuKPm6fa3AY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NOqUxmWw; spf=pass (imf10.hostedemail.com: domain of andy.shevchenko@gmail.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=andy.shevchenko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717688222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z0CcpV2wixNBBsWnqllQP0w7gH4qVqjZf0tpOhmRG6w=; b=sYyr8jpBGdEIOBtdEqYGgMt2THw2oyGYZZ3fWTOaznK7EiwsHuUmcWwvirJHtn6Rc7yqfb /br2nf2jiuczd60u/jcFUssxezqg0iJ2omFyPvYQj7cvVg913N3RJf2zVr1f+W6Ag0Koa5 aKxm9zd0It6zX1P/snwe76zuBCglGUU= Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a6c8537bfa0so105940066b.3 for ; Thu, 06 Jun 2024 08:37:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717688221; x=1718293021; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=z0CcpV2wixNBBsWnqllQP0w7gH4qVqjZf0tpOhmRG6w=; b=NOqUxmWwox+pInF6AKQl4vChcpuBv80JVJWBjvu9jyqkxFdG2FWP3HGxA/wVbgpeYc I27s9NvJtw6Ki1LyGjtEq7gfSZIS1KP8w/J/i2plZ0f2wr4zApUqMLXL9XHquEmWtTjg JYrKdvwoDhKVbIr0rxOqh6od9eBgsocTE1/EfteAesSsHvclNJE7wUBRA8EktHAsWFsX AqmhCoHUeSGvTz99julVheszawsRO1F8vYcJz2oNt7X6LyBbnnStvxFOpjaIWQQ7534Q /10sje3vJqwiWmPmrdpLhp/0vExjmNSa46BHp0ReNZlKhH4UkbIdb9y0F8ZowsVVj8ap 6HmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717688221; x=1718293021; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z0CcpV2wixNBBsWnqllQP0w7gH4qVqjZf0tpOhmRG6w=; b=izSOrplSwsZrBCWH6Z25YmrhB4P7ckU63w+A2H1rqRrkiyUNiTByRIt2JBcqRIaSLc UEat5Z4YNA3u/hVtFESvzLKSCKj3qYy/b2QeeZ9mHTGAIz91SeqqJHYAaf0A2a/i71Nb WzNTT0TUo87cIaezeD63+Xd3mmwro1psj0v8uhVZZ5GNz5pWv+tKYHj1CFiEx44O+3it SfjK3tQWZJFvjBVbzYfFcuV4ZNzyFrcoWfjgR9K0EmISaCL30fosEnAY4/XNKLw/T0uT sQd6dx+YscDrqg9sfLR/VVLN4YVaPa1J85yeB2TBYWzJbc6yQaijZdOCj3P6cXGUVe04 K6Ew== X-Forwarded-Encrypted: i=1; AJvYcCXdjXlFeoyKoXD/um/r1Z3wDNVNGyQ51pkQmBZTZC7Re4PpEsH1N93OoMAOHQGyO2Bx+W922OTyR9Nms1PxX7Bdp0w= X-Gm-Message-State: AOJu0Yyu0MCMxc8xu2j/ikzy844eR0Ut4nLe/MXxfPkvhvGtqirP02r8 i/6oWPAOR5d8BZNvKyzjQjBS9IuFpbU7/nFNc+rNkqqofZucrB6cMigydS2jc1ujA46evuytTUA 5+6NLt1Ygf6eywTdmfIyP/oJcqKo= X-Google-Smtp-Source: AGHT+IGYy+6jXYj5hB4bCe72oEPd7/wFRZlO4muopcqbCwOTrV/F8kNYcHgUnvaExo6oahDVN2z3XOtiHpb/dYfZWqU= X-Received: by 2002:a17:906:349b:b0:a6c:717d:b97b with SMTP id a640c23a62f3a-a6c717dbf08mr261559266b.34.1717688220973; Thu, 06 Jun 2024 08:37:00 -0700 (PDT) MIME-Version: 1.0 References: <20240606144608.97817-2-jean-philippe@linaro.org> In-Reply-To: <20240606144608.97817-2-jean-philippe@linaro.org> From: Andy Shevchenko Date: Thu, 6 Jun 2024 18:36:24 +0300 Message-ID: Subject: Re: [PATCH] mm/util: Swap kmemdup_array() arguments To: Jean-Philippe Brucker Cc: thierry.reding@gmail.com, jonathanh@nvidia.com, kees@kernel.org, andy@kernel.org, akpm@linux-foundation.org, linux-tegra@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: BEB13C000C X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: sp9ht6nm1mgomfp8kgesxzkeqmxqjpia X-HE-Tag: 1717688222-916707 X-HE-Meta: U2FsdGVkX1/FiVfWrjIxNyDcT4oEXSSeUFqYAMgzh05TDVtlOYFk1DaHqHzyupxBywfUVLZynFKZlSQ1KYHUF7jao3IbInGL5jvYvmX5NlbeNuoTudvsv39weyE2gg0p3qSx+3Y+SRlYajXSWZ3gk74x2KPe+K6ONqoCuNBzmyPQrObp6L5pSjbd+Ej4KOwICyXOeAtFX2flMndBbIjxJTOyJHhpA2omhGyWnDHC9PLlWE/PhvIlQOW1X1q47AL6NEmkF8wCT7Cp4PzK8BI9L9X2KwQeXo8hOwN9Fuo2qh/VBhKCI8ueIY0g9FUxhPS+VfSFDt6TxPbRmpqDaAvsP8gDI2h7lPpo1d7DO3U3Pa6u4ZBKqo5xvOqiM2xHwalILdou1nN2Rgxflt5bbOxkJutk4kYcdm30gsHssHQEm6BazXTM9BD4eSUAfKyf5QHeCkURRGobLQYZRVTVOrAuoUi9ZxgsyMJKqMhn0dGLuDQVKuToKxpYpl2JzXnJ/KuvDKlTAJL2X2x2uHu9mGX3mZ0c1knA+PEIy1VSLb0jlTashkobOqFiTdPWv5F9aoScdck4D/7w2GAb/+d4V0YQwa0mANkWgk+AybLp538R6AHEIK+uozfDR2ERe8Q+wZcMvydvm93yK1LYZ5eOMyUm3bNBs+hc18PUoCnr9P31UlAdREJvLeU7vS7zNLrsq+bVDfmLXbxlKfIUBqQmmypRDxmdelNcef7UfcVO0YOIhsat1RBXiqpXySOMbz4Ja4aKeCzZh44dvVuCN6bkgQ5RLwTO9bd6dJuGvpw1kK8Cn7CTgOXVe703gOfRG8BsmkKNKyBifW5FszY13PwZsIZl5bV1KJHZDHN+1qd873h9TkKwH7E5v0uEMMvR72jgvAdhqHoXKPUSazdtuxwkLVOFZKQEoTxIn6TRmLV/IBrCnUDUpbbrEiE/rWSqaTzyTosuaMegGe1rCJobsLqOFgg XBhEM3Si khw0m27lWvVzt1iGgNarFD7G8lo5+IcMYZlHZTwcXbvo6A+tqZAiCsi/m6wqbVszNgBx5dlCW+dSF52Ek7EVeUXsxC9s08QKRmD6p3L82fPxrqhT1zq4XIqUJ1N/w8pzsOyhv+ftNuei7DWyOL88nKsTD8Tvyz4beuKEXFo370d9i5FuOkUVD1e0qjgDCoR6+20mgnSuTDYrwfQiV2oEYdZ8lGqXTNJoHLHYUGXUblUwL50nfNCDRrEOc4eVIr5+Qus32KBZSAK0O34OJorIN8qOwzngF4VC28TOQw8WKykEgJLO6rizD8hqwDTKNl0xovWw1pdZHf0Cwa7hJF8PUA5xM5Q/Z4fXB73eOC5TWOkGo24Zf5wK1U4OytflocZuqh8NrC2RtOno0aHEIGNwfJQTQwww3PH+2SiH5ZdJdl5LdUTrvaIea0LMN28iWtM5rzVbeOLv6nksCHmA3NFpZn2lojL0d9w6oPDKbmPuQyC6aHTkjDkbTX42WDF5np4fzJuGkcEIsLEH8XctWcKl/X5eDoe6C67dFc+2O3fzZZZD5MkY5lz5hx/qUxNb0nDZMY71M+gsbX1w48hk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.138690, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 6, 2024 at 5:47=E2=80=AFPM Jean-Philippe Brucker wrote: > > GCC 14.1 complains about the argument usage of kmemdup_array(): > > drivers/soc/tegra/fuse/fuse-tegra.c:130:65: error: 'kmemdup_array' size= s specified with 'sizeof' in the earlier argument and not in the later argu= ment [-Werror=3Dcalloc-transposed-args] > 130 | fuse->lookups =3D kmemdup_array(fuse->soc->lookups, siz= eof(*fuse->lookups), > | = ^ > drivers/soc/tegra/fuse/fuse-tegra.c:130:65: note: earlier argument shou= ld specify number of elements, later size of each element > > The annotation introduced by commit 7d78a7773355 ("string: Add > additional __realloc_size() annotations for "dup" helpers") lets the > compiler think that kmemdup_array() follows the same format as calloc(), > with the number of elements preceding the size of one element. So we > could simply swap the arguments to __realloc_size() to get rid of that > warning, but it seems cleaner to instead have kmemdup_array() follow the > same format as krealloc_array(), memdup_array_user(), calloc() etc. LGTM, it seems we don't have many users (yet), this looks like a comprehensive change. Reviewed-by: Andy Shevchenko --=20 With Best Regards, Andy Shevchenko