From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C73A8C7EE21 for ; Mon, 1 May 2023 19:57:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C341900003; Mon, 1 May 2023 15:57:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 472DC900002; Mon, 1 May 2023 15:57:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33A7E900003; Mon, 1 May 2023 15:57:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 243D1900002 for ; Mon, 1 May 2023 15:57:47 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D846D80896 for ; Mon, 1 May 2023 19:57:46 +0000 (UTC) X-FDA: 80742746532.21.D8526A4 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by imf16.hostedemail.com (Postfix) with ESMTP id 10FA4180011 for ; Mon, 1 May 2023 19:57:44 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=H8s0D2Pn; spf=pass (imf16.hostedemail.com: domain of andy.shevchenko@gmail.com designates 209.85.219.42 as permitted sender) smtp.mailfrom=andy.shevchenko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682971065; a=rsa-sha256; cv=none; b=zP2soXKoI+dCvzpTOvJJzdjergJ6TPlA6NHTRsuZG7Zn5HTFCpjlVRNSnpP2irFLqqO4jN S2sCI+GLHl+X0c4umZpB2El8dRuwpapKCyxJN5CY4m5X9l436mToVt07VdugU9yg/xLnFj ftzpj360zFelW+pCFkn+laZYcAenMPA= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=H8s0D2Pn; spf=pass (imf16.hostedemail.com: domain of andy.shevchenko@gmail.com designates 209.85.219.42 as permitted sender) smtp.mailfrom=andy.shevchenko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682971065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9KWtLWCFndJNZE972x4UIl3VMb5lgPnWy05QC+e9YHQ=; b=aEeN9tK/BtzMQzA+ICCyAFPYi+fG3D4FjnCD0Bu6sqnk59Yt4T/Ha5OY26rkgYoW5N5Kq/ qvIwx9S28OG8Ecc8/a3T5XyZbv5JLfyO4mQOZzAHR1lb38a0P9DludmfJF9R+yU55qxhJj X5+qH8EUCC53obTbz4edJxMTmarDeeE= Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-61b5de68cd5so3766646d6.1 for ; Mon, 01 May 2023 12:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682971064; x=1685563064; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9KWtLWCFndJNZE972x4UIl3VMb5lgPnWy05QC+e9YHQ=; b=H8s0D2PnStbB558QXUaT5ll4HgeOP3F3gveA5ZpgVXoGtOyCk7qdahHdBJG2qJuoFD 0HqzyJ4Zg0siuJOE4NGOCejap5WAcKxJOUSig772mCh4QsCtjNTYhOT/LwicIJWE9bWs jrJT26m+1Bq+eQTAJu9XUgL54sZ3rBnmD1Wf3mgD63haBjTeb1LZFJOQGajyc8vpiEsQ V1w1TCUdZjhisRQlyxsFwexQ3NynHRek48vOQiL25dSyMrTfOeaKKLioUpoCHgP64K4R 6askIQpetdUtujGGp4kZIUBJMb/jdkXxrQ9+K8YBjSjSjTr4VDS6Hh6nwnpHLOhwtPL5 B5uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682971064; x=1685563064; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9KWtLWCFndJNZE972x4UIl3VMb5lgPnWy05QC+e9YHQ=; b=N+5ukskIuzq1rGmkwX0YCR4NMHn/7tPjEktvTRbc7manHbrNUX9ORNZwygYd3hyjPf 2E62BH79vDu1NDsKboiEPif9Or4DP6IEOzD6o8lcix0fLe/mvWAU7CKsFjjWgsxk1iPR Jq5zet/kzJmCxJjfpVgTsdVa0LR2XMgAreG/ItidEvukdIqDbkiG2M50ZxeetZgLHMLs 5fitZGLBdxCzDiWH2hmODJ2P/09kj4SjG2KcvxK9oxshggHvEiemce3QousBej1l3hN4 wP5ZZn4O/6qHnJFjQPl+CiafAWLY79F3/jAwBKC2OxnlVq5uk1rJs5mRPkUid4d/dsuY +v7w== X-Gm-Message-State: AC+VfDwAi+vuaTAY5Ddd4Y+YP2riP1/vmzzg58OOJxCFSsHlip/7jQtJ ash2JfXKZDdzIbENptdrTMj5jfYyoCgHCsPYsN0= X-Google-Smtp-Source: ACHHUZ4CCRpTSnLWkEGaALw7g2diddNGGTgl3gTtsMDJ7pS/HKTxf5g9t615t5zWEkRqE+QbhaeBbmG/dmnn24JEO8g= X-Received: by 2002:a05:6214:4008:b0:5ea:654e:4d3f with SMTP id kd8-20020a056214400800b005ea654e4d3fmr1607440qvb.5.1682971064004; Mon, 01 May 2023 12:57:44 -0700 (PDT) MIME-Version: 1.0 References: <20230501165450.15352-1-surenb@google.com> <20230501165450.15352-2-surenb@google.com> In-Reply-To: From: Andy Shevchenko Date: Mon, 1 May 2023 22:57:07 +0300 Message-ID: Subject: Re: [PATCH 01/40] lib/string_helpers: Drop space in string_get_size's output To: Kent Overstreet Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Andy Shevchenko , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "Michael S. Tsirkin" , Jason Wang , =?UTF-8?B?Tm9yYWxmIFRyw6/Cv8K9bm5lcw==?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 10FA4180011 X-Rspamd-Server: rspam01 X-Stat-Signature: 5ssmky9j3zu4hrzjmwujttp3agonrwzu X-HE-Tag: 1682971064-538818 X-HE-Meta: U2FsdGVkX18FpODgoerxKbKRznVdKYfrYee3a2ftaVQwnCDQSG+16LwaxdZw2jP69p3GIruJbkqbBkiLnxawxa028q29Ge6Py+7BSrl/UwDxVlhA0388f0W16MsfjEQ155ADYiyEvexTIWW52uyOqGRK5O3S+GAJ1ibaoQWIOpOanTgL90pJajqFhHzG5egv0/0ArCsOkH4HROuRm8Om8pEi2WYqLsHXILeHkWb4Fd956opq2eUUUfUzolEn4K/TYzIcA8LDsqkZycCMSBaqQtehRLvWfBJz2r8pTfoCmGEGcb7TYcDyH1QqSwV5LY/iNXB73cwrlvXFUu9ee0ZbbcqxkvuHy9NTJ1j+SMZob5xZy5d9vU3dauosDsB8+zkv/HhHdreQEX8jsskpOU3hBj5T9u9mJMkK3KbHwGF26vMsaC2gsxhJFBcYL3ishE/7uZC9b/dmiNVmtavqInWo2UzflTKYjItHYv1ZfUCwtPkWoS0J27PqRU6lzD7wNL9NsyjwLsaaB26S3iMMeYX8fJXl6twFH1rtcUJOa5WIGaEsT8IusGv9T5g8j95E8J5eq4iyWEzg++sFBVORDs46u5AlJCdlmHO7sN8NpliIpjaLfQCsidttdgXbYpChkVq1xpOIAHF1NVouTL6xpmm5Di6GkWPuLXh9y8Sa5oZkf13AjRtSBr2CY2g7V17C3w/naYw6CMDx7+WIVZpD5DK7lSvstdv7tZv6piGLSEcS/qK1VOJ0BSIj8w0FF7CrgXXYUzX1Ccqkk5lXCZcxoIMGKy+k3tLlMgxmQRZRXeHTEZTbEBxCTeyZ75qh2qmjbxmwGlZGa1zllQPYgOKdvZgTHsisNe5em/Ng+V2gkB7opPFWAIZ68zFAbd6Rd2i1knJsocQrhBFkcGZYy0F0Hr6d1F2cZaee39vZD81fzcNt5uFFw/jc1DSsdOH8mplMpS0pc56o0U+bOZFIGGKpc/8 Tiyx3t/3 SN+qdnjFtSczDSD6PLt4m7BSFuu4MAWIpi5pTsGfWfNszUBeQG3tFlGiqIj/5UrEZiLvK1nr7IWyz+vT0EOAnP4f2VcYuMJfjeCMEgPcHgd9o52j2n8WWUlyNq2YUNxGmp42tKm94ZVGWXZCwaY8XmhDkasg9dNZnogivtdB4g0QHwiGYVogKFebb8IfmNIVv6oLErpHDYWFQET4UpKPT3HOCJcbt+SsfivrDMX7aGX/M5v+7KQNx0XzPhywsjlKHtElCAbTJ7zhio1tWlOEQ974AvzSbMhtP7rF7cq+WqdvddWEuPZqv4tjsJXyicRMO8tx8wylER14zXavptNp9neOnf//AQAjJISfgImpHT2qwh5RKHfzrqNbIC4VHsthZUGWcsZHoKwtmp1ZYlwSDnUj8DpIINfW9Dg2B799iVu7MI0GrQLp3bpD3rxm08BxQSp20nUAtKR4lRMa+28LrrQpJE+km/SRMIc1fqBCfxqZFiM8F0fYaGbzuFu1kindAM98GYjGu7n0iZ1M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 1, 2023 at 10:36=E2=80=AFPM Kent Overstreet wrote: > > On Mon, May 01, 2023 at 11:13:15AM -0700, Davidlohr Bueso wrote: > > On Mon, 01 May 2023, Suren Baghdasaryan wrote: > > > > > From: Kent Overstreet > > > > > > Previously, string_get_size() outputted a space between the number an= d > > > the units, i.e. > > > 9.88 MiB > > > > > > This changes it to > > > 9.88MiB > > > > > > which allows it to be parsed correctly by the 'sort -h' command. But why do we need that? What's the use case? > > Wouldn't this break users that already parse it the current way? > > It's not impossible - but it's not used in very many places and we > wouldn't be printing in human-readable units if it was meant to be > parsed - it's mainly used for debug output currently. > > If someone raises a specific objection we'll do something different, > otherwise I think standardizing on what userspace tooling already parses > is a good idea. Yes, I NAK this on the basis of https://english.stackexchange.com/a/2911/153144 --=20 With Best Regards, Andy Shevchenko