From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3221DC388F2 for ; Tue, 3 Nov 2020 10:54:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7577E223BF for ; Tue, 3 Nov 2020 10:54:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z1nxH0jD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7577E223BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6F1056B006C; Tue, 3 Nov 2020 05:54:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A2F76B0074; Tue, 3 Nov 2020 05:54:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56B9F6B0078; Tue, 3 Nov 2020 05:54:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id 27FC66B006C for ; Tue, 3 Nov 2020 05:54:27 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CBA351EE6 for ; Tue, 3 Nov 2020 10:54:26 +0000 (UTC) X-FDA: 77442798132.20.nail22_200675f272b8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id AA325180C07A3 for ; Tue, 3 Nov 2020 10:54:26 +0000 (UTC) X-HE-Tag: nail22_200675f272b8 X-Filterd-Recvd-Size: 5096 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Nov 2020 10:54:26 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id e7so13828308pfn.12 for ; Tue, 03 Nov 2020 02:54:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Pr70uaXWQ5V9OEnpZUw1+PkE5bFME26YS/kMKBh3/j4=; b=Z1nxH0jDHYEqq8hm0bVNqvQCGIZiEpIpb3zSwcYXQieBLtra1nCwDJgpu5pP89uJzE AkhrBgNlD6HCyN456iYZGK8zXMn2VqjNio/0ngfT65e6vFKeH9P/k+YNx0fz0NX90SQM JId+N9RTHwMw0LwsVjrJ0K/iWTlm+/5RRX+O/Qjs6Unhw7bP80fuwGuRg+eAD4HDASkn xBbZ2MPC8C7aomhpP8xQDtCO64OoJw54a0Ax1nTLubP8Yh2DLws0e+6UO7/9eRpRrt3U p4wJZFBQok7bOE/bbaJc+Lng79kYbok1iizF3WW9gFugdQUddODfxMzleDA0d88pCHQj 0aaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Pr70uaXWQ5V9OEnpZUw1+PkE5bFME26YS/kMKBh3/j4=; b=rDbP0y92wb1lrunij6Ux9wq0nBoZwTXlyjdsMiy5OY9cf0NkSNmUdbFLhGH37QDQK6 BVz1quL60Vdt/nOAA63mFx7+ryr/O1GHJhNtwnoSHS80OEaB16/LuxZR6MsefnON62GA oE1UE+SkGeNfPt5/pq6OOep2C4uSSaouzjl37NCfF03EC+uNg04x53dL1ZFQN8vTFFJ/ mngUhjUZhegDY4kF4NlKl2cRqogc9ccuOPMO5LybTwxYW81oC+sILc6q28ngpfbTKk4s T7efRIphcjo1ngL8fqBcikEsBSileoryZ9Sglc8Z4Wo8EbI4CHIeyTKeNAhAk9a5CEOd 6Mzw== X-Gm-Message-State: AOAM533SQz+tpE29NvHAYsgbciWfSQSrZo7dACxVM7PVEeUO6tNkoarj 3i16HhtaPxKN4j2meO3PXy4Tyr71R+ETRxpvrls= X-Google-Smtp-Source: ABdhPJzFEjyEEdc+kSmf/T1nHeNhjOJHPnuC+7t9Znx2RJFmaAHHYOf4fCTxwiGuX4v/1cJJtqmJw1ySNSiuUS5bxLE= X-Received: by 2002:a17:90a:430b:: with SMTP id q11mr3222009pjg.129.1604400865170; Tue, 03 Nov 2020 02:54:25 -0800 (PST) MIME-Version: 1.0 References: <20201102152037.963-1-brgl@bgdev.pl> <21d80265fccfcb5d76851c84d1c2d88e0421ab85.camel@perches.com> In-Reply-To: From: Andy Shevchenko Date: Tue, 3 Nov 2020 12:55:14 +0200 Message-ID: Subject: Re: [PATCH v2 0/8] slab: provide and use krealloc_array() To: Bartosz Golaszewski Cc: Joe Perches , Andy Shevchenko , Sumit Semwal , Gustavo Padovan , =?UTF-8?Q?Christian_K=C3=B6nig?= , Mauro Carvalho Chehab , Borislav Petkov , Tony Luck , James Morse , Robert Richter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Alexander Shishkin , Linus Walleij , "Michael S . Tsirkin" , Jason Wang , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Jaroslav Kysela , Takashi Iwai , Linux Media Mailing List , "open list:DRM PANEL DRIVERS" , linaro-mm-sig@lists.linaro.org, Linux Kernel Mailing List , linux-edac@vger.kernel.org, "open list:GPIO SUBSYSTEM" , "open list:VFIO DRIVER" , virtualization@lists.linux-foundation.org, netdev , linux-mm , Linux-ALSA , Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 3, 2020 at 12:13 PM Bartosz Golaszewski wrote: > On Tue, Nov 3, 2020 at 5:14 AM Joe Perches wrote: > > On Mon, 2020-11-02 at 16:20 +0100, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > Yeah so I had this concern for devm_krealloc() and even sent a patch > that extended it to honor __GFP_ZERO before I noticed that regular > krealloc() silently ignores __GFP_ZERO. I'm not sure if this is on > purpose. Maybe we should either make krealloc() honor __GFP_ZERO or > explicitly state in its documentation that it ignores it? And my voice here is to ignore for the same reasons: respect realloc(3) and making common sense with the idea of REallocating (capital letters on purpose). -- With Best Regards, Andy Shevchenko