From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E97DC433DB for ; Mon, 15 Feb 2021 15:05:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8A4BA64E29 for ; Mon, 15 Feb 2021 15:05:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A4BA64E29 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D6EE08D0108; Mon, 15 Feb 2021 10:05:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D1E068D00FD; Mon, 15 Feb 2021 10:05:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C356A8D0108; Mon, 15 Feb 2021 10:05:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0030.hostedemail.com [216.40.44.30]) by kanga.kvack.org (Postfix) with ESMTP id ADCCC8D00FD for ; Mon, 15 Feb 2021 10:05:44 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 680CD824805A for ; Mon, 15 Feb 2021 15:05:44 +0000 (UTC) X-FDA: 77820826608.12.pin87_4e183ff2763c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 4B0FE180033A8 for ; Mon, 15 Feb 2021 15:05:44 +0000 (UTC) X-HE-Tag: pin87_4e183ff2763c X-Filterd-Recvd-Size: 5434 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Mon, 15 Feb 2021 15:05:43 +0000 (UTC) Received: by mail-pl1-f175.google.com with SMTP id b8so3865822plh.12 for ; Mon, 15 Feb 2021 07:05:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vBPOTgDnRyfh/jbkq0mDPyS8WhUVxDcfQsnUHhMxiTk=; b=lR3mqK6+gcma+9WxZTFESttkKFOoo09FPTux/fvBc4FNcAa7QWTHFjkbxMghjItZcb 4T3i9qWTp7r+KHu9wFfFdmmfO4ghqxvvuQDd+LtTsBJ6To36NNgIJgIPO/MYynJ5S4mR QOnLzRxD7iTU6XfHS2pRGnCojqzpvE7+SHtLg3TAr9GFNWUwmhr1C9ciMB2dWomdyYFo hDi5YI7NN3FypVOHsakJX3R6til3kbS5lXI3MFTQn+d9rElPbFo6CPAaLVgZghdmoaeD iXNNRzjnlPsv2Lx1R0uapN2cKX6Nki+HVCdNIR1WFWlp/6df3SqJW73wyODs6yZotmvN J2kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vBPOTgDnRyfh/jbkq0mDPyS8WhUVxDcfQsnUHhMxiTk=; b=ATbJhsYE2pdoui48SqyeI8GERM3d0gGvADCNO0byyvFdHsuD1pnp2o9mUQ4LfaTLOy 2Ml+PvOVWyLGaowDw2fVHwEQo8RyMiqdb81KHca5FjQsbi9+H6QyIyRGhlls52FqKus9 O//loI/wkBPaBa+yw4USkDIDANenO9wqlPPWv0FJjTjJ9KTLvnaClgNh26ln0BJjEHW1 6XykQstUDG+a1RnKk+mXmdWqR6xi02bk88Etb/ErYkRPI4X/jxvj9jTcYsnZYFrBANGL 8v/kA+ppk3HztKpsCwu7xQjm0NJl1/kiV2XzJl9iz7QnjUAjezMwH9pKvx5GkNJUSnTX d0wA== X-Gm-Message-State: AOAM5305KUa12HUDHPVIBR8efVNGXWrITRzTK2o/L/skvJnPl2qm+9v1 03tsX1t1L14MmkkQOvThg/h4fHcCBuJZVBqkRgg= X-Google-Smtp-Source: ABdhPJze9hfWMFP3Hl772hywP9ma8noyEmevP6+5mVvSvMXEe5gIAJQDxWOWTqdFYsyoYQNkFpILVG6RlsnnUOx7vrc= X-Received: by 2002:a17:90a:c84:: with SMTP id v4mr16806227pja.228.1613401542838; Mon, 15 Feb 2021 07:05:42 -0800 (PST) MIME-Version: 1.0 References: <20210215134015.GR2087@kadam> In-Reply-To: <20210215134015.GR2087@kadam> From: Andy Shevchenko Date: Mon, 15 Feb 2021 17:05:26 +0200 Message-ID: Subject: Re: [linux-next:master 2008/11103] drivers/iio/magnetometer/yamaha-yas530.c:891 yas5xx_probe() warn: missing error code 'ret' To: Dan Carpenter Cc: kbuild@lists.01.org, Linus Walleij , kbuild test robot , kbuild-all@lists.01.org, Linux Memory Management List , Jonathan Cameron Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 15, 2021 at 3:40 PM Dan Carpenter wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 07f7e57c63aaa2afb4ea31edef05e08699a63a00 > commit: de8860b1ed4701ea7e6f760f02d79ca6a3b656a1 [2008/11103] iio: magnetometer: Add driver for Yamaha YAS530 > config: x86_64-randconfig-m001-20210215 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter > > smatch warnings: > drivers/iio/magnetometer/yamaha-yas530.c:891 yas5xx_probe() warn: missing error code 'ret' Indeed. > de8860b1ed4701 Linus Walleij 2020-12-24 872 switch (yas5xx->devid) { > de8860b1ed4701 Linus Walleij 2020-12-24 873 case YAS530_DEVICE_ID: > de8860b1ed4701 Linus Walleij 2020-12-24 874 ret = yas530_get_calibration_data(yas5xx); > de8860b1ed4701 Linus Walleij 2020-12-24 875 if (ret) > de8860b1ed4701 Linus Walleij 2020-12-24 876 goto assert_reset; > de8860b1ed4701 Linus Walleij 2020-12-24 877 dev_info(dev, "detected YAS530 MS-3E %s", > de8860b1ed4701 Linus Walleij 2020-12-24 878 yas5xx->version ? "B" : "A"); > de8860b1ed4701 Linus Walleij 2020-12-24 879 strncpy(yas5xx->name, "yas530", sizeof(yas5xx->name)); > de8860b1ed4701 Linus Walleij 2020-12-24 880 break; > de8860b1ed4701 Linus Walleij 2020-12-24 881 case YAS532_DEVICE_ID: > de8860b1ed4701 Linus Walleij 2020-12-24 882 ret = yas532_get_calibration_data(yas5xx); > de8860b1ed4701 Linus Walleij 2020-12-24 883 if (ret) > de8860b1ed4701 Linus Walleij 2020-12-24 884 goto assert_reset; > de8860b1ed4701 Linus Walleij 2020-12-24 885 dev_info(dev, "detected YAS532/YAS533 MS-3R/F %s", > de8860b1ed4701 Linus Walleij 2020-12-24 886 yas5xx->version ? "AC" : "AB"); > de8860b1ed4701 Linus Walleij 2020-12-24 887 strncpy(yas5xx->name, "yas532", sizeof(yas5xx->name)); > de8860b1ed4701 Linus Walleij 2020-12-24 888 break; > de8860b1ed4701 Linus Walleij 2020-12-24 889 default: > de8860b1ed4701 Linus Walleij 2020-12-24 890 dev_err(dev, "unhandled device ID %02x\n", yas5xx->devid); > de8860b1ed4701 Linus Walleij 2020-12-24 @891 goto assert_reset; > > "ret = -EINVAL;" I think more of -ENODEV. > de8860b1ed4701 Linus Walleij 2020-12-24 892 } -- With Best Regards, Andy Shevchenko