From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91E1EC7EE23 for ; Tue, 2 May 2023 15:59:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B19B26B0072; Tue, 2 May 2023 11:59:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A50E56B0075; Tue, 2 May 2023 11:59:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E0026B0078; Tue, 2 May 2023 11:59:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by kanga.kvack.org (Postfix) with ESMTP id 4B2A96B0072 for ; Tue, 2 May 2023 11:59:25 -0400 (EDT) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-54fb6ac1e44so55807057b3.1 for ; Tue, 02 May 2023 08:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683043165; x=1685635165; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Qrcuuma9akhRKA9cVsiv9Wp3Fts3/L+OpcqEI96PfXk=; b=oWkaW/QHDmVAIwXE6um8XgFVH9fxeKJhTuzmDEyHG7WTcHAmPtKHku68GdRxYdjKDC QNCOwVzrvpSm/yXpwqEjWUidwwG+mljL3EbB1MF5ofKP1/WOiTv88KK2Ax7kPzi2dArl tUN65DKCQNvz4MG7BWIIT0wUkpoLfQvkD5Uxmyut7pRhBnoKZZsdwvv4lTv11Zk5sy60 qQvyVXb/tFenRwBi+8EODoCqX14xxP1rg72FzseekL545g1sLvrUI9GrVg1WxYN/+PZs 8K5acvxUcvXlruUIYVYdutany9oZJEW1SVkRIrgE9+qvXtP2Nwg2GzI6NZBPKH8xFpwT SPbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683043165; x=1685635165; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qrcuuma9akhRKA9cVsiv9Wp3Fts3/L+OpcqEI96PfXk=; b=F/zZMPkqE/9Utc9fAorKiHd0si6tq7bHypYMhOES++bhsblrir6Ahe4P/3htatygfW hHImCHyrU805IZ5hUvUxjekp3kw3n2dExLi6K0WN4rGPFwwrMJM85aarcgllm+3sWl2d U6qAIOAXpdcJtTpatXy4D985qPKFSd2w6OZQTVQWnlOgrOu78WiXm6oV3/qajBV8XWwb HWUWWzftCDOZhm7xXstGXR06ofK1W4xnAr4GfECNduD6f288ZJke2EkVab/n4stCgmUc 7OSXOXrAasnE53djxeHN47tnT0eQTFvpC7HsPuGBqrAns+D+mNZ+3WwduRpSmJgWSRyJ vBOA== X-Gm-Message-State: AC+VfDwLzsk9JjrsBNnobOTMLeJtacKAo2AL2C7JVglQ8/vtW0A0GxJW pHNMoBhFSpfERs7R16R2GDZwqDXqSA01mc5VBNiFlr1/4rvQQY5h X-Google-Smtp-Source: ACHHUZ6UI2cU+vYPscYDDBkkT3Plhp9qvN6okFjmkrVKfQQGe2MFQv7qiNq0uAhkrc7LvrOfXehK4e+SQ+W+CPsbV3k= X-Received: by 2002:a05:6214:d04:b0:56e:aeaa:95b2 with SMTP id 4-20020a0562140d0400b0056eaeaa95b2mr3054068qvh.9.1683005674261; Mon, 01 May 2023 22:34:34 -0700 (PDT) MIME-Version: 1.0 References: <20230501165450.15352-1-surenb@google.com> <20230501165450.15352-2-surenb@google.com> In-Reply-To: From: Andy Shevchenko Date: Tue, 2 May 2023 08:33:57 +0300 Message-ID: Subject: Re: [PATCH 01/40] lib/string_helpers: Drop space in string_get_size's output To: Kent Overstreet Cc: James Bottomley , Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Andy Shevchenko , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "Michael S. Tsirkin" , Jason Wang , =?UTF-8?B?Tm9yYWxmIFRyw6/Cv8K9bm5lcw==?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 2, 2023 at 6:18=E2=80=AFAM Kent Overstreet wrote: > On Mon, May 01, 2023 at 10:22:18PM -0400, James Bottomley wrote: ... > > > If someone raises a specific objection we'll do something different, > > > otherwise I think standardizing on what userspace tooling already > > > parses is a good idea. > > > > If you want to omit the space, why not simply add your own variant? A > > string_get_size_nospace() which would use most of the body of this one > > as a helper function but give its own snprintf format string at the > > end. It's only a couple of lines longer as a patch and has the bonus > > that it definitely wouldn't break anything by altering an existing > > output. > > I'm happy to do that - I just wanted to post this version first to see > if we can avoid the fragmentation and do a bit of standardizing with > how everything else seems to do that. Actually instead of producing zillions of variants, do a %p extension to the printf() and that's it. We have, for example, %pt with T and with space to follow users that want one or the other variant. Same can be done with string_get_size(). --=20 With Best Regards, Andy Shevchenko